28625 2009-08-21 14:44:50 -0700 [REGRESSION] Focus ring problems in contentEditable areas 2009-08-21 15:20:09 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC All RESOLVED FIXED Regression P2 Critical --- 20329 1 pkasting hyatt dglazkov mitz oldest_to_newest 141983 0 pkasting 2009-08-21 14:44:50 -0700 Filing on behalf of dglazkov, originally noted on bug 20329 comment 18. "Landing [r47440 to fix bug 20329] introduced a pretty ghastly regression: The focus ring now snakes around overflowing objects in contenteditable areas. Take a look at this for instance on a ToT: http://trac.webkit.org/export/47638/trunk/LayoutTests/editing/pasteboard/styled-element-markup.html Part of the reason this wasn't caught because we don't run pixel tests on build bots." 142005 1 hyatt 2009-08-21 15:03:14 -0700 Consequence of letting boxes have their full height even in quirks mode. All focus ring rects that are added need to clamp themselves to the root line box top and line box bottom. 142008 2 hyatt 2009-08-21 15:04:19 -0700 This is a quirks-mode-only bug basically. 142014 3 hyatt 2009-08-21 15:14:26 -0700 "pretty ghastly regression" is a bit of an exaggeration by the way, given that contenteditable areas with overflow:visible set are pretty rare (as having an outline grow as you type is pretty bad UI to start with), and that the regression doesn't occur in strict mode either. :) 142017 4 38405 hyatt 2009-08-21 15:16:48 -0700 Created attachment 38405 Patch to clamp to lineTop/lineBottom for all outline rects from line boxes. 142019 5 hyatt 2009-08-21 15:20:09 -0700 Fixed in r47643. 38405 2009-08-21 15:16:48 -0700 2009-08-21 15:18:43 -0700 Patch to clamp to lineTop/lineBottom for all outline rects from line boxes. patch.txt text/plain 3774 hyatt SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NzY0MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMDktMDgtMjEgIERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yODYyNSwgZm9jdXMgcmluZ3MgZG9u J3QgcmVzcGVjdCB0aGUgbm9uLXN0cmljdCBtb2RlCisgICAgICAgIGxpbmUgYm94IHNocmlua2lu ZyBxdWlyay4gIE1ha2Ugc3VyZSBvdXRsaW5lcyBkb24ndCBleHRlbmQgb3V0c2lkZSB0aGUgbGlu ZVRvcCBhbmQgbGluZUJvdHRvbQorICAgICAgICBvZiB0aGUgcm9vdCBsaW5lIGJveC4KKworICAg ICAgICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgICogcmVuZGVyaW5nL1Jl bmRlckJsb2NrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJsb2NrOjphZGRGb2N1c1Jp bmdSZWN0cyk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlcklubGluZS5jcHA6CisgICAgICAg IChXZWJDb3JlOjpSZW5kZXJJbmxpbmU6OmFkZEZvY3VzUmluZ1JlY3RzKToKKyAgICAgICAgKFdl YkNvcmU6OlJlbmRlcklubGluZTo6cGFpbnRPdXRsaW5lKToKKwogMjAwOS0wOC0yMSAgUnlvc3Vr ZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBObyBSZXZpZXcuCkluZGV4OiBX ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCShyZXZpc2lvbiA0NzU5NSkKKysrIFdlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckJsb2NrLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDk2MCw4ICs0OTYwLDEx IEBAIHZvaWQgUmVuZGVyQmxvY2s6OmFkZEZvY3VzUmluZ1JlY3RzKEdyYXAKICAgICAgICAgZ3Jh cGhpY3NDb250ZXh0LT5hZGRGb2N1c1JpbmdSZWN0KEludFJlY3QodHgsIHR5LCB3aWR0aCgpLCBo ZWlnaHQoKSkpOwogCiAgICAgaWYgKCFoYXNPdmVyZmxvd0NsaXAoKSAmJiAhaGFzQ29udHJvbENs aXAoKSkgewotICAgICAgICBmb3IgKElubGluZVJ1bkJveCogY3VyciA9IGZpcnN0TGluZUJveCgp OyBjdXJyOyBjdXJyID0gY3Vyci0+bmV4dExpbmVCb3goKSkKLSAgICAgICAgICAgIGdyYXBoaWNz Q29udGV4dC0+YWRkRm9jdXNSaW5nUmVjdChJbnRSZWN0KHR4ICsgY3Vyci0+eCgpLCB0eSArIGN1 cnItPnkoKSwgY3Vyci0+d2lkdGgoKSwgY3Vyci0+aGVpZ2h0KCkpKTsKKyAgICAgICAgZm9yIChS b290SW5saW5lQm94KiBjdXJyID0gZmlyc3RSb290Qm94KCk7IGN1cnI7IGN1cnIgPSBjdXJyLT5u ZXh0Um9vdEJveCgpKSB7CisgICAgICAgICAgICBpbnQgdG9wID0gbWF4KGN1cnItPmxpbmVUb3Ao KSwgY3Vyci0+eSgpKTsKKyAgICAgICAgICAgIGludCBib3R0b20gPSBtaW4oY3Vyci0+bGluZUJv dHRvbSgpLCBjdXJyLT55KCkgKyBjdXJyLT5oZWlnaHQoKSk7CisgICAgICAgICAgICBncmFwaGlj c0NvbnRleHQtPmFkZEZvY3VzUmluZ1JlY3QoSW50UmVjdCh0eCArIGN1cnItPngoKSwgdHkgKyB0 b3AsIGN1cnItPndpZHRoKCksIGJvdHRvbSAtIHRvcCkpOworICAgICAgICB9CiAKICAgICAgICAg Zm9yIChSZW5kZXJPYmplY3QqIGN1cnIgPSBmaXJzdENoaWxkKCk7IGN1cnI7IGN1cnIgPSBjdXJy LT5uZXh0U2libGluZygpKSB7CiAgICAgICAgICAgICBpZiAoIWN1cnItPmlzVGV4dCgpICYmICFj dXJyLT5pc0xpc3RNYXJrZXIoKSAmJiBjdXJyLT5pc0JveCgpKSB7CkluZGV4OiBXZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJJbmxpbmUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcmVuZGVyaW5n L1JlbmRlcklubGluZS5jcHAJKHJldmlzaW9uIDQ3NTkxKQorKysgV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVySW5saW5lLmNwcAkod29ya2luZyBjb3B5KQpAQCAtODE4LDggKzgxOCwxMiBAQCB2b2lk IFJlbmRlcklubGluZTo6aW1hZ2VDaGFuZ2VkKFdyYXBwZWRJCiAKIHZvaWQgUmVuZGVySW5saW5l OjphZGRGb2N1c1JpbmdSZWN0cyhHcmFwaGljc0NvbnRleHQqIGdyYXBoaWNzQ29udGV4dCwgaW50 IHR4LCBpbnQgdHkpCiB7Ci0gICAgZm9yIChJbmxpbmVSdW5Cb3gqIGN1cnIgPSBmaXJzdExpbmVC b3goKTsgY3VycjsgY3VyciA9IGN1cnItPm5leHRMaW5lQm94KCkpCi0gICAgICAgIGdyYXBoaWNz Q29udGV4dC0+YWRkRm9jdXNSaW5nUmVjdChJbnRSZWN0KHR4ICsgY3Vyci0+eCgpLCB0eSArIGN1 cnItPnkoKSwgY3Vyci0+d2lkdGgoKSwgY3Vyci0+aGVpZ2h0KCkpKTsKKyAgICBmb3IgKElubGlu ZVJ1bkJveCogY3VyciA9IGZpcnN0TGluZUJveCgpOyBjdXJyOyBjdXJyID0gY3Vyci0+bmV4dExp bmVCb3goKSkgeworICAgICAgICBSb290SW5saW5lQm94KiByb290ID0gY3Vyci0+cm9vdCgpOwor ICAgICAgICBpbnQgdG9wID0gbWF4KHJvb3QtPmxpbmVUb3AoKSwgY3Vyci0+eSgpKTsKKyAgICAg ICAgaW50IGJvdHRvbSA9IG1pbihyb290LT5saW5lQm90dG9tKCksIGN1cnItPnkoKSArIGN1cnIt PmhlaWdodCgpKTsKKyAgICAgICAgZ3JhcGhpY3NDb250ZXh0LT5hZGRGb2N1c1JpbmdSZWN0KElu dFJlY3QodHggKyBjdXJyLT54KCksIHR5ICsgdG9wLCBjdXJyLT53aWR0aCgpLCBib3R0b20gLSB0 b3ApKTsKKyAgICB9CiAKICAgICBmb3IgKFJlbmRlck9iamVjdCogY3VyciA9IGZpcnN0Q2hpbGQo KTsgY3VycjsgY3VyciA9IGN1cnItPm5leHRTaWJsaW5nKCkpIHsKICAgICAgICAgaWYgKCFjdXJy LT5pc1RleHQoKSAmJiAhY3Vyci0+aXNMaXN0TWFya2VyKCkpIHsKQEAgLTg3MSw5ICs4NzUsMTIg QEAgdm9pZCBSZW5kZXJJbmxpbmU6OnBhaW50T3V0bGluZShHcmFwaGljcwogICAgIFZlY3RvcjxJ bnRSZWN0PiByZWN0czsKIAogICAgIHJlY3RzLmFwcGVuZChJbnRSZWN0KCkpOwotICAgIGZvciAo SW5saW5lUnVuQm94KiBjdXJyID0gZmlyc3RMaW5lQm94KCk7IGN1cnI7IGN1cnIgPSBjdXJyLT5u ZXh0TGluZUJveCgpKQotICAgICAgICByZWN0cy5hcHBlbmQoSW50UmVjdChjdXJyLT54KCksIGN1 cnItPnkoKSwgY3Vyci0+d2lkdGgoKSwgY3Vyci0+aGVpZ2h0KCkpKTsKLQorICAgIGZvciAoSW5s aW5lUnVuQm94KiBjdXJyID0gZmlyc3RMaW5lQm94KCk7IGN1cnI7IGN1cnIgPSBjdXJyLT5uZXh0 TGluZUJveCgpKSB7CisgICAgICAgIFJvb3RJbmxpbmVCb3gqIHJvb3QgPSBjdXJyLT5yb290KCk7 CisgICAgICAgIGludCB0b3AgPSBtYXgocm9vdC0+bGluZVRvcCgpLCBjdXJyLT55KCkpOworICAg ICAgICBpbnQgYm90dG9tID0gbWluKHJvb3QtPmxpbmVCb3R0b20oKSwgY3Vyci0+eSgpICsgY3Vy ci0+aGVpZ2h0KCkpOworICAgICAgICByZWN0cy5hcHBlbmQoSW50UmVjdChjdXJyLT54KCksIHRv cCwgY3Vyci0+d2lkdGgoKSwgYm90dG9tIC0gdG9wKSk7CisgICAgfQogICAgIHJlY3RzLmFwcGVu ZChJbnRSZWN0KCkpOwogCiAgICAgZm9yICh1bnNpZ25lZCBpID0gMTsgaSA8IHJlY3RzLnNpemUo KSAtIDE7IGkrKykK