<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>285275</bug_id>
          
          <creation_ts>2024-12-31 23:57:05 -0800</creation_ts>
          <short_desc>Cosmetic improvements to InlineDisplay*Builder coordinate mapping</short_desc>
          <delta_ts>2025-01-02 14:32:03 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>WebKit Local Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>285222</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="fantasai">fantasai.bugs</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>bfulgham</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>zalan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2084405</commentid>
    <comment_count>0</comment_count>
    <who name="fantasai">fantasai.bugs</who>
    <bug_when>2024-12-31 23:57:05 -0800</bug_when>
    <thetext>Some improvements we could consider for InlineDisplayContentBuilder and InlineDisplayLineBuilder:

- Adopt line-relative terminology to shorten variable and function names.
- Use &quot;logical left&quot; and &quot;logical right&quot; consistent with their usage in RenderBlock etc.
- Pass around writingMode objects directly; and clarify whose writingMode it is.
- Reorganize InlineDisplayLineBuilder::build to organize its calculations better.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2084406</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2024-12-31 23:57:14 -0800</bug_when>
    <thetext>&lt;rdar://problem/142227210&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2084411</commentid>
    <comment_count>2</comment_count>
    <who name="fantasai">fantasai.bugs</who>
    <bug_when>2025-01-01 00:54:12 -0800</bug_when>
    <thetext>https://github.com/WebKit/WebKit/pull/38448</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2084554</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2025-01-02 14:32:01 -0800</bug_when>
    <thetext>Committed 288380@main (ce9e73cd2b64): &lt;https://commits.webkit.org/288380@main&gt;

Reviewed commits have been landed. Closing PR #38448 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>