<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>28397</bug_id>
          
          <creation_ts>2009-08-17 10:33:34 -0700</creation_ts>
          <short_desc>[Chromium] Upstream Chromium port test baselines</short_desc>
          <delta_ts>2010-03-22 09:29:45 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>28395</blocked>
    
    <blocked>28398</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Dimitri Glazkov (Google)">dglazkov</reporter>
          <assigned_to name="Dirk Pranke">dpranke</assigned_to>
          <cc>dpranke</cc>
    
    <cc>michelangelo</cc>
    
    <cc>mrowe</cc>
    
    <cc>ojan</cc>
    
    <cc>pam</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>140753</commentid>
    <comment_count>0</comment_count>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2009-08-17 10:33:34 -0700</bug_when>
    <thetext>If we want to run layout tests out of svn.webkit.org, we should have our baselines (and expectations) live upstream. This is a master bug to track the progress on this effort.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>140794</commentid>
    <comment_count>1</comment_count>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2009-08-17 12:32:55 -0700</bug_when>
    <thetext>This probably shouldn&apos;t be tackled head-on: there are currently 24177 files weighing about 260MB in http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/

I don&apos;t think adding these to LayoutTests/platform/ is prudent.

Perhaps they could be an external dependency?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>140800</commentid>
    <comment_count>2</comment_count>
    <who name="Ojan Vafai">ojan</who>
    <bug_when>2009-08-17 13:06:44 -0700</bug_when>
    <thetext>Wouldn&apos;t having them as an external dependency mean that people would need to check out chromium code in order to change a test&apos;s baseline for chromium?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>140823</commentid>
    <comment_count>3</comment_count>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2009-08-17 13:45:55 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; Wouldn&apos;t having them as an external dependency mean that people would need to
&gt; check out chromium code in order to change a test&apos;s baseline for chromium?

You&apos;re right. With other ports starting to steadily check in their test expectations as well, how will we handle this?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>141546</commentid>
    <comment_count>4</comment_count>
    <who name="Pam Greene (IRC:pamg)">pam</who>
    <bug_when>2009-08-19 12:27:29 -0700</bug_when>
    <thetext>I currently check out all the platform results for Mac, QT, etc., even though I don&apos;t use them. Granted that the platform/chromium results are much larger, it still seems better to me to include them in the repository like any other port. The first update afterward is painful, but the ongoing cost of ~250 MB isn&apos;t that bad.

I&apos;d probably support a more general solution to letting people pick which parts of the repository they wanted to check out... but Ojan has a good point about baselines.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>195048</commentid>
    <comment_count>5</comment_count>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2010-03-02 07:51:50 -0800</bug_when>
    <thetext>We&apos;re uploading these straight-up.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>201605</commentid>
    <comment_count>6</comment_count>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2010-03-18 15:41:47 -0700</bug_when>
    <thetext>*** Bug 36330 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>202545</commentid>
    <comment_count>7</comment_count>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2010-03-22 09:29:45 -0700</bug_when>
    <thetext>Expectations landed as

http://trac.webkit.org/changeset/56278,
http://trac.webkit.org/changeset/56277,
http://trac.webkit.org/changeset/56276,
http://trac.webkit.org/changeset/56274,
http://trac.webkit.org/changeset/56273,
http://trac.webkit.org/changeset/56272,
http://trac.webkit.org/changeset/56271,
http://trac.webkit.org/changeset/56270,
http://trac.webkit.org/changeset/56267,
http://trac.webkit.org/changeset/56259,
http://trac.webkit.org/changeset/56255,
http://trac.webkit.org/changeset/56253,
http://trac.webkit.org/changeset/56252,
http://trac.webkit.org/changeset/56251.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>