28370 2009-08-16 15:35:54 -0700 check-webkit-style: add check for 'using std::foo;' statements 2009-08-16 17:45:08 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ddkilzer webkit-unassigned eric levin mitz oldest_to_newest 140610 0 34940 ddkilzer 2009-08-16 15:35:54 -0700 Created attachment 34940 Patch v1 Reviewed by NOBODY (OOPS!). In <http://webkit.org/b/28355#c1>, it was noted that new source files use 'using namespace std;' instead of individual 'use std::foo;' statements. This adds a level 4 check for such statements. * Scripts/modules/cpp_style.py: (_ERROR_CATEGORIES): Added 'build/using_std'. (check_using_std): Added. (check_style): Added call to check_using_std(). * Scripts/modules/cpp_style_unittest.py: (WebKitStyleTest.test_using_std): Added unit test. --- 3 files changed, 54 insertions(+), 0 deletions(-) 140612 1 ddkilzer 2009-08-16 15:52:37 -0700 (In reply to comment #0) > In <http://webkit.org/b/28355#c1>, it was noted that new source > files use 'using namespace std;' instead of individual > 'use std::foo;' statements. This adds a level 4 check for such > statements. That should be 'using std::foo;' in the ChangeLog comment. Already fixed locally. 140626 2 34940 levin 2009-08-16 16:31:22 -0700 Comment on attachment 34940 Patch v1 > + 'Use \'using namespace std;\' instead of \'using std::%s;\'.' % method_name) Consider using "" for the outer quotes to avoid the \' because it makes it easier to read. Like this: "Use 'using namespace std;' instead of 'using std::%s;'." % method_name) > diff --git a/WebKitTools/Scripts/modules/cpp_style_unittest.py b/WebKitTools/Scripts/modules/cpp_style_unittest.py > + 'Use \'using namespace std;\' instead of \'using std::min;\'.' Consider using "" for the outer quotes to avoid the \'. 140633 3 ddkilzer 2009-08-16 17:45:03 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKitTools/ChangeLog M WebKitTools/Scripts/modules/cpp_style.py M WebKitTools/Scripts/modules/cpp_style_unittest.py Committed r47346 M WebKitTools/ChangeLog M WebKitTools/Scripts/modules/cpp_style_unittest.py M WebKitTools/Scripts/modules/cpp_style.py r47346 = b78d6ef8825272cc9ccf21957ae16d96d64080c7 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47346 140634 4 ddkilzer 2009-08-16 17:45:08 -0700 All reviewed patches have been landed. Closing bug. 34940 2009-08-16 15:35:54 -0700 2009-08-16 16:31:22 -0700 Patch v1 20090816153554.patch text/plain 4456 ddkilzer ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBhMzRhNGRiLi4wZWQxMzViIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMDktMDgt MTYgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICBjaGVjay13 ZWJraXQtc3R5bGU6IGFkZCBjaGVjayBmb3IgJ3VzaW5nIHN0ZDo6Zm9vOycgc3RhdGVtZW50cwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIDxodHRw Oi8vd2Via2l0Lm9yZy9iLzI4MzU1I2MxPiwgaXQgd2FzIG5vdGVkIHRoYXQgbmV3IHNvdXJjZQor ICAgICAgICBmaWxlcyB1c2UgJ3VzaW5nIG5hbWVzcGFjZSBzdGQ7JyBpbnN0ZWFkIG9mIGluZGl2 aWR1YWwKKyAgICAgICAgJ3VzZSBzdGQ6OmZvbzsnIHN0YXRlbWVudHMuICBUaGlzIGFkZHMgYSBs ZXZlbCA0IGNoZWNrIGZvciBzdWNoCisgICAgICAgIHN0YXRlbWVudHMuCisKKyAgICAgICAgKiBT Y3JpcHRzL21vZHVsZXMvY3BwX3N0eWxlLnB5OgorICAgICAgICAoX0VSUk9SX0NBVEVHT1JJRVMp OiBBZGRlZCAnYnVpbGQvdXNpbmdfc3RkJy4KKyAgICAgICAgKGNoZWNrX3VzaW5nX3N0ZCk6IEFk ZGVkLgorICAgICAgICAoY2hlY2tfc3R5bGUpOiBBZGRlZCBjYWxsIHRvIGNoZWNrX3VzaW5nX3N0 ZCgpLgorICAgICAgICAqIFNjcmlwdHMvbW9kdWxlcy9jcHBfc3R5bGVfdW5pdHRlc3QucHk6Cisg ICAgICAgIChXZWJLaXRTdHlsZVRlc3QudGVzdF91c2luZ19zdGQpOiBBZGRlZCB1bml0IHRlc3Qu CisKIDIwMDktMDgtMTQgIEFkYW0gQmVyZ2t2aXN0ICA8YWRhbS5iZXJna3Zpc3RAZXJpY3Nzb24u Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCmRpZmYgLS1naXQgYS9XZWJL aXRUb29scy9TY3JpcHRzL21vZHVsZXMvY3BwX3N0eWxlLnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0 cy9tb2R1bGVzL2NwcF9zdHlsZS5weQppbmRleCA4NmMwNDAxLi4xMGZhYTI0IDEwMDY0NAotLS0g YS9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY3BwX3N0eWxlLnB5CisrKyBiL1dlYktpdFRv b2xzL1NjcmlwdHMvbW9kdWxlcy9jcHBfc3R5bGUucHkKQEAgLTMsNiArMyw3IEBACiAjCiAjIENv cHlyaWdodCAoQykgMjAwOSBHb29nbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogIyBDb3B5 cmlnaHQgKEMpIDIwMDkgVG9yY2ggTW9iaWxlIEluYy4KKyMgQ29weXJpZ2h0IChDKSAyMDA5IEFw cGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICMKICMgUmVkaXN0cmlidXRpb24gYW5kIHVz ZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAjIG1vZGlmaWNh dGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9u cyBhcmUKQEAgLTExNyw2ICsxMTgsNyBAQCBfRVJST1JfQ0FURUdPUklFUyA9ICcnJ1wKICAgICBi dWlsZC9uYW1lc3BhY2VzCiAgICAgYnVpbGQvcHJpbnRmX2Zvcm1hdAogICAgIGJ1aWxkL3N0b3Jh Z2VfY2xhc3MKKyAgICBidWlsZC91c2luZ19zdGQKICAgICBsZWdhbC9jb3B5cmlnaHQKICAgICBy ZWFkYWJpbGl0eS9icmFjZXMKICAgICByZWFkYWJpbGl0eS9jYXN0aW5nCkBAIC0xNzQxLDYgKzE3 NDMsMzEgQEAgZGVmIGNoZWNrX25hbWVzcGFjZV9pbmRlbnRhdGlvbihmaWxlbmFtZSwgY2xlYW5f bGluZXMsIGxpbmVfbnVtYmVyLCBmaWxlX2V4dGVuc2kKICAgICAgICAgICAgIGJyZWFrCiAKIAor ZGVmIGNoZWNrX3VzaW5nX3N0ZChmaWxlbmFtZSwgY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyLCBl cnJvcik6CisgICAgIiIiTG9va3MgZm9yICd1c2luZyBzdGQ6OmZvbzsnIHN0YXRlbWVudHMgd2hp Y2ggc2hvdWxkIGJlIHJlcGxhY2VkIHdpdGggJ3VzaW5nIG5hbWVzcGFjZSBzdGQ7Jy4KKworICAg IEFyZ3M6CisgICAgICBmaWxlbmFtZTogVGhlIG5hbWUgb2YgdGhlIGN1cnJlbnQgZmlsZS4KKyAg ICAgIGNsZWFuX2xpbmVzOiBBIENsZWFuc2VkTGluZXMgaW5zdGFuY2UgY29udGFpbmluZyB0aGUg ZmlsZS4KKyAgICAgIGxpbmVfbnVtYmVyOiBUaGUgbnVtYmVyIG9mIHRoZSBsaW5lIHRvIGNoZWNr LgorICAgICAgZXJyb3I6IFRoZSBmdW5jdGlvbiB0byBjYWxsIHdpdGggYW55IGVycm9ycyBmb3Vu ZC4KKyAgICAiIiIKKworICAgICMgVGhpcyBjaGVjayBkb2Vzbid0IGFwcGx5IHRvIEMgb3IgT2Jq ZWN0aXZlLUMgaW1wbGVtZW50YXRpb24gZmlsZXMuCisgICAgaWYgZmlsZW5hbWUuZW5kc3dpdGgo Jy5jJykgb3IgZmlsZW5hbWUuZW5kc3dpdGgoJy5tJyk6CisgICAgICAgIHJldHVybgorCisgICAg bGluZSA9IGNsZWFuX2xpbmVzLmVsaWRlZFtsaW5lX251bWJlcl0gIyBHZXQgcmlkIG9mIGNvbW1l bnRzIGFuZCBzdHJpbmdzLgorCisgICAgdXNpbmdfc3RkX21hdGNoID0gbWF0Y2gocidccyp1c2lu Z1xzK3N0ZDo6KD9QPG1ldGhvZF9uYW1lPlxTKylccyo7XHMqJCcsIGxpbmUpCisgICAgaWYgbm90 IHVzaW5nX3N0ZF9tYXRjaDoKKyAgICAgICAgcmV0dXJuCisKKyAgICBtZXRob2RfbmFtZSA9IHVz aW5nX3N0ZF9tYXRjaC5ncm91cCgnbWV0aG9kX25hbWUnKQorICAgIGVycm9yKGZpbGVuYW1lLCBs aW5lX251bWJlciwgJ2J1aWxkL3VzaW5nX3N0ZCcsIDQsCisgICAgICAgICAgJ1VzZSBcJ3VzaW5n IG5hbWVzcGFjZSBzdGQ7XCcgaW5zdGVhZCBvZiBcJ3VzaW5nIHN0ZDo6JXM7XCcuJyAlIG1ldGhv ZF9uYW1lKQorCisKIGRlZiBjaGVja19zd2l0Y2hfaW5kZW50YXRpb24oZmlsZW5hbWUsIGNsZWFu X2xpbmVzLCBsaW5lX251bWJlciwgZXJyb3IpOgogICAgICIiIkxvb2tzIGZvciBpbmRlbnRhdGlv biBlcnJvcnMgaW5zaWRlIG9mIHN3aXRjaCBzdGF0ZW1lbnRzLgogCkBAIC0yMTc0LDYgKzIyMDEs NyBAQCBkZWYgY2hlY2tfc3R5bGUoZmlsZW5hbWUsIGNsZWFuX2xpbmVzLCBsaW5lX251bWJlciwg ZmlsZV9leHRlbnNpb24sIGVycm9yKToKIAogICAgICMgU29tZSBtb3JlIHN0eWxlIGNoZWNrcwog ICAgIGNoZWNrX25hbWVzcGFjZV9pbmRlbnRhdGlvbihmaWxlbmFtZSwgY2xlYW5fbGluZXMsIGxp bmVfbnVtYmVyLCBmaWxlX2V4dGVuc2lvbiwgZXJyb3IpCisgICAgY2hlY2tfdXNpbmdfc3RkKGZp bGVuYW1lLCBjbGVhbl9saW5lcywgbGluZV9udW1iZXIsIGVycm9yKQogICAgIGNoZWNrX3N3aXRj aF9pbmRlbnRhdGlvbihmaWxlbmFtZSwgY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyLCBlcnJvcikK ICAgICBjaGVja19icmFjZXMoZmlsZW5hbWUsIGNsZWFuX2xpbmVzLCBsaW5lX251bWJlciwgZXJy b3IpCiAgICAgY2hlY2tfZXhpdF9zdGF0ZW1lbnRfc2ltcGxpZmljYXRpb25zKGZpbGVuYW1lLCBj bGVhbl9saW5lcywgbGluZV9udW1iZXIsIGVycm9yKQpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMv U2NyaXB0cy9tb2R1bGVzL2NwcF9zdHlsZV91bml0dGVzdC5weSBiL1dlYktpdFRvb2xzL1Njcmlw dHMvbW9kdWxlcy9jcHBfc3R5bGVfdW5pdHRlc3QucHkKaW5kZXggYWQwMWZjMy4uNjk2MzI0OCAx MDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NwcF9zdHlsZV91bml0dGVz dC5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY3BwX3N0eWxlX3VuaXR0ZXN0 LnB5CkBAIC0zLDYgKzMsNyBAQAogIwogIyBDb3B5cmlnaHQgKEMpIDIwMDkgR29vZ2xlIEluYy4g QWxsIHJpZ2h0cyByZXNlcnZlZC4KICMgQ29weXJpZ2h0IChDKSAyMDA5IFRvcmNoIE1vYmlsZSBJ bmMuCisjIENvcHlyaWdodCAoQykgMjAwOSBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQu CiAjCiAjIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMs IHdpdGggb3Igd2l0aG91dAogIyBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQg dGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMgYXJlCkBAIC0zNDI1LDYgKzM0MjYsMTMgQEAg Y2xhc3MgV2ViS2l0U3R5bGVUZXN0KENwcFN0eWxlVGVzdEJhc2UpOgogICAgICAgICAgICAgJ2lm IChvdGhlcnRydWUgPT0gZm9udFR5cGUpJywKICAgICAgICAgICAgICcnKQogCisgICAgZGVmIHRl c3RfdXNpbmdfc3RkKHNlbGYpOgorICAgICAgICBzZWxmLmFzc2VydF9saW50KAorICAgICAgICAg ICAgJ3VzaW5nIHN0ZDo6bWluOycsCisgICAgICAgICAgICAnVXNlIFwndXNpbmcgbmFtZXNwYWNl IHN0ZDtcJyBpbnN0ZWFkIG9mIFwndXNpbmcgc3RkOjptaW47XCcuJworICAgICAgICAgICAgJyAg W2J1aWxkL3VzaW5nX3N0ZF0gWzRdJywKKyAgICAgICAgICAgICdmb28uY3BwJykKKwogICAgIGRl ZiB0ZXN0X25hbWVzKHNlbGYpOgogICAgICAgICAjIEZJWE1FOiBJbXBsZW1lbnQgdGhpcy4KICAg ICAgICAgcGFzcw==