28276 2009-08-13 13:20:29 -0700 Geolocation error callback is invoked synchronously if service fails to start 2009-11-05 18:46:17 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 27944 29179 31184 1 steveblock steveblock andreip bolsinga commit-queue steveblock oldest_to_newest 140000 0 steveblock 2009-08-13 13:20:29 -0700 Currently, when a Geolocation method is called, the error callback is invoked synchronously if the Geolocation service fails to start. This behavior is incorrect. All callbacks should be asynchronous. See the W3C spec - http://www.w3.org/TR/geolocation-API/#geolocation_interface. 145823 1 steveblock 2009-09-09 10:29:07 -0700 The fix for this bug requires the 'setFatalError' framework in the fix for Bug 27944. 158567 2 42029 steveblock 2009-10-28 08:38:00 -0700 Created attachment 42029 Patch 1 for Bug 28276 Adding a test for this bug would require new methods to be added to the mock Geolocation service and LayoutTestController. For such a simple fix, I don't think it's worthwhile. 161035 3 42029 commit-queue 2009-11-05 18:46:13 -0800 Comment on attachment 42029 Patch 1 for Bug 28276 Clearing flags on attachment: 42029 Committed r50585: <http://trac.webkit.org/changeset/50585> 161037 4 commit-queue 2009-11-05 18:46:17 -0800 All reviewed patches have been landed. Closing bug. 42029 2009-10-28 08:38:00 -0700 2009-11-05 18:46:12 -0800 Patch 1 for Bug 28276 serviceErrorCallbackShouldBeAsync.txt text/plain 2919 steveblock SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MDIxNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMDktMTAtMjggIFN0ZXZlIEJsb2NrICA8c3RldmVibG9ja0Bnb29n bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IElmIHRoZSBHZW9sb2NhdGlvbiBzZXJ2aWNlIGZhaWxzIHRvIHN0YXJ0LCBpbnZva2UgdGhlIGVy cm9yIGNhbGxiYWNrIGFzeW5jaHJvbm91c2x5LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjgyNzYKKworICAgICAgICBBbGwgR2VvbG9jYXRpb24gY2Fs bGJhY2tzIG11c3QgYmUgaW52b2tlZCBhc3luY2hyb25vdXNseS4KKyAgICAgICAgU2VlIGh0dHA6 Ly93d3cudzMub3JnL1RSL2dlb2xvY2F0aW9uLUFQSS8jZ2VvbG9jYXRpb25faW50ZXJmYWNlCisK KyAgICAgICAgTm8gbmV3IHRlc3RzIHBvc3NpYmxlIHdpdGggY3VycmVudCBMYXlvdXRUZXN0Q29u dHJvbGxlci4KKworICAgICAgICAqIHBhZ2UvR2VvbG9jYXRpb24uY3BwOgorICAgICAgICAoV2Vi Q29yZTo6R2VvbG9jYXRpb246OmdldEN1cnJlbnRQb3NpdGlvbik6IE1vZGlmaWVkLiBBc3NlcnRz IHRoYXQgc3RhcnRSZXF1ZXN0IHJldHVybmVkIGEgbm90aWZpZXIuCisgICAgICAgIChXZWJDb3Jl OjpHZW9sb2NhdGlvbjo6d2F0Y2hQb3NpdGlvbik6IE1vZGlmaWVkLiBBc3NlcnRzIHRoYXQgc3Rh cnRSZXF1ZXN0IHJldHVybmVkIGEgbm90aWZpZXIuCisgICAgICAgIChXZWJDb3JlOjpHZW9sb2Nh dGlvbjo6c3RhcnRSZXF1ZXN0KTogTW9kaWZpZWQuIElmIHRoZSBHZW9sb2NhdGlvbiBzZXJ2aWNl IGZhaWxzIHRvIHN0YXJ0LCBzZXQgYSBmYXRhbCBlcnJvciBvbiB0aGUgbm90aWZpZXIuCisKIDIw MDktMTAtMjggIFN0ZXZlIEJsb2NrICA8c3RldmVibG9ja0Bnb29nbGUuY29tPgogCiAgICAgICAg IFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpJbmRleDogV2ViQ29yZS9wYWdlL0dlb2xvY2F0aW9u LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvR2VvbG9jYXRpb24uY3BwCShyZXZpc2lv biA1MDIxMykKKysrIFdlYkNvcmUvcGFnZS9HZW9sb2NhdGlvbi5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTE1MSw4ICsxNTEsNyBAQCB2b2lkIEdlb2xvY2F0aW9uOjpkaXNjb25uZWN0RnJhbWUoKQog dm9pZCBHZW9sb2NhdGlvbjo6Z2V0Q3VycmVudFBvc2l0aW9uKFBhc3NSZWZQdHI8UG9zaXRpb25D YWxsYmFjaz4gc3VjY2Vzc0NhbGxiYWNrLCBQYXNzUmVmUHRyPFBvc2l0aW9uRXJyb3JDYWxsYmFj az4gZXJyb3JDYWxsYmFjaywgUGFzc1JlZlB0cjxQb3NpdGlvbk9wdGlvbnM+IG9wdGlvbnMpCiB7 CiAgICAgUmVmUHRyPEdlb05vdGlmaWVyPiBub3RpZmllciA9IHN0YXJ0UmVxdWVzdChzdWNjZXNz Q2FsbGJhY2ssIGVycm9yQ2FsbGJhY2ssIG9wdGlvbnMpOwotICAgIGlmICghbm90aWZpZXIpCi0g ICAgICAgIHJldHVybjsKKyAgICBBU1NFUlQobm90aWZpZXIpOwogCiAgICAgbV9vbmVTaG90cy5h ZGQobm90aWZpZXIpOwogfQpAQCAtMTYwLDggKzE1OSw3IEBAIHZvaWQgR2VvbG9jYXRpb246Omdl dEN1cnJlbnRQb3NpdGlvbihQYXMKIGludCBHZW9sb2NhdGlvbjo6d2F0Y2hQb3NpdGlvbihQYXNz UmVmUHRyPFBvc2l0aW9uQ2FsbGJhY2s+IHN1Y2Nlc3NDYWxsYmFjaywgUGFzc1JlZlB0cjxQb3Np dGlvbkVycm9yQ2FsbGJhY2s+IGVycm9yQ2FsbGJhY2ssIFBhc3NSZWZQdHI8UG9zaXRpb25PcHRp b25zPiBvcHRpb25zKQogewogICAgIFJlZlB0cjxHZW9Ob3RpZmllcj4gbm90aWZpZXIgPSBzdGFy dFJlcXVlc3Qoc3VjY2Vzc0NhbGxiYWNrLCBlcnJvckNhbGxiYWNrLCBvcHRpb25zKTsKLSAgICBp ZiAoIW5vdGlmaWVyKQotICAgICAgICByZXR1cm4gMDsKKyAgICBBU1NFUlQobm90aWZpZXIpOwog CiAgICAgc3RhdGljIGludCBuZXh0QXZhaWxhYmxlV2F0Y2hJZCA9IDE7CiAgICAgbV93YXRjaGVy cy5zZXQobmV4dEF2YWlsYWJsZVdhdGNoSWQsIG5vdGlmaWVyLnJlbGVhc2UoKSk7CkBAIC0xNzks MTMgKzE3Nyw4IEBAIFBhc3NSZWZQdHI8R2VvbG9jYXRpb246Okdlb05vdGlmaWVyPiBHZW8KICAg ICBlbHNlIHsKICAgICAgICAgaWYgKG5vdGlmaWVyLT5oYXNaZXJvVGltZW91dCgpIHx8IG1fc2Vy dmljZS0+c3RhcnRVcGRhdGluZyhub3RpZmllci0+bV9vcHRpb25zLmdldCgpKSkKICAgICAgICAg ICAgIG5vdGlmaWVyLT5zdGFydFRpbWVySWZOZWVkZWQoKTsKLSAgICAgICAgZWxzZSB7Ci0gICAg ICAgICAgICBpZiAobm90aWZpZXItPm1fZXJyb3JDYWxsYmFjaykgewotICAgICAgICAgICAgICAg IFJlZlB0cjxQb3NpdGlvbkVycm9yPiBlcnJvciA9IFBvc2l0aW9uRXJyb3I6OmNyZWF0ZShQb3Np dGlvbkVycm9yOjpQRVJNSVNTSU9OX0RFTklFRCwgIlVuYWJsZSB0byBTdGFydCIpOwotICAgICAg ICAgICAgICAgIG5vdGlmaWVyLT5tX2Vycm9yQ2FsbGJhY2stPmhhbmRsZUV2ZW50KGVycm9yLmdl dCgpKTsKLSAgICAgICAgICAgIH0KLSAgICAgICAgICAgIHJldHVybiAwOwotICAgICAgICB9Cisg ICAgICAgIGVsc2UKKyAgICAgICAgICAgIG5vdGlmaWVyLT5zZXRGYXRhbEVycm9yKFBvc2l0aW9u RXJyb3I6OmNyZWF0ZShQb3NpdGlvbkVycm9yOjpVTktOT1dOX0VSUk9SLCAiRmFpbGVkIHRvIHN0 YXJ0IEdlb2xvY2F0aW9uIHNlcnZpY2UiKSk7CiAgICAgfQogCiAgICAgcmV0dXJuIG5vdGlmaWVy LnJlbGVhc2UoKTsK