<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>28252</bug_id>
          
          <creation_ts>2009-08-13 03:19:12 -0700</creation_ts>
          <short_desc>[Haiku] Adding the lack of JPEG support to ImageSource.cpp.</short_desc>
          <delta_ts>2009-08-28 10:55:07 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Other</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>WONTFIX</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Maxime Simon">simon.maxime</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>leavengood</cc>
    
    <cc>pkasting</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>139770</commentid>
    <comment_count>0</comment_count>
    <who name="Maxime Simon">simon.maxime</who>
    <bug_when>2009-08-13 03:19:12 -0700</bug_when>
    <thetext>For the moment the Haiku port doesn&apos;t support JPEG (there is no libjpeg in the default system).
Here are some modifications in ImageSource.cpp to consider this.

Regards,
Maxime</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>139789</commentid>
    <comment_count>1</comment_count>
      <attachid>34728</attachid>
    <who name="Maxime Simon">simon.maxime</who>
    <bug_when>2009-08-13 04:12:43 -0700</bug_when>
    <thetext>Created attachment 34728
Adding the lack of JPEG support to ImageSource.cpp.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>139888</commentid>
    <comment_count>2</comment_count>
      <attachid>34728</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-08-13 09:54:30 -0700</bug_when>
    <thetext>Comment on attachment 34728
Adding the lack of JPEG support to ImageSource.cpp.

What are the style changes from?  check-webkit-style?  I&apos;d have to check the guide to see if those are correct or not, I can never remember for multi-line operations.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>139894</commentid>
    <comment_count>3</comment_count>
    <who name="Maxime Simon">simon.maxime</who>
    <bug_when>2009-08-13 09:59:15 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; (From update of attachment 34728 [details])
&gt; What are the style changes from?  check-webkit-style?  I&apos;d have to check the
&gt; guide to see if those are correct or not, I can never remember for multi-line
&gt; operations.

From the guideline:
- never compare to 0.
- in a condition &amp;&amp; and || should be put on the begin of the line.

check-webkit-style complained with ImageSourceHaiku for these things, so I supposed it the same for this file. :)

Regards,
Maxime</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>139917</commentid>
    <comment_count>4</comment_count>
    <who name="Peter Kasting">pkasting</who>
    <bug_when>2009-08-13 10:30:28 -0700</bug_when>
    <thetext>I&apos;m fine with the style changes, I think they&apos;re correct.  Only suggestion I&apos;d make is to put in a comment about why you&apos;re not supporting JPEG for Haiku:

#if !PLATFFORM(HAIKU)  // Haiku doesn&apos;t ship libjpeg right now.

Looks fine to me otherwise if Eric wants to r+.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>139952</commentid>
    <comment_count>5</comment_count>
      <attachid>34728</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-08-13 11:44:09 -0700</bug_when>
    <thetext>Comment on attachment 34728
Adding the lack of JPEG support to ImageSource.cpp.

Great!  Please add the comment as peter suggested and post the revised patch for me (or anyone else) to r+.  Looks good though.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>139954</commentid>
    <comment_count>6</comment_count>
      <attachid>34762</attachid>
    <who name="Maxime Simon">simon.maxime</who>
    <bug_when>2009-08-13 11:47:57 -0700</bug_when>
    <thetext>Created attachment 34762
Adding the lack of JPEG support to ImageSource.cpp</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>139955</commentid>
    <comment_count>7</comment_count>
      <attachid>34763</attachid>
    <who name="Maxime Simon">simon.maxime</who>
    <bug_when>2009-08-13 11:49:02 -0700</bug_when>
    <thetext>Created attachment 34763
Adding the lack of JPEG support to ImageSource.cpp</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>140564</commentid>
    <comment_count>8</comment_count>
      <attachid>34763</attachid>
    <who name="Maxime Simon">simon.maxime</who>
    <bug_when>2009-08-16 09:36:38 -0700</bug_when>
    <thetext>Comment on attachment 34763
Adding the lack of JPEG support to ImageSource.cpp

I mark this one as obsolete, because the Haiku is working on integrating libjpeg natively.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>143402</commentid>
    <comment_count>9</comment_count>
    <who name="Peter Kasting">pkasting</who>
    <bug_when>2009-08-28 10:40:18 -0700</bug_when>
    <thetext>I interpret comment 8 as saying we should go ahead and close this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>143405</commentid>
    <comment_count>10</comment_count>
    <who name="Ryan Leavengood">leavengood</who>
    <bug_when>2009-08-28 10:55:07 -0700</bug_when>
    <thetext>(In reply to comment #9)
&gt; I interpret comment 8 as saying we should go ahead and close this.

Yes sir, the closing of this is fine. I found it quite silly for Haiku to not have libjpeg exposed so I rectified that problem :)</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>34728</attachid>
            <date>2009-08-13 04:12:43 -0700</date>
            <delta_ts>2009-08-13 11:47:57 -0700</delta_ts>
            <desc>Adding the lack of JPEG support to ImageSource.cpp.</desc>
            <filename>bug-28252-20090813131241.patch</filename>
            <type>text/plain</type>
            <size>2785</size>
            <attacher name="Maxime Simon">simon.maxime</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
NThlZjMzZC4uODcyMGJkNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi
Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0wOC0xMyAgTWF4aW1lIFNpbW9u
ICA8c2ltb24ubWF4aW1lQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg
KE9PUFMhKS4KKworICAgICAgICBbSGFpa3VdIEFkZGluZyB0aGUgbGFjayBvZiBKUEVHIHN1cHBv
cnQgdG8gSW1hZ2VTb3VyY2UuY3BwLgorICAgICAgICBGb3IgdGhlIG1vbWVudCB0aGUgSGFpa3Ug
cG9ydCBkb2Vzbid0IHN1cHBvcnQgSlBFRyAodGhlcmUgaXMgbm8gbGlianBlZworICAgICAgICBp
biB0aGUgZGVmYXVsdCBzeXN0ZW0pLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z
aG93X2J1Zy5jZ2k/aWQ9MjgyNTIKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0ltYWdl
U291cmNlLmNwcDogQWxzbyBzb21lIHN0eWxlIGNsZWFudXAuCisgICAgICAgIChXZWJDb3JlOjpj
cmVhdGVEZWNvZGVyKToKKwogMjAwOS0wOC0xMiAgSm9zZXBoIFBlY29yYXJvICA8am9lcGVjazAy
QGdtYWlsLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBUaW1vdGh5IEhhdGNoZXIuCmRpZmYg
LS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdlU291cmNlLmNwcCBiL1dlYkNv
cmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2VTb3VyY2UuY3BwCmluZGV4IDhmOTEwNDIuLjUxNWY3
NTYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2VTb3VyY2UuY3Bw
CisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2VTb3VyY2UuY3BwCkBAIC0zMSw3
ICszMSw5IEBACiAjaW5jbHVkZSAiQk1QSW1hZ2VEZWNvZGVyLmgiCiAjaW5jbHVkZSAiR0lGSW1h
Z2VEZWNvZGVyLmgiCiAjaW5jbHVkZSAiSUNPSW1hZ2VEZWNvZGVyLmgiCisjaWYgIVBMQVRGT1JN
KEhBSUtVKQogI2luY2x1ZGUgIkpQRUdJbWFnZURlY29kZXIuaCIKKyNlbmRpZgogI2luY2x1ZGUg
IlBOR0ltYWdlRGVjb2Rlci5oIgogI2luY2x1ZGUgIlhCTUltYWdlRGVjb2Rlci5oIgogI2luY2x1
ZGUgIlNoYXJlZEJ1ZmZlci5oIgpAQCAtNDksMzQgKzUxLDM2IEBAIEltYWdlRGVjb2RlciogY3Jl
YXRlRGVjb2Rlcihjb25zdCBWZWN0b3I8Y2hhcj4mIGRhdGEpCiAgICAgY29uc3QgY2hhciogY29u
dGVudHMgPSBkYXRhLmRhdGEoKTsKIAogICAgIC8vIEdJRnMgYmVnaW4gd2l0aCBHSUY4KDcgb3Ig
OSkuCi0gICAgaWYgKHN0cm5jbXAoY29udGVudHMsICJHSUY4IiwgNCkgPT0gMCkKKyAgICBpZiAo
IXN0cm5jbXAoY29udGVudHMsICJHSUY4IiwgNCkpCiAgICAgICAgIHJldHVybiBuZXcgR0lGSW1h
Z2VEZWNvZGVyKCk7CiAKICAgICAvLyBUZXN0IGZvciBQTkcuCi0gICAgaWYgKHVDb250ZW50c1sw
XT09MHg4OSAmJgotICAgICAgICB1Q29udGVudHNbMV09PTB4NTAgJiYKLSAgICAgICAgdUNvbnRl
bnRzWzJdPT0weDRFICYmCi0gICAgICAgIHVDb250ZW50c1szXT09MHg0NykKKyAgICBpZiAodUNv
bnRlbnRzWzBdID09IDB4ODkKKyAgICAgICAgJiYgdUNvbnRlbnRzWzFdID09IDB4NTAKKyAgICAg
ICAgJiYgdUNvbnRlbnRzWzJdID09IDB4NEUKKyAgICAgICAgJiYgdUNvbnRlbnRzWzNdID09IDB4
NDcpCiAgICAgICAgIHJldHVybiBuZXcgUE5HSW1hZ2VEZWNvZGVyKCk7CiAKKyNpZiAhUExBVEZP
Uk0oSEFJS1UpCiAgICAgLy8gSlBFRwotICAgIGlmICh1Q29udGVudHNbMF09PTB4RkYgJiYKLSAg
ICAgICAgdUNvbnRlbnRzWzFdPT0weEQ4ICYmCi0gICAgICAgIHVDb250ZW50c1syXT09MHhGRikK
KyAgICBpZiAodUNvbnRlbnRzWzBdID09IDB4RkYKKyAgICAgICAgJiYgdUNvbnRlbnRzWzFdID09
IDB4RDgKKyAgICAgICAgJiYgdUNvbnRlbnRzWzJdID09IDB4RkYpCiAgICAgICAgIHJldHVybiBu
ZXcgSlBFR0ltYWdlRGVjb2RlcigpOworI2VuZGlmCiAKICAgICAvLyBCTVAKLSAgICBpZiAoc3Ry
bmNtcChjb250ZW50cywgIkJNIiwgMikgPT0gMCkKKyAgICBpZiAoIXN0cm5jbXAoY29udGVudHMs
ICJCTSIsIDIpKQogICAgICAgICByZXR1cm4gbmV3IEJNUEltYWdlRGVjb2RlcigpOwogCiAgICAg
Ly8gSUNPcyBhbHdheXMgYmVnaW4gd2l0aCBhIDItYnl0ZSAwIGZvbGxvd2VkIGJ5IGEgMi1ieXRl
IDEuCiAgICAgLy8gQ1VScyBiZWdpbiB3aXRoIDItYnl0ZSAwIGZvbGxvd2VkIGJ5IDItYnl0ZSAy
LgotICAgIGlmICghbWVtY21wKGNvbnRlbnRzLCAiXDAwMFwwMDBcMDAxXDAwMCIsIDQpIHx8Ci0g
ICAgICAgICFtZW1jbXAoY29udGVudHMsICJcMDAwXDAwMFwwMDJcMDAwIiwgNCkpCisgICAgaWYg
KCFtZW1jbXAoY29udGVudHMsICJcMDAwXDAwMFwwMDFcMDAwIiwgNCkKKyAgICAgICAgfHwgIW1l
bWNtcChjb250ZW50cywgIlwwMDBcMDAwXDAwMlwwMDAiLCA0KSkKICAgICAgICAgcmV0dXJuIG5l
dyBJQ09JbWFnZURlY29kZXIoKTsKIAogICAgIC8vIFhCTXMgcmVxdWlyZSA4IGJ5dGVzIG9mIGlu
Zm8uCi0gICAgaWYgKGxlbmd0aCA+PSA4ICYmIHN0cm5jbXAoY29udGVudHMsICIjZGVmaW5lICIs
IDgpID09IDApCisgICAgaWYgKGxlbmd0aCA+PSA4ICYmICFzdHJuY21wKGNvbnRlbnRzLCAiI2Rl
ZmluZSAiLCA4KSkKICAgICAgICAgcmV0dXJuIG5ldyBYQk1JbWFnZURlY29kZXIoKTsKIAogICAg
IC8vIEdpdmUgdXAuIFdlIGRvbid0IGtub3cgd2hhdCB0aGUgaGVjayB0aGlzIGlzLg==
</data>
<flag name="review"
          id="18923"
          type_id="1"
          status="-"
          setter="eric"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>34762</attachid>
            <date>2009-08-13 11:47:57 -0700</date>
            <delta_ts>2009-08-13 11:49:02 -0700</delta_ts>
            <desc>Adding the lack of JPEG support to ImageSource.cpp</desc>
            <filename>Adding the lack of JPEG support to ImageSource.cpp.diff</filename>
            <type>text/plain</type>
            <size>2826</size>
            <attacher name="Maxime Simon">simon.maxime</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
NThlZjMzZC4uODcyMGJkNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi
Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0wOC0xMyAgTWF4aW1lIFNpbW9u
ICA8c2ltb24ubWF4aW1lQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg
KE9PUFMhKS4KKworICAgICAgICBbSGFpa3VdIEFkZGluZyB0aGUgbGFjayBvZiBKUEVHIHN1cHBv
cnQgdG8gSW1hZ2VTb3VyY2UuY3BwLgorICAgICAgICBGb3IgdGhlIG1vbWVudCB0aGUgSGFpa3Ug
cG9ydCBkb2Vzbid0IHN1cHBvcnQgSlBFRyAodGhlcmUgaXMgbm8gbGlianBlZworICAgICAgICBp
biB0aGUgZGVmYXVsdCBzeXN0ZW0pLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z
aG93X2J1Zy5jZ2k/aWQ9MjgyNTIKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0ltYWdl
U291cmNlLmNwcDogQWxzbyBzb21lIHN0eWxlIGNsZWFudXAuCisgICAgICAgIChXZWJDb3JlOjpj
cmVhdGVEZWNvZGVyKToKKwogMjAwOS0wOC0xMiAgSm9zZXBoIFBlY29yYXJvICA8am9lcGVjazAy
QGdtYWlsLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBUaW1vdGh5IEhhdGNoZXIuCmRpZmYg
LS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdlU291cmNlLmNwcCBiL1dlYkNv
cmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2VTb3VyY2UuY3BwCmluZGV4IDhmOTEwNDIuLjUxNWY3
NTYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2VTb3VyY2UuY3Bw
CisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2VTb3VyY2UuY3BwCkBAIC0zMSw3
ICszMSw5IEBACiAjaW5jbHVkZSAiQk1QSW1hZ2VEZWNvZGVyLmgiCiAjaW5jbHVkZSAiR0lGSW1h
Z2VEZWNvZGVyLmgiCiAjaW5jbHVkZSAiSUNPSW1hZ2VEZWNvZGVyLmgiCisjaWYgIVBMQVRGT1JN
KEhBSUtVKSAvLyBIYWlrdSBkb2Vzbid0IHNoaXAgbGlianBlZyByaWdodCBub3cuCiAjaW5jbHVk
ZSAiSlBFR0ltYWdlRGVjb2Rlci5oIgorI2VuZGlmCiAjaW5jbHVkZSAiUE5HSW1hZ2VEZWNvZGVy
LmgiCiAjaW5jbHVkZSAiWEJNSW1hZ2VEZWNvZGVyLmgiCiAjaW5jbHVkZSAiU2hhcmVkQnVmZmVy
LmgiCkBAIC00OSwzNCArNTEsMzYgQEAgSW1hZ2VEZWNvZGVyKiBjcmVhdGVEZWNvZGVyKGNvbnN0
IFZlY3RvcjxjaGFyPiYgZGF0YSkKICAgICBjb25zdCBjaGFyKiBjb250ZW50cyA9IGRhdGEuZGF0
YSgpOwogCiAgICAgLy8gR0lGcyBiZWdpbiB3aXRoIEdJRjgoNyBvciA5KS4KLSAgICBpZiAoc3Ry
bmNtcChjb250ZW50cywgIkdJRjgiLCA0KSA9PSAwKQorICAgIGlmICghc3RybmNtcChjb250ZW50
cywgIkdJRjgiLCA0KSkKICAgICAgICAgcmV0dXJuIG5ldyBHSUZJbWFnZURlY29kZXIoKTsKIAog
ICAgIC8vIFRlc3QgZm9yIFBORy4KLSAgICBpZiAodUNvbnRlbnRzWzBdPT0weDg5ICYmCi0gICAg
ICAgIHVDb250ZW50c1sxXT09MHg1MCAmJgotICAgICAgICB1Q29udGVudHNbMl09PTB4NEUgJiYK
LSAgICAgICAgdUNvbnRlbnRzWzNdPT0weDQ3KQorICAgIGlmICh1Q29udGVudHNbMF0gPT0gMHg4
OQorICAgICAgICAmJiB1Q29udGVudHNbMV0gPT0gMHg1MAorICAgICAgICAmJiB1Q29udGVudHNb
Ml0gPT0gMHg0RQorICAgICAgICAmJiB1Q29udGVudHNbM10gPT0gMHg0NykKICAgICAgICAgcmV0
dXJuIG5ldyBQTkdJbWFnZURlY29kZXIoKTsKIAorI2lmICFQTEFURk9STShIQUlLVSkKICAgICAv
LyBKUEVHCi0gICAgaWYgKHVDb250ZW50c1swXT09MHhGRiAmJgotICAgICAgICB1Q29udGVudHNb
MV09PTB4RDggJiYKLSAgICAgICAgdUNvbnRlbnRzWzJdPT0weEZGKQorICAgIGlmICh1Q29udGVu
dHNbMF0gPT0gMHhGRgorICAgICAgICAmJiB1Q29udGVudHNbMV0gPT0gMHhEOAorICAgICAgICAm
JiB1Q29udGVudHNbMl0gPT0gMHhGRikKICAgICAgICAgcmV0dXJuIG5ldyBKUEVHSW1hZ2VEZWNv
ZGVyKCk7CisjZW5kaWYKIAogICAgIC8vIEJNUAotICAgIGlmIChzdHJuY21wKGNvbnRlbnRzLCAi
Qk0iLCAyKSA9PSAwKQorICAgIGlmICghc3RybmNtcChjb250ZW50cywgIkJNIiwgMikpCiAgICAg
ICAgIHJldHVybiBuZXcgQk1QSW1hZ2VEZWNvZGVyKCk7CiAKICAgICAvLyBJQ09zIGFsd2F5cyBi
ZWdpbiB3aXRoIGEgMi1ieXRlIDAgZm9sbG93ZWQgYnkgYSAyLWJ5dGUgMS4KICAgICAvLyBDVVJz
IGJlZ2luIHdpdGggMi1ieXRlIDAgZm9sbG93ZWQgYnkgMi1ieXRlIDIuCi0gICAgaWYgKCFtZW1j
bXAoY29udGVudHMsICJcMDAwXDAwMFwwMDFcMDAwIiwgNCkgfHwKLSAgICAgICAgIW1lbWNtcChj
b250ZW50cywgIlwwMDBcMDAwXDAwMlwwMDAiLCA0KSkKKyAgICBpZiAoIW1lbWNtcChjb250ZW50
cywgIlwwMDBcMDAwXDAwMVwwMDAiLCA0KQorICAgICAgICB8fCAhbWVtY21wKGNvbnRlbnRzLCAi
XDAwMFwwMDBcMDAyXDAwMCIsIDQpKQogICAgICAgICByZXR1cm4gbmV3IElDT0ltYWdlRGVjb2Rl
cigpOwogCiAgICAgLy8gWEJNcyByZXF1aXJlIDggYnl0ZXMgb2YgaW5mby4KLSAgICBpZiAobGVu
Z3RoID49IDggJiYgc3RybmNtcChjb250ZW50cywgIiNkZWZpbmUgIiwgOCkgPT0gMCkKKyAgICBp
ZiAobGVuZ3RoID49IDggJiYgIXN0cm5jbXAoY29udGVudHMsICIjZGVmaW5lICIsIDgpKQogICAg
ICAgICByZXR1cm4gbmV3IFhCTUltYWdlRGVjb2RlcigpOwogCiAgICAgLy8gR2l2ZSB1cC4gV2Ug
ZG9uJ3Qga25vdyB3aGF0IHRoZSBoZWNrIHRoaXMgaXMu
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>34763</attachid>
            <date>2009-08-13 11:49:02 -0700</date>
            <delta_ts>2009-08-16 09:36:37 -0700</delta_ts>
            <desc>Adding the lack of JPEG support to ImageSource.cpp</desc>
            <filename>Adding the lack of JPEG support to ImageSource.cpp.diff</filename>
            <type>text/plain</type>
            <size>2867</size>
            <attacher name="Maxime Simon">simon.maxime</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
NThlZjMzZC4uODcyMGJkNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi
Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0wOC0xMyAgTWF4aW1lIFNpbW9u
ICA8c2ltb24ubWF4aW1lQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg
KE9PUFMhKS4KKworICAgICAgICBbSGFpa3VdIEFkZGluZyB0aGUgbGFjayBvZiBKUEVHIHN1cHBv
cnQgdG8gSW1hZ2VTb3VyY2UuY3BwLgorICAgICAgICBGb3IgdGhlIG1vbWVudCB0aGUgSGFpa3Ug
cG9ydCBkb2Vzbid0IHN1cHBvcnQgSlBFRyAodGhlcmUgaXMgbm8gbGlianBlZworICAgICAgICBp
biB0aGUgZGVmYXVsdCBzeXN0ZW0pLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z
aG93X2J1Zy5jZ2k/aWQ9MjgyNTIKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0ltYWdl
U291cmNlLmNwcDogQWxzbyBzb21lIHN0eWxlIGNsZWFudXAuCisgICAgICAgIChXZWJDb3JlOjpj
cmVhdGVEZWNvZGVyKToKKwogMjAwOS0wOC0xMiAgSm9zZXBoIFBlY29yYXJvICA8am9lcGVjazAy
QGdtYWlsLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBUaW1vdGh5IEhhdGNoZXIuCmRpZmYg
LS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdlU291cmNlLmNwcCBiL1dlYkNv
cmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2VTb3VyY2UuY3BwCmluZGV4IDhmOTEwNDIuLjUxNWY3
NTYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2VTb3VyY2UuY3Bw
CisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2VTb3VyY2UuY3BwCkBAIC0zMSw3
ICszMSw5IEBACiAjaW5jbHVkZSAiQk1QSW1hZ2VEZWNvZGVyLmgiCiAjaW5jbHVkZSAiR0lGSW1h
Z2VEZWNvZGVyLmgiCiAjaW5jbHVkZSAiSUNPSW1hZ2VEZWNvZGVyLmgiCisjaWYgIVBMQVRGT1JN
KEhBSUtVKSAvLyBIYWlrdSBkb2Vzbid0IHNoaXAgbGlianBlZyByaWdodCBub3cuCiAjaW5jbHVk
ZSAiSlBFR0ltYWdlRGVjb2Rlci5oIgorI2VuZGlmCiAjaW5jbHVkZSAiUE5HSW1hZ2VEZWNvZGVy
LmgiCiAjaW5jbHVkZSAiWEJNSW1hZ2VEZWNvZGVyLmgiCiAjaW5jbHVkZSAiU2hhcmVkQnVmZmVy
LmgiCkBAIC00OSwzNCArNTEsMzYgQEAgSW1hZ2VEZWNvZGVyKiBjcmVhdGVEZWNvZGVyKGNvbnN0
IFZlY3RvcjxjaGFyPiYgZGF0YSkKICAgICBjb25zdCBjaGFyKiBjb250ZW50cyA9IGRhdGEuZGF0
YSgpOwogCiAgICAgLy8gR0lGcyBiZWdpbiB3aXRoIEdJRjgoNyBvciA5KS4KLSAgICBpZiAoc3Ry
bmNtcChjb250ZW50cywgIkdJRjgiLCA0KSA9PSAwKQorICAgIGlmICghc3RybmNtcChjb250ZW50
cywgIkdJRjgiLCA0KSkKICAgICAgICAgcmV0dXJuIG5ldyBHSUZJbWFnZURlY29kZXIoKTsKIAog
ICAgIC8vIFRlc3QgZm9yIFBORy4KLSAgICBpZiAodUNvbnRlbnRzWzBdPT0weDg5ICYmCi0gICAg
ICAgIHVDb250ZW50c1sxXT09MHg1MCAmJgotICAgICAgICB1Q29udGVudHNbMl09PTB4NEUgJiYK
LSAgICAgICAgdUNvbnRlbnRzWzNdPT0weDQ3KQorICAgIGlmICh1Q29udGVudHNbMF0gPT0gMHg4
OQorICAgICAgICAmJiB1Q29udGVudHNbMV0gPT0gMHg1MAorICAgICAgICAmJiB1Q29udGVudHNb
Ml0gPT0gMHg0RQorICAgICAgICAmJiB1Q29udGVudHNbM10gPT0gMHg0NykKICAgICAgICAgcmV0
dXJuIG5ldyBQTkdJbWFnZURlY29kZXIoKTsKIAorI2lmICFQTEFURk9STShIQUlLVSkgLy8gSGFp
a3UgZG9lc24ndCBzaGlwIGxpYmpwZWcgcmlnaHQgbm93LgogICAgIC8vIEpQRUcKLSAgICBpZiAo
dUNvbnRlbnRzWzBdPT0weEZGICYmCi0gICAgICAgIHVDb250ZW50c1sxXT09MHhEOCAmJgotICAg
ICAgICB1Q29udGVudHNbMl09PTB4RkYpCisgICAgaWYgKHVDb250ZW50c1swXSA9PSAweEZGCisg
ICAgICAgICYmIHVDb250ZW50c1sxXSA9PSAweEQ4CisgICAgICAgICYmIHVDb250ZW50c1syXSA9
PSAweEZGKQogICAgICAgICByZXR1cm4gbmV3IEpQRUdJbWFnZURlY29kZXIoKTsKKyNlbmRpZgog
CiAgICAgLy8gQk1QCi0gICAgaWYgKHN0cm5jbXAoY29udGVudHMsICJCTSIsIDIpID09IDApCisg
ICAgaWYgKCFzdHJuY21wKGNvbnRlbnRzLCAiQk0iLCAyKSkKICAgICAgICAgcmV0dXJuIG5ldyBC
TVBJbWFnZURlY29kZXIoKTsKIAogICAgIC8vIElDT3MgYWx3YXlzIGJlZ2luIHdpdGggYSAyLWJ5
dGUgMCBmb2xsb3dlZCBieSBhIDItYnl0ZSAxLgogICAgIC8vIENVUnMgYmVnaW4gd2l0aCAyLWJ5
dGUgMCBmb2xsb3dlZCBieSAyLWJ5dGUgMi4KLSAgICBpZiAoIW1lbWNtcChjb250ZW50cywgIlww
MDBcMDAwXDAwMVwwMDAiLCA0KSB8fAotICAgICAgICAhbWVtY21wKGNvbnRlbnRzLCAiXDAwMFww
MDBcMDAyXDAwMCIsIDQpKQorICAgIGlmICghbWVtY21wKGNvbnRlbnRzLCAiXDAwMFwwMDBcMDAx
XDAwMCIsIDQpCisgICAgICAgIHx8ICFtZW1jbXAoY29udGVudHMsICJcMDAwXDAwMFwwMDJcMDAw
IiwgNCkpCiAgICAgICAgIHJldHVybiBuZXcgSUNPSW1hZ2VEZWNvZGVyKCk7CiAKICAgICAvLyBY
Qk1zIHJlcXVpcmUgOCBieXRlcyBvZiBpbmZvLgotICAgIGlmIChsZW5ndGggPj0gOCAmJiBzdHJu
Y21wKGNvbnRlbnRzLCAiI2RlZmluZSAiLCA4KSA9PSAwKQorICAgIGlmIChsZW5ndGggPj0gOCAm
JiAhc3RybmNtcChjb250ZW50cywgIiNkZWZpbmUgIiwgOCkpCiAgICAgICAgIHJldHVybiBuZXcg
WEJNSW1hZ2VEZWNvZGVyKCk7CiAKICAgICAvLyBHaXZlIHVwLiBXZSBkb24ndCBrbm93IHdoYXQg
dGhlIGhlY2sgdGhpcyBpcy4=
</data>

          </attachment>
      

    </bug>

</bugzilla>