28181 2009-08-11 10:41:21 -0700 RVCT elftran fails to resolve QPainter::staticMetaObject coming with QWebView::RenderHints property. 2009-08-14 07:50:33 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) S60 Emulator S60 3rd edition RESOLVED FIXED Qt P2 Normal --- 27065 1 yongjun.zhang webkit-unassigned eric hausmann laszlo.gombos oldest_to_newest 139035 0 yongjun.zhang 2009-08-11 10:41:21 -0700 QWebView::RenderHints property makes QWebView::staticMetaObject depends on QPainter::staticMetaObject with breaks RVCT elftran linking. We have to remove this property now, until the right symbol is exported. 139048 1 34579 yongjun.zhang 2009-08-11 11:30:16 -0700 Created attachment 34579 don't use RenderHint property when building for symbian. It is a temporary fix, should be reverted when the right symbol is exported from QT lib. 139243 2 34579 eric 2009-08-11 22:34:14 -0700 Comment on attachment 34579 don't use RenderHint property when building for symbian. The code you're adding should have a FIXME explaining the temporary nature. 139244 3 eric 2009-08-11 22:34:35 -0700 You also should file a bug about backing this out (and ideally link to it from your FIXME) 139976 4 34771 yongjun.zhang 2009-08-13 12:31:23 -0700 Created attachment 34771 Modified patch as per Eric's comments. Thanks for the quick review. I modified the patch as suggested in the comments: 1. created a bug (https://bugs.webkit.org/show_bug.cgi?id=28273) to remind me to revert the change later. 2. added //FIXME comment and link to the above bug. 139978 5 34771 eric 2009-08-13 12:40:04 -0700 Comment on attachment 34771 Modified patch as per Eric's comments. Tab in ChangeLog. r- as that will fail to land. So is there a bug with upstream Qt about getting this resolved? OR does nokia build some custom S60 Qt, and thus the bug would be with Nokia? 139983 6 34773 yongjun.zhang 2009-08-13 12:50:30 -0700 Created attachment 34773 Remove tab in previous patch (bad copy&paste habbit :) ) This bug will be fixed in upstream Qt for S60. This is a temporary fix to make webkit build with current Qt 4.5.2 for S60. 139989 7 eric 2009-08-13 13:13:14 -0700 Do we have a bug number for the upstream fix? 140012 8 hausmann 2009-08-13 13:52:00 -0700 Good point Eric, there is a bug number. I'll dig it out tomorrow. 140013 9 eric 2009-08-13 13:53:12 -0700 Thank you. I just figure it's best that we get all the documentation in the right place now, while we're making the change, instead of 3 years from now, when we're wondering if we can back it out or not. ;) 140180 10 hausmann 2009-08-14 01:34:30 -0700 The upstream bug report in Qt is tracked at http://qt.nokia.com/developer/task-tracker/index_html?method=entry&id=258893 140231 11 34773 hausmann 2009-08-14 07:48:41 -0700 Comment on attachment 34773 Remove tab in previous patch (bad copy&paste habbit :) ) r=me I'll change the url in the comment to the upstream bug url when landing. 140232 12 hausmann 2009-08-14 07:50:33 -0700 Landed in r47285 34579 2009-08-11 11:30:16 -0700 2009-08-13 12:31:23 -0700 don't use RenderHint property when building for symbian. elftran_rvct.patch text/plain 1480 yongjun.zhang SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNDcwMzgpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDktMDgtMTEgIFlvbmdqdW4gWmhhbmcgIDx5b25nanVu LnpoYW5nQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjgxODEK KworICAgICAgICBSVkNUIGVsZnRyYW4gZmFpbHMgdG8gcmVzb2x2ZSBRUGFpbnRlcjo6c3RhdGlj TWV0YU9iamVjdCBjb21pbmcgd2l0aCAKKyAgICAgICAgUVdlYlZpZXc6OlJlbmRlckhpbnRzIHBy b3BlcnR5LgorCisgICAgICAgIFRoaXMgaXMgYSB0ZW1wb3JhcnkgZml4IGFuZCB3aWxsIGJlIHJl dmVyZXRlZCB3aGVuIHRoZSByaWdodCBzeW1ib2xzCisgICAgICAgIGV4cG9ydGVkIGZyb20gUXQg bGliIGluIFM2MC4KKworICAgICAgICAqIEFwaS9xd2Vidmlldy5oOgorCiAyMDA5LTA4LTEwICBL YXZpbmRyYSBQYWxhcmFqYSAgPGthdmluZHJhLnBhbGFyYWphQG5va2lhLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFubi4KSW5kZXg6IFdlYktpdC9xdC9BcGkvcXdlYnZp ZXcuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvcXQvQXBpL3F3ZWJ2aWV3LmgJKHJldmlzaW9uIDQ3 MDM4KQorKysgV2ViS2l0L3F0L0FwaS9xd2Vidmlldy5oCSh3b3JraW5nIGNvcHkpCkBAIC01MCw3 ICs1MCw5IEBAIGNsYXNzIFFXRUJLSVRfRVhQT1JUIFFXZWJWaWV3IDogcHVibGljIFEKICAgICAv L1FfUFJPUEVSVFkoUXQ6OlRleHRJbnRlcmFjdGlvbkZsYWdzIHRleHRJbnRlcmFjdGlvbkZsYWdz IFJFQUQgdGV4dEludGVyYWN0aW9uRmxhZ3MgV1JJVEUgc2V0VGV4dEludGVyYWN0aW9uRmxhZ3Mp CiAgICAgUV9QUk9QRVJUWShxcmVhbCB0ZXh0U2l6ZU11bHRpcGxpZXIgUkVBRCB0ZXh0U2l6ZU11 bHRpcGxpZXIgV1JJVEUgc2V0VGV4dFNpemVNdWx0aXBsaWVyIERFU0lHTkFCTEUgZmFsc2UpCiAg ICAgUV9QUk9QRVJUWShxcmVhbCB6b29tRmFjdG9yIFJFQUQgem9vbUZhY3RvciBXUklURSBzZXRa b29tRmFjdG9yKQorI2lmICFkZWZpbmVkKFFfT1NfU1lNQklBTikKICAgICBRX1BST1BFUlRZKFFQ YWludGVyOjpSZW5kZXJIaW50cyByZW5kZXJIaW50cyBSRUFEIHJlbmRlckhpbnRzIFdSSVRFIHNl dFJlbmRlckhpbnRzKQorI2VuZGlmCiAgICAgUV9GTEFHUyhRUGFpbnRlcjo6UmVuZGVySGludHMp CiBwdWJsaWM6CiAgICAgZXhwbGljaXQgUVdlYlZpZXcoUVdpZGdldCogcGFyZW50ID0gMCk7Cg== 34771 2009-08-13 12:31:23 -0700 2009-08-13 12:50:30 -0700 Modified patch as per Eric's comments. elftran_symbol.patch text/plain 1715 yongjun.zhang SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNDcyMjQpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDktMDgtMTMgIFlvbmdqdW4gWmhhbmcgIDx5b25nanVu LnpoYW5nQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworCWh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yODE4MQorCisgICAg ICAgIFJWQ1QgZWxmdHJhbiBmYWlscyB0byByZXNvbHZlIFFQYWludGVyOjpzdGF0aWNNZXRhT2Jq ZWN0IGNvbWluZyB3aXRoIAorICAgICAgICBRV2ViVmlldzo6UmVuZGVySGludHMgcHJvcGVydHku CisKKyAgICAgICAgVGhpcyBpcyBhIHRlbXBvcmFyeSBmaXggYW5kIHdpbGwgYmUgcmV2ZXJldGVk IHdoZW4gdGhlIHJpZ2h0IHN5bWJvbHMKKyAgICAgICAgZXhwb3J0ZWQgZnJvbSBRdCBsaWIgaW4g UzYwLgorCisgICAgICAgICogQXBpL3F3ZWJ2aWV3Lmg6CisKIDIwMDktMDgtMTMgIE5vcmJlcnQg TGVzZXIgIDxub3JiZXJ0Lmxlc2VyQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBT aW1vbiBIYXVzbWFubi4KSW5kZXg6IFdlYktpdC9xdC9BcGkvcXdlYnZpZXcuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJLaXQvcXQvQXBpL3F3ZWJ2aWV3LmgJKHJldmlzaW9uIDQ3MDM4KQorKysgV2ViS2l0 L3F0L0FwaS9xd2Vidmlldy5oCSh3b3JraW5nIGNvcHkpCkBAIC01MCw3ICs1MCwxMyBAQCBjbGFz cyBRV0VCS0lUX0VYUE9SVCBRV2ViVmlldyA6IHB1YmxpYyBRCiAgICAgLy9RX1BST1BFUlRZKFF0 OjpUZXh0SW50ZXJhY3Rpb25GbGFncyB0ZXh0SW50ZXJhY3Rpb25GbGFncyBSRUFEIHRleHRJbnRl cmFjdGlvbkZsYWdzIFdSSVRFIHNldFRleHRJbnRlcmFjdGlvbkZsYWdzKQogICAgIFFfUFJPUEVS VFkocXJlYWwgdGV4dFNpemVNdWx0aXBsaWVyIFJFQUQgdGV4dFNpemVNdWx0aXBsaWVyIFdSSVRF IHNldFRleHRTaXplTXVsdGlwbGllciBERVNJR05BQkxFIGZhbHNlKQogICAgIFFfUFJPUEVSVFko cXJlYWwgem9vbUZhY3RvciBSRUFEIHpvb21GYWN0b3IgV1JJVEUgc2V0Wm9vbUZhY3RvcikKKwor Ly8gRklYTUU6IHRlbXBvcmFyeSB3b3JrIGFyb3VuZCBmb3IgZWxmdHJhbiBpc3N1ZSB0aGF0IGl0 IGNvdWxkbid0IGZpbmQgdGhlIFFQYWludGVyOjpzdGF0aWNNZXRhT2JqZWN0CisvLyBzeW1ib2wg ZnJvbSBRdCBsaWI7IGl0IHNob3VsZCBiZSByZXZlcnRlZCBhZnRlciB0aGUgcmlnaHQgc3ltYm9s IGlzIGV4cG9ydGVkLiAgCisvLyBTZWUgYnVnOiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjgyNzMKKyNpZiAhZGVmaW5lZChRX09TX1NZTUJJQU4pCiAgICAgUV9QUk9Q RVJUWShRUGFpbnRlcjo6UmVuZGVySGludHMgcmVuZGVySGludHMgUkVBRCByZW5kZXJIaW50cyBX UklURSBzZXRSZW5kZXJIaW50cykKKyNlbmRpZgogICAgIFFfRkxBR1MoUVBhaW50ZXI6OlJlbmRl ckhpbnRzKQogcHVibGljOgogICAgIGV4cGxpY2l0IFFXZWJWaWV3KFFXaWRnZXQqIHBhcmVudCA9 IDApOwo= 34773 2009-08-13 12:50:30 -0700 2009-08-14 07:48:41 -0700 Remove tab in previous patch (bad copy&paste habbit :) ) elftran_symbol.patch text/plain 1730 yongjun.zhang SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNDcyMjQpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDktMDgtMTMgIFlvbmdqdW4gWmhhbmcgIDx5b25nanVu LnpoYW5nQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KyAgICAgICAgCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yODE4MQorCisgICAgICAgIFJWQ1QgZWxmdHJhbiBmYWlscyB0byByZXNvbHZlIFFQYWludGVy OjpzdGF0aWNNZXRhT2JqZWN0IGNvbWluZyB3aXRoIAorICAgICAgICBRV2ViVmlldzo6UmVuZGVy SGludHMgcHJvcGVydHkuCisKKyAgICAgICAgVGhpcyBpcyBhIHRlbXBvcmFyeSBmaXggYW5kIHdp bGwgYmUgcmV2ZXJldGVkIHdoZW4gdGhlIHJpZ2h0IHN5bWJvbHMKKyAgICAgICAgZXhwb3J0ZWQg ZnJvbSBRdCBsaWIgaW4gUzYwLgorCisgICAgICAgICogQXBpL3F3ZWJ2aWV3Lmg6CisKIDIwMDkt MDgtMTMgIE5vcmJlcnQgTGVzZXIgIDxub3JiZXJ0Lmxlc2VyQG5va2lhLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFubi4KSW5kZXg6IFdlYktpdC9xdC9BcGkvcXdlYnZp ZXcuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvcXQvQXBpL3F3ZWJ2aWV3LmgJKHJldmlzaW9uIDQ3 MDM4KQorKysgV2ViS2l0L3F0L0FwaS9xd2Vidmlldy5oCSh3b3JraW5nIGNvcHkpCkBAIC01MCw3 ICs1MCwxMyBAQCBjbGFzcyBRV0VCS0lUX0VYUE9SVCBRV2ViVmlldyA6IHB1YmxpYyBRCiAgICAg Ly9RX1BST1BFUlRZKFF0OjpUZXh0SW50ZXJhY3Rpb25GbGFncyB0ZXh0SW50ZXJhY3Rpb25GbGFn cyBSRUFEIHRleHRJbnRlcmFjdGlvbkZsYWdzIFdSSVRFIHNldFRleHRJbnRlcmFjdGlvbkZsYWdz KQogICAgIFFfUFJPUEVSVFkocXJlYWwgdGV4dFNpemVNdWx0aXBsaWVyIFJFQUQgdGV4dFNpemVN dWx0aXBsaWVyIFdSSVRFIHNldFRleHRTaXplTXVsdGlwbGllciBERVNJR05BQkxFIGZhbHNlKQog ICAgIFFfUFJPUEVSVFkocXJlYWwgem9vbUZhY3RvciBSRUFEIHpvb21GYWN0b3IgV1JJVEUgc2V0 Wm9vbUZhY3RvcikKKworLy8gRklYTUU6IHRlbXBvcmFyeSB3b3JrIGFyb3VuZCBmb3IgZWxmdHJh biBpc3N1ZSB0aGF0IGl0IGNvdWxkbid0IGZpbmQgdGhlIFFQYWludGVyOjpzdGF0aWNNZXRhT2Jq ZWN0CisvLyBzeW1ib2wgZnJvbSBRdCBsaWI7IGl0IHNob3VsZCBiZSByZXZlcnRlZCBhZnRlciB0 aGUgcmlnaHQgc3ltYm9sIGlzIGV4cG9ydGVkLiAgCisvLyBTZWUgYnVnOiBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjgyNzMKKyNpZiAhZGVmaW5lZChRX09TX1NZTUJJ QU4pCiAgICAgUV9QUk9QRVJUWShRUGFpbnRlcjo6UmVuZGVySGludHMgcmVuZGVySGludHMgUkVB RCByZW5kZXJIaW50cyBXUklURSBzZXRSZW5kZXJIaW50cykKKyNlbmRpZgogICAgIFFfRkxBR1Mo UVBhaW50ZXI6OlJlbmRlckhpbnRzKQogcHVibGljOgogICAgIGV4cGxpY2l0IFFXZWJWaWV3KFFX aWRnZXQqIHBhcmVudCA9IDApOwo=