<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>281717</bug_id>
          
          <creation_ts>2024-10-17 19:43:26 -0700</creation_ts>
          <short_desc>[Tools][WPE] generate-bundle: fix shipping of inspector.gresource after 284551@main</short_desc>
          <delta_ts>2024-10-18 04:22:37 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WPE WebKit</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=280512</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Carlos Alberto Lopez Perez">clopez</reporter>
          <assigned_to name="Carlos Alberto Lopez Perez">clopez</assigned_to>
          <cc>aperez</cc>
    
    <cc>bugs-noreply</cc>
    
    <cc>dpino</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2068989</commentid>
    <comment_count>0</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2024-10-17 19:43:26 -0700</bug_when>
    <thetext>Since 284269@main the &apos;InspectorResource&apos; library no longer exists for WPE so that makes the script generate-bundle fail when it tries to add it to the bundle.

See: https://build.webkit.org/#/builders/1322/builds/2

284551@main attempted to fix this but it didn&apos;t because the script is still trying to copy that library as you can see above

Also the new file inspector.gresource file that is copied to the bundle root path doesn&apos;t actually work because WPE is unable to find the file at runtime because we are not specifying it.

You can check that if you export the env var WEBKIT_INSPECTOR_HTTP_SERVER=127.0.0.1:8186 so the webinspector starts then WPE crashes.

So we need to copy this file to a share sub-directory inside the bundle and export the required env var on the wrapper.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2068990</commentid>
    <comment_count>1</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2024-10-17 19:46:37 -0700</bug_when>
    <thetext>&gt; Also the new file inspector.gresource file that is copied to the bundle root path doesn&apos;t actually work because WPE is unable to find the file at runtime because we are not specifying it.

I mean that we are not exporting the WEBKIT_INSPECTOR_RESOURCES_PATH env var to tell WPE where is the gresource file, so WPE defaults to load it from /usr/local/share/wpe-webkit-2.0/ which is not what we want.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2068993</commentid>
    <comment_count>2</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2024-10-17 19:53:09 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/35403</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2069076</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2024-10-18 04:22:34 -0700</bug_when>
    <thetext>Committed 285389@main (316bb9885276): &lt;https://commits.webkit.org/285389@main&gt;

Reviewed commits have been landed. Closing PR #35403 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>