28069 2009-08-07 08:15:51 -0700 Add inline to help winscw compiler resolve specialized argument in templated functions. 2009-08-07 13:15:55 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) S60 Emulator S60 3rd edition RESOLVED FIXED Qt P2 Normal --- 27065 1 yongjun.zhang webkit-unassigned abarth eric oldest_to_newest 137884 0 yongjun.zhang 2009-08-07 08:15:51 -0700 Wiscw compiler cannot resolve template argument "mode" from the following code: ---------------------------------------------------- template <int mode> void test_function() { int m = mode; // it complains mode is not defined } ---------------------------------------------------- If we inline this function, the compiler won't report the error. 137912 1 34281 yongjun.zhang 2009-08-07 09:03:07 -0700 Created attachment 34281 Add inline to help winscw compiler resolve specialized argument in templated functions. The inline is only enabled for winscw compiler; for other compilers, it will be disabled to avoid increasing the binary size. 137913 2 34281 eric 2009-08-07 09:04:57 -0700 Comment on attachment 34281 Add inline to help winscw compiler resolve specialized argument in templated functions. I don't see why this can't be inline for all compilers. "inline" is a hint anyway. Compilers can (and will) ignore it. 137915 3 eric 2009-08-07 09:05:37 -0700 you could add a comment about how "inline" is required there to help the winscw compiler if you like. 137971 4 34292 yongjun.zhang 2009-08-07 10:46:18 -0700 Created attachment 34292 Modified patch as per Eric's comments. Thanks for the quick review. The new patch removes winscw compiler specific flag. 137978 5 34292 eric 2009-08-07 10:49:35 -0700 Comment on attachment 34292 Modified patch as per Eric's comments. LGTM. 138085 6 34292 abarth 2009-08-07 13:15:50 -0700 Comment on attachment 34292 Modified patch as per Eric's comments. Clearing review flag on attachment: 34292 Committing to http://svn.webkit.org/repository/webkit/trunk ... M JavaScriptCore/ChangeLog M JavaScriptCore/runtime/LiteralParser.cpp Committed r46910 M LayoutTests/platform/mac/Skipped M LayoutTests/platform/win/Skipped M LayoutTests/ChangeLog r46909 = b66fe77cc3bbc2d501a8b5d5a3fc7dd3d62d7df0 (trunk) M JavaScriptCore/runtime/LiteralParser.cpp M JavaScriptCore/ChangeLog r46910 = 0fc235ef070baf8ffb224dc034ba71c824933021 (trunk) First, rewinding head to replay your work on top of it... Nothing to do. http://trac.webkit.org/changeset/46910 138086 7 abarth 2009-08-07 13:15:55 -0700 All reviewed patches have been landed. Closing bug. 34281 2009-08-07 09:03:07 -0700 2009-08-07 09:04:56 -0700 Add inline to help winscw compiler resolve specialized argument in templated functions. literalParser_inline.patch text/plain 1412 yongjun.zhang SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQ2ODkxKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMDgtMDcgIFlvbmdqdW4g WmhhbmcgIDx5b25nanVuLnpoYW5nQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjgwNjkKKworICAgICAgICBBZGQgaW5saW5lIHRvIGhlbHAgd2luc2N3IGNvbXBp bGVyIHJlc29sdmUgc3BlY2lhbGl6ZWQgYXJndW1lbnQgaW4gCisgICAgICAgIHRlbXBsYXRlZCBm dW5jdGlvbnMuICAgICAgICAKKworICAgICAgICAqIHJ1bnRpbWUvTGl0ZXJhbFBhcnNlci5jcHA6 CisgICAgICAgIChKU0M6OkxpdGVyYWxQYXJzZXI6OkxleGVyOjpsZXhTdHJpbmcpOgorCiAyMDA5 LTA4LTA2ICBOb3JiZXJ0IExlc2VyICA8bm9yYmVydC5sZXNlckBub2tpYS5jb20+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBKYXZhU2NyaXB0Q29yZS9ydW50aW1l L0xpdGVyYWxQYXJzZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL3J1bnRpbWUv TGl0ZXJhbFBhcnNlci5jcHAJKHJldmlzaW9uIDQ2ODkwKQorKysgSmF2YVNjcmlwdENvcmUvcnVu dGltZS9MaXRlcmFsUGFyc2VyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTI5LDcgKzEyOSwxMSBA QCB0ZW1wbGF0ZSA8TGl0ZXJhbFBhcnNlcjo6UGFyc2VyTW9kZSBtb2RlCiAgICAgcmV0dXJuIChj ID49ICcgJyAmJiAobW9kZSA9PSBMaXRlcmFsUGFyc2VyOjpTdHJpY3RKU09OIHx8IGMgPD0gMHhm ZikgJiYgYyAhPSAnXFwnICYmIGMgIT0gJyInKSB8fCBjID09ICdcdCc7CiB9CiAKLXRlbXBsYXRl IDxMaXRlcmFsUGFyc2VyOjpQYXJzZXJNb2RlIG1vZGU+IExpdGVyYWxQYXJzZXI6OlRva2VuVHlw ZSBMaXRlcmFsUGFyc2VyOjpMZXhlcjo6bGV4U3RyaW5nKExpdGVyYWxQYXJzZXJUb2tlbiYgdG9r ZW4pCit0ZW1wbGF0ZSA8TGl0ZXJhbFBhcnNlcjo6UGFyc2VyTW9kZSBtb2RlPgorI2lmIENPTVBJ TEVSKFdJTlNDVykKK2lubGluZQorI2VuZGlmCitMaXRlcmFsUGFyc2VyOjpUb2tlblR5cGUgTGl0 ZXJhbFBhcnNlcjo6TGV4ZXI6OmxleFN0cmluZyhMaXRlcmFsUGFyc2VyVG9rZW4mIHRva2VuKQog ewogICAgICsrbV9wdHI7CiAgICAgY29uc3QgVUNoYXIqIHJ1blN0YXJ0Owo= 34292 2009-08-07 10:46:18 -0700 2009-08-07 13:15:49 -0700 Modified patch as per Eric's comments. literalParser_inline.patch text/plain 1480 yongjun.zhang SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQ2ODk1KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMDgtMDcgIFlvbmdqdW4g WmhhbmcgIDx5b25nanVuLnpoYW5nQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjgwNjkKKworICAgICAgICBBZGQgaW5saW5lIHRvIGhlbHAgd2luc2N3IGNvbXBp bGVyIHJlc29sdmUgc3BlY2lhbGl6ZWQgYXJndW1lbnQgaW4gCisgICAgICAgIHRlbXBsYXRlZCBm dW5jdGlvbnMuICAKKworICAgICAgICAqIHJ1bnRpbWUvTGl0ZXJhbFBhcnNlci5jcHA6CisgICAg ICAgIChKU0M6OkxpdGVyYWxQYXJzZXI6OkxleGVyOjpsZXhTdHJpbmcpOgorCiAyMDA5LTA4LTA2 ICBOb3JiZXJ0IExlc2VyICA8bm9yYmVydC5sZXNlckBub2tpYS5jb20+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL0xpdGVy YWxQYXJzZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL3J1bnRpbWUvTGl0ZXJh bFBhcnNlci5jcHAJKHJldmlzaW9uIDQ2ODkwKQorKysgSmF2YVNjcmlwdENvcmUvcnVudGltZS9M aXRlcmFsUGFyc2VyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTI5LDcgKzEyOSw4IEBAIHRlbXBs YXRlIDxMaXRlcmFsUGFyc2VyOjpQYXJzZXJNb2RlIG1vZGUKICAgICByZXR1cm4gKGMgPj0gJyAn ICYmIChtb2RlID09IExpdGVyYWxQYXJzZXI6OlN0cmljdEpTT04gfHwgYyA8PSAweGZmKSAmJiBj ICE9ICdcXCcgJiYgYyAhPSAnIicpIHx8IGMgPT0gJ1x0JzsKIH0KIAotdGVtcGxhdGUgPExpdGVy YWxQYXJzZXI6OlBhcnNlck1vZGUgbW9kZT4gTGl0ZXJhbFBhcnNlcjo6VG9rZW5UeXBlIExpdGVy YWxQYXJzZXI6OkxleGVyOjpsZXhTdHJpbmcoTGl0ZXJhbFBhcnNlclRva2VuJiB0b2tlbikKKy8v ICJpbmxpbmUiIGlzIHJlcXVpcmVkIGhlcmUgdG8gaGVscCBXSU5TQ1cgY29tcGlsZXIgcmVzb2x2 ZSBzcGVjaWFsaXplZCBhcmd1bWVudCBpbiB0ZW1wbGF0ZWQgZnVuY3Rpb25zLgordGVtcGxhdGUg PExpdGVyYWxQYXJzZXI6OlBhcnNlck1vZGUgbW9kZT4gaW5saW5lIExpdGVyYWxQYXJzZXI6OlRv a2VuVHlwZSBMaXRlcmFsUGFyc2VyOjpMZXhlcjo6bGV4U3RyaW5nKExpdGVyYWxQYXJzZXJUb2tl biYgdG9rZW4pCiB7CiAgICAgKyttX3B0cjsKICAgICBjb25zdCBVQ2hhciogcnVuU3RhcnQ7Cg==