278908 2024-08-30 02:06:09 -0700 [GTK][WPE][Skia] Invalid result or crash when painting an accelerated ImageBitmap into WebGL 2024-11-26 01:06:15 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=283704 P2 Normal --- 1 magomez plampe bugs-noreply plampe oldest_to_newest 2056496 0 magomez 2024-08-30 02:06:09 -0700 A common pattern when rendering to WebGL is creating an ImageBitmap, rendering into it, and then uploading the result into a WebGL texture. This is typically done for text rendering, for example. When the created ImageBitmap is big enough, it's created as accelerated, which means that it's backed by a gl texture instead of a normal buffer. In this case, trying to render the content of that ImageBitmap won't work as expected. It may cause a crash or fail to actually render properly. The problem can be avoided by not accelerating ImageBitmaps, which is why I know that the problem is related to the accelerated ones. It can be reproduced with https://strike.lightningjs.io/es6/#home where the rendering will be wrong. 2057560 1 472446 plampe 2024-09-04 05:48:20 -0700 Created attachment 472446 minimal reproducing example 2057561 2 plampe 2024-09-04 05:50:48 -0700 The issue is about worker with context B creating accelerated ImageBitmap, transferring it (with ownership) to the main, and the main thread with context A using such ImageBitmap (context B) in texImage2D() and therefore leading to failure of when reading pixels - due to skia GrDirectContext mismatch. 2057588 3 plampe 2024-09-04 08:18:19 -0700 Pull request: https://github.com/WebKit/WebKit/pull/33122 2059705 4 ews-feeder 2024-09-12 09:56:34 -0700 Committed 283563@main (b2b8d3a40c38): <https://commits.webkit.org/283563@main> Reviewed commits have been landed. Closing PR #33122 and removing active labels. 472446 2024-09-04 05:48:20 -0700 2024-09-04 05:48:20 -0700 minimal reproducing example index.html text/html 3624 plampe PGh0bWw+CiAgPGhlYWQ+CiAgICA8c2NyaXB0IGlkPSdteVdvcmtlcicgdHlwZT0ndGV4dC93b3Jr ZXInPgogICAgICBzZWxmLm9ubWVzc2FnZSA9IGZ1bmN0aW9uKG1zZykgewogICAgICAgICAgdmFy IGltZyA9IG1zZy5kYXRhOwogICAgICAgICAgY29uc29sZS5sb2coImdvdCBtc2cgZnJvbSBtYWlu OiIgKyBpbWcpOwogICAgICAgICAgdmFyIGdldE9mZnNjcmVlbkNhbnZhc0ZvckZpbHRlciA9IGZ1 bmN0aW9uKGZpbHRlciwgcGF0dGVybikgewogICAgICAgICAgICAgIHZhciBvYyA9IG5ldyBPZmZz Y3JlZW5DYW52YXMoODAsIDgwKTsKICAgICAgICAgICAgICB2YXIgb2ZmQ3R4ID0gb2MuZ2V0Q29u dGV4dCgnMmQnKTsKICAgICAgICAgICAgICBvZmZDdHguZmlsdGVyID0gZmlsdGVyOwogICAgICAg ICAgICAgIG9mZkN0eC5kcmF3SW1hZ2UocGF0dGVybiwgNSwgNSk7CiAgICAgICAgICAgICAgb2Zm Q3R4LmRyYXdJbWFnZShwYXR0ZXJuLCAyNSwgMjUpOwogICAgICAgICAgICAgIG9mZkN0eC5kcmF3 SW1hZ2UocGF0dGVybiwgNDUsIDQ1KTsKICAgICAgICAgICAgICAvLyBjb25zb2xlLmxvZygib2Zm Q3R4OiAiICsgb2ZmQ3R4LmdldEltYWdlRGF0YSgwLCAwLCA4MCwgODApLmRhdGEpOwogICAgICAg ICAgICAgIHJldHVybiBvYzsKICAgICAgICAgIH07CgogICAgICAgICAgdmFyIG9jID0gZ2V0T2Zm c2NyZWVuQ2FudmFzRm9yRmlsdGVyKCdub25lJywgaW1nKTsKICAgICAgICAgIHZhciBpbWFnZUJp dG1hcCA9IG9jLnRyYW5zZmVyVG9JbWFnZUJpdG1hcCgpOwogICAgICAgICAgc2VsZi5wb3N0TWVz c2FnZShpbWFnZUJpdG1hcCk7CiAgICAgIH07CiAgICA8L3NjcmlwdD4KICA8L2hlYWQ+CiAgPGJv ZHk+CiAgICA8Y2FudmFzIGlkPSJjYW52YXMiIHdpZHRoPSI1MDAiIGhlaWdodD0iMjAwIiBzdHls ZT0iYm9yZGVyOiAxcHggc29saWQgIzAwMCIvPgogICAgPHNjcmlwdD4KICAgICAgdmFyIGNyZWF0 ZVBhdHRlcm5DYW52YXMgPSBmdW5jdGlvbigpIHsKICAgICAgICAgIHZhciBwYXR0ZXJuQ2FudmFz ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgnY2FudmFzJyk7CiAgICAgICAgICBwYXR0ZXJuQ2Fu dmFzLndpZHRoID0gMjA7CiAgICAgICAgICBwYXR0ZXJuQ2FudmFzLmhlaWdodCA9IDIwOwogICAg ICAgICAgdmFyIHBhdHRlcm5DdHggPSBwYXR0ZXJuQ2FudmFzLmdldENvbnRleHQoJzJkJyk7CiAg ICAgICAgICBwYXR0ZXJuQ3R4LmZpbGxTdHlsZSA9ICcjQTAwJzsKICAgICAgICAgIHBhdHRlcm5D dHguZmlsbFJlY3QoMCwgMCwgMTAsIDEwKTsKICAgICAgICAgIHBhdHRlcm5DdHguZmlsbFN0eWxl ID0gJyMwQTAnOwogICAgICAgICAgcGF0dGVybkN0eC5maWxsUmVjdCgxMCwgMCwgMTAsIDEwKTsK ICAgICAgICAgIHBhdHRlcm5DdHguZmlsbFN0eWxlID0gJyMwMEEnOwogICAgICAgICAgcGF0dGVy bkN0eC5maWxsUmVjdCgwLCAxMCwgMTAsIDEwKTsKICAgICAgICAgIHBhdHRlcm5DdHguZmlsbFN0 eWxlID0gIiNBQTAiOwogICAgICAgICAgcGF0dGVybkN0eC5maWxsUmVjdCgxMCwgMTAsIDEwLCAx MCk7CiAgICAgICAgICByZXR1cm4gcGF0dGVybkNhbnZhczsKICAgICAgfTsKICAgICAgLy8gdmFy IGdldFJlZ3VsYXJDb250ZXh0Rm9yRmlsdGVyID0gZnVuY3Rpb24oZmlsdGVyLCBwYXR0ZXJuKSB7 CiAgICAgIC8vICAgICB2YXIgYyA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImNhbnZhcyIpOwog ICAgICAvLyAgICAgYy53aWR0aCA9IGMuaGVpZ2h0ID0gODA7CiAgICAgIC8vICAgICB2YXIgY3R4 ID0gYy5nZXRDb250ZXh0KCcyZCcpOwogICAgICAvLyAgICAgY29uc29sZS5sb2coJ2dldFJlZ3Vs YXJDb250ZXh0Rm9yRmlsdGVyOicrZmlsdGVyKTsKICAgICAgLy8gICAgIGN0eC5maWx0ZXIgPSBm aWx0ZXI7CiAgICAgIC8vICAgICBjdHguZHJhd0ltYWdlKHBhdHRlcm4sIDUsIDUpOwogICAgICAv LyAgICAgY3R4LmRyYXdJbWFnZShwYXR0ZXJuLCAyNSwgMjUpOwogICAgICAvLyAgICAgY3R4LmRy YXdJbWFnZShwYXR0ZXJuLCA0NSwgNDUpOwogICAgICAvLyAgICAgcmV0dXJuIGN0eDsKICAgICAg Ly8gfTsKICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudHNCeVRhZ05hbWUoImJvZHkiKVswXS5vbmxv YWQgPSBhc3luYyAoKSA9PiB7CiAgICAgICAgICB2YXIgcGF0dGVybkNhbnZhcyA9IGNyZWF0ZVBh dHRlcm5DYW52YXMoKTsKICAgICAgICAgIC8vIGdldFJlZ3VsYXJDb250ZXh0Rm9yRmlsdGVyKCJu b25lIiwgcGF0dGVybkNhbnZhcyk7CiAgICAgICAgICB2YXIgcGF0dGVybiA9IGF3YWl0IGNyZWF0 ZUltYWdlQml0bWFwKHBhdHRlcm5DYW52YXMpOwogICAgICAgICAgaWYgKHRydWUpIHsKICAgICAg ICAgICAgICB2YXIgY2FudmFzID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImNhbnZhcyIpOwog ICAgICAgICAgICAgIHZhciBjdHggPSBjYW52YXMuZ2V0Q29udGV4dCgnMmQnKTsKICAgICAgICAg ICAgICBjdHguZHJhd0ltYWdlKHBhdHRlcm4sIDUsIDUpOwogICAgICAgICAgfQogICAgICAgICAg Ly8gc3luYwogICAgICAgICAgLy8gdmFyIG9jID0gbmV3IE9mZnNjcmVlbkNhbnZhcyg4MCwgODAp OwogICAgICAgICAgLy8gdmFyIG9mZkN0eCA9IG9jLmdldENvbnRleHQoJzJkJyk7CiAgICAgICAg ICAvLyBvZmZDdHguZmlsdGVyID0gJ2JsdXIoMTBweCknOwogICAgICAgICAgLy8gb2ZmQ3R4LmRy YXdJbWFnZShwYXR0ZXJuLCA1LCA1KTsKICAgICAgICAgIC8vIG9mZkN0eC5kcmF3SW1hZ2UocGF0 dGVybiwgMjUsIDI1KTsKICAgICAgICAgIC8vIG9mZkN0eC5kcmF3SW1hZ2UocGF0dGVybiwgNDUs IDQ1KTsKICAgICAgICAgIC8vIHZhciBvY0ltYWdlQml0bWFwID0gb2MudHJhbnNmZXJUb0ltYWdl Qml0bWFwKCk7CiAgICAgICAgICAvLyB2YXIgY2FudmFzID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5 SWQoImNhbnZhcyIpOwogICAgICAgICAgLy8gdmFyIGN0eCA9IGNhbnZhcy5nZXRDb250ZXh0KCcy ZCcpOwogICAgICAgICAgLy8gY3R4LmRyYXdJbWFnZShvY0ltYWdlQml0bWFwLCAwLCAwKTsKCiAg ICAgICAgICAvLyB3b3JrZXJzOgogICAgICAgICAgdmFyIGJsb2IgPSBuZXcgQmxvYihbZG9jdW1l bnQuZ2V0RWxlbWVudEJ5SWQoJ215V29ya2VyJykudGV4dENvbnRlbnRdKTsKICAgICAgICAgIHZh ciB3b3JrZXIgPSBuZXcgV29ya2VyKFVSTC5jcmVhdGVPYmplY3RVUkwoYmxvYikpOwogICAgICAg ICAgd29ya2VyLmFkZEV2ZW50TGlzdGVuZXIoJ21lc3NhZ2UnLCBtc2cgPT4gewogICAgICAgICAg ICAgIGNvbnNvbGUubG9nKCJnb3QgbXNnIGZyb20gd29ya2VyOiIgKyBtc2cuZGF0YSk7CiAgICAg ICAgICAgICAgdmFyIGNhbnZhcyA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJjYW52YXMiKTsK ICAgICAgICAgICAgICB2YXIgY3R4ID0gY2FudmFzLmdldENvbnRleHQoJzJkJyk7CiAgICAgICAg ICAgICAgY3R4LmRyYXdJbWFnZShtc2cuZGF0YSwgODAsIDApOwogICAgICAgICAgfSk7CiAgICAg ICAgICB3b3JrZXIucG9zdE1lc3NhZ2UocGF0dGVybiwgW3BhdHRlcm5dKTsgLy8gaGVyZSdzIHRo ZSB0aGluZwogICAgICAgICAgLy8gd29ya2VyLnBvc3RNZXNzYWdlKHBhdHRlcm4pOwogICAgICB9 CiAgICA8L3NjcmlwdD4KICA8L2JvZHk+CjwvaHRtbD4K