<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>278460</bug_id>
          
          <creation_ts>2024-08-21 05:16:07 -0700</creation_ts>
          <short_desc>[GLib] Improve FPS counter</short_desc>
          <delta_ts>2025-04-29 05:11:50 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WPE WebKit</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>268972</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Pawel Lampe">plampe</reporter>
          <assigned_to name="Diego Pino">dpino</assigned_to>
          <cc>bugs-noreply</cc>
    
    <cc>dpino</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2054395</commentid>
    <comment_count>0</comment_count>
    <who name="Pawel Lampe">plampe</who>
    <bug_when>2024-08-21 05:16:07 -0700</bug_when>
    <thetext>Currently - in skia builds - the FPS counter (that used to be shown when WEBKIT_SHOW_FPS=1) is not displayed</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2054663</commentid>
    <comment_count>1</comment_count>
    <who name="Pawel Lampe">plampe</who>
    <bug_when>2024-08-22 02:21:15 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/32580</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2110410</commentid>
    <comment_count>2</comment_count>
    <who name="Pawel Lampe">plampe</who>
    <bug_when>2025-04-11 06:11:23 -0700</bug_when>
    <thetext>As drawing FPS counter interferes with the graphics pipeline it should be avoided - it would be ideal to log FPS instead.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2113261</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2025-04-26 00:50:09 -0700</bug_when>
    <thetext>Committed 294148@main (b7df35a60c2f): &lt;https://commits.webkit.org/294148@main&gt;

Reviewed commits have been landed. Closing PR #32580 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2113785</commentid>
    <comment_count>4</comment_count>
    <who name="Diego Pino">dpino</who>
    <bug_when>2025-04-29 01:06:47 -0700</bug_when>
    <thetext>This changeset broke the build for WPE in ARM-32 bit architectures.

https://build.webkit.org/#/builders/860/builds/19500

The reason is the changeset made use of the data type `std::atomic&lt;std::optional&lt;double&gt;&gt;`. The size of an optional is the size of the data type it stores plus the size of bool, which in this case is 9-bytes. In 32-bit architectures, atomic data types larger than 8-bytes require linking with libatomic. There was a test in the CMake files to determining whether to link with libatomic or not, but this use case was not managed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2113786</commentid>
    <comment_count>5</comment_count>
    <who name="Diego Pino">dpino</who>
    <bug_when>2025-04-29 01:08:01 -0700</bug_when>
    <thetext>Re-opening for pull request https://github.com/WebKit/WebKit/pull/44664</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2113853</commentid>
    <comment_count>6</comment_count>
    <who name="Diego Pino">dpino</who>
    <bug_when>2025-04-29 04:47:17 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/44682</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2113856</commentid>
    <comment_count>7</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2025-04-29 05:11:47 -0700</bug_when>
    <thetext>Committed 294245@main (20c693e72e84): &lt;https://commits.webkit.org/294245@main&gt;

Reviewed commits have been landed. Closing PR #44682 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>