27846 2009-07-30 11:58:10 -0700 MessageEvent should not be cancelable by default 2009-09-15 14:58:41 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 atwilson atwilson ap eric oldest_to_newest 135910 0 atwilson 2009-07-30 11:58:10 -0700 Currently, all MessageEvents are cancelable by default, but all of the uses in the HTML5 spec specify that it should not be. For example (from the spec for window.postMessage): "Create an event that uses the MessageEvent interface, with the event name message, which does not bubble, is not cancelable, and has no default action." 147237 1 39583 atwilson 2009-09-14 18:03:53 -0700 Created attachment 39583 proposed patch 147240 2 39583 commit-queue 2009-09-14 18:34:28 -0700 Comment on attachment 39583 proposed patch Rejecting patch 39583 from commit-queue. This patch will require manual commit. ['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1'] failed with exit code 1 147323 3 39583 eric 2009-09-15 10:45:12 -0700 Comment on attachment 39583 proposed patch media/video-source-error.html -> timed out You've been bit by flakey media tests. :( bug 28624. Hopefully I'll get a chance to look at fixing that after perf stuff today. 147332 4 atwilson 2009-09-15 10:54:27 -0700 OK, I'm ready to manually commit it anyway - if the commit-queue fails again I'll just manually commit. When I get a commit-queue failure, is there any way for me to tell what the failure was? 147336 5 39583 commit-queue 2009-09-15 10:57:57 -0700 Comment on attachment 39583 proposed patch Rejecting patch 39583 from commit-queue. This patch will require manual commit. ['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1'] failed with exit code 1 147345 6 atwilson 2009-09-15 11:28:08 -0700 Landed manually as r48395. 147388 7 eric 2009-09-15 14:58:41 -0700 http/tests/xmlhttprequest/cross-origin-authorization.html -> failed Maybe that was flakey? I think it might be related... 39583 2009-09-14 18:03:53 -0700 2009-09-15 10:57:57 -0700 proposed patch x text/plain 3268 atwilson ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBlYThjYTUwLi4wOWM4NjNkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMDkt MTQgIERyZXcgV2lsc29uICA8YXR3aWxzb25AZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNZXNzYWdlRXZlbnQgc2hvdWxkIG5vdCBi ZSBjYW5jZWxhYmxlIGJ5IGRlZmF1bHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTI3ODQ2CisKKyAgICAgICAgKiBmYXN0L2V2ZW50cy9tZXNzYWdlLXBv cnQtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGZhc3QvZXZlbnRzL21lc3NhZ2UtcG9ydC5odG1s OgorICAgICAgICBBZGRlZCB0ZXN0IGNhc2UgdG8gY2hlY2sgc3RhdGUgb2YgTWVzc2FnZUV2ZW50 LmNhbmNlbGFibGUgYXR0cmlidXRlLgorCiAyMDA5LTA5LTEyICBTYW0gV2VpbmlnICA8c2FtQHdl YmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFjaWVqIFN0YWNob3dpYWsuCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9tZXNzYWdlLXBvcnQtZXhwZWN0ZWQudHh0 IGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvbWVzc2FnZS1wb3J0LWV4cGVjdGVkLnR4dAppbmRl eCBjOWJmNjM2Li4xYzkxZDVjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9t ZXNzYWdlLXBvcnQtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL21l c3NhZ2UtcG9ydC1leHBlY3RlZC50eHQKQEAgLTYsNSArNiw2IEBAIFNpbXBsZSBleGNoYW5nZTog U1VDQ0VTUwogUG9zdGVkIHBvcnQ6IFNVQ0NFU1MKIEV2ZW50IExpc3RlbmVyOiBTVUNDRVNTCiBD bG9zZWQgcG9ydDogU1VDQ0VTUworTWVzc2FnZUV2ZW50LmNhbmNlbGFibGUgZGVmYXVsdHMgdG8g ZmFsc2U6IFBBU1MKIERPTkUKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMv bWVzc2FnZS1wb3J0Lmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9tZXNzYWdlLXBvcnQu aHRtbAppbmRleCBhNWRkNDc1Li5lYjgwMTgzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0 L2V2ZW50cy9tZXNzYWdlLXBvcnQuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9t ZXNzYWdlLXBvcnQuaHRtbApAQCAtODIsNyArODIsMjEgQEAgZnVuY3Rpb24gdGVzdDUoKQogICAg IC8vIENyZWF0ZSBhIGNoYW5uZWwgYW5kIHB1dCBzb21lIG1lc3NhZ2VzIGluIGl0IHdoaWNoIHdp bGwgZ28gdW5kZWxpdmVyZWQgYW5kIHNob3VsZCBub3QgbGVhawogICAgIHZhciBjaGFubmVsID0g bmV3IE1lc3NhZ2VDaGFubmVsOwogICAgIGNoYW5uZWwucG9ydDEucG9zdE1lc3NhZ2UoImFiY2Rl Iik7Ci0gICAgLy8gTm93IHdhaXQgYSBzaG9ydCBwZXJpb2Qgb2YgdGltZSB0byBlbnN1cmUgbm8g bWVzc2FnZXMgY29tZSBpbiBmcm9tIHByZXZpb3VzIHRlc3RzLgorICAgIHRlc3Q2KCk7Cit9CisK K2Z1bmN0aW9uIHRlc3Q2KCkKK3sKKyAgICB2YXIgY2hhbm5lbCA9IG5ldyBNZXNzYWdlQ2hhbm5l bDsKKyAgICBjaGFubmVsLnBvcnQxLnBvc3RNZXNzYWdlKCJob3dkeSIpOworICAgIGNoYW5uZWwu cG9ydDIub25tZXNzYWdlID0gZnVuY3Rpb24oZXZlbnQpIHsKKyAgICAgICAgbG9nKCJNZXNzYWdl RXZlbnQuY2FuY2VsYWJsZSBkZWZhdWx0cyB0byAiICsgZXZlbnQuY2FuY2VsYWJsZSArICI6ICIg KyAoZXZlbnQuY2FuY2VsYWJsZSA/ICJGQUlMIiA6ICJQQVNTIikpOworICAgICAgICBkb25lKCk7 CisgICAgfQorfQorCitmdW5jdGlvbiBkb25lKCkgeworICAgIC8vIFdhaXQgYSBzaG9ydCBwZXJp b2Qgb2YgdGltZSB0byBlbnN1cmUgbm8gbWVzc2FnZXMgY29tZSBpbiBmcm9tIHByZXZpb3VzIHRl c3RzLgogICAgIHNldFRpbWVvdXQoZnVuY3Rpb24oKSB7CiAgICAgICAgIGxvZygiRE9ORSIpOwog ICAgICAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBjNmEwMWZlLi4yOGM1ZjU1 IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE0IEBACisyMDA5LTA5LTE0ICBEcmV3IFdpbHNvbiAgPGF0d2lsc29uQGdvb2ds ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg TWVzc2FnZUV2ZW50IHNob3VsZCBub3QgYmUgY2FuY2VsYWJsZSBieSBkZWZhdWx0CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNzg0NgorCisgICAgICAg ICogZG9tL01lc3NhZ2VFdmVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpNZXNzYWdlRXZlbnQ6 Ok1lc3NhZ2VFdmVudCk6CisgICAgICAgIENoYW5nZWQgY29uc3RydWN0b3IgdG8gc2V0IGNhbmNl bGFibGU9ZmFsc2UgYnkgZGVmYXVsdCwgcGVyIHRoZSBIVE1MNSBzcGVjLgorCiAyMDA5LTA5LTEy ICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFj aWVqIFN0YWNob3dpYWsuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2RvbS9NZXNzYWdlRXZlbnQuY3Bw IGIvV2ViQ29yZS9kb20vTWVzc2FnZUV2ZW50LmNwcAppbmRleCAzMjkyYjM0Li4yZWY4YmMyIDEw MDY0NAotLS0gYS9XZWJDb3JlL2RvbS9NZXNzYWdlRXZlbnQuY3BwCisrKyBiL1dlYkNvcmUvZG9t L01lc3NhZ2VFdmVudC5jcHAKQEAgLTM4LDcgKzM4LDcgQEAgTWVzc2FnZUV2ZW50OjpNZXNzYWdl RXZlbnQoKQogfQogCiBNZXNzYWdlRXZlbnQ6Ok1lc3NhZ2VFdmVudChjb25zdCBTdHJpbmcmIGRh dGEsIGNvbnN0IFN0cmluZyYgb3JpZ2luLCBjb25zdCBTdHJpbmcmIGxhc3RFdmVudElkLCBQYXNz UmVmUHRyPERPTVdpbmRvdz4gc291cmNlLCBQYXNzT3duUHRyPE1lc3NhZ2VQb3J0QXJyYXk+IHBv cnRzKQotICAgIDogRXZlbnQoZXZlbnROYW1lcygpLm1lc3NhZ2VFdmVudCwgZmFsc2UsIHRydWUp CisgICAgOiBFdmVudChldmVudE5hbWVzKCkubWVzc2FnZUV2ZW50LCBmYWxzZSwgZmFsc2UpCiAg ICAgLCBtX2RhdGEoZGF0YSkKICAgICAsIG1fb3JpZ2luKG9yaWdpbikKICAgICAsIG1fbGFzdEV2 ZW50SWQobGFzdEV2ZW50SWQpCg==