278426 2024-08-20 16:13:09 -0700 [ews-build] Bugzillas enclosed in <> in commit messages do not get closed upon landing 2024-09-04 13:12:46 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 244010 1 ryanhaddad aakash_jain aakash_jain bfan2 ddkilzer karlcow webkit-bug-importer oldest_to_newest 2054245 0 ryanhaddad 2024-08-20 16:13:09 -0700 Bugzillas enclosed in <> in commit messages do not get closed upon landing, as our regex doesn't account for this case. See https://github.com/WebKit/WebKit/pull/32350 and https://github.com/WebKit/WebKit/pull/32459 as examples. 2054252 1 ryanhaddad 2024-08-20 16:17:30 -0700 This is happening because the CloseBug step depends upon the bug_id property being set. Since our regex fails to pull out the ID from bugzilla URLs inside of less than / greater than characters, this step is being skipped. 2054255 2 webkit-bug-importer 2024-08-20 16:17:52 -0700 <rdar://problem/134376407> 2054360 3 karlcow 2024-08-20 23:48:34 -0700 ``` regex = r"^.*webkit.org\/(b\/|show_bug\.cgi\?id=)(\d+)>?$" test_str = ("webkit.org/b/123\n" "https://webkit.org/b/123\n" "https://bugs.webkit.org/show_bug.cgi?id=123\n" "<webkit.org/b/123>\n" "<https://webkit.org/b/123>\n" "<https://bugs.webkit.org/show_bug.cgi?id=123>") ``` 2054653 4 karlcow 2024-08-22 00:45:14 -0700 This is used in https://github.com/WebKit/WebKit/blob/6febcde4e258e8dd77930b0a793d16b6836ec163/Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tracker.py#L101-L103 ``` if data.get('type') in ('bugzilla', 'github'): unpacked['url'] = data.get('url') unpacked['res'] = [re.compile(r) for r in data.get('res', [])] ``` which then goes through a list of regex. https://github.com/WebKit/WebKit/blob/6febcde4e258e8dd77930b0a793d16b6836ec163/metadata/trackers.json#L5-L10 ``` "type" : "bugzilla", "url" : "https://bugs.webkit.org", "res" : [ "\\Awebkit.org/b/(?P<id>\\d+)\\Z", "\\Ahttps?://webkit.org/b/(?P<id>\\d+)\\Z", "\\A<webkit.org/b/(?P<id>\\d+)>\\Z", "\\A<https?://webkit.org/b/(?P<id>\\d+)>\\Z" ], ``` The proposal in Comment #3 reduces this to one regex. 2057627 5 aakash_jain 2024-09-04 10:24:46 -0700 Pull request: https://github.com/WebKit/WebKit/pull/33125 2057672 6 ews-feeder 2024-09-04 13:12:44 -0700 Committed 283169@main (23ede0a38256): <https://commits.webkit.org/283169@main> Reviewed commits have been landed. Closing PR #33125 and removing active labels.