27822 2009-07-29 17:18:47 -0700 REGRESSION (r46039): Should restore previous connections-per-host limit for non-http(s) hosts 2009-07-29 17:33:57 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED P2 Normal --- 1 beidson webkit-unassigned darin oldest_to_newest 135746 0 beidson 2009-07-29 17:18:47 -0700 We should restore previous connections-per-host limit for non-http(s) hosts The change in r46039 to restrict even file urls without exception has broken other WebKit apps, including Adobe's installer (<rdar://problem/7091659>) 135747 1 33756 beidson 2009-07-29 17:22:06 -0700 Created attachment 33756 A fix No layout test, as we haven't yet figured out how reproducibly stress the loader in a reliable and predictable manner to test this class of bug. 135748 2 33756 darin 2009-07-29 17:27:04 -0700 Comment on attachment 33756 A fix r=me Does the non-named host limit ever do any good at all? Maybe we should remove the limit entirely for non-named hosts. 135750 3 beidson 2009-07-29 17:33:07 -0700 Thanks for the review! The answer to your question is answered by a comment where the hard-coded limit of 20 is established for non-named hosts: // Having a limit might still help getting more important resources first ...which, of course, was the original motivation for the limits in the first place. It's unclear how much of a benefit this limit might be, but it is clear that there is theoretically a benefit. 135751 4 beidson 2009-07-29 17:33:57 -0700 Sending ChangeLog Sending loader/loader.cpp Transmitting file data .. Committed revision 46569. 33756 2009-07-29 17:22:06 -0700 2009-07-29 17:27:04 -0700 A fix patch.txt text/plain 1899 beidson SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NjU2OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDktMDctMjkgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIChS RUdSRVNTSU9OOiByNDYwMzkpIFNob3VsZCByZXN0b3JlIHByZXZpb3VzIGNvbm5lY3Rpb25zLXBl ci1ob3N0IGxpbWl0IGZvciBub24taHR0cChzKSBob3N0cworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjc4MjIgYW5kIDxyZGFyOi8vcHJvYmxlbS83MDkx NjU5PgorCisgICAgICAgICogbG9hZGVyL2xvYWRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpM b2FkZXI6Okhvc3Q6OnNlcnZlUGVuZGluZ1JlcXVlc3RzKTogRm9yIG5vbi1odHRwKHMpIGhvc3Rz LCByZXN0b3JlIHRoZSBwcmV2aW91cyBiZWhhdmlvciBvZiAKKyAgICAgICAgICBvbmx5IGxpbWl0 aW5nIGNvbm5lY3Rpb25zIHdoaWxlIHBhcnNpbmcgYW5kIHN0aWxsIHRyeWluZyB0byBmaWd1cmUg b3V0IHN0eWxlc2hlZXQgdXJscy4KKwogMjAwOS0wNy0yOSAgWW9uZyBMaSAgPHlvbmcubGlAdG9y Y2htb2JpbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEdlb3JnZSBTdGFpa29zLgpJbmRl eDogV2ViQ29yZS9sb2FkZXIvbG9hZGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2xvYWRl ci9sb2FkZXIuY3BwCShyZXZpc2lvbiA0NjU1MSkKKysrIFdlYkNvcmUvbG9hZGVyL2xvYWRlci5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTI4OCw3ICsyODgsMTEgQEAgdm9pZCBMb2FkZXI6Okhvc3Q6 OnNlcnZlUGVuZGluZ1JlcXVlc3RzKAogICAgICAgICBEb2NMb2FkZXIqIGRvY0xvYWRlciA9IHJl cXVlc3QtPmRvY0xvYWRlcigpOwogICAgICAgICBib29sIHJlc291cmNlSXNDYWNoZVZhbGlkYXRv ciA9IHJlcXVlc3QtPmNhY2hlZFJlc291cmNlKCktPmlzQ2FjaGVWYWxpZGF0b3IoKTsKIAotICAg ICAgICBpZiAobV9yZXF1ZXN0c0xvYWRpbmcuc2l6ZSgpICsgbV9ub25DYWNoZWRSZXF1ZXN0c0lu RmxpZ2h0ID49IG1fbWF4UmVxdWVzdHNJbkZsaWdodCkgeworICAgICAgICAvLyBGb3IgbmFtZWQg aG9zdHMgLSB3aGljaCBhcmUgb25seSBodHRwKHMpIGhvc3RzIC0gd2Ugc2hvdWxkIGFsd2F5cyBl bmZvcmNlIHRoZSBjb25uZWN0aW9uIGxpbWl0LgorICAgICAgICAvLyBGb3Igbm9uLW5hbWVkIGhv c3RzIC0gZXZlcnl0aGluZyBidXQgaHR0cChzKSAtIHdlIHNob3VsZCBvbmx5IGVuZm9yY2UgdGhl IGxpbWl0IGlmIHRoZSBkb2N1bWVudCBpc24ndCBkb25lIHBhcnNpbmcgCisgICAgICAgIC8vIGFu ZCB3ZSBkb24ndCBrbm93IGFsbCBzdHlsZXNoZWV0cyB5ZXQuCisgICAgICAgIGJvb2wgc2hvdWxk TGltaXRSZXF1ZXN0cyA9ICFtX25hbWUuaXNOdWxsKCkgfHwgZG9jTG9hZGVyLT5kb2MoKS0+cGFy c2luZygpIHx8ICFkb2NMb2FkZXItPmRvYygpLT5oYXZlU3R5bGVzaGVldHNMb2FkZWQoKTsKKyAg ICAgICAgaWYgKHNob3VsZExpbWl0UmVxdWVzdHMgJiYgbV9yZXF1ZXN0c0xvYWRpbmcuc2l6ZSgp ICsgbV9ub25DYWNoZWRSZXF1ZXN0c0luRmxpZ2h0ID49IG1fbWF4UmVxdWVzdHNJbkZsaWdodCkg ewogICAgICAgICAgICAgc2VydmVMb3dlclByaW9yaXR5ID0gZmFsc2U7CiAgICAgICAgICAgICBy ZXR1cm47CiAgICAgICAgIH0K