277057 2024-07-24 17:54:20 -0700 Make writing-mode/direction/TextFlow conditional checks consistent, efficient, and correct 2025-01-02 12:07:03 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 166941 1 fantasai.bugs fantasai.bugs bfulgham ntim simon.fraser webkit-bug-importer zalan oldest_to_newest 2048226 0 fantasai.bugs 2024-07-24 17:54:20 -0700 We currently have a ton of ad-hoc checks for writing-mode and direction in our codebase, each following their own pattern of boolean operators, temporary variables, and conditional statements. This makes the code harder to read, and more likely to contain errors. We should instead have RenderStyle return a WritingMode object (similar to Gecko's) that encapsulates all of the relevant CSS style information and that has convenience methods to easily, efficiently, and correctly return the specific resolved information that layout code tends to query. 2048227 1 webkit-bug-importer 2024-07-24 17:54:40 -0700 <rdar://problem/132446895> 2052022 2 fantasai.bugs 2024-08-11 22:49:12 -0700 Pull request: https://github.com/WebKit/WebKit/pull/32026 2069816 3 ews-feeder 2024-10-22 09:27:02 -0700 Committed 285555@main (72e07604aff9): <https://commits.webkit.org/285555@main> Reviewed commits have been landed. Closing PR #32026 and removing active labels. 2069818 4 ntim 2024-10-22 09:27:52 -0700 *** Bug 276028 has been marked as a duplicate of this bug. *** 2084537 5 ntim 2025-01-02 12:07:03 -0800 *** Bug 260036 has been marked as a duplicate of this bug. ***