276358 2024-07-09 00:07:14 -0700 margin and preferred width calculation for MathML elements 2024-07-10 01:41:16 -0700 1 1 1 Unclassified WebKit MathML WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 276169 276413 1 fred.wang fred.wang ahmad.saleem792 webkit-bug-importer zalan oldest_to_newest 2045260 0 fred.wang 2024-07-09 00:07:14 -0700 Many "preferred width" tests are failing for margin-002/margin-003 (from imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/), even if the block size, inline size and coordinates are correct. I guess the problem is that the margins are not set when computePreferredLogicalWidths() (for layoutBlock() this is done by recomputeLogicalWidth() IIUC). Need to debug a bit what's happening here. 2045262 1 fred.wang 2024-07-09 00:25:52 -0700 This is likely the reason why LayoutTests/imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/padding-border-margin-001.html is failing too, the size and rendering of the `<mrow>` and `<math>` elements are correct and the block size of the `<div>` container is good. However, the inline margins don't seem to taken into account for the inline size of the `<div>`. 2045302 2 fred.wang 2024-07-09 07:28:07 -0700 Pull request: https://github.com/WebKit/WebKit/pull/30604 2045486 3 ahmad.saleem792 2024-07-10 01:20:52 -0700 @Alan - from Comment 1 - is it using IFC as well for MathML? 2045492 4 ews-feeder 2024-07-10 01:40:17 -0700 Committed 280810@main (9a8589b0774a): <https://commits.webkit.org/280810@main> Reviewed commits have been landed. Closing PR #30604 and removing active labels. 2045493 5 webkit-bug-importer 2024-07-10 01:41:16 -0700 <rdar://problem/131447182>