276026 2024-06-28 20:01:55 -0700 [MathML] <mfrac> with out-of-flow numerator/denominator produces unexpected result 2024-07-04 05:24:36 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 179739 1 zalan zalan bfulgham changseok dbarton esprehn+autocc ews-watchlist fred.wang glenn koivisto kondapallykalyan pdr simon.fraser zalan oldest_to_newest 2043730 0 zalan 2024-06-28 20:01:55 -0700 <rdar://130757408> 2043734 1 471770 zalan 2024-06-28 20:35:08 -0700 Created attachment 471770 [fast-cq]Patch 2043787 2 ews-feeder 2024-06-29 13:03:42 -0700 Committed 280505@main (c37d84f4267d): <https://commits.webkit.org/280505@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 471770. 2044400 3 471770 fred.wang 2024-07-03 00:14:47 -0700 Comment on attachment 471770 [fast-cq]Patch View in context: https://bugs.webkit.org/attachment.cgi?id=471770&action=review > COMMIT_MESSAGE:8 > +(Alternatively we can mark such content as invalid as they are certainly expected to be inflow boxes, but the rest of the MathML renderers follow this logic.) For reference the behavior described in MathML Core ( https://www.w3.org/TR/mathml-core/#fractions-mfrac ): > If the <mfrac> element has less or more than two in-flow children, its layout algorithm is the same as the mrow element. Otherwise, the first in-flow child is called numerator, the second in-flow child is called denominator and the layout algorithm is explained below. We should probably review all the MathML elements and see if they follow this logic. 2044427 4 zalan 2024-07-03 05:24:58 -0700 (In reply to Frédéric Wang (:fredw) from comment #3) > Comment on attachment 471770 [details] > [fast-cq]Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=471770&action=review > > > COMMIT_MESSAGE:8 > > +(Alternatively we can mark such content as invalid as they are certainly expected to be inflow boxes, but the rest of the MathML renderers follow this logic.) > > For reference the behavior described in MathML Core ( > https://www.w3.org/TR/mathml-core/#fractions-mfrac ): > > > If the <mfrac> element has less or more than two in-flow children, its layout algorithm is the same as the mrow element. Otherwise, the first in-flow child is called numerator, the second in-flow child is called denominator and the layout algorithm is explained below. Thank you! I did a quick search before submitting this patch and landed on the spec, hence my hesitation in the changelog entry. > > We should probably review all the MathML elements and see if they follow > this logic. Yeah, we should certainly do that! 2044662 5 fred.wang 2024-07-04 04:04:51 -0700 (In reply to zalan from comment #4) > > We should probably review all the MathML elements and see if they follow > > this logic. > Yeah, we should certainly do that! OK apparently I already had opened bug 179739 for that and more recently MathML Core specified how to handle it. I'll propose this task to an Igalia's Coding Experience student. 2044669 6 zalan 2024-07-04 05:24:36 -0700 (In reply to Frédéric Wang (:fredw) from comment #5) > (In reply to zalan from comment #4) > > > We should probably review all the MathML elements and see if they follow > > > this logic. > > Yeah, we should certainly do that! > > OK apparently I already had opened bug 179739 for that and more recently > MathML Core specified how to handle it. I'll propose this task to an > Igalia's Coding Experience student. Awesome! Thank you for taking care of this! 471770 2024-06-28 20:35:08 -0700 2024-06-30 06:09:26 -0700 [fast-cq]Patch bug-276026-20240628203507.patch text/plain 3479 zalan RnJvbSA4YWFlZDU4MWFkZWE3YmUyOTI4OTRkZTBiZGMyMmIzNmUwYzlhYmIyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGFuIEJhcmFkbGF5IDx6YWxhbkBhcHBsZS5jb20+CkRhdGU6 IEZyaSwgMjggSnVuIDIwMjQgMjA6MjU6MTkgLTA3MDAKU3ViamVjdDogW1BBVENIXSBbTWF0aE1M XSA8bWZyYWM+IHdpdGggb3V0LW9mLWZsb3cgbnVtZXJhdG9yL2Rlbm9taW5hdG9yCiBwcm9kdWNl cyB1bmV4cGVjdGVkIHJlc3VsdCBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9Mjc2MDI2CiA8cmRhcjovLzEzMDc1NzQwOD4KClJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgoKT3V0LW9mLWZsb3cgKG51bWVyYXRvci9kZW5vbWluYXRvcikgY2hpbGRyZW4gaGF2ZSB0byBn ZXQgaW5zZXJ0ZWQgdG8gdGhlaXIgY29udGFpbmluZyBibG9jaydzIGxpc3Qgd2hpbGUgcnVubmlu ZyBpbmZsb3cgbGF5b3V0LgooQWx0ZXJuYXRpdmVseSB3ZSBjYW4gbWFyayBzdWNoIGNvbnRlbnQg YXMgaW52YWxpZCBhcyB0aGV5IGFyZSBjZXJ0YWlubHkgZXhwZWN0ZWQgdG8gYmUgaW5mbG93IGJv eGVzLCBidXQgdGhlIHJlc3Qgb2YgdGhlIE1hdGhNTCByZW5kZXJlcnMgZm9sbG93IHRoaXMgbG9n aWMuKQoKKiBMYXlvdXRUZXN0cy9tYXRobWwvb3V0LW9mLWZsb3ctZnJhY3Rpb24tY29udGVudC1j cmFzaC1leHBlY3RlZC50eHQ6IEFkZGVkLgoqIExheW91dFRlc3RzL21hdGhtbC9vdXQtb2YtZmxv dy1mcmFjdGlvbi1jb250ZW50LWNyYXNoLmh0bWw6IEFkZGVkLgoqIFNvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9tYXRobWwvUmVuZGVyTWF0aE1MRnJhY3Rpb24uY3BwOgooV2ViQ29yZTo6UmVuZGVy TWF0aE1MRnJhY3Rpb246OmxheW91dEJsb2NrKToKLS0tCiAuLi4vcmVuZGVyaW5nL21hdGhtbC9S ZW5kZXJNYXRoTUxGcmFjdGlvbi5jcHAgfCAgNSArKysrCiAuLi5mLWZsb3ctZnJhY3Rpb24tY29u dGVudC1jcmFzaC1leHBlY3RlZC50eHQgfCAgMSArCiAuLi4vb3V0LW9mLWZsb3ctZnJhY3Rpb24t Y29udGVudC1jcmFzaC5odG1sICAgfCAyNCArKysrKysrKysrKysrKysrKysrCiAzIGZpbGVzIGNo YW5nZWQsIDMwIGluc2VydGlvbnMoKykKIGNyZWF0ZSBtb2RlIDEwMDY0NCBMYXlvdXRUZXN0cy9t YXRobWwvb3V0LW9mLWZsb3ctZnJhY3Rpb24tY29udGVudC1jcmFzaC1leHBlY3RlZC50eHQKIGNy ZWF0ZSBtb2RlIDEwMDY0NCBMYXlvdXRUZXN0cy9tYXRobWwvb3V0LW9mLWZsb3ctZnJhY3Rpb24t Y29udGVudC1jcmFzaC5odG1sCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L21hdGhtbC9SZW5kZXJNYXRoTUxGcmFjdGlvbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvbWF0aG1sL1JlbmRlck1hdGhNTEZyYWN0aW9uLmNwcAppbmRleCAzNzA5YTYxYzQ5M2IuLjY3 N2M1ZjhmNGZhMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL21hdGhtbC9S ZW5kZXJNYXRoTUxGcmFjdGlvbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL21h dGhtbC9SZW5kZXJNYXRoTUxGcmFjdGlvbi5jcHAKQEAgLTI0OCw2ICsyNDgsMTEgQEAgdm9pZCBS ZW5kZXJNYXRoTUxGcmFjdGlvbjo6bGF5b3V0QmxvY2soYm9vbCByZWxheW91dENoaWxkcmVuLCBM YXlvdXRVbml0KQogICAgIExheW91dFBvaW50IGRlbm9taW5hdG9yTG9jYXRpb24oaG9yaXpvbnRh bE9mZnNldChkZW5vbWluYXRvcigpLCBlbGVtZW50KCkuZGVub21pbmF0b3JBbGlnbm1lbnQoKSks IHZlcnRpY2FsT2Zmc2V0KTsKICAgICBkZW5vbWluYXRvcigpLnNldExvY2F0aW9uKGRlbm9taW5h dG9yTG9jYXRpb24pOwogCisgICAgaWYgKG51bWVyYXRvcigpLmlzT3V0T2ZGbG93UG9zaXRpb25l ZCgpKQorICAgICAgICBudW1lcmF0b3IoKS5jb250YWluaW5nQmxvY2soKS0+aW5zZXJ0UG9zaXRp b25lZE9iamVjdChudW1lcmF0b3IoKSk7CisgICAgaWYgKGRlbm9taW5hdG9yKCkuaXNPdXRPZkZs b3dQb3NpdGlvbmVkKCkpCisgICAgICAgIGRlbm9taW5hdG9yKCkuY29udGFpbmluZ0Jsb2NrKCkt Pmluc2VydFBvc2l0aW9uZWRPYmplY3QoZGVub21pbmF0b3IoKSk7CisKICAgICB2ZXJ0aWNhbE9m ZnNldCArPSBkZW5vbWluYXRvcigpLmxvZ2ljYWxIZWlnaHQoKTsgLy8gVGhpcyBpcyB0aGUgYm90 dG9tIG9mIG91ciByZW5kZXJlci4KICAgICBzZXRMb2dpY2FsSGVpZ2h0KHZlcnRpY2FsT2Zmc2V0 KTsKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWF0aG1sL291dC1vZi1mbG93LWZyYWN0aW9u LWNvbnRlbnQtY3Jhc2gtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvbWF0aG1sL291dC1vZi1m bG93LWZyYWN0aW9uLWNvbnRlbnQtY3Jhc2gtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAwMDAwMC4uNDliMTFiYmY0NjM5Ci0tLSAvZGV2L251bGwKKysrIGIv TGF5b3V0VGVzdHMvbWF0aG1sL291dC1vZi1mbG93LWZyYWN0aW9uLWNvbnRlbnQtY3Jhc2gtZXhw ZWN0ZWQudHh0CkBAIC0wLDAgKzEgQEAKK1BBU1MgaWYgbm8gY3Jhc2ggb3IgYXNzZXJ0LiBjb250 ZW50CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9tYXRobWwvb3V0LW9mLWZsb3ctZnJhY3Rpb24t Y29udGVudC1jcmFzaC5odG1sIGIvTGF5b3V0VGVzdHMvbWF0aG1sL291dC1vZi1mbG93LWZyYWN0 aW9uLWNvbnRlbnQtY3Jhc2guaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAw MDAwMDAuLjQ2NzRmZjRiNTVkNAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL21hdGht bC9vdXQtb2YtZmxvdy1mcmFjdGlvbi1jb250ZW50LWNyYXNoLmh0bWwKQEAgLTAsMCArMSwyNCBA QAorPHN0eWxlPgorKiB7CisgIHBvc2l0aW9uOiBhYnNvbHV0ZTsgCit9CisjaHRtbHZhcjAwMDA4 IHsKKyAgLXdlYmtpdC11c2VyLW1vZGlmeTogcmVhZC13cml0ZS1wbGFpbnRleHQtb25seTsKK30K Kzwvc3R5bGU+CitQQVNTIGlmIG5vIGNyYXNoIG9yIGFzc2VydC4KKzxkaXYgaWQ9Imh0bWx2YXIw MDAwMyI+PHNwYW4gaWQ9Imh0bWx2YXIwMDAwNyI+Y29udGVudDwvZGl2PgorPGRpdiBpZD0iaHRt bHZhcjAwMDA4Ij4KKzxkaXYgaWQ9Imh0bWx2YXIwMDAyNCI+PC9kaXY+Cis8ZGl2IGlkPSJodG1s dmFyMDAwMjciPgorPG1hdGg+PG1mcmFjPjxtaT48L21pPjxtaT48bWkgaWQ9Zm9vPjwvZGl2Pgor PHNjcmlwdD4KK2lmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0 KCk7CisKK2h0bWx2YXIwMDAwNy5hcHBlbmQoImZvbyIpOworZG9jdW1lbnQuZ2V0RWxlbWVudEJ5 SWQoImZvbyIpLmFwcGVuZENoaWxkKGh0bWx2YXIwMDAwMyk7CitodG1sdmFyMDAwMjQuYXBwZW5k Q2hpbGQoaHRtbHZhcjAwMDI3KTsKK3dpbmRvdy5maW5kKCJmb28iLHRydWUsdHJ1ZSxmYWxzZSxm YWxzZSk7Citkb2N1bWVudC5leGVjQ29tbWFuZCgiaW5zZXJ0SFRNTCIsICIiKTsKKzwvc2NyaXB0 Pgo=