<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>275100</bug_id>
          
          <creation_ts>2024-06-04 01:48:49 -0700</creation_ts>
          <short_desc>CanvasBase owns a ImageBuffer that belongs to the CanvasRenderingContext</short_desc>
          <delta_ts>2026-02-27 03:13:08 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Canvas</component>
          <version>WebKit Local Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>274750</dependson>
    
    <dependson>275105</dependson>
    
    <dependson>275144</dependson>
    
    <dependson>275201</dependson>
    
    <dependson>275563</dependson>
    
    <dependson>275902</dependson>
    
    <dependson>277478</dependson>
    
    <dependson>306603</dependson>
    
    <dependson>306606</dependson>
    
    <dependson>306608</dependson>
    
    <dependson>306613</dependson>
    
    <dependson>306617</dependson>
    
    <dependson>308815</dependson>
          <blocked>267291</blocked>
    
    <blocked>273622</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Kimmo Kinnunen">kkinnunen</reporter>
          <assigned_to name="Kimmo Kinnunen">kkinnunen</assigned_to>
          <cc>sabouhallawa</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2039609</commentid>
    <comment_count>0</comment_count>
    <who name="Kimmo Kinnunen">kkinnunen</who>
    <bug_when>2024-06-04 01:48:49 -0700</bug_when>
    <thetext>CanvasBase owns a ImageBuffer that belongs to the CanvasRenderingContext

This is a problem because only CanvasRenderingContext2DBase really uses the ImageBuffer. Others would be better performing if the CanvasBase didn&apos;t have a ImageBuffer, rather the buffer was asked from the context.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2039611</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2024-06-04 01:49:19 -0700</bug_when>
    <thetext>&lt;rdar://problem/129208981&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2044906</commentid>
    <comment_count>2</comment_count>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2024-07-05 21:04:07 -0700</bug_when>
    <thetext>&gt; the buffer was asked from the context
This seems backwards. The buffer vends the context.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2049793</commentid>
    <comment_count>3</comment_count>
    <who name="Kimmo Kinnunen">kkinnunen</who>
    <bug_when>2024-07-31 04:32:37 -0700</bug_when>
    <thetext>(In reply to Simon Fraser (smfr) from comment #2)
&gt; &gt; the buffer was asked from the context
&gt; This seems backwards. The buffer vends the context.

The intention was to say &quot;the |drawing or display] buffer copy was asked from the [canvas rendering] context&quot;. In this context &quot;buffer vends the context&quot; doesn&apos;t make sense.

The specific variant of canvas rendering context should return the rendering results image, it is private logic of said rendering type.

The specific variant of canvas rendering context should manage the drawing buffer backing store in the manner it needs to manage it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2179401</commentid>
    <comment_count>4</comment_count>
    <who name="Kimmo Kinnunen">kkinnunen</who>
    <bug_when>2026-02-09 04:07:22 -0800</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/58197</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2181185</commentid>
    <comment_count>5</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2026-02-13 01:37:58 -0800</bug_when>
    <thetext>Committed 307450@main (39eb51251d8f): &lt;https://commits.webkit.org/307450@main&gt;

Reviewed commits have been landed. Closing PR #58197 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>