27064 2009-07-07 20:17:17 -0700 Turn off non-portable date manipulations for SYMBIAN (as well) 2009-07-15 07:18:49 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 27065 1 laszlo.gombos webkit-unassigned ddkilzer hausmann norbert.leser yongjun.zhang oldest_to_newest 130350 0 laszlo.gombos 2009-07-07 20:17:17 -0700 The timegm() function and the tm_gmtoff and tm_zone fields are extensions to the ISO and POSIX standards; these are not available on WIN and some other UNIX-like systems (SOLARIS, SYMBIAN). The rules to turn off these non-portable dependencies are repeated several times in wtf/DateMath.*. Perhaps we should introduce HAVE_XXX guards for these non-portable dependencies and place the rules in one single location. 130351 1 32425 laszlo.gombos 2009-07-07 20:31:25 -0700 Created attachment 32425 Proposed fix. 131584 2 32425 ddkilzer 2009-07-14 09:21:56 -0700 Comment on attachment 32425 Proposed fix. Nice. r=me 131881 3 hausmann 2009-07-15 07:18:49 -0700 Nice, landed in r45908 32425 2009-07-07 20:31:25 -0700 2009-07-14 09:21:56 -0700 Proposed fix. patch_27064.txt text/plain 3641 laszlo.gombos SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQ1NjE3KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMDktMDctMDcgIExhc3psbyBH b21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFR1cm4gb2ZmIG5vbi1wb3J0YWJsZSBkYXRlIG1h bmlwdWxhdGlvbnMgZm9yIFNZTUJJQU4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTI3MDY0CisKKyAgICAgICAgSW50cm9kdWNlIEhBVkUoVE1fR01UT0ZG KSwgSEFWRShUTV9aT05FKSBhbmQgSEFWRShUSU1FR00pIGd1YXJkcyAKKyAgICAgICAgYW5kIHBs YWNlIHRoZSBydWxlcyBmb3IgY29udHJvbGxpbmcgdGhlIGd1YXJkcyBpbiBQbGF0Zm9ybS5oLgor ICAgICAgICBUdXJuIG9mZiB0aGVzZSBuZXdseSBpbnRyb2R1Y2VkIGd1YXJkcyBmb3IgU1lNQklB Ti4KKworICAgICAgICAqIHd0Zi9EYXRlTWF0aC5jcHA6CisgICAgICAgIChXVEY6OmNhbGN1bGF0 ZVVUQ09mZnNldCk6CisgICAgICAgICogd3RmL0RhdGVNYXRoLmg6CisgICAgICAgIChXVEY6Okdy ZWdvcmlhbkRhdGVUaW1lOjpHcmVnb3JpYW5EYXRlVGltZSk6CisgICAgICAgIChXVEY6OkdyZWdv cmlhbkRhdGVUaW1lOjpvcGVyYXRvciB0bSk6CisgICAgICAgICogd3RmL1BsYXRmb3JtLmg6CisK IDIwMDktMDctMDcgIEdhdmluIEJhcnJhY2xvdWdoICA8YmFycmFjbG91Z2hAYXBwbGUuY29tPgog CiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCkluZGV4OiBKYXZhU2NyaXB0Q29yZS93 dGYvRGF0ZU1hdGguY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL3d0Zi9EYXRlTWF0 aC5jcHAJKHJldmlzaW9uIDQ1NTkwKQorKysgSmF2YVNjcmlwdENvcmUvd3RmL0RhdGVNYXRoLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMzc1LDE0ICszNzUsMTkgQEAgc3RhdGljIGludDMyX3QgY2Fs Y3VsYXRlVVRDT2Zmc2V0KCkKICAgICBsb2NhbHQudG1fd2RheSA9IDA7CiAgICAgbG9jYWx0LnRt X3lkYXkgPSAwOwogICAgIGxvY2FsdC50bV9pc2RzdCA9IDA7Ci0jaWYgUExBVEZPUk0oV0lOX09T KSB8fCBQTEFURk9STShTT0xBUklTKSB8fCBDT01QSUxFUihSVkNUKQorI2lmIEhBVkUoVE1fR01U T0ZGKQorICAgIGxvY2FsdC50bV9nbXRvZmYgPSAwOworI2VuZGlmCisjaWYgSEFWRShUTV9aT05F KQorICAgIGxvY2FsdC50bV96b25lID0gMDsKKyNlbmRpZgorICAgIAorI2lmIEhBVkUoVElNRUdN KQorICAgIHRpbWVfdCB1dGNPZmZzZXQgPSB0aW1lZ20oJmxvY2FsdCkgLSBta3RpbWUoJmxvY2Fs dCk7CisjZWxzZQogICAgIC8vIFVzaW5nIGEgY2FubmVkIGRhdGUgb2YgMDEvMDEvMjAwOSBvbiBw bGF0Zm9ybXMgd2l0aCB3ZWFrZXIgZGF0ZS1oYW5kbGluZyBmb28uCiAgICAgbG9jYWx0LnRtX3ll YXIgPSAxMDk7CiAgICAgdGltZV90IHV0Y09mZnNldCA9IDEyMzA3NjgwMDAgLSBta3RpbWUoJmxv Y2FsdCk7Ci0jZWxzZQotICAgIGxvY2FsdC50bV96b25lID0gMDsKLSAgICBsb2NhbHQudG1fZ210 b2ZmID0gMDsKLSAgICB0aW1lX3QgdXRjT2Zmc2V0ID0gdGltZWdtKCZsb2NhbHQpIC0gbWt0aW1l KCZsb2NhbHQpOwogI2VuZGlmCiAKICAgICByZXR1cm4gc3RhdGljX2Nhc3Q8aW50MzJfdD4odXRj T2Zmc2V0ICogMTAwMCk7CkluZGV4OiBKYXZhU2NyaXB0Q29yZS93dGYvRGF0ZU1hdGguaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS93dGYvRGF0ZU1hdGguaAkocmV2aXNpb24gNDU1OTAp CisrKyBKYXZhU2NyaXB0Q29yZS93dGYvRGF0ZU1hdGguaAkod29ya2luZyBjb3B5KQpAQCAtMTA5 LDE0ICsxMDksMTcgQEAgc3RydWN0IEdyZWdvcmlhbkRhdGVUaW1lIDogTm9uY29weWFibGUgewog ICAgICAgICAsIHllYXIoaW5UbS50bV95ZWFyKQogICAgICAgICAsIGlzRFNUKGluVG0udG1faXNk c3QpCiAgICAgewotI2lmICFQTEFURk9STShXSU5fT1MpICYmICFQTEFURk9STShTT0xBUklTKSAm JiAhQ09NUElMRVIoUlZDVCkKKyNpZiBIQVZFKFRNX0dNVE9GRikKICAgICAgICAgdXRjT2Zmc2V0 ID0gc3RhdGljX2Nhc3Q8aW50PihpblRtLnRtX2dtdG9mZik7CisjZWxzZQorICAgICAgICB1dGNP ZmZzZXQgPSBzdGF0aWNfY2FzdDxpbnQ+KGdldFVUQ09mZnNldCgpIC8gbXNQZXJTZWNvbmQgKyAo aXNEU1QgPyBzZWNvbmRzUGVySG91ciA6IDApKTsKKyNlbmRpZgogCisjaWYgSEFWRShUTV9aT05F KQogICAgICAgICBpbnQgaW5ab25lU2l6ZSA9IHN0cmxlbihpblRtLnRtX3pvbmUpICsgMTsKICAg ICAgICAgdGltZVpvbmUgPSBuZXcgY2hhcltpblpvbmVTaXplXTsKICAgICAgICAgc3RybmNweSh0 aW1lWm9uZSwgaW5UbS50bV96b25lLCBpblpvbmVTaXplKTsKICNlbHNlCi0gICAgICAgIHV0Y09m ZnNldCA9IHN0YXRpY19jYXN0PGludD4oZ2V0VVRDT2Zmc2V0KCkgLyBtc1BlclNlY29uZCArIChp c0RTVCA/IHNlY29uZHNQZXJIb3VyIDogMCkpOwogICAgICAgICB0aW1lWm9uZSA9IDA7CiAjZW5k aWYKICAgICB9CkBAIC0xMzYsOCArMTM5LDEwIEBAIHN0cnVjdCBHcmVnb3JpYW5EYXRlVGltZSA6 IE5vbmNvcHlhYmxlIHsKICAgICAgICAgcmV0LnRtX3llYXIgID0gIHllYXI7CiAgICAgICAgIHJl dC50bV9pc2RzdCA9ICBpc0RTVDsKIAotI2lmICFQTEFURk9STShXSU5fT1MpICYmICFQTEFURk9S TShTT0xBUklTKSAmJiAhQ09NUElMRVIoUlZDVCkKKyNpZiBIQVZFKFRNX0dNVE9GRikKICAgICAg ICAgcmV0LnRtX2dtdG9mZiA9IHN0YXRpY19jYXN0PGxvbmc+KHV0Y09mZnNldCk7CisjZW5kaWYK KyNpZiBIQVZFKFRNX1pPTkUpCiAgICAgICAgIHJldC50bV96b25lID0gdGltZVpvbmU7CiAjZW5k aWYKIApJbmRleDogSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g SmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgJKHJldmlzaW9uIDQ1NTkwKQorKysgSmF2YVNj cmlwdENvcmUvd3RmL1BsYXRmb3JtLmgJKHdvcmtpbmcgY29weSkKQEAgLTQwMSw2ICs0MDEsMTIg QEAKICNlbmRpZgogI2VuZGlmIC8qICFkZWZpbmVkKEhBVkVfQUNDRVNTSUJJTElUWSkgKi8KIAor I2lmICFQTEFURk9STShXSU5fT1MpICYmICFQTEFURk9STShTT0xBUklTKSAmJiAhUExBVEZPUk0o U1lNQklBTikgJiYgIUNPTVBJTEVSKFJWQ1QpCisjZGVmaW5lIEhBVkVfVE1fR01UT0ZGIDEKKyNk ZWZpbmUgSEFWRV9UTV9aT05FIDEKKyNkZWZpbmUgSEFWRV9USU1FR00gMQorI2VuZGlmICAgICAK KwogI2lmIFBMQVRGT1JNKERBUldJTikKIAogI2RlZmluZSBIQVZFX0VSUk5PX0ggMQo=