27055 2009-07-07 19:03:20 -0700 Qualify include path with wtf 2009-07-15 08:14:25 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) S60 Hardware S60 3rd edition RESOLVED FIXED P2 Normal --- 27065 0 norbert.leser webkit-unassigned bfulgham hausmann laszlo.gombos yongjun.zhang oldest_to_newest 130336 0 32415 norbert.leser 2009-07-07 19:03:20 -0700 Created attachment 32415 Code patch for Interpreter.h On Symbian platforms we encounter include ambiguities of HashMap.h file, which is already present in default location. Since that header filename is very generic, it appears to be appropriate and saver to add a pathname qualifier "wtf/HashMap.h" to the include statement. 130360 1 32415 darin 2009-07-07 21:59:39 -0700 Comment on attachment 32415 Code patch for Interpreter.h It's OK to change the include here to the normal style, but the normal style is to include <wtf/HashMap.h> and include in a separate paragraph. 131263 2 32415 eric 2009-07-13 00:45:54 -0700 Comment on attachment 32415 Code patch for Interpreter.h r- per Darin's comment. 131783 3 32756 laszlo.gombos 2009-07-14 18:25:31 -0700 Created attachment 32756 Second try. Updated the patch based on Darin's feedback (filling in for Norbert.) Note that since this patch reverses a subset of r44418 (presumably a build fix for WIN_CAIRO), the proposed fix might break WIN_CAIRO port (I CCd Brent on the bug). 131801 4 bfulgham 2009-07-14 20:20:08 -0700 This change should be fine for WIN_CAIRO. I added the HashMap.h because it was needed to compile. Using the fully-qualified wtf/HashMap.h path should not be a problem. 131890 5 hausmann 2009-07-15 08:14:25 -0700 Landed in r45909 32415 2009-07-07 19:03:20 -0700 2009-07-13 00:45:54 -0700 Code patch for Interpreter.h patch_Interpreter_h.txt text/plain 952 norbert.leser SW5kZXg6IENoYW5nZUxvZw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIENoYW5nZUxvZwkocmV2aXNpb24gNDU2 MDgpCisrKyBDaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMiBAQAorMjAwOS0w Ny0wNyAgTm9yYmVydCBMZXNlciAgPG5vcmJlcnQubGVzZXJAbm9raWEuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFF1YWxpZnkgaW5jbHVkZSBw YXRoIHdpdGggd3RmLiAgICAgICAgCisgICAgICAgIEF2b2lkcyBpbmNsdWRlIGFtYmlndWl0aWVz IG9mIEhhc2hNYXAuaCBmaWxlLgorCisgICAgICAgICogSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0 ZXIvSW50ZXJwcmV0ZXIuaDoKKwogMjAwOS0wNy0wMyAgSmFuIE1pY2hhZWwgQWxvbnpvICA8am1h bG9uem9Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBYYW4gTG9wZXogYW5kIEd1 c3Rhdm8gTm9yb25oYS4KSW5kZXg6IEphdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0ludGVycHJl dGVyLmgNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0NCi0tLSBKYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9JbnRlcnBy ZXRlci5oCShyZXZpc2lvbiA0NTYwOCkKKysrIEphdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0lu dGVycHJldGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTMxLDcgKzMxLDcgQEAKIAogI2luY2x1ZGUg IkFyZ0xpc3QuaCIKICNpbmNsdWRlICJGYXN0QWxsb2NCYXNlLmgiCi0jaW5jbHVkZSAiSGFzaE1h cC5oIgorI2luY2x1ZGUgInd0Zi9IYXNoTWFwLmgiCiAjaW5jbHVkZSAiSlNDZWxsLmgiCiAjaW5j bHVkZSAiSlNWYWx1ZS5oIgogI2luY2x1ZGUgIkpTT2JqZWN0LmgiCg== 32756 2009-07-14 18:25:31 -0700 2009-07-14 21:58:00 -0700 Second try. patch_27055.txt text/plain 1046 laszlo.gombos SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQ1ODg3KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMDctMTQgIE5vcmJlcnQg TGVzZXIgIDxub3JiZXJ0Lmxlc2VyQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBRdWFsaWZ5IGluY2x1ZGUgcGF0aCB3aXRoIHd0Zgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjcwNTUKKwor ICAgICAgICAqIGludGVycHJldGVyL0ludGVycHJldGVyLmg6CisKIDIwMDktMDctMTQgIFpvbHRh biBIb3J2YXRoICA8aHpvbHRhbkBpbmYudS1zemVnZWQuaHU+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgRGFyaW4gQWRsZXIuCkluZGV4OiBKYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9JbnRlcnBy ZXRlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0ludGVycHJl dGVyLmgJKHJldmlzaW9uIDQ1ODU2KQorKysgSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIvSW50 ZXJwcmV0ZXIuaAkod29ya2luZyBjb3B5KQpAQCAtMzEsMTMgKzMxLDE0IEBACiAKICNpbmNsdWRl ICJBcmdMaXN0LmgiCiAjaW5jbHVkZSAiRmFzdEFsbG9jQmFzZS5oIgotI2luY2x1ZGUgIkhhc2hN YXAuaCIKICNpbmNsdWRlICJKU0NlbGwuaCIKICNpbmNsdWRlICJKU1ZhbHVlLmgiCiAjaW5jbHVk ZSAiSlNPYmplY3QuaCIKICNpbmNsdWRlICJPcGNvZGUuaCIKICNpbmNsdWRlICJSZWdpc3RlckZp bGUuaCIKIAorI2luY2x1ZGUgPHd0Zi9IYXNoTWFwLmg+CisKIG5hbWVzcGFjZSBKU0MgewogCiAg ICAgY2xhc3MgQ29kZUJsb2NrOwo=