27053 2009-07-07 18:52:25 -0700 Ambiguity in LabelScope initialization 2009-07-13 01:20:40 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) S60 Emulator S60 3rd edition RESOLVED FIXED P2 Normal --- 27065 0 norbert.leser webkit-unassigned hausmann laszlo.gombos yongjun.zhang oldest_to_newest 130334 0 32413 norbert.leser 2009-07-07 18:52:25 -0700 Created attachment 32413 Code patch for BytecodeGenerator.cpp Codewarrior compiler (WINSCW) latest b482 on Symbian cannot resolve type of "0" unambiguously. Set expression explicitly to PassRefPtr<Label>::PassRefPtr(). Rather than implementing conditional block for COMPILER(WINSCW) it appears to be save and appropriate to modify the main-line code accordingly. 130337 1 32413 ggaren 2009-07-07 19:09:16 -0700 Comment on attachment 32413 Code patch for BytecodeGenerator.cpp r=me I think you can just write "PassRefPtr<Label>()" instead of "PassRefPtr<Label>::PassRefPtr()". 130349 2 32424 norbert.leser 2009-07-07 19:39:23 -0700 Created attachment 32424 Updated patch for bug# 27053 I just verified Geoffrey's suggestion about simplifying the statement, and he's right. The updated patch contains the respective modification. 131085 3 32424 eric 2009-07-10 23:14:20 -0700 Comment on attachment 32424 Updated patch for bug# 27053 OK. Your ChangeLog seems to have an extra return in it though. 131269 4 hausmann 2009-07-13 01:20:40 -0700 Landed in r45791. The ChangeLog was made from the wrong directory, btw. I moved it up to JavaScriptCore/ChangeLog and fixed the path. 32413 2009-07-07 18:52:25 -0700 2009-07-07 19:39:23 -0700 Code patch for BytecodeGenerator.cpp patch_BytecodeGenerator_cpp.txt text/plain 1450 norbert.leser SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQ1NjA3 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMDct MDcgIE5vcmJlcnQgTGVzZXIgIDxub3JiZXJ0Lmxlc2VyQG5va2lhLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBbWJpZ3VpdHkgaW4gTGFiZWxT Y29wZSBpbml0aWFsaXphdGlvbgorCisgICAgICAgIENvZGV3YXJyaW9yIGNvbXBpbGVyIChXSU5T Q1cpIGxhdGVzdCBiNDgyIG9uIFN5bWJpYW4gY2Fubm90IHJlc29sdmUKKyAgICAgICAgdHlwZSBv ZiAiMCIgdW5hbWJpZ3VvdXNseS4gU2V0IGV4cHJlc3Npb24gZXhwbGljaXRseSB0bworICAgICAg ICBQYXNzUmVmUHRyPExhYmVsPjo6UGFzc1JlZlB0cigpCisKKyAgICAgICAgKiBKYXZhU2NyaXB0 Q29yZS9ieXRlY29tcGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3IuY3BwCis6CisKIDIwMDktMDctMDMg IEphbiBNaWNoYWVsIEFsb256byAgPGptYWxvbnpvQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgWGFuIExvcGV6IGFuZCBHdXN0YXZvIE5vcm9uaGEuCkluZGV4OiBKYXZhU2NyaXB0 Q29yZS9ieXRlY29tcGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3IuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEph dmFTY3JpcHRDb3JlL2J5dGVjb21waWxlci9CeXRlY29kZUdlbmVyYXRvci5jcHAJKHJldmlzaW9u IDQ1NjA1KQorKysgSmF2YVNjcmlwdENvcmUvYnl0ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9y LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTI1LDcgKzUyNSw3IEBAIFBhc3NSZWZQdHI8TGFiZWxT Y29wZT4gQnl0ZWNvZGVHZW5lcmF0b3IKICAgICAgICAgbV9sYWJlbFNjb3Blcy5yZW1vdmVMYXN0 KCk7CiAKICAgICAvLyBBbGxvY2F0ZSBuZXcgbGFiZWwgc2NvcGUuCi0gICAgTGFiZWxTY29wZSBz Y29wZSh0eXBlLCBuYW1lLCBzY29wZURlcHRoKCksIG5ld0xhYmVsKCksIHR5cGUgPT0gTGFiZWxT Y29wZTo6TG9vcCA/IG5ld0xhYmVsKCkgOiAwKTsgLy8gT25seSBsb29wcyBoYXZlIGNvbnRpbnVl IHRhcmdldHMuCisgICAgTGFiZWxTY29wZSBzY29wZSh0eXBlLCBuYW1lLCBzY29wZURlcHRoKCks IG5ld0xhYmVsKCksIHR5cGUgPT0gTGFiZWxTY29wZTo6TG9vcCA/IG5ld0xhYmVsKCkgOiBQYXNz UmVmUHRyPExhYmVsPjo6UGFzc1JlZlB0cigpKTsgLy8gT25seSBsb29wcyBoYXZlIGNvbnRpbnVl IHRhcmdldHMuCiAgICAgbV9sYWJlbFNjb3Blcy5hcHBlbmQoc2NvcGUpOwogICAgIHJldHVybiAm bV9sYWJlbFNjb3Blcy5sYXN0KCk7CiB9Cg== 32424 2009-07-07 19:39:23 -0700 2009-07-10 23:14:20 -0700 Updated patch for bug# 27053 patch_BytecodeGenerator_cpp_2.txt text/plain 1438 norbert.leser SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQ1NjA3 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMDct MDcgIE5vcmJlcnQgTGVzZXIgIDxub3JiZXJ0Lmxlc2VyQG5va2lhLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBbWJpZ3VpdHkgaW4gTGFiZWxT Y29wZSBpbml0aWFsaXphdGlvbgorCisgICAgICAgIENvZGV3YXJyaW9yIGNvbXBpbGVyIChXSU5T Q1cpIGxhdGVzdCBiNDgyIG9uIFN5bWJpYW4gY2Fubm90IHJlc29sdmUKKyAgICAgICAgdHlwZSBv ZiAiMCIgdW5hbWJpZ3VvdXNseS4gU2V0IGV4cHJlc3Npb24gZXhwbGljaXRseSB0bworICAgICAg ICBQYXNzUmVmUHRyPExhYmVsPjo6UGFzc1JlZlB0cigpCisKKyAgICAgICAgKiBKYXZhU2NyaXB0 Q29yZS9ieXRlY29tcGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3IuY3BwCis6CisKIDIwMDktMDctMDMg IEphbiBNaWNoYWVsIEFsb256byAgPGptYWxvbnpvQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgWGFuIExvcGV6IGFuZCBHdXN0YXZvIE5vcm9uaGEuCkluZGV4OiBKYXZhU2NyaXB0 Q29yZS9ieXRlY29tcGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3IuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEph dmFTY3JpcHRDb3JlL2J5dGVjb21waWxlci9CeXRlY29kZUdlbmVyYXRvci5jcHAJKHJldmlzaW9u IDQ1NjA1KQorKysgSmF2YVNjcmlwdENvcmUvYnl0ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9y LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTI1LDcgKzUyNSw3IEBAIFBhc3NSZWZQdHI8TGFiZWxT Y29wZT4gQnl0ZWNvZGVHZW5lcmF0b3IKICAgICAgICAgbV9sYWJlbFNjb3Blcy5yZW1vdmVMYXN0 KCk7CiAKICAgICAvLyBBbGxvY2F0ZSBuZXcgbGFiZWwgc2NvcGUuCi0gICAgTGFiZWxTY29wZSBz Y29wZSh0eXBlLCBuYW1lLCBzY29wZURlcHRoKCksIG5ld0xhYmVsKCksIHR5cGUgPT0gTGFiZWxT Y29wZTo6TG9vcCA/IG5ld0xhYmVsKCkgOiAwKTsgLy8gT25seSBsb29wcyBoYXZlIGNvbnRpbnVl IHRhcmdldHMuCisgICAgTGFiZWxTY29wZSBzY29wZSh0eXBlLCBuYW1lLCBzY29wZURlcHRoKCks IG5ld0xhYmVsKCksIHR5cGUgPT0gTGFiZWxTY29wZTo6TG9vcCA/IG5ld0xhYmVsKCkgOiBQYXNz UmVmUHRyPExhYmVsPigpKTsgLy8gT25seSBsb29wcyBoYXZlIGNvbnRpbnVlIHRhcmdldHMuCiAg ICAgbV9sYWJlbFNjb3Blcy5hcHBlbmQoc2NvcGUpOwogICAgIHJldHVybiAmbV9sYWJlbFNjb3Bl cy5sYXN0KCk7CiB9Cg==