27037 2009-07-07 12:38:47 -0700 Fix baselines for inline tables. 2012-06-14 16:17:53 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED DUPLICATE 84167 P2 Normal --- 1 agl webkit-unassigned abarth eric hyatt jchaffraix robert oldest_to_newest 130254 0 agl 2009-07-07 12:38:47 -0700 CSS specifies that the baseline of an inline table is the baseline of the first row. Previously, inline tables were floating off into nowhere. See http://www.w3.org/TR/CSS2/visudet.html#leading: "The baseline of an 'inline-table' is the baseline of the first row of the table." 130255 1 32388 agl 2009-07-07 12:42:23 -0700 Created attachment 32388 patch I'm not sure that the patch fixes this in the right way. The layout test included certainly demonstrates the issue and the patch fixes that, but it seems to cause some layout test failures which I'm still looking at. 130290 2 eric 2009-07-07 15:52:25 -0700 This is hyatt's area. Possibly Adele too. 132071 3 32388 eric 2009-07-15 16:10:57 -0700 Comment on attachment 32388 patch Haven't heard much from the table folks. But this looks sane to me. Please fix your style error: +int RenderTable::baselinePosition(bool firstLine, bool isRootLineBox) const { + if (firstBody() && style()->display() == INLINE_TABLE) Make sure you've run the layout tests when landing. 132380 4 abarth 2009-07-16 15:53:37 -0700 Will land. 132385 5 32388 abarth 2009-07-16 16:09:20 -0700 Comment on attachment 32388 patch This patch fails the following tests: editing/pasteboard/innerText-inline-table.html editing/selection/iframe.html editing/selection/inline-table.html editing/selection/table-caret-3.html fast/css-generated-content/inline-display-types.html fast/encoding/utf-16-big-endian.html fast/encoding/utf-16-little-endian.html fast/inline-block/001.html fast/invalid/residual-style.html fast/repaint/float-overflow-right.html fast/repaint/float-overflow.html http/tests/misc/redirect-to-about-blank.html tables/mozilla/bugs/bug2479-2.html 132390 6 abarth 2009-07-16 16:16:01 -0700 Unassigning. This is no longer actionable by me. 132437 7 agl 2009-07-16 18:36:25 -0700 Sorry, I didn't intend for anyone to land this patch just yet. It does 'fail' tests, but I believe that the baselines are currently wrong for those tests. I don't have time to look at this now, so I'll leave the patch r-'ed. 649606 8 jchaffraix 2012-06-14 16:17:53 -0700 This was solved by Robert as part of bug 84167. Duplicating this bug as the other bug had a fix that landed. I believe Robert's coverage was enough to cover the test in this patch. *** This bug has been marked as a duplicate of bug 84167 *** 32388 2009-07-07 12:42:23 -0700 2010-06-10 17:47:57 -0700 patch patch text/plain 3740 agl ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAwMTc3YWYxLi43Zjk5Yjg0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMDktMDct MDcgIEFkYW0gTGFuZ2xleSAgPGFnbEBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBiYXNlbGluZXMgZm9yIGlubGluZSB0YWJs ZXMuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI3 MDM3CisKKyAgICAgICAgQ1NTIHNwZWNpZmllcyB0aGF0IHRoZSBiYXNlbGluZSBvZiBhbiBpbmxp bmUgdGFibGUgaXMgdGhlIGJhc2VsaW5lIG9mCisgICAgICAgIHRoZSBmaXJzdCByb3cuIFByZXZp b3VzbHksIGlubGluZSB0YWJsZXMgd2VyZSBmbG9hdGluZyBvZmYgaW50bworICAgICAgICBub3do ZXJlLgorCisgICAgICAgIFNlZSBodHRwOi8vd3d3LnczLm9yZy9UUi9DU1MyL3Zpc3VkZXQuaHRt bCNsZWFkaW5nOgorICAgICAgICAgICJUaGUgYmFzZWxpbmUgb2YgYW4gJ2lubGluZS10YWJsZScg aXMgdGhlIGJhc2VsaW5lIG9mIHRoZSBmaXJzdCByb3cKKyAgICAgICAgICBvZiB0aGUgdGFibGUu IgorCisgICAgICAgICogZmFzdC90YWJsZS9pbmxpbmUtdGFibGUtYmFzZWxpbmUuaHRtbDogQWRk ZWQuCisKIDIwMDktMDctMDYgIFBpZXJyZSBkJ0hlcmJlbW9udCAgPHBkaGVyYmVtb250QGFwcGxl LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIuCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9mYXN0L3RhYmxlL2lubGluZS10YWJsZS1iYXNlbGluZS5odG1sIGIvTGF5b3V0 VGVzdHMvZmFzdC90YWJsZS9pbmxpbmUtdGFibGUtYmFzZWxpbmUuaHRtbApuZXcgZmlsZSBtb2Rl IDEwMDY0NAppbmRleCAwMDAwMDAwLi4wNTk3M2ZlCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0 VGVzdHMvZmFzdC90YWJsZS9pbmxpbmUtdGFibGUtYmFzZWxpbmUuaHRtbApAQCAtMCwwICsxLDEx IEBACis8aHRtbD4KKyAgPGhlYWQ+CisgICAgPHRpdGxlPklubGluZSB0YWJsZSBiYXNlbGluZXM8 L3RpdGxlPgorICA8L2hlYWQ+CisKKyAgPGJvZHk+CisgICAgPHA+Q1NTIHNwZWNpZmllcyB0aGF0 IHRoZSBiYXNlbGluZSBvZiBhbiBpbmxpbmUgdGFibGUgaXMgdGhlIGJhc2VsaW5lIG9mIHRoZSBm aXJzdCByb3cuIEJlbG93IHlvdSBzaG91bGQgc2VlIGEgc2luZ2xlIGxpbmUgb2YgdGV4dCwgdW5i cm9rZW4gd2l0aCBhIGNvbnNpc3RlbnQgYmFzZWxpbmUgYW5kLCBzdGFydGluZyBiZWxvdyB0aGUg J2EnIG9mIHRoZSBmaXJzdCBsaW5lLCBhbm90aGVyIGxpbmUuPC9wPgorCisgICAgPHA+VGhpcyBz aG91bGQgYmUgPHNwYW4gc3R5bGU9ImRpc3BsYXk6IGlubGluZS10YWJsZTsiPjxzcGFuIHN0eWxl PSJkaXNwbGF5OiB0YWJsZS1yb3c7Ij5hIHNpbmdsZSBsaW5lIG9mIHRleHQuPC9zcGFuPjxzcGFu IHN0eWxlPSJkaXNwbGF5OiB0YWJsZS1yb3c7Ij5UaGlzIHNob3VsZCBzdGFydCB1bmRlciB0aGUg J2EnLjwvc3Bhbj48L3NwYW4+PC9wPgorICA8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9X ZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGI4ZGI3NGMuLjJiMjZi MWQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMjUgQEAKKzIwMDktMDctMDcgIEFkYW0gTGFuZ2xleSAgPGFnbEBnb29nbGUu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZp eCBiYXNlbGluZXMgZm9yIGlubGluZSB0YWJsZXMuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI3MDM3CisKKyAgICAgICAgQ1NTIHNwZWNpZmllcyB0 aGF0IHRoZSBiYXNlbGluZSBvZiBhbiBpbmxpbmUgdGFibGUgaXMgdGhlIGJhc2VsaW5lIG9mCisg ICAgICAgIHRoZSBmaXJzdCByb3cuIFByZXZpb3VzbHksIGlubGluZSB0YWJsZXMgd2VyZSBmbG9h dGluZyBvZmYgaW50bworICAgICAgICBub3doZXJlLgorCisgICAgICAgIFNlZSBodHRwOi8vd3d3 LnczLm9yZy9UUi9DU1MyL3Zpc3VkZXQuaHRtbCNsZWFkaW5nOgorICAgICAgICAgICJUaGUgYmFz ZWxpbmUgb2YgYW4gJ2lubGluZS10YWJsZScgaXMgdGhlIGJhc2VsaW5lIG9mIHRoZSBmaXJzdCBy b3cKKyAgICAgICAgICBvZiB0aGUgdGFibGUuIgorCisgICAgICAgIFRlc3Q6IGZhc3QvdGFibGUv aW5saW5lLXRhYmxlLWJhc2VsaW5lLmh0bWwKKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJU YWJsZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUYWJsZTo6YmFzZWxpbmVQb3NpdGlv bik6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRhYmxlLmg6CisKIDIwMDktMDctMDYgIFBp ZXJyZSBkJ0hlcmJlbW9udCAgPHBkaGVyYmVtb250QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZp ZXdlZCBieSBTaW1vbiBGcmFzZXIuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJUYWJsZS5jcHAgYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZS5jcHAKaW5kZXggNDhi MGQxYy4uMTZlNzc2MSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGUu Y3BwCisrKyBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRhYmxlLmNwcApAQCAtMTE1MSw0ICsx MTUxLDExIEBAIGJvb2wgUmVuZGVyVGFibGU6Om5vZGVBdFBvaW50KGNvbnN0IEhpdFRlc3RSZXF1 ZXN0JiByZXF1ZXN0LCBIaXRUZXN0UmVzdWx0JiByZXN1CiAgICAgcmV0dXJuIGZhbHNlOwogfQog CitpbnQgUmVuZGVyVGFibGU6OmJhc2VsaW5lUG9zaXRpb24oYm9vbCBmaXJzdExpbmUsIGJvb2wg aXNSb290TGluZUJveCkgY29uc3QgeworICAgIGlmIChmaXJzdEJvZHkoKSAmJiBzdHlsZSgpLT5k aXNwbGF5KCkgPT0gSU5MSU5FX1RBQkxFKQorICAgICAgICByZXR1cm4gZmlyc3RCb2R5KCktPmZp cnN0TGluZUJveEJhc2VsaW5lKCk7CisKKyAgICByZXR1cm4gUmVuZGVyQmxvY2s6OmJhc2VsaW5l UG9zaXRpb24oZmlyc3RMaW5lLCBpc1Jvb3RMaW5lQm94KTsKK30KKwogfQpkaWZmIC0tZ2l0IGEv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGUuaCBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl clRhYmxlLmgKaW5kZXggMDdlMDJiMC4uZWQwMjNmNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyVGFibGUuaAorKysgYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZS5o CkBAIC04Myw2ICs4Myw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIGJvb2wgbm9kZUF0UG9pbnQo Y29uc3QgSGl0VGVzdFJlcXVlc3QmLCBIaXRUZXN0UmVzdWx0JiwgaW50IHhQb3MsIGludCB5UG9z LCBpbnQgdHgsIGludCB0eSwgSGl0VGVzdEFjdGlvbik7CiAgICAgCiAgICAgdmlydHVhbCBpbnQg Zmlyc3RMaW5lQm94QmFzZWxpbmUoKSBjb25zdDsKKyAgICB2aXJ0dWFsIGludCBiYXNlbGluZVBv c2l0aW9uKGJvb2wgZmlyc3RMaW5lLCBib29sIGlzUm9vdExpbmVCb3ggPSBmYWxzZSkgY29uc3Q7 CiAKICAgICB2aXJ0dWFsIFJlbmRlckJsb2NrKiBmaXJzdExpbmVCbG9jaygpIGNvbnN0OwogICAg IHZpcnR1YWwgdm9pZCB1cGRhdGVGaXJzdExldHRlcigpOwo=