<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>270047</bug_id>
          
          <creation_ts>2024-02-25 02:28:35 -0800</creation_ts>
          <short_desc>[Skia] Do not use the legacy native GL/EGL interface factory</short_desc>
          <delta_ts>2024-02-26 00:14:15 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>WebKit Local Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>268972</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Adrian Perez">aperez</reporter>
          <assigned_to name="Adrian Perez">aperez</assigned_to>
          <cc>bfulgham</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>zalan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2016681</commentid>
    <comment_count>0</comment_count>
    <who name="Adrian Perez">aperez</who>
    <bug_when>2024-02-25 02:28:35 -0800</bug_when>
    <thetext>Skia is slowly transitioning away from the implicit instantiation of
its GL/EGL interface helpers via GrGLMakeNativeInterface(), which I have
been made aware of in a comment here:

  https://skia-review.googlesource.com/c/skia/+/814176/comment/dc3041af_dbaf1a16/

From the WebKit side what we need to do is explicitly passing a GrGLInterface
which we have explicitly created when using GrDirectContext::MakeGL()</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2016682</commentid>
    <comment_count>1</comment_count>
    <who name="Adrian Perez">aperez</who>
    <bug_when>2024-02-25 02:39:33 -0800</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/25069</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2016785</commentid>
    <comment_count>2</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2024-02-26 00:13:32 -0800</bug_when>
    <thetext>Committed 275311@main (c6ffba680732): &lt;https://commits.webkit.org/275311@main&gt;

Reviewed commits have been landed. Closing PR #25069 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2016786</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2024-02-26 00:14:15 -0800</bug_when>
    <thetext>&lt;rdar://problem/123618141&gt;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>