269646 2024-02-17 08:59:56 -0800 [Painting] Use typographicMode in overlineOffsetForTextBoxPainting 2024-07-26 19:23:06 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 245559 1 zalan zalan bfulgham ews-watchlist koivisto mmaxfield simon.fraser webkit-bug-importer zalan oldest_to_newest 2014820 0 zalan 2024-02-17 08:59:56 -0800 to match spec language. 2014822 1 469947 zalan 2024-02-17 09:05:07 -0800 Created attachment 469947 [fast-cq]Patch 2014947 2 ews-feeder 2024-02-18 09:06:27 -0800 Committed 274949@main (3abb713c4d2f): <https://commits.webkit.org/274949@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 469947. 2014948 3 webkit-bug-importer 2024-02-18 09:07:18 -0800 <rdar://problem/123190952> 469947 2024-02-17 09:05:07 -0800 2024-02-18 09:06:28 -0800 [fast-cq]Patch bug-269646-20240217090506.patch text/plain 3168 zalan RnJvbSBlOGUyNWZmYzJkZGU5NWFlMWNmOGMxMDI0YzBkZmMwYzM3OWE2NjNjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGFuIEJhcmFkbGF5IDx6YWxhbkBhcHBsZS5jb20+CkRhdGU6 IFNhdCwgMTcgRmViIDIwMjQgMDk6MDA6MDcgLTA4MDAKU3ViamVjdDogW1BBVENIXSBbUGFpbnRp bmddIFVzZSB0eXBvZ3JhcGhpY01vZGUgaW4KIG92ZXJsaW5lT2Zmc2V0Rm9yVGV4dEJveFBhaW50 aW5nCiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjY5NjQ2CgpSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCkl0IG1ha2VzIGl0IGVhc2llciB0byByZWFzb24gYWJv dXQgb3ZlciB2cy4gdW5kZXIgc2lkZXMgKGNsb3NlciB0byBzcGVjIGxhbmd1YWdlKQpzZWUgaHR0 cHM6Ly9kcmFmdHMuY3Nzd2cub3JnL2Nzcy13cml0aW5nLW1vZGVzLTQvI2xpbmUtZGlyZWN0aW9u cwoKKiBTb3VyY2UvV2ViQ29yZS9zdHlsZS9JbmxpbmVUZXh0Qm94U3R5bGUuY3BwOgooV2ViQ29y ZTo6b3ZlcmxpbmVPZmZzZXRGb3JUZXh0Qm94UGFpbnRpbmcpOgotLS0KIFNvdXJjZS9XZWJDb3Jl L3N0eWxlL0lubGluZVRleHRCb3hTdHlsZS5jcHAgfCAyNSArKysrKysrKysrKy0tLS0tLS0tLS0K IDEgZmlsZSBjaGFuZ2VkLCAxMyBpbnNlcnRpb25zKCspLCAxMiBkZWxldGlvbnMoLSkKCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9zdHlsZS9JbmxpbmVUZXh0Qm94U3R5bGUuY3BwIGIvU291 cmNlL1dlYkNvcmUvc3R5bGUvSW5saW5lVGV4dEJveFN0eWxlLmNwcAppbmRleCBmMjg4YTAxZmU2 ZmIuLjA3NWViZWRiM2JiMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvc3R5bGUvSW5saW5l VGV4dEJveFN0eWxlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9zdHlsZS9JbmxpbmVUZXh0Qm94 U3R5bGUuY3BwCkBAIC0zMzAsMjMgKzMzMCwyNCBAQCBmbG9hdCB1bmRlcmxpbmVPZmZzZXRGb3JU ZXh0Qm94UGFpbnRpbmcoY29uc3QgSW5saW5lSXRlcmF0b3I6OklubGluZUJveCYgaW5saW5lQgog CiBmbG9hdCBvdmVybGluZU9mZnNldEZvclRleHRCb3hQYWludGluZyhjb25zdCBJbmxpbmVJdGVy YXRvcjo6SW5saW5lQm94JiBpbmxpbmVCb3gsIGNvbnN0IFJlbmRlclN0eWxlJiBzdHlsZSkKIHsK LSAgICBhdXRvIHdyaXRpbmdNb2RlID0gc3R5bGUud3JpdGluZ01vZGUoKTsKLSAgICBpZiAoaXNI b3Jpem9udGFsV3JpdGluZ01vZGUod3JpdGluZ01vZGUpKQotICAgICAgICByZXR1cm4geyB9Owot CiAgICAgaWYgKCFzdHlsZS50ZXh0RGVjb3JhdGlvbnNJbkVmZmVjdCgpLmNvbnRhaW5zKFRleHRE ZWNvcmF0aW9uTGluZTo6VW5kZXJsaW5lKSkKICAgICAgICAgcmV0dXJuIHsgfTsKIAotICAgIGF1 dG8gdW5kZXJsaW5lUG9zaXRpb24gPSBzdHlsZS50ZXh0VW5kZXJsaW5lUG9zaXRpb24oKTsKLSAg ICAvLyBJZiAncmlnaHQnIGNhdXNlcyB0aGUgdW5kZXJsaW5lIHRvIGJlIGRyYXduIG9uIHRoZSAi b3ZlciIgc2lkZSBvZiB0aGUgdGV4dCwgdGhlbiBhbiBvdmVybGluZSBhbHNvIHN3aXRjaGVzIHNp ZGVzIGFuZCBpcyBkcmF3biBvbiB0aGUgInVuZGVyIiBzaWRlLgotICAgIC8vIElmICdsZWZ0JyBj YXVzZXMgdGhlIHVuZGVybGluZSB0byBiZSBkcmF3biBvbiB0aGUgIm92ZXIiIHNpZGUgb2YgdGhl IHRleHQsIHRoZW4gYW4gb3ZlcmxpbmUgYWxzbyBzd2l0Y2hlcyBzaWRlcyBhbmQgaXMgZHJhd24g b24gdGhlICJ1bmRlciIgc2lkZS4KLSAgICBhdXRvIG92ZXJCZWNvbWVzVW5kZXIgPSAodW5kZXJs aW5lUG9zaXRpb24gPT0gVGV4dFVuZGVybGluZVBvc2l0aW9uOjpMZWZ0ICYmIHdyaXRpbmdNb2Rl ID09IFdyaXRpbmdNb2RlOjpTaWRld2F5c0xyKQotICAgICAgICB8fCAodW5kZXJsaW5lUG9zaXRp b24gPT0gVGV4dFVuZGVybGluZVBvc2l0aW9uOjpSaWdodCAmJiAod3JpdGluZ01vZGUgPT0gV3Jp dGluZ01vZGU6OlZlcnRpY2FsTHIgfHwgd3JpdGluZ01vZGUgPT0gV3JpdGluZ01vZGU6OlZlcnRp Y2FsUmwgfHwgd3JpdGluZ01vZGUgPT0gV3JpdGluZ01vZGU6OlNpZGV3YXlzUmwpKTsKLQotICAg IGlmICghb3ZlckJlY29tZXNVbmRlcikKKyAgICBpZiAoc3R5bGUuaXNIb3Jpem9udGFsV3JpdGlu Z01vZGUoKSkKICAgICAgICAgcmV0dXJuIHsgfTsKIAotICAgIHJldHVybiBpbmxpbmVCb3hDb250 ZW50Qm94SGVpZ2h0KGlubGluZUJveCk7CisgICAgYXV0byB1bmRlcmxpbmVQb3NpdGlvbiA9IHN0 eWxlLnRleHRVbmRlcmxpbmVQb3NpdGlvbigpOworICAgIGF1dG8gb3ZlckJlY29tZXNVbmRlciA9 IFsmXSB7CisgICAgICAgIGF1dG8gdHlwb2dyYXBoaWNNb2RlID0gc3R5bGUudHlwb2dyYXBoaWNN b2RlKCk7CisgICAgICAgIC8vIElmICdyaWdodCcgY2F1c2VzIHRoZSB1bmRlcmxpbmUgdG8gYmUg ZHJhd24gb24gdGhlICJvdmVyIiBzaWRlIG9mIHRoZSB0ZXh0LCB0aGVuIGFuIG92ZXJsaW5lIGFs c28gc3dpdGNoZXMgc2lkZXMgYW5kIGlzIGRyYXduIG9uIHRoZSAidW5kZXIiIHNpZGUuCisgICAg ICAgIGlmICh1bmRlcmxpbmVQb3NpdGlvbiA9PSBUZXh0VW5kZXJsaW5lUG9zaXRpb246OlJpZ2h0 KQorICAgICAgICAgICAgcmV0dXJuIHR5cG9ncmFwaGljTW9kZSA9PSBUeXBvZ3JhcGhpY01vZGU6 OlZlcnRpY2FsIHx8IHN0eWxlLmJsb2NrRmxvd0RpcmVjdGlvbigpID09IEJsb2NrRmxvd0RpcmVj dGlvbjo6UmlnaHRUb0xlZnQ7CisgICAgICAgIC8vIElmICdsZWZ0JyBjYXVzZXMgdGhlIHVuZGVy bGluZSB0byBiZSBkcmF3biBvbiB0aGUgIm92ZXIiIHNpZGUgb2YgdGhlIHRleHQsIHRoZW4gYW4g b3ZlcmxpbmUgYWxzbyBzd2l0Y2hlcyBzaWRlcyBhbmQgaXMgZHJhd24gb24gdGhlICJ1bmRlciIg c2lkZS4KKyAgICAgICAgaWYgKHVuZGVybGluZVBvc2l0aW9uID09IFRleHRVbmRlcmxpbmVQb3Np dGlvbjo6TGVmdCkKKyAgICAgICAgICAgIHJldHVybiB0eXBvZ3JhcGhpY01vZGUgPT0gVHlwb2dy YXBoaWNNb2RlOjpIb3Jpem9udGFsICYmIHN0eWxlLmJsb2NrRmxvd0RpcmVjdGlvbigpID09IEJs b2NrRmxvd0RpcmVjdGlvbjo6TGVmdFRvUmlnaHQ7CisgICAgICAgIHJldHVybiBmYWxzZTsKKyAg ICB9OworICAgIHJldHVybiBvdmVyQmVjb21lc1VuZGVyKCkgPyBpbmxpbmVCb3hDb250ZW50Qm94 SGVpZ2h0KGlubGluZUJveCkgOiAwLmY7CiB9CiAKIH0K