<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>269165</bug_id>
          
          <creation_ts>2024-02-11 03:47:49 -0800</creation_ts>
          <short_desc>[Digital Identity]: navigator.identity should be implemented by a separate IdentityCredentialManager</short_desc>
          <delta_ts>2024-03-11 16:35:03 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>Other</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>268726</dependson>
          <blocked>268516</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Marcos Caceres">marcosc</reporter>
          <assigned_to name="Marcos Caceres">marcosc</assigned_to>
          <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2012583</commentid>
    <comment_count>0</comment_count>
    <who name="Marcos Caceres">marcosc</who>
    <bug_when>2024-02-11 03:47:49 -0800</bug_when>
    <thetext>Once bug 268516 is in place, we need to implement an IdentityCredentialManager class that inherits from CredentialManager. 

My idea is to make the methods on CredentialManager all virtual, so to allow IdentityCredentialManager to override them.

At the same time, we want to have shared error checking behavior in both IdentityCredentialManager and CredentialManager, so need to make sure that we split those checks out.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2012584</commentid>
    <comment_count>1</comment_count>
    <who name="Marcos Caceres">marcosc</who>
    <bug_when>2024-02-11 03:49:01 -0800</bug_when>
    <thetext>I mean, once 268726 is in place instead.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2014923</commentid>
    <comment_count>2</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2024-02-18 03:48:13 -0800</bug_when>
    <thetext>&lt;rdar://problem/123184696&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2017938</commentid>
    <comment_count>3</comment_count>
    <who name="Marcos Caceres">marcosc</who>
    <bug_when>2024-02-29 23:16:39 -0800</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/25338</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2020283</commentid>
    <comment_count>4</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2024-03-11 16:35:01 -0700</bug_when>
    <thetext>Committed 275939@main (2dbfef33bb52): &lt;https://commits.webkit.org/275939@main&gt;

Reviewed commits have been landed. Closing PR #25338 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>