268796 2024-02-05 19:36:05 -0800 [MSE] Remove HTMLMediaElement access from MediaSource 2024-02-11 03:03:58 -0800 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 268911 264134 1 jean-yves.avenard jean-yves.avenard webkit-bug-importer oldest_to_newest 2010873 0 jean-yves.avenard 2024-02-05 19:36:05 -0800 subtask of bug 264134 Currently the MediaSource::monitorSourceBuffer requires the mediaElement's currentTime. But to do so, it directly access the HTMLMediaElement::currentMediaTime [1] As the MediaSource may not be running in the same thread in the future, it may not be safe for the MediaSource to directly access the MediaElement. An alternative would be to access the MediaPlayer instead, which has a more up to date value of the current time. [1] https://searchfox.org/wubkat/rev/5266b069f715d2051da7f1fc8def26d5dcd5e03c/Source/WebCore/Modules/mediasource/MediaSource.cpp#182-187 2010874 1 webkit-bug-importer 2024-02-05 19:36:24 -0800 <rdar://problem/122359957> 2012170 2 jean-yves.avenard 2024-02-09 06:08:51 -0800 Pull request: https://github.com/WebKit/WebKit/pull/24142 2012575 3 ews-feeder 2024-02-11 03:03:57 -0800 Committed 274442@main (b0908a7024e1): <https://commits.webkit.org/274442@main> Reviewed commits have been landed. Closing PR #24142 and removing active labels.