268060 2024-01-24 21:39:45 -0800 `check-webkit-style --git-index` fails with error 2024-04-06 15:53:52 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 265030 InRadar P2 Normal --- 1 simon.fraser webkit-unassigned bfan2 jbedard simon.fraser webkit-bug-importer oldest_to_newest 2007462 0 simon.fraser 2024-01-24 21:39:45 -0800 OpenSource % ./Tools/Scripts/check-webkit-style --git-index Traceback (most recent call last): File "/Volumes/Data/Development/system/webkit/OpenSource/./Tools/Scripts/check-webkit-style", line 46, in <module> sys.exit(CheckWebKitStyle().main()) File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/webkitpy/style/main.py", line 157, in main patch = host.scm().create_patch(options.git_commit, changed_files=changed_files, git_index=options.git_index, find_branch=True) File "/Volumes/Data/Development/system/webkit/OpenSource/Tools/Scripts/webkitpy/common/checkout/scm/git.py", line 376, in create_patch assert command[1] == 'diff' AssertionError 2009633 1 webkit-bug-importer 2024-01-31 21:40:13 -0800 <rdar://problem/122068513> 2026146 2 jbedard 2024-04-04 17:21:49 -0700 I can't reproduce this. Is there any more information about the state of your checkout when encountering this error? Looking at the code, I suspect this has something to do with generating a patch with a commit message instead of just a diff, so it's probably related to to being on a PR branch vs main and then having a commit vs just changed files. 2026309 3 jbedard 2024-04-05 09:49:33 -0700 User says this works for them now, closing this bug. 2026551 4 gsnedders 2024-04-06 15:53:52 -0700 This will've been fixed by bug 265030, 273780@main. *** This bug has been marked as a duplicate of bug 265030 ***