26770 2009-06-26 22:44:57 -0700 Transitions fail to run sometimes 2021-04-22 16:19:58 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 93136 1 simon.fraser simon.fraser cmarrin eoconnor gsnedders menard webkit-bug-importer oldest_to_newest 128643 0 simon.fraser 2009-06-26 22:44:57 -0700 I'm playing with trying to make opacity transitions only run in hardware when the page is already in hardware, and am running into a bug. AnimationControllerPrivate has a m_waitingForAResponse member variable, which gets set to 'true' when an animation is going to run in hardware, and give us a callback when it starts. However, nothing sets this to false, so if you later try and run a software anim in the same frame (since the AnimationController has the same lifetime as the frame), then it never starts. This may explain some of the transition weirdness. 128644 1 simon.fraser 2009-06-26 22:47:14 -0700 Is this the right place to clear it? diff --git a/WebCore/page/animation/AnimationController.cpp b/WebCore/page/animation/AnimationController.cpp index 58a1f5b..c5bd82a 100644 --- a/WebCore/page/animation/AnimationController.cpp +++ b/WebCore/page/animation/AnimationController.cpp @@ -432,6 +432,7 @@ void AnimationControllerPrivate::startTimeResponse(double t) m_responseWaiters = 0; m_lastResponseWaiter = 0; + m_waitingForAResponse = false; } AnimationController::AnimationController(Frame* frame) 128645 2 simon.fraser 2009-06-26 22:56:02 -0700 Actually this works fine as long as receivedStartTimeResponse() gets called. However, if it doesn't for some reason (layer gets blown away?), then that flag gets left set to true. 128651 3 cmarrin 2009-06-27 06:32:23 -0700 You analysis looks right. The problem is what to do if the thing that will trigger the callback never happens. I think if we save a ref to the AnimationBase object that will trigger the callback, and then clear the flag if that object gets destroyed, it will ensure the flag is always in the right state. But in that case, if the flag gets cleared, we will have to make the callback happen right away to get the other animations started. This will destroy sync, but that won't be a big issue in this special case. It will be very rare. 151764 4 40494 simon.fraser 2009-10-01 21:23:49 -0700 Created attachment 40494 Possible testcase Here's a test that I think is showing the same issue. After you run this one test, navigating to another page with animations asserts: ASSERTION FAILED: !childNeedsStyleRecalc() (/Volumes/WebKit/WebKit.git/WebCore/dom/Document.cpp:1193 void WebCore::Document::unscheduleStyleRecalc()) 151766 5 simon.fraser 2009-10-01 21:38:43 -0700 The change in comment 1 makes this problem caused by the testcase go away. 152947 6 simon.fraser 2009-10-06 21:58:27 -0700 There's a reproducible instance of this issue in bug 29984. 154660 7 41190 simon.fraser 2009-10-14 14:46:48 -0700 Created attachment 41190 Patch 154819 8 simon.fraser 2009-10-15 09:53:11 -0700 http://trac.webkit.org/changeset/49633 155182 9 simon.fraser 2009-10-16 13:15:05 -0700 This broke accelerated transitions in some cases: bug 30453. 155183 10 simon.fraser 2009-10-16 13:17:11 -0700 Reopening to cover the issues with broken transitions related to visibility:hidden (see also bug 29984). 155938 11 41190 eric 2009-10-19 15:12:11 -0700 Comment on attachment 41190 Patch Clearing mitz's r+ on this obsolete patch. 267085 12 simon.fraser 2010-08-19 17:28:01 -0700 <rdar://problem/8281319> 1753136 13 gsnedders 2021-04-22 06:32:04 -0700 http://trac.webkit.org/changeset/98735 and http://trac.webkit.org/changeset/98776 apparently fixed this? 1753346 14 webkit-bug-importer 2021-04-22 16:19:58 -0700 <rdar://problem/77043647> 40494 2009-10-01 21:23:49 -0700 2009-10-01 21:23:49 -0700 Possible testcase visibility-transform.html text/html 1385 simon.fraser PCFET0NUWVBFIGh0bWwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMDEgVHJhbnNpdGlvbmFs Ly9FTiIKICAgImh0dHA6Ly93d3cudzMub3JnL1RSL2h0bWw0L2xvb3NlLmR0ZCI+Cgo8aHRtbCBs YW5nPSJlbiI+CjxoZWFkPgogIDx0aXRsZT5WaXNpYmlsaXR5IGFuaW1hdGlvbjwvdGl0bGU+CiAg PHN0eWxlIHR5cGU9InRleHQvY3NzIiBtZWRpYT0ic2NyZWVuIj4KICAgIC5jb250YWluZXIgewog ICAgICBoZWlnaHQ6IDIwMHB4OwogICAgICB3aWR0aDogNjAwcHg7CiAgICAgIG1hcmdpbjogMjBw eDsKICAgICAgYm9yZGVyOiAxcHggc29saWQgYmxhY2s7CiAgICB9CiAgICAKICAgIC5ib3ggewog ICAgICBwb3NpdGlvbjogYWJzb2x1dGU7CiAgICAgIHdpZHRoOiAxMDBweDsKICAgICAgaGVpZ2h0 OiAxMDBweDsKICAgIH0KICAgIAogICAgLmluY29taW5nIHsKICAgICAgYmFja2dyb3VuZC1jb2xv cjogYmx1ZTsKICAgICAgLXdlYmtpdC1hbmltYXRpb246IG1vdmUgMnMgbGluZWFyLCBpbmNvbWlu Zy12aXNpYmlsaXR5IDJzIGxpbmVhcjsKICAgIH0KCiAgICAub3V0Z29pbmcgewogICAgICBiYWNr Z3JvdW5kLWNvbG9yOiByZWQ7CiAgICAgIC13ZWJraXQtYW5pbWF0aW9uOiBtb3ZlIDJzIGxpbmVh ciwgb3V0Z29pbmctdmlzaWJpbGl0eSAycyBsaW5lYXI7CiAgICB9CiAgICAKICAgIEAtd2Via2l0 LWtleWZyYW1lcyBtb3ZlCiAgICB7CiAgICAgIDAlICB7IC13ZWJraXQtdHJhbnNmb3JtOiB0cmFu c2xhdGUoMCwgMCkgcm90YXRlKDApOyB9CiAgICAgIDEwMCV7IC13ZWJraXQtdHJhbnNmb3JtOiB0 cmFuc2xhdGUoNTAwcHgsIDApIHJvdGF0ZSgyMGRlZyk7IH0KICAgIH0KCiAgICBALXdlYmtpdC1r ZXlmcmFtZXMgb3V0Z29pbmctdmlzaWJpbGl0eQogICAgewogICAgICAwJSAgeyB2aXNpYmlsaXR5 OiB2aXNpYmxlOyB9CiAgICAgIDUwJSB7IHZpc2liaWxpdHk6IHZpc2libGU7IH0KICAgICAgNTEl IHsgdmlzaWJpbGl0eTogaGlkZGVuOyB9CiAgICAgIDEwMCV7IHZpc2liaWxpdHk6IGhpZGRlbjsg fQogICAgfQoKICAgIEAtd2Via2l0LWtleWZyYW1lcyBpbmNvbWluZy12aXNpYmlsaXR5CiAgICB7 CiAgICAgIDAlICB7IHZpc2liaWxpdHk6IGhpZGRlbjsgfQogICAgICA1MCUgeyB2aXNpYmlsaXR5 OiBoaWRkZW47IH0KICAgICAgNTElIHsgdmlzaWJpbGl0eTogdmlzaWJsZTsgfQogICAgICAxMDAl eyB2aXNpYmlsaXR5OiB2aXNpYmxlOyB9CiAgICB9CiAgICAKICA8L3N0eWxlPgo8L2hlYWQ+Cjxi b2R5PgoKPGRpdiBjbGFzcz0iY29udGFpbmVyIj4KICA8ZGl2IGNsYXNzPSJpbmNvbWluZyBib3gi PjwvZGl2PgogIDwhLS0gPGRpdiBjbGFzcz0ib3V0Z29pbmcgYm94Ij48L2Rpdj4gLS0+CjwvZGl2 Pgo8L2JvZHk+CjwvaHRtbD4= 41190 2009-10-14 14:46:48 -0700 2009-10-19 15:12:11 -0700 Patch 26770_patch.txt text/plain 11244 simon.fraser ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBjNmUwOTQ3Li41ZDcwOTdjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMTAt MTQgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVHJhbnNpdGlvbnMgZmFpbCB0byBy dW4gc29tZXRpbWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yNjc3MAorICAgICAgICAKKyAgICAgICAgQWRkIGEgdGVzdCBmb3Igc3RhcnRpbmcgYW4g YWNjZWxlcmF0ZWQgYW5pbWF0aW9uIG9uIGFuIGVsZW1lbnQgd2l0aCBhIHZpc2liaWxpdHk6aGlk ZGVuIGFuY2VzdG9yLAorICAgICAgICB0byBlbnN1cmUgdGhhdCBpdCBkb2VzIG5vdCBibG9jayBz dWJzZXF1ZW50IHRyYW5zaXRpb25zLgorCisgICAgICAgICogY29tcG9zaXRpbmcvYW5pbWF0aW9u L2FuaW1hdGVkLWNvbXBvc2l0ZWQtaW5zaWRlLWhpZGRlbi1leHBlY3RlZC50eHQ6IEFkZGVkLgor ICAgICAgICAqIGNvbXBvc2l0aW5nL2FuaW1hdGlvbi9hbmltYXRlZC1jb21wb3NpdGVkLWluc2lk ZS1oaWRkZW4uaHRtbDogQWRkZWQuCisKIDIwMDktMTAtMTMgIFNpbW9uIEZyYXNlciAgPHNpbW9u LmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFuIEJlcm5zdGVpbi4K ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2NvbXBvc2l0aW5nL2FuaW1hdGlvbi9hbmltYXRlZC1j b21wb3NpdGVkLWluc2lkZS1oaWRkZW4tZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvY29tcG9z aXRpbmcvYW5pbWF0aW9uL2FuaW1hdGVkLWNvbXBvc2l0ZWQtaW5zaWRlLWhpZGRlbi1leHBlY3Rl ZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uODU3MjZmZAotLS0gL2Rl di9udWxsCisrKyBiL0xheW91dFRlc3RzL2NvbXBvc2l0aW5nL2FuaW1hdGlvbi9hbmltYXRlZC1j b21wb3NpdGVkLWluc2lkZS1oaWRkZW4tZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsNCBAQAorVGVz dHMgdGhhdCBzdGFydGluZyBhbiBhbmltYXRpb24gb24gYW4gZWxlbWVudCBpbnNpZGUgYSB2aXNp YmlsaXR5OmhpZGRlbiBlbGVtZW50IGRvZXMgbm90IGJsb2NrIGxhdGVyIHRyYW5zaXRpb25zLgor CitQQVNTIC0gImxlZnQiIHByb3BlcnR5IGZvciAidHJhbnNpdGlvbi10ZXN0ZXIiIGVsZW1lbnQg YXQgMC41cyBzYXcgc29tZXRoaW5nIGNsb3NlIHRvOiAxMAorCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9jb21wb3NpdGluZy9hbmltYXRpb24vYW5pbWF0ZWQtY29tcG9zaXRlZC1pbnNpZGUtaGlk ZGVuLmh0bWwgYi9MYXlvdXRUZXN0cy9jb21wb3NpdGluZy9hbmltYXRpb24vYW5pbWF0ZWQtY29t cG9zaXRlZC1pbnNpZGUtaGlkZGVuLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAw MDAwMC4uYTY3ZTU0MwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2NvbXBvc2l0aW5n L2FuaW1hdGlvbi9hbmltYXRlZC1jb21wb3NpdGVkLWluc2lkZS1oaWRkZW4uaHRtbApAQCAtMCww ICsxLDcxIEBACis8IURPQ1RZUEUgaHRtbCBQVUJMSUMgIi0vL1czQy8vRFREIEhUTUwgNC4wMSBU cmFuc2l0aW9uYWwvL0VOIgorICAgImh0dHA6Ly93d3cudzMub3JnL1RSL2h0bWw0L2xvb3NlLmR0 ZCI+CisKKzxodG1sIGxhbmc9ImVuIj4KKzxoZWFkPgorICA8dGl0bGU+VmlzaWJpbGl0eSBuZXN0 ZWQ8L3RpdGxlPgorICA8c3R5bGUgdHlwZT0idGV4dC9jc3MiIG1lZGlhPSJzY3JlZW4iPgorICAg IC5ib3ggeworICAgICAgcG9zaXRpb246IHJlbGF0aXZlOworICAgICAgd2lkdGg6IDEwMHB4Owor ICAgICAgaGVpZ2h0OiAxMDBweDsKKyAgICAgIGJvcmRlcjogMXB4IHNvbGlkIGJsYWNrOworICAg IH0KKyAgICAKKyAgICAubWlkZGxlIHsKKyAgICAgIHZpc2liaWxpdHk6IGhpZGRlbjsKKyAgICB9 CisKKyAgICAuaW5uZXIgeworICAgICAgd2lkdGg6IDgwcHg7CisgICAgICBoZWlnaHQ6IDgwcHg7 CisgICAgICAtd2Via2l0LWFuaW1hdGlvbjogc3BpbiA1cyBsaW5lYXIgaW5maW5pdGU7CisgICAg fQorCisgICAgQC13ZWJraXQta2V5ZnJhbWVzIHNwaW4geworICAgICAgMCUgeyAtd2Via2l0LXRy YW5zZm9ybTogcm90YXRlKDApOyB9CisgICAgICAxMDAlIHsgLXdlYmtpdC10cmFuc2Zvcm06IHJv dGF0ZSgzNjBkZWcpOyB9CisgICAgfQorICAgIAorICAgICN0cmFuc2l0aW9uLXRlc3RlciB7Cisg ICAgICBwb3NpdGlvbjogcmVsYXRpdmU7CisgICAgICBsZWZ0OiAwOworICAgICAgYmFja2dyb3Vu ZC1jb2xvcjogYmx1ZTsKKyAgICAgIC13ZWJraXQtdHJhbnNpdGlvbjogbGVmdCAxcyBsaW5lYXI7 CisgICAgfQorICAgIAorICAgICNjb250YWluZXIuYW5pbWF0aW5nICN0cmFuc2l0aW9uLXRlc3Rl ciB7CisgICAgICBsZWZ0OiAyMHB4OworICAgIH0KKyAgICAKKyAgPC9zdHlsZT4KKyAgPHNjcmlw dCBzcmM9Ii4uLy4uL3RyYW5zaXRpb25zL3RyYW5zaXRpb24tdGVzdC1oZWxwZXJzLmpzIiB0eXBl PSJ0ZXh0L2phdmFzY3JpcHQiIGNoYXJzZXQ9InV0Zi04Ij48L3NjcmlwdD4KKyAgPHNjcmlwdCB0 eXBlPSJ0ZXh0L2phdmFzY3JpcHQiIGNoYXJzZXQ9InV0Zi04Ij4KKyAgICBjb25zdCBleHBlY3Rl ZFZhbHVlcyA9IFsKKyAgICAgIC8vIFt0aW1lLCBlbGVtZW50LWlkLCBwcm9wZXJ0eSwgZXhwZWN0 ZWQtdmFsdWUsIHRvbGVyYW5jZV0KKyAgICAgIFswLjUsICd0cmFuc2l0aW9uLXRlc3RlcicsICds ZWZ0JywgMTAsIDJdLAorICAgIF07CisKKyAgICBmdW5jdGlvbiBzZXR1cFRlc3QoKQorICAgIHsK KyAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdjb250YWluZXInKS5jbGFzc05hbWUgPSAn YW5pbWF0aW5nJzsKKyAgICB9CisKKyAgICBydW5UcmFuc2l0aW9uVGVzdChleHBlY3RlZFZhbHVl cywgc2V0dXBUZXN0LCB0cnVlIC8qIHVzZSBwYXVzZSBBUEkgKi8pOworICA8L3NjcmlwdD4KKzwv aGVhZD4KKzxib2R5PgorCis8cD5UZXN0cyB0aGF0IHN0YXJ0aW5nIGFuIGFuaW1hdGlvbiBvbiBh biBlbGVtZW50IGluc2lkZSBhIHZpc2liaWxpdHk6aGlkZGVuIGVsZW1lbnQgZG9lcyBub3QgYmxv Y2sgbGF0ZXIgdHJhbnNpdGlvbnMuPC9wPgorICA8ZGl2IGlkPSJjb250YWluZXIiIGNsYXNzPSJj b250YWluZXIiPgorICAgIDxkaXYgaWQ9InRyYW5zaXRpb24tdGVzdGVyIiBjbGFzcz0iYm94Ij48 L2Rpdj4KKworICAgIDxkaXYgY2xhc3M9Im1pZGRsZSBib3giPgorICAgICAgPGRpdiBjbGFzcz0i aW5uZXIgYm94Ij48L2Rpdj4KKyAgICA8L2Rpdj4KKyAgPC9kaXY+CisKKzxkaXYgaWQ9InJlc3Vs dCI+PC9kaXY+CisKKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdl TG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmFmOGUwYS4uMTJiODYzYyAxMDA2NDQKLS0t IGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwz NiBAQAorMjAwOS0xMC0xNCAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUcmFuc2l0 aW9ucyBmYWlsIHRvIHJ1biBzb21ldGltZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTI2NzcwCisKKyAgICAgICAgRml4IGFuIGlzc3VlIHdoZXJlIHdl IGNvdWxkIGF0dGVtcHQgdG8gc3RhcnQgYWNjZWxlcmF0ZWQgYW5pbWF0aW9ucyBvciB0cmFuc2l0 aW9ucyBvbgorICAgICAgICBHcmFwaGljc0xheWVyIHRoYXQgd2VyZSBub3Qgcm9vdGVkIChiZWNh dXNlIG9mIHZpc2liaWxpdHk6aGlkZGVuKSwgd2hpY2ggd291bGQgbGVhdmUKKyAgICAgICAgdGhl IEFuaW1hdGlvbkNvbnRyb2xsZXIncyBtX3dhaXRpbmdGb3JSZXNwb25zZSBmbGFnIGluIGEgc3Rh dGUgdGhhdCBraWxsZWQgc3Vic2VxdWVudAorICAgICAgICBzb2Z0d2FyZSB0cmFuc2l0aW9ucy4K KworICAgICAgICAqIHBhZ2UvYW5pbWF0aW9uL0FuaW1hdGlvbkNvbnRyb2xsZXIuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6QW5pbWF0aW9uQ29udHJvbGxlclByaXZhdGU6OkFuaW1hdGlvbkNvbnRy b2xsZXJQcml2YXRlKToKKyAgICAgICAgKFdlYkNvcmU6OkFuaW1hdGlvbkNvbnRyb2xsZXJQcml2 YXRlOjplbmRBbmltYXRpb25VcGRhdGUpOgorICAgICAgICAoV2ViQ29yZTo6QW5pbWF0aW9uQ29u dHJvbGxlclByaXZhdGU6OnJlY2VpdmVkU3RhcnRUaW1lUmVzcG9uc2UpOgorICAgICAgICAoV2Vi Q29yZTo6QW5pbWF0aW9uQ29udHJvbGxlclByaXZhdGU6OmFkZFRvU3RhcnRUaW1lUmVzcG9uc2VX YWl0TGlzdCk6CisgICAgICAgIChXZWJDb3JlOjpBbmltYXRpb25Db250cm9sbGVyUHJpdmF0ZTo6 c3RhcnRUaW1lUmVzcG9uc2UpOgorICAgICAgICAqIHBhZ2UvYW5pbWF0aW9uL0FuaW1hdGlvbkNv bnRyb2xsZXJQcml2YXRlLmg6CisgICAgICAgIE1ha2Ugc29tZSBtZXRob2RzIG5vbi1pbmxpbmUg Zm9yIGVhc2Ugb2YgZGVidWdnaW5nICh0aGVzZSBhcmUgbm90IGhvdCBtZXRob2RzKS4KKyAgICAg ICAgUmVuYW1lIG1fd2FpdGluZ0ZvckFSZXNwb25zZSB0byBtX3dhaXRpbmdGb3JSZXNwb25zZS4K KyAgICAgICAgCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NMYXllci5oOgor ICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzTGF5ZXIuY3BwOgorICAgICAgICAo V2ViQ29yZTo6R3JhcGhpY3NMYXllcjo6aGFzQW5jZXN0b3IpOgorICAgICAgICBOZXcgbWV0aG9k IHRvIHJlcG9ydCB3aGV0aGVyIHRoZSByZWNlaXZlciBoYXMgdGhlIGdpdmVuIGxheWVyIGFzIGFu IGFuY2VzdG9yLiBVc2VkIGZvciBjaGVja2luZworICAgICAgICB3aGV0aGVyIGEgbGF5ZXIgaXMg cm9vdGVkLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllckJhY2tpbmc6OnN0YXJ0QW5pbWF0aW9uKToKKyAg ICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyQmFja2luZzo6c3RhcnRUcmFuc2l0aW9uKToKKyAg ICAgICAgRG9uJ3QgdHJ5IHRvIHN0YXJ0IGFjY2VsZXJhdGVkIGFuaW1hdGlvbnMgb3IgdHJhbnNp dGlvbnMgb24gbm9uLXJvb3RlZCBHcmFwaGljc0xheWVycy4KKwogMjAwOS0xMC0xMyAgRHJldyBX aWxzb24gIDxhdHdpbHNvbkBhdHdpbHNvbi1tYWNwcm8ubG9jYWw+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgRGF2aWQgTGV2aW4uCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BhZ2UvYW5pbWF0aW9uL0Fu aW1hdGlvbkNvbnRyb2xsZXIuY3BwIGIvV2ViQ29yZS9wYWdlL2FuaW1hdGlvbi9BbmltYXRpb25D b250cm9sbGVyLmNwcAppbmRleCA2OTE5MzJlLi5hYTVkZTJjIDEwMDY0NAotLS0gYS9XZWJDb3Jl L3BhZ2UvYW5pbWF0aW9uL0FuaW1hdGlvbkNvbnRyb2xsZXIuY3BwCisrKyBiL1dlYkNvcmUvcGFn ZS9hbmltYXRpb24vQW5pbWF0aW9uQ29udHJvbGxlci5jcHAKQEAgLTU1LDcgKzU1LDcgQEAgQW5p bWF0aW9uQ29udHJvbGxlclByaXZhdGU6OkFuaW1hdGlvbkNvbnRyb2xsZXJQcml2YXRlKEZyYW1l KiBmcmFtZSkKICAgICAsIG1fbGFzdFN0eWxlQXZhaWxhYmxlV2FpdGVyKDApCiAgICAgLCBtX3Jl c3BvbnNlV2FpdGVycygwKQogICAgICwgbV9sYXN0UmVzcG9uc2VXYWl0ZXIoMCkKLSAgICAsIG1f d2FpdGluZ0ZvckFSZXNwb25zZShmYWxzZSkKKyAgICAsIG1fd2FpdGluZ0ZvclJlc3BvbnNlKGZh bHNlKQogewogfQogCkBAIC0yNzksNiArMjc5LDE5IEBAIGRvdWJsZSBBbmltYXRpb25Db250cm9s bGVyUHJpdmF0ZTo6YmVnaW5BbmltYXRpb25VcGRhdGVUaW1lKCkKICAgICByZXR1cm4gbV9iZWdp bkFuaW1hdGlvblVwZGF0ZVRpbWU7CiB9CiAKK3ZvaWQgQW5pbWF0aW9uQ29udHJvbGxlclByaXZh dGU6OmVuZEFuaW1hdGlvblVwZGF0ZSgpCit7CisgICAgc3R5bGVBdmFpbGFibGUoKTsKKyAgICBp ZiAoIW1fd2FpdGluZ0ZvclJlc3BvbnNlKQorICAgICAgICBzdGFydFRpbWVSZXNwb25zZShiZWdp bkFuaW1hdGlvblVwZGF0ZVRpbWUoKSk7Cit9CisKK3ZvaWQgQW5pbWF0aW9uQ29udHJvbGxlclBy aXZhdGU6OnJlY2VpdmVkU3RhcnRUaW1lUmVzcG9uc2UoZG91YmxlIHRpbWUpCit7CisgICAgbV93 YWl0aW5nRm9yUmVzcG9uc2UgPSBmYWxzZTsKKyAgICBzdGFydFRpbWVSZXNwb25zZSh0aW1lKTsK K30KKwogUGFzc1JlZlB0cjxSZW5kZXJTdHlsZT4gQW5pbWF0aW9uQ29udHJvbGxlclByaXZhdGU6 OmdldEFuaW1hdGVkU3R5bGVGb3JSZW5kZXJlcihSZW5kZXJPYmplY3QqIHJlbmRlcmVyKQogewog ICAgIGlmICghcmVuZGVyZXIpCkBAIC0zNzgsNyArMzkxLDcgQEAgdm9pZCBBbmltYXRpb25Db250 cm9sbGVyUHJpdmF0ZTo6YWRkVG9TdGFydFRpbWVSZXNwb25zZVdhaXRMaXN0KEFuaW1hdGlvbkJh c2UqIGEKICAgICBBU1NFUlQoIWFuaW1hdGlvbi0+bmV4dCgpKTsKICAgICAKICAgICBpZiAod2ls bEdldFJlc3BvbnNlKQotICAgICAgICBtX3dhaXRpbmdGb3JBUmVzcG9uc2UgPSB0cnVlOworICAg ICAgICBtX3dhaXRpbmdGb3JSZXNwb25zZSA9IHRydWU7CiAgICAgCiAgICAgaWYgKG1fcmVzcG9u c2VXYWl0ZXJzKQogICAgICAgICBtX2xhc3RSZXNwb25zZVdhaXRlci0+c2V0TmV4dChhbmltYXRp b24pOwpAQCAtNDA4LDEzICs0MjEsMTMgQEAgdm9pZCBBbmltYXRpb25Db250cm9sbGVyUHJpdmF0 ZTo6cmVtb3ZlRnJvbVN0YXJ0VGltZVJlc3BvbnNlV2FpdExpc3QoQW5pbWF0aW9uQmEKICAgICB9 CiB9CiAKLXZvaWQgQW5pbWF0aW9uQ29udHJvbGxlclByaXZhdGU6OnN0YXJ0VGltZVJlc3BvbnNl KGRvdWJsZSB0KQordm9pZCBBbmltYXRpb25Db250cm9sbGVyUHJpdmF0ZTo6c3RhcnRUaW1lUmVz cG9uc2UoZG91YmxlIHRpbWUpCiB7CiAgICAgLy8gR28gdGhyb3VnaCBsaXN0IG9mIHdhaXRlcnMg YW5kIHNlbmQgdGhlbSBvbiB0aGVpciB3YXkKICAgICBmb3IgKEFuaW1hdGlvbkJhc2UqIGFuaW1h dGlvbiA9IG1fcmVzcG9uc2VXYWl0ZXJzOyBhbmltYXRpb247ICkgewogICAgICAgICBBbmltYXRp b25CYXNlKiBuZXh0QW5pbWF0aW9uID0gYW5pbWF0aW9uLT5uZXh0KCk7CiAgICAgICAgIGFuaW1h dGlvbi0+c2V0TmV4dCgwKTsKLSAgICAgICAgYW5pbWF0aW9uLT5vbkFuaW1hdGlvblN0YXJ0UmVz cG9uc2UodCk7CisgICAgICAgIGFuaW1hdGlvbi0+b25BbmltYXRpb25TdGFydFJlc3BvbnNlKHRp bWUpOwogICAgICAgICBhbmltYXRpb24gPSBuZXh0QW5pbWF0aW9uOwogICAgIH0KICAgICAKZGlm ZiAtLWdpdCBhL1dlYkNvcmUvcGFnZS9hbmltYXRpb24vQW5pbWF0aW9uQ29udHJvbGxlclByaXZh dGUuaCBiL1dlYkNvcmUvcGFnZS9hbmltYXRpb24vQW5pbWF0aW9uQ29udHJvbGxlclByaXZhdGUu aAppbmRleCAzNTliOWI1Li43ZGIzODAzIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BhZ2UvYW5pbWF0 aW9uL0FuaW1hdGlvbkNvbnRyb2xsZXJQcml2YXRlLmgKKysrIGIvV2ViQ29yZS9wYWdlL2FuaW1h dGlvbi9BbmltYXRpb25Db250cm9sbGVyUHJpdmF0ZS5oCkBAIC04MCwxOCArODAsOCBAQCBwdWJs aWM6CiAKICAgICBkb3VibGUgYmVnaW5BbmltYXRpb25VcGRhdGVUaW1lKCk7CiAgICAgdm9pZCBz ZXRCZWdpbkFuaW1hdGlvblVwZGF0ZVRpbWUoZG91YmxlIHQpIHsgbV9iZWdpbkFuaW1hdGlvblVw ZGF0ZVRpbWUgPSB0OyB9Ci0gICAgdm9pZCBlbmRBbmltYXRpb25VcGRhdGUoKQotICAgIHsKLSAg ICAgICAgc3R5bGVBdmFpbGFibGUoKTsKLSAgICAgICAgaWYgKCFtX3dhaXRpbmdGb3JBUmVzcG9u c2UpCi0gICAgICAgICAgICBzdGFydFRpbWVSZXNwb25zZShiZWdpbkFuaW1hdGlvblVwZGF0ZVRp bWUoKSk7Ci0gICAgfQotICAgIAotICAgIHZvaWQgcmVjZWl2ZWRTdGFydFRpbWVSZXNwb25zZShk b3VibGUgdCkKLSAgICB7Ci0gICAgICAgIG1fd2FpdGluZ0ZvckFSZXNwb25zZSA9IGZhbHNlOwot ICAgICAgICBzdGFydFRpbWVSZXNwb25zZSh0KTsKLSAgICB9CisgICAgdm9pZCBlbmRBbmltYXRp b25VcGRhdGUoKTsKKyAgICB2b2lkIHJlY2VpdmVkU3RhcnRUaW1lUmVzcG9uc2UoZG91YmxlKTsK ICAgICAKICAgICB2b2lkIGFkZFRvU3R5bGVBdmFpbGFibGVXYWl0TGlzdChBbmltYXRpb25CYXNl Kik7CiAgICAgdm9pZCByZW1vdmVGcm9tU3R5bGVBdmFpbGFibGVXYWl0TGlzdChBbmltYXRpb25C YXNlKik7ICAgIApAQCAtMTI3LDcgKzExNyw3IEBAIHByaXZhdGU6CiAgICAgCiAgICAgQW5pbWF0 aW9uQmFzZSogbV9yZXNwb25zZVdhaXRlcnM7CiAgICAgQW5pbWF0aW9uQmFzZSogbV9sYXN0UmVz cG9uc2VXYWl0ZXI7Ci0gICAgYm9vbCBtX3dhaXRpbmdGb3JBUmVzcG9uc2U7CisgICAgYm9vbCBt X3dhaXRpbmdGb3JSZXNwb25zZTsKIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAt LWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NMYXllci5jcHAgYi9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzTGF5ZXIuY3BwCmluZGV4IGIzNzViZDMuLmQx OTZhMGMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NMYXll ci5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0xheWVyLmNwcApA QCAtODYsNiArODYsMTYgQEAgR3JhcGhpY3NMYXllcjo6fkdyYXBoaWNzTGF5ZXIoKQogICAgIHJl bW92ZUZyb21QYXJlbnQoKTsKIH0KIAorYm9vbCBHcmFwaGljc0xheWVyOjpoYXNBbmNlc3RvcihH cmFwaGljc0xheWVyKiBhbmNlc3RvcikgY29uc3QKK3sKKyAgICBmb3IgKEdyYXBoaWNzTGF5ZXIq IGN1cnIgPSBwYXJlbnQoKTsgY3VycjsgY3VyciA9IGN1cnItPnBhcmVudCgpKSB7CisgICAgICAg IGlmIChjdXJyID09IGFuY2VzdG9yKQorICAgICAgICAgICAgcmV0dXJuIHRydWU7CisgICAgfQor ICAgIAorICAgIHJldHVybiBmYWxzZTsKK30KKwogdm9pZCBHcmFwaGljc0xheWVyOjphZGRDaGls ZChHcmFwaGljc0xheWVyKiBjaGlsZExheWVyKQogewogICAgIEFTU0VSVChjaGlsZExheWVyICE9 IHRoaXMpOwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0xh eWVyLmggYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzTGF5ZXIuaAppbmRleCAy OTI0MDczLi5lNWIxN2E2IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dy YXBoaWNzTGF5ZXIuaAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzTGF5 ZXIuaApAQCAtMTcyLDYgKzE3Miw5IEBAIHB1YmxpYzoKICAgICBHcmFwaGljc0xheWVyKiBwYXJl bnQoKSBjb25zdCB7IHJldHVybiBtX3BhcmVudDsgfTsKICAgICB2b2lkIHNldFBhcmVudChHcmFw aGljc0xheWVyKiBsYXllcikgeyBtX3BhcmVudCA9IGxheWVyOyB9IC8vIEludGVybmFsIHVzZSBv bmx5LgogICAgIAorICAgIC8vIFJldHVybnMgdHJ1ZSBpZiB0aGUgbGF5ZXIgaGFzIHRoZSBnaXZl biBsYXllciBhcyBhbiBhbmNlc3RvciAoZXhjbHVkaW5nIHNlbGYpLgorICAgIGJvb2wgaGFzQW5j ZXN0b3IoR3JhcGhpY3NMYXllciopIGNvbnN0OworICAgIAogICAgIGNvbnN0IFZlY3RvcjxHcmFw aGljc0xheWVyKj4mIGNoaWxkcmVuKCkgY29uc3QgeyByZXR1cm4gbV9jaGlsZHJlbjsgfQogCiAg ICAgLy8gQWRkIGNoaWxkIGxheWVycy4gSWYgdGhlIGNoaWxkIGlzIGFscmVhZHkgcGFyZW50ZWQs IGl0IHdpbGwgYmUgcmVtb3ZlZCBmcm9tIGl0cyBvbGQgcGFyZW50LgpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5nLmNwcCBiL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckxheWVyQmFja2luZy5jcHAKaW5kZXggNTBlNDc1Ni4uYmY1OGEyZSAxMDA2NDQKLS0t IGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5nLmNwcAorKysgYi9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwCkBAIC0xMDM0LDYgKzEwMzQsMTAgQEAg Ym9vbCBSZW5kZXJMYXllckJhY2tpbmc6OnN0YXJ0QW5pbWF0aW9uKGRvdWJsZSBiZWdpblRpbWUs IGNvbnN0IEFuaW1hdGlvbiogYW5pbSwKICAgICBpZiAoIWhhc09wYWNpdHkgJiYgIWhhc1RyYW5z Zm9ybSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIAorICAgIC8vIERvbid0IHN0YXJ0IGFu aW1hdGlvbnMgaWYgd2UncmUgbm90IHJvb3RlZCwgYmVjYXVzZSB3ZSB3b24ndCBnZXQgdGhlIGNh bGxiYWNrIHRoYXQgdGhlIGFuaW1hdGlvbiBzdGFydGVkLgorICAgIGlmICghbV9ncmFwaGljc0xh eWVyLT5oYXNBbmNlc3Rvcihjb21wb3NpdG9yKCktPnJvb3RQbGF0Zm9ybUxheWVyKCkpKQorICAg ICAgICByZXR1cm4gZmFsc2U7CisKICAgICBLZXlmcmFtZVZhbHVlTGlzdCB0cmFuc2Zvcm1WZWN0 b3IoQW5pbWF0ZWRQcm9wZXJ0eVdlYmtpdFRyYW5zZm9ybSk7CiAgICAgS2V5ZnJhbWVWYWx1ZUxp c3Qgb3BhY2l0eVZlY3RvcihBbmltYXRlZFByb3BlcnR5T3BhY2l0eSk7CiAKQEAgLTEwNzUsNiAr MTA3OSwxMCBAQCBib29sIFJlbmRlckxheWVyQmFja2luZzo6c3RhcnRUcmFuc2l0aW9uKGRvdWJs ZSBiZWdpblRpbWUsIGludCBwcm9wZXJ0eSwgY29uc3QgUgogICAgIGJvb2wgZGlkQW5pbWF0ZSA9 IGZhbHNlOwogICAgIEFTU0VSVChwcm9wZXJ0eSAhPSBjQW5pbWF0ZUFsbCk7CiAKKyAgICAvLyBE b24ndCBzdGFydCBhbmltYXRpb25zIGlmIHdlJ3JlIG5vdCByb290ZWQsIGJlY2F1c2Ugd2Ugd29u J3QgZ2V0IHRoZSBjYWxsYmFjayB0aGF0IHRoZSBhbmltYXRpb24gc3RhcnRlZC4KKyAgICBpZiAo IW1fZ3JhcGhpY3NMYXllci0+aGFzQW5jZXN0b3IoY29tcG9zaXRvcigpLT5yb290UGxhdGZvcm1M YXllcigpKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCiAgICAgaWYgKHByb3BlcnR5ID09IChp bnQpQ1NTUHJvcGVydHlPcGFjaXR5KSB7CiAgICAgICAgIGNvbnN0IEFuaW1hdGlvbiogb3BhY2l0 eUFuaW0gPSB0b1N0eWxlLT50cmFuc2l0aW9uRm9yUHJvcGVydHkoQ1NTUHJvcGVydHlPcGFjaXR5 KTsKICAgICAgICAgaWYgKG9wYWNpdHlBbmltICYmICFvcGFjaXR5QW5pbS0+aXNFbXB0eU9yWmVy b0R1cmF0aW9uKCkpIHsK