26721 2009-06-25 07:22:00 -0700 Pointer to incomplete class type is not allowed compilation error with RVCT 2009-07-07 20:57:16 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Other RESOLVED FIXED P2 Normal --- 27065 0 laszlo.gombos webkit-unassigned hausmann norbert.leser oldest_to_newest 128182 0 laszlo.gombos 2009-06-25 07:22:00 -0700 Building accessibility\accessibilityimagemaplink.cpp fails with the following error (using the ARM RVCT compiler): "WebKit\JavaScriptCore/wtf/PassRefPtr.h", line 43: Error: #393: pointer to incomplete class type is not allowed ALWAYS_INLINE ~PassRefPtr() { if (UNLIKELY(m_ptr != 0)) m_ptr->deref(); } ^ detected during instantiation of "WTF::PassRefPtr<T>::~PassRefPtr() [with T=WebCore::Event]" 128184 1 31856 laszlo.gombos 2009-06-25 08:18:26 -0700 Created attachment 31856 Include Event.h in Node.h instead of forward declaring the Event class This bug is similar in nature to https://bugs.webkit.org/show_bug.cgi?id=24539. In this particular case "PassRefPtr<Event> underlyingEvent = 0" needs to know about the Event class definition . 128199 2 laszlo.gombos 2009-06-25 09:39:47 -0700 I just run into some related discussion on WebKit-dev from 2008. Paul sheds some lights on the differences between GCC/MSVC and ARM RVCT. http://lists.macosforge.org/pipermail/webkit-dev/2008-September/004799.html 128232 3 31856 darin 2009-06-25 12:03:08 -0700 Comment on attachment 31856 Include Event.h in Node.h instead of forward declaring the Event class We really don't want to include Event.h in every single file that includes Node.h. Lets remove the default value for underlyingEvent, and fix the callers to pass zero explicitly instead. 128373 4 31901 laszlo.gombos 2009-06-25 20:18:15 -0700 Created attachment 31901 Remove the default value for PassRefPtr<Event> args Thanks Darin for the quick review. Removed some defaults from Node.h to eliminate the dependency on the Event class definition. RVCT no longer fails on this after these changes. 128440 5 eric 2009-06-26 01:40:07 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/dom/Document.cpp M WebCore/dom/Node.cpp M WebCore/dom/Node.h Committed r45251 http://trac.webkit.org/changeset/45251 31856 2009-06-25 08:18:26 -0700 2009-06-25 20:18:15 -0700 Include Event.h in Node.h instead of forward declaring the Event class patch_26721.txt text/plain 1105 laszlo.gombos SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NTE0MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDktMDYtMjQgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21i b3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICJQb2ludGVyIHRvIGluY29tcGxldGUgY2xhc3MgdHlwZSBpcyBub3QgYWxsb3dlZCIg ZXJyb3Igd2l0aCBSVkNUCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yNjcyMQorCisgICAgICAgIEJhc2VkIG9uIE5vcmJlcnQgTGVzZXIncyB3b3JrLgor CisgICAgICAgICogZG9tL05vZGUuaDogSW5jbHVkZSAiRXZlbnQuaCIgaW5zdGVhZCBvZiBmb3J3 YXJkIGRlY2xhcmF0aW9uCisKIDIwMDktMDYtMjIgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0 Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEaW1pdHJpIEdsYXprb3YuCkluZGV4OiBXZWJD b3JlL2RvbS9Ob2RlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9kb20vTm9kZS5oCShyZXZpc2lv biA0NTEzOCkKKysrIFdlYkNvcmUvZG9tL05vZGUuaAkod29ya2luZyBjb3B5KQpAQCAtMjYsNiAr MjYsNyBAQAogI2RlZmluZSBOb2RlX2gKIAogI2luY2x1ZGUgIkRvY1B0ci5oIgorI2luY2x1ZGUg IkV2ZW50LmgiCiAjaW5jbHVkZSAiRXZlbnRUYXJnZXQuaCIKICNpbmNsdWRlICJLVVJMSGFzaC5o IgogI2luY2x1ZGUgIlBsYXRmb3JtU3RyaW5nLmgiCkBAIC00NSw3ICs0Niw2IEBAIGNsYXNzIENv bnRhaW5lck5vZGU7CiBjbGFzcyBEb2N1bWVudDsKIGNsYXNzIER5bmFtaWNOb2RlTGlzdDsKIGNs YXNzIEVsZW1lbnQ7Ci1jbGFzcyBFdmVudDsKIGNsYXNzIEV2ZW50TGlzdGVuZXI7CiBjbGFzcyBG cmFtZTsKIGNsYXNzIEludFJlY3Q7Cg== 31901 2009-06-25 20:18:15 -0700 2009-06-25 22:04:11 -0700 Remove the default value for PassRefPtr<Event> args patch_26721_2.txt text/plain 4222 laszlo.gombos SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0NTIzMykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMDktMDYtMjUgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21i b3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICJQb2ludGVyIHRvIGluY29tcGxldGUgY2xhc3MgdHlwZSBpcyBub3QgYWxsb3dlZCIg ZXJyb3Igd2l0aCBSVkNUCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yNjcyMQorCisgICAgICAgIEJhc2VkIG9uIE5vcmJlcnQgTGVzZXIncyB3b3JrLgor CisgICAgICAgICogZG9tL0RvY3VtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50 OjpzZXRGb2N1c2VkTm9kZSk6CisgICAgICAgICogZG9tL05vZGUuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6Tm9kZTo6ZGlzcGF0Y2hNb3VzZUV2ZW50KToKKyAgICAgICAgKiBkb20vTm9kZS5oOiBS ZW1vdmUgdGhlIGRlZmF1bHQgdmFsdWUgZm9yIFBhc3NSZWZQdHI8RXZlbnQ+IGFyZ3MsCisgICAg ICAgIHRvIGVsaW1pbmF0ZSBkZXBlbmRlbmN5IG9uIHRoZSBFdmVudCBjbGFzcyBkZWZpbml0aW9u CisKIDIwMDktMDYtMjUgIFBpZXJyZSBkJ0hlcmJlbW9udCAgPHBkaGVyYmVtb250QGFwcGxlLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KSW5kZXg6IFdlYkNvcmUvZG9t L0RvY3VtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAJKHJl dmlzaW9uIDQ1MjMzKQorKysgV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0yNTQwLDcgKzI1NDAsNyBAQCBib29sIERvY3VtZW50OjpzZXRGb2N1c2VkTm9kZShQYXNz UmVmUHRyCiAgICAgICAgICAgICBmb2N1c0NoYW5nZUJsb2NrZWQgPSB0cnVlOwogICAgICAgICAg ICAgbmV3Rm9jdXNlZE5vZGUgPSAwOwogICAgICAgICB9Ci0gICAgICAgIG9sZEZvY3VzZWROb2Rl LT5kaXNwYXRjaFVJRXZlbnQoZXZlbnROYW1lcygpLkRPTUZvY3VzT3V0RXZlbnQpOworICAgICAg ICBvbGRGb2N1c2VkTm9kZS0+ZGlzcGF0Y2hVSUV2ZW50KGV2ZW50TmFtZXMoKS5ET01Gb2N1c091 dEV2ZW50LCAwLCAwKTsKICAgICAgICAgaWYgKG1fZm9jdXNlZE5vZGUpIHsKICAgICAgICAgICAg IC8vIGhhbmRsZXIgc2hpZnRlZCBmb2N1cwogICAgICAgICAgICAgZm9jdXNDaGFuZ2VCbG9ja2Vk ID0gdHJ1ZTsKQEAgLTI1NzAsNyArMjU3MCw3IEBAIGJvb2wgRG9jdW1lbnQ6OnNldEZvY3VzZWRO b2RlKFBhc3NSZWZQdHIKICAgICAgICAgICAgIGZvY3VzQ2hhbmdlQmxvY2tlZCA9IHRydWU7CiAg ICAgICAgICAgICBnb3RvIFNldEZvY3VzZWROb2RlRG9uZTsKICAgICAgICAgfQotICAgICAgICBt X2ZvY3VzZWROb2RlLT5kaXNwYXRjaFVJRXZlbnQoZXZlbnROYW1lcygpLkRPTUZvY3VzSW5FdmVu dCk7CisgICAgICAgIG1fZm9jdXNlZE5vZGUtPmRpc3BhdGNoVUlFdmVudChldmVudE5hbWVzKCku RE9NRm9jdXNJbkV2ZW50LCAwLCAwKTsKICAgICAgICAgaWYgKG1fZm9jdXNlZE5vZGUgIT0gbmV3 Rm9jdXNlZE5vZGUpIHsgCiAgICAgICAgICAgICAvLyBoYW5kbGVyIHNoaWZ0ZWQgZm9jdXMKICAg ICAgICAgICAgIGZvY3VzQ2hhbmdlQmxvY2tlZCA9IHRydWU7CkluZGV4OiBXZWJDb3JlL2RvbS9O b2RlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2RvbS9Ob2RlLmNwcAkocmV2aXNpb24gNDUy MzMpCisrKyBXZWJDb3JlL2RvbS9Ob2RlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjYzMyw3ICsy NjMzLDcgQEAgYm9vbCBOb2RlOjpkaXNwYXRjaE1vdXNlRXZlbnQoY29uc3QgUGxhdAogICAgIHJl dHVybiBkaXNwYXRjaE1vdXNlRXZlbnQoZXZlbnRUeXBlLCBidXR0b24sIGRldGFpbCwKICAgICAg ICAgY29udGVudHNQb3MueCgpLCBjb250ZW50c1Bvcy55KCksIGV2ZW50Lmdsb2JhbFgoKSwgZXZl bnQuZ2xvYmFsWSgpLAogICAgICAgICBldmVudC5jdHJsS2V5KCksIGV2ZW50LmFsdEtleSgpLCBl dmVudC5zaGlmdEtleSgpLCBldmVudC5tZXRhS2V5KCksCi0gICAgICAgIGZhbHNlLCByZWxhdGVk VGFyZ2V0KTsKKyAgICAgICAgZmFsc2UsIHJlbGF0ZWRUYXJnZXQsIDApOwogfQogCiB2b2lkIE5v ZGU6OmRpc3BhdGNoU2ltdWxhdGVkTW91c2VFdmVudChjb25zdCBBdG9taWNTdHJpbmcmIGV2ZW50 VHlwZSwKSW5kZXg6IFdlYkNvcmUvZG9tL05vZGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2Rv bS9Ob2RlLmgJKHJldmlzaW9uIDQ1MjMzKQorKysgV2ViQ29yZS9kb20vTm9kZS5oCSh3b3JraW5n IGNvcHkpCkBAIC01MzEsNyArNTMxLDcgQEAgcHVibGljOgogICAgIHZvaWQgcmVtb3ZlQWxsRXZl bnRMaXN0ZW5lcnMoKSB7IGlmIChoYXNSYXJlRGF0YSgpKSByZW1vdmVBbGxFdmVudExpc3RlbmVy c1Nsb3dDYXNlKCk7IH0KIAogICAgIHZvaWQgZGlzcGF0Y2hTdWJ0cmVlTW9kaWZpZWRFdmVudCgp OwotICAgIHZvaWQgZGlzcGF0Y2hVSUV2ZW50KGNvbnN0IEF0b21pY1N0cmluZyYgZXZlbnRUeXBl LCBpbnQgZGV0YWlsID0gMCwgUGFzc1JlZlB0cjxFdmVudD4gdW5kZXJseWluZ0V2ZW50ID0gMCk7 CisgICAgdm9pZCBkaXNwYXRjaFVJRXZlbnQoY29uc3QgQXRvbWljU3RyaW5nJiBldmVudFR5cGUs IGludCBkZXRhaWwsIFBhc3NSZWZQdHI8RXZlbnQ+IHVuZGVybHlpbmdFdmVudCk7CiAgICAgYm9v bCBkaXNwYXRjaEtleUV2ZW50KGNvbnN0IFBsYXRmb3JtS2V5Ym9hcmRFdmVudCYpOwogICAgIHZv aWQgZGlzcGF0Y2hXaGVlbEV2ZW50KFBsYXRmb3JtV2hlZWxFdmVudCYpOwogICAgIGJvb2wgZGlz cGF0Y2hNb3VzZUV2ZW50KGNvbnN0IFBsYXRmb3JtTW91c2VFdmVudCYsIGNvbnN0IEF0b21pY1N0 cmluZyYgZXZlbnRUeXBlLApAQCAtNTM5LDggKzUzOSw4IEBAIHB1YmxpYzoKICAgICBib29sIGRp c3BhdGNoTW91c2VFdmVudChjb25zdCBBdG9taWNTdHJpbmcmIGV2ZW50VHlwZSwgaW50IGJ1dHRv biwgaW50IGNsaWNrQ291bnQsCiAgICAgICAgIGludCBwYWdlWCwgaW50IHBhZ2VZLCBpbnQgc2Ny ZWVuWCwgaW50IHNjcmVlblksCiAgICAgICAgIGJvb2wgY3RybEtleSwgYm9vbCBhbHRLZXksIGJv b2wgc2hpZnRLZXksIGJvb2wgbWV0YUtleSwKLSAgICAgICAgYm9vbCBpc1NpbXVsYXRlZCA9IGZh bHNlLCBOb2RlKiByZWxhdGVkVGFyZ2V0ID0gMCwgUGFzc1JlZlB0cjxFdmVudD4gdW5kZXJseWlu Z0V2ZW50ID0gMCk7Ci0gICAgdm9pZCBkaXNwYXRjaFNpbXVsYXRlZE1vdXNlRXZlbnQoY29uc3Qg QXRvbWljU3RyaW5nJiBldmVudFR5cGUsIFBhc3NSZWZQdHI8RXZlbnQ+IHVuZGVybHlpbmdFdmVu dCA9IDApOworICAgICAgICBib29sIGlzU2ltdWxhdGVkLCBOb2RlKiByZWxhdGVkVGFyZ2V0LCBQ YXNzUmVmUHRyPEV2ZW50PiB1bmRlcmx5aW5nRXZlbnQpOworICAgIHZvaWQgZGlzcGF0Y2hTaW11 bGF0ZWRNb3VzZUV2ZW50KGNvbnN0IEF0b21pY1N0cmluZyYgZXZlbnRUeXBlLCBQYXNzUmVmUHRy PEV2ZW50PiB1bmRlcmx5aW5nRXZlbnQpOwogICAgIHZvaWQgZGlzcGF0Y2hTaW11bGF0ZWRDbGlj ayhQYXNzUmVmUHRyPEV2ZW50PiB1bmRlcmx5aW5nRXZlbnQsIGJvb2wgc2VuZE1vdXNlRXZlbnRz ID0gZmFsc2UsIGJvb2wgc2hvd1ByZXNzZWRMb29rID0gdHJ1ZSk7CiAgICAgdm9pZCBkaXNwYXRj aFByb2dyZXNzRXZlbnQoY29uc3QgQXRvbWljU3RyaW5nJiBldmVudFR5cGUsIGJvb2wgbGVuZ3Ro Q29tcHV0YWJsZUFyZywgdW5zaWduZWQgbG9hZGVkQXJnLCB1bnNpZ25lZCB0b3RhbEFyZyk7CiAg ICAgdm9pZCBkaXNwYXRjaFdlYktpdEFuaW1hdGlvbkV2ZW50KGNvbnN0IEF0b21pY1N0cmluZyYg ZXZlbnRUeXBlLCBjb25zdCBTdHJpbmcmIGFuaW1hdGlvbk5hbWUsIGRvdWJsZSBlbGFwc2VkVGlt ZSk7Cg==