<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>266396</bug_id>
          
          <creation_ts>2023-12-14 02:30:31 -0800</creation_ts>
          <short_desc>[CMake] Allow enabling C++ library assertions if supported</short_desc>
          <delta_ts>2025-03-18 05:55:56 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>CMake</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=245692</see_also>
    
    <see_also>https://bugs.webkit.org/show_bug.cgi?id=271737</see_also>
    
    <see_also>https://bugs.webkit.org/show_bug.cgi?id=289007</see_also>
    
    <see_also>https://bugs.webkit.org/show_bug.cgi?id=289953</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>287149</dependson>
    
    <dependson>287431</dependson>
    
    <dependson>287477</dependson>
    
    <dependson>287553</dependson>
    
    <dependson>287558</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Adrian Perez">aperez</reporter>
          <assigned_to name="Adrian Perez">aperez</assigned_to>
          <cc>bugs-noreply</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1999512</commentid>
    <comment_count>0</comment_count>
    <who name="Adrian Perez">aperez</who>
    <bug_when>2023-12-14 02:30:31 -0800</bug_when>
    <thetext>In bug #245692 the built-in lightweight assertions supported by libc++
have been enabled for the Apple ports. We may want to do the same for
the ports that use CMake.

While at it, consider supporting also GNU libstdc++, which according
to https://gcc.gnu.org/onlinedocs/libstdc++/manual/using_macros.html
has a similar feature toggled by the _GLIBCXX_ASSERTIONS macro.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1999513</commentid>
    <comment_count>1</comment_count>
    <who name="Adrian Perez">aperez</who>
    <bug_when>2023-12-14 02:31:53 -0800</bug_when>
    <thetext>I&apos;ve had a half cooked patch for this sitting on a local branch for
months, so it&apos;s probably better to iron it out a bit and get it in
shape for submission =)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1999518</commentid>
    <comment_count>2</comment_count>
    <who name="Adrian Perez">aperez</who>
    <bug_when>2023-12-14 02:42:19 -0800</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/21785</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2094726</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2025-02-14 00:57:39 -0800</bug_when>
    <thetext>Committed 290394@main (3b5d8ebc05c0): &lt;https://commits.webkit.org/290394@main&gt;

Reviewed commits have been landed. Closing PR #21785 and removing active labels.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>