26558 2009-06-19 12:47:32 -0700 [fixup-needed] WINCE needs important date related symbols 2009-08-02 01:05:37 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 23154 1 manyoso webkit-unassigned abarth staikos oldest_to_newest 127000 0 manyoso 2009-06-19 12:47:32 -0700 Hi, The date functions in DateConstructor and DatePrototype rely upon the symbols 'time' and 'strftime' which are not available under WINCE proper. Rather they are provided by libce. 127001 1 31560 manyoso 2009-06-19 12:48:37 -0700 Created attachment 31560 Rectify 127003 2 31560 staikos 2009-06-19 12:50:27 -0700 Comment on attachment 31560 Rectify We should enhance our strftime to support # later and remove the formatting hack. 127010 3 manyoso 2009-06-19 13:10:40 -0700 Landed with r44866. 127052 4 31560 darin 2009-06-19 15:57:47 -0700 Comment on attachment 31560 Rectify Normally we put these kinds of workarounds into header files. For example, this is what MathExtras.h is for. Also, is there really no WinCE system header file to include to get these? 127410 5 yong.li.webkit 2009-06-22 11:39:29 -0700 (In reply to comment #4) > (From update of attachment 31560 [review]) > Normally we put these kinds of workarounds into header files. For example, this > is what MathExtras.h is for. > > Also, is there really no WinCE system header file to include to get these? > Really no. C runtime on WINCE doesn't contain these functions. This is why we need to provide a WINCE implementation for them. 135933 6 staikos 2009-07-30 12:29:27 -0700 A patch was missed apparently. 135943 7 33806 joenotcharles 2009-07-30 12:47:59 -0700 Created attachment 33806 patch to DateMath.cpp DateMath.cpp also uses time symbols that have no header file on WinCE 135946 8 33806 staikos 2009-07-30 12:49:46 -0700 Comment on attachment 33806 patch to DateMath.cpp > +#if PLATFORM(WINCE) && ! PLATFORM(QT) Maybe remove that extra space on checkin 136526 9 abarth 2009-08-02 01:05:37 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M JavaScriptCore/ChangeLog M JavaScriptCore/wtf/DateMath.cpp Committed r46692 M JavaScriptCore/wtf/DateMath.cpp M JavaScriptCore/ChangeLog r46692 = 63611919366d757b9062c49340f72b14c7a06f32 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46692 31560 2009-06-19 12:48:37 -0700 2009-06-19 12:50:27 -0700 Rectify 26558.patch text/plain 2396 manyoso ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCAxZmVkOGM1Li4wNzhmNThjIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTUg QEAKIDIwMDktMDYtMTkgIFlvbmcgTGkgIDx5b25nLmxpQHRvcmNobW9iaWxlLmNvbT4KIAorICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEZWNsYXJlIHRoZXNl IHN5bWJvbHMgZXh0ZXJuIGZvciBXSU5DRSBhcyB0aGV5IGFyZSBwcm92aWRlZCBieSBsaWJjZS4K KworICAgICAgICAqIHJ1bnRpbWUvRGF0ZUNvbnN0cnVjdG9yLmNwcDoKKyAgICAgICAgKiBydW50 aW1lL0RhdGVQcm90b3R5cGUuY3BwOgorICAgICAgICAoSlNDOjpmb3JtYXRMb2NhbGVEYXRlKToK KworMjAwOS0wNi0xOSAgWW9uZyBMaSAgPHlvbmcubGlAdG9yY2htb2JpbGUuY29tPgorCiAgICAg ICAgIFJldmlld2VkIGJ5IEdlb3JnZSBTdGFpa29zLgogCiAgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNjU0MwpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENv cmUvcnVudGltZS9EYXRlQ29uc3RydWN0b3IuY3BwIGIvSmF2YVNjcmlwdENvcmUvcnVudGltZS9E YXRlQ29uc3RydWN0b3IuY3BwCmluZGV4IGYxY2Y5MzMuLjZkN2Q5MzQgMTAwNjQ0Ci0tLSBhL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvRGF0ZUNvbnN0cnVjdG9yLmNwcAorKysgYi9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL0RhdGVDb25zdHJ1Y3Rvci5jcHAKQEAgLTM1LDYgKzM1LDEwIEBACiAjaW5j bHVkZSA8d3RmL0RhdGVNYXRoLmg+CiAjaW5jbHVkZSA8d3RmL01hdGhFeHRyYXMuaD4KIAorI2lm IFBMQVRGT1JNKFdJTkNFKSAmJiAhUExBVEZPUk0oUVQpCitleHRlcm4gIkMiIHRpbWVfdCB0aW1l KHRpbWVfdCogdGltZXIpOyAvL3Byb3ZpZGVkIGJ5IGxpYmNlCisjZW5kaWYKKwogI2lmIEhBVkUo U1lTX1RJTUVfSCkKICNpbmNsdWRlIDxzeXMvdGltZS5oPgogI2VuZGlmCmRpZmYgLS1naXQgYS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL0RhdGVQcm90b3R5cGUuY3BwIGIvSmF2YVNjcmlwdENvcmUv cnVudGltZS9EYXRlUHJvdG90eXBlLmNwcAppbmRleCAxNDA2MTk3Li43YjE1OWEwIDEwMDY0NAot LS0gYS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0RhdGVQcm90b3R5cGUuY3BwCisrKyBiL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvRGF0ZVByb3RvdHlwZS5jcHAKQEAgLTEsNiArMSw3IEBACiAvKgog ICogIENvcHlyaWdodCAoQykgMTk5OS0yMDAwIEhhcnJpIFBvcnRlbiAocG9ydGVuQGtkZS5vcmcp CiAgKiAgQ29weXJpZ2h0IChDKSAyMDA0LCAyMDA1LCAyMDA2LCAyMDA3LCAyMDA4IEFwcGxlIElu Yy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqICBDb3B5cmlnaHQgKEMpIDIwMDgsIDIwMDkgVG9y Y2ggTW9iaWxlLCBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKgogICogIFRoaXMgbGlicmFy eSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IKICAqICBt b2RpZnkgaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgTGVzc2VyIEdlbmVyYWwgUHVibGlj CkBAIC01OSw2ICs2MCwxMCBAQAogI2luY2x1ZGUgPENvcmVGb3VuZGF0aW9uL0NvcmVGb3VuZGF0 aW9uLmg+CiAjZW5kaWYKIAorI2lmIFBMQVRGT1JNKFdJTkNFKSAmJiAhUExBVEZPUk0oUVQpCitl eHRlcm4gIkMiIHNpemVfdCBzdHJmdGltZShjaGFyICogY29uc3QgcywgY29uc3Qgc2l6ZV90IG1h eHNpemUsIGNvbnN0IGNoYXIgKiBjb25zdCBmb3JtYXQsIGNvbnN0IHN0cnVjdCB0bSAqIGNvbnN0 IHQpOyAvL3Byb3ZpZGVkIGJ5IGxpYmNlCisjZW5kaWYKKwogdXNpbmcgbmFtZXNwYWNlIFdURjsK IAogbmFtZXNwYWNlIEpTQyB7CkBAIC0xOTAsNiArMTk1LDkgQEAgc3RhdGljIEpTQ2VsbCogZm9y bWF0TG9jYWxlRGF0ZShFeGVjU3RhdGUqIGV4ZWMsIGNvbnN0IEdyZWdvcmlhbkRhdGVUaW1lJiBn ZHQsIEwKIHsKICNpZiBIQVZFKExBTkdJTkZPX0gpCiAgICAgc3RhdGljIGNvbnN0IG5sX2l0ZW0g Zm9ybWF0c1tdID0geyBEX1RfRk1ULCBEX0ZNVCwgVF9GTVQgfTsKKyNlbGlmIFBMQVRGT1JNKFdJ TkNFKSAmJiAhUExBVEZPUk0oUVQpCisgICAgLy8gc3RyZnRpbWUoKSB3ZSBhcmUgdXNpbmcgZG9l cyBub3Qgc3VwcG9ydCAjCisgICAgc3RhdGljIGNvbnN0IGNoYXIqIGNvbnN0IGZvcm1hdFN0cmlu Z3NbXSA9IHsgIiVjIiwgIiV4IiwgIiVYIiB9OwogI2Vsc2UKICAgICBzdGF0aWMgY29uc3QgY2hh ciogY29uc3QgZm9ybWF0U3RyaW5nc1tdID0geyAiJSNjIiwgIiUjeCIsICIlWCIgfTsKICNlbmRp Zgo= 33806 2009-07-30 12:47:59 -0700 2009-07-30 12:49:46 -0700 patch to DateMath.cpp bug26558.patch text/plain 1336 joenotcharles ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCBiZTM1ZjliLi41Mzc4Y2MzIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMTUg QEAKIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBEYXRl TWF0aCBkZXBlbmRzIG9uIHN0cmZ0aW1lIGFuZCBsb2NhbHRpbWUsIHdoaWNoIG5lZWQgdG8gYmUg aW1wb3J0ZWQgbWFudWFsbHkgb24gV2luQ0UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTI2NTU4CisKKyAgICAgICAgKiB3dGYvRGF0ZU1hdGguY3BwOgor CisyMDA5LTA3LTMwICBZb25nIExpICA8eW9uZy5saUB0b3JjaG1vYmlsZS5jb20+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKICAgICAgICAgUmVzdXJyZWN0IHRoZSBv bGQgR2V0VGlja0NvdW50IGltcGxlbWVudGF0aW9uIG9mIGN1cnJlbnRUaW1lLCBjb250cm9sbGVk IGJ5IFdURl9VU0VfUVVFUllfUEVSRk9STUFOQ0VfQ09VTlRFUgogICAgICAgICBjdXJyZW50U3lz dGVtVGltZSB0YWtlbiBmcm9tIG9sZGVyIFdlYktpdDsgY3VycmVudFRpbWUgd3JpdHRlbiBieSBZ b25nIExpIDx5b25nLmxpQHRvcmNobW9iaWxlLmNvbT47IGNsZWFudXAgYnkgSm9lIE1hc29uIDxq b2UubWFzb25AdG9yY2htb2JpbGUuY29tPgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9Mjc4NDgKZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL3d0Zi9E YXRlTWF0aC5jcHAgYi9KYXZhU2NyaXB0Q29yZS93dGYvRGF0ZU1hdGguY3BwCmluZGV4IDY0OGRj NzAuLmJhNDY4OWQgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL3d0Zi9EYXRlTWF0aC5jcHAK KysrIGIvSmF2YVNjcmlwdENvcmUvd3RmL0RhdGVNYXRoLmNwcApAQCAtNjUsNiArNjUsMTEgQEAK ICNpbmNsdWRlIDxub3RpZnkuaD4KICNlbmRpZgogCisjaWYgUExBVEZPUk0oV0lOQ0UpICYmICEg UExBVEZPUk0oUVQpCitleHRlcm4gIkMiIHNpemVfdCBzdHJmdGltZShjaGFyICogY29uc3Qgcywg Y29uc3Qgc2l6ZV90IG1heHNpemUsIGNvbnN0IGNoYXIgKiBjb25zdCBmb3JtYXQsIGNvbnN0IHN0 cnVjdCB0bSAqIGNvbnN0IHQpOworZXh0ZXJuICJDIiBzdHJ1Y3QgdG0gKiBsb2NhbHRpbWUoY29u c3QgdGltZV90ICp0aW1lcik7CisjZW5kaWYKKwogI2lmIEhBVkUoU1lTX1RJTUVfSCkKICNpbmNs dWRlIDxzeXMvdGltZS5oPgogI2VuZGlmCg==