265167 2023-11-20 17:50:49 -0800 [view-transitions] Implement parsing & checking for pseudo-elements 2023-11-23 13:33:49 -0800 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://github.com/web-platform-tests/wpt/pull/43301 InRadar P2 Normal --- 265283 259055 1 ntim ntim commit-queue philn webkit-bug-importer oldest_to_newest 1994022 0 ntim 2023-11-20 17:50:49 -0800 ... 1994023 1 webkit-bug-importer 2023-11-20 17:51:07 -0800 <rdar://problem/118666802> 1994107 2 ntim 2023-11-21 01:10:51 -0800 Pull request: https://github.com/WebKit/WebKit/pull/20775 1994263 3 ntim 2023-11-21 16:57:09 -0800 Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/43301 1994307 4 ews-feeder 2023-11-21 23:42:03 -0800 Committed 271040@main (331b2c1ac240): <https://commits.webkit.org/271040@main> Reviewed commits have been landed. Closing PR #20775 and removing active labels. 1994513 5 philn 2023-11-23 04:15:09 -0800 Looks like this patch broke Debug test bots: https://build.webkit.org/results/GTK-Linux-64-bit-Debug-Tests/271069@main%20(11794)/results.html STDERR: SHOULD NEVER BE REACHED STDERR: /app/webkit/Source/WebCore/inspector/agents/InspectorCSSAgent.cpp(433) : static std::optional<Inspector::Protocol::CSS::PseudoId> WebCore::InspectorCSSAgent::protocolValueForPseudoId(WebCore::PseudoId) Thread 1 (Thread 0x7ff0a5859a40 (LWP 715647)): #0 WTFCrash() () at /app/webkit/Source/WTF/wtf/Assertions.cpp:333 #1 0x00007ff0bb481541 in WTFCrashWithInfo(int, char const*, char const*, int) () at /app/webkit/WebKitBuild/GTK/Debug/WTF/Headers/wtf/Assertions.h:778 #2 0x00007ff0c0b03835 in WebCore::InspectorCSSAgent::protocolValueForPseudoId(WebCore::PseudoId) (pseudoId=WebCore::PseudoId::ViewTransition) at /app/webkit/Source/WebCore/inspector/agents/InspectorCSSAgent.cpp:433 #3 0x00007ff0c0b03ba8 in WebCore::InspectorCSSAgent::getMatchedStylesForNode(int, std::optional<bool>&&, std::optional<bool>&&) (this=0x7ff09c031380, nodeId=7, includePseudo=..., includeInherited=...) at /app/webkit/Source/WebCore/inspector/agents/InspectorCSSAgent.cpp:475 #4 0x00007ff0aff4ac2f in Inspector::CSSBackendDispatcher::getMatchedStylesForNode(long, WTF::RefPtr<WTF::JSONImpl::Object, WTF::RawPtrTraits<WTF::JSONImpl::Object>, WTF::DefaultRefDerefTraits<WTF::JSONImpl::Object> >&&) (this=0x7ff09c2421a0, protocol_requestId=7, protocol_parameters=...) at /app/webkit/WebKitBuild/GTK/Debug/JavaScriptCore/DerivedSources/inspector/InspectorBackendDispatchers.cpp:777 #5 0x00007ff0aff4a643 in Inspector::CSSBackendDispatcher::dispatch(long, WTF::String const&, WTF::Ref<WTF::JSONImpl::Object, WTF::RawPtrTraits<WTF::JSONImpl::Object> >&&) (this=0x7ff09c2421a0, protocol_requestId=7, protocol_method=..., protocol_message=...) at /app/webkit/WebKitBuild/GTK/Debug/JavaScriptCore/DerivedSources/inspector/InspectorBackendDispatchers.cpp:717 #6 0x00007ff0aff445c4 in Inspector::BackendDispatcher::dispatch(WTF::String const&) (this=0x7ff09c038a40, message=...) at /app/webkit/Source/JavaScriptCore/inspector/InspectorBackendDispatcher.cpp:183 #7 0x00007ff0c0a73ea4 in WebCore::InspectorController::dispatchMessageFromFrontend(WTF::String const&) (this=0x7ff09c0eae80, message=...) at /app/webkit/Source/WebCore/inspector/InspectorController.cpp:417 #8 0x00007ff0c0a82c72 in WebCore::InspectorBackendDispatchTask::dispatchOneMessage() (this=0x7ff09c250480) at /app/webkit/Source/WebCore/inspector/InspectorFrontendClientLocal.cpp:125 #9 0x00007ff0c0a82ac2 in WebCore::InspectorBackendDispatchTask::scheduleOneShot()::{lambda()#1}::operator()() const (__closure=0x7ff09c31c408) at /app/webkit/Source/WebCore/inspector/InspectorFrontendClientLocal.cpp:112 #10 0x00007ff0c0a9eade in WTF::Detail::CallableWrapper<WebCore::InspectorBackendDispatchTask::scheduleOneShot()::{lambda()#1}, void>::call() (this=0x7ff09c31c400) at /app/webkit/WebKitBuild/GTK/Debug/WTF/Headers/wtf/Function.h:53 #11 0x00007ff0af95c68f in WTF::Function<void ()>::operator()() const (this=0x7ffcb635b520) at /app/webkit/WebKitBuild/GTK/Debug/WTF/Headers/wtf/Function.h:82 #12 0x00007ff0b0ff7259 in WTF::RunLoop::performWork() (this=0x7ff09c0180c0) at /app/webkit/Source/WTF/wtf/RunLoop.cpp:147 #13 0x00007ff0b10ab80a in operator()(gpointer) const (__closure=0x0, userData=0x7ff09c0180c0) at /app/webkit/Source/WTF/wtf/glib/RunLoopGLib.cpp:80 #14 0x00007ff0b10ab82e in _FUN(gpointer) () at /app/webkit/Source/WTF/wtf/glib/RunLoopGLib.cpp:82 #15 0x00007ff0b10ab79d in operator()(GSource*, GSourceFunc, gpointer) const (__closure=0x0, source=0x55da3fe38810, callback=0x7ff0b10ab811 <_FUN(gpointer)>, userData=0x7ff09c0180c0) at /app/webkit/Source/WTF/wtf/glib/RunLoopGLib.cpp:53 #16 0x00007ff0b10ab7eb in _FUN(GSource*, GSourceFunc, gpointer) () at /app/webkit/Source/WTF/wtf/glib/RunLoopGLib.cpp:56 #17 0x00007ff0aa2e3d36 in g_main_dispatch (context=0x55da3fe0ea00) at ../glib/gmain.c:3460 #18 g_main_context_dispatch (context=0x55da3fe0ea00) at ../glib/gmain.c:4200 #19 0x00007ff0aa3412b8 in g_main_context_iterate.isra.0 (context=0x55da3fe0ea00, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at ../glib/gmain.c:4276 #20 0x00007ff0aa2e33ff in g_main_loop_run (loop=0x55da3fe387f0) at ../glib/gmain.c:4479 #21 0x00007ff0b10abe5e in WTF::RunLoop::run() () at /app/webkit/Source/WTF/wtf/glib/RunLoopGLib.cpp:108 #22 0x00007ff0bcfd2bc7 in WebKit::AuxiliaryProcessMainBase<WebKit::WebProcess, true>::run(int, char**) (this=0x7ffcb635b7f0, argc=4, argv=0x7ffcb635b9b8) at /app/webkit/Source/WebKit/Shared/AuxiliaryProcessMain.h:72 #23 0x00007ff0bcfcf6c6 in WebKit::AuxiliaryProcessMain<WebKit::WebProcessMainGtk>(int, char**) (argc=4, argv=0x7ffcb635b9b8) at /app/webkit/Source/WebKit/Shared/AuxiliaryProcessMain.h:98 #24 0x00007ff0bcfc7912 in WebKit::WebProcessMain(int, char**) (argc=4, argv=0x7ffcb635b9b8) at /app/webkit/Source/WebKit/WebProcess/gtk/WebProcessMainGtk.cpp:98 #25 0x000055da3fbe8989 in main(int, char**) (argc=4, argv=0x7ffcb635b9b8) at /app/webkit/Source/WebKit/WebProcess/EntryPoint/unix/WebProcessMain.cpp:31 1994515 6 philn 2023-11-23 04:17:58 -0800 Also happening on mac btw :( 1994524 7 commit-queue 2023-11-23 04:56:00 -0800 Re-opened since this is blocked by bug 265283 1994539 8 vitaly 2023-11-23 06:39:17 -0800 Pull request: https://github.com/WebKit/WebKit/pull/20849 1994585 9 ews-feeder 2023-11-23 13:33:47 -0800 Committed 271089@main (e2c3f84bd18e): <https://commits.webkit.org/271089@main> Reviewed commits have been landed. Closing PR #20849 and removing active labels.