264676 2023-11-11 08:02:22 -0800 Add remaining 'legend' UA stylesheet rules from HTML Web Specification 2025-03-01 01:41:39 -0800 1 1 1 Unclassified WebKit CSS Safari Technology Preview Unspecified Unspecified RESOLVED DUPLICATE 189304 InRadar, WPTImpact P2 Normal --- 1 ahmad.saleem792 webkit-unassigned ntim webkit-bug-importer oldest_to_newest 1991852 0 ahmad.saleem792 2023-11-11 08:02:22 -0800 Hi Team, While looking into default UA stylesheet of 'ladybird' browser, I noticed that they are following all UA stylesheet rules and noticed, we have added following: ____ legend[align=left i] { justify-self: left; } legend[align=center i] { justify-self: center; } legend[align=right i] { justify-self: right; } ____ Web-Spec: https://html.spec.whatwg.org/#the-fieldset-and-legend-elements In my local testing, adding them leads to progress following test case: http://wpt.live/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/legend-align-justify-self.html I think we should go for it and get all those WPT wins unless if there is genuine reason that we don't want to do them. Thanks! 1991913 1 ahmad.saleem792 2023-11-11 15:34:20 -0800 Please refer to PR attempt, which is not correct way to approach this bug as highlighted by Tim. https://github.com/WebKit/WebKit/pull/20370 Just to note for future purposes: "It's complicated. You'd need to implement support for justify-self for children of blocks and remove the old code that maps align to text-align, and then sync the UA styles as you did here." 1993675 2 webkit-bug-importer 2023-11-18 08:03:14 -0800 <rdar://problem/118602283> 2099586 3 ahmad.saleem792 2025-03-01 01:41:39 -0800 *** This bug has been marked as a duplicate of bug 189304 ***