<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>263701</bug_id>
          
          <creation_ts>2023-10-25 18:20:07 -0700</creation_ts>
          <short_desc>STDIN and STDOUT of Perl CGI scripts should be binary mode for Windows Perl</short_desc>
          <delta_ts>2023-11-05 22:42:33 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>264237</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Fujii Hironori">fujii</reporter>
          <assigned_to name="Fujii Hironori">fujii</assigned_to>
          <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1987630</commentid>
    <comment_count>0</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2023-10-25 18:20:07 -0700</bug_when>
    <thetext>The STDOUT has to be binary mode for Windows Perl not to convert &apos;\n&apos; to &apos;\r\n&apos;.
&quot;use CGI&quot; automatically does it.
Add &quot;binmode STDOUT&quot; for other Perl CGI scripts.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1987631</commentid>
    <comment_count>1</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2023-10-25 18:29:41 -0700</bug_when>
    <thetext>Pull request: https://github.com/WebKit/WebKit/pull/19577</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1987637</commentid>
    <comment_count>2</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2023-10-25 19:20:07 -0700</bug_when>
    <thetext>Do I need to binmode STDIN too? CGI.pm sets binmode to STDIN too. Should I &quot;use CGI&quot;?
https://github.com/leejo/CGI.pm/blob/46617ba3049b53a1ac0c15d6fc6c49b2ee26f33d/lib/CGI.pm#L214-L215</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1987903</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-10-26 22:30:56 -0700</bug_when>
    <thetext>Committed 269838@main (5a716d72adac): &lt;https://commits.webkit.org/269838@main&gt;

Reviewed commits have been landed. Closing PR #19577 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1987904</commentid>
    <comment_count>4</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2023-10-26 22:31:15 -0700</bug_when>
    <thetext>&lt;rdar://problem/117568744&gt;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>