263448 2023-10-20 09:47:30 -0700 Build fix: add gtest dependency to gmock project 2023-10-20 13:04:15 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 263225 1 ddkilzer ddkilzer webkit-bug-importer oldest_to_newest 1986446 0 ddkilzer 2023-10-20 09:47:30 -0700 Build fix: add gtest dependency to gmock project. The gmock project depends on headers from the gtest project, but Xcode is not aware of this dependency, so gmock can sometimes build before gtest, resulting in a build failure: ``` In file included from OpenSource/Source/ThirdParty/gmock/src/gmock-all.cc:39: In file included from include/gmock/gmock.h:59: In file included from include/gmock/gmock-actions.h:145: In file included from include/gmock/internal/gmock-internal-utils.h:46: include/gmock/internal/gmock-port.h:56:10: fatal error: 'gtest/internal/gtest-port.h' file not found #include <gtest/internal/gtest-port.h> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/gmock/internal/gmock-port.h:56:10: note: did not find header 'internal/gtest-port.h' in framework 'gtest' (loaded from 'OpenSource/WebKitBuild/Release') 1 error generated. ``` 1986447 1 webkit-bug-importer 2023-10-20 09:47:45 -0700 <rdar://problem/117266314> 1986452 2 ddkilzer 2023-10-20 10:21:59 -0700 Pull request: https://github.com/WebKit/WebKit/pull/19347 1986500 3 ews-feeder 2023-10-20 13:04:08 -0700 Committed 269581@main (14adb9294c87): <https://commits.webkit.org/269581@main> Reviewed commits have been landed. Closing PR #19347 and removing active labels.