<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>261022</bug_id>
          
          <creation_ts>2023-09-01 00:48:00 -0700</creation_ts>
          <short_desc>[TextureMapper] Move filter specific code from BitmapTextureGL to TextureMapperGL</short_desc>
          <delta_ts>2023-09-03 18:36:13 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Platform</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>231653</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Akihiro Kiuchi">aki.develop8128</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>fujii</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1974945</commentid>
    <comment_count>0</comment_count>
    <who name="Akihiro Kiuchi">aki.develop8128</who>
    <bug_when>2023-09-01 00:48:00 -0700</bug_when>
    <thetext>This is a preparation refactoring for https://bugs.webkit.org/show_bug.cgi?id=231653.

To fix the issue above, we have to change the number of passes needed to do blur filtering according to the standard deviation of the blur.
Now the number of passes for each filter is specified in BitmapTextureGL.cpp but other parameters regarding filtering such as shader options are specified in TextureMapperGL.cpp, which leads to the inconsistency and low readability.

My suggestion is to move the loop of passes, written in BitmapTextureGL.cpp for now, to TextureMapperGL.cpp</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1975071</commentid>
    <comment_count>1</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2023-09-01 13:53:56 -0700</bug_when>
    <thetext>PR https://github.com/WebKit/WebKit/pull/17335</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1975292</commentid>
    <comment_count>2</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-09-03 18:35:33 -0700</bug_when>
    <thetext>Committed 267599@main (499bdf98d4a7): &lt;https://commits.webkit.org/267599@main&gt;

Reviewed commits have been landed. Closing PR #17335 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1975293</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2023-09-03 18:36:13 -0700</bug_when>
    <thetext>&lt;rdar://problem/114912332&gt;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>