260409 2023-08-18 14:43:09 -0700 Empty files should not succeed in loading (as WebVTT) 2023-10-23 02:48:00 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED http://wpt.live/webvtt/parsing/file-parsing/signature-invalid.html BrowserCompat, InRadar, WPTImpact P2 Normal --- 179370 1 ahmad.saleem792 webkit-unassigned annevk destra eric.carlson jer.noble karlcow kohei.ueno119 webkit-bug-importer oldest_to_newest 1972148 0 ahmad.saleem792 2023-08-18 14:43:09 -0700 Hi Team, While going through Blink's commit, I came across another potential merge: Blink Commit: https://chromium.googlesource.com/chromium/src.git/+/0983d4b64cb5f519684f773daa27b2ac9b8f8688 WebKit Source: https://searchfox.org/wubkat/source/Source/WebCore/loader/TextTrackLoader.cpp#120 WPT Test Case: https://wpt.fyi/results/webvtt/parsing/file-parsing/signature-invalid.html?label=master&label=experimental&aligned=&q=signature WPT Test Case Live Link: http://wpt.live/webvtt/parsing/file-parsing/signature-invalid.html ^ It is about first failure - 'signature, empty'. Just wanted to raise, so we can fix it. Adding "WPTImpact" and "BrowserCompat" tags. Thanks! 1972186 1 webkit-bug-importer 2023-08-18 18:34:04 -0700 <rdar://problem/114118292> 1973374 2 ahmad.saleem792 2023-08-24 15:45:07 -0700 NOTE - Doing 1-1 Blink Merge leads to two WPT regressions: html/semantics/embedded-content/media-elements/track/track-element /track-add-remove-cue.html and html/semantics/embedded-content/media-elements/track/track-element/track-text-track-cue-list.html ___ PR attempt: https://github.com/WebKit/WebKit/pull/16863 ____ NOTE: We should sync 'webvtt' and look into why the tests are timing out and fix it. Still investigating but closing my PR for time being. 1976339 3 annevk 2023-09-07 23:26:14 -0700 I was thinking of fixing this in TextTrackLoader::notifyFinished by changing if (m_cueParser) m_cueParser->fileFinished(); to if (m_cueParser) m_cueParser->fileFinished(); else m_state = Failed; but I'm not sure if that would similarly regress tests. However, looking closely at your commit it seems that WebKit would still invoke processNewCueData for the non-Failed states whereas Chromium would not (at least not at that point in time). Syncing webvtt WPT is probably a good next step here. I can maybe do that today between meetings. 1986670 4 kohei.ueno119 2023-10-21 06:25:16 -0700 @Ahmad Saleem @Anne van Kesteren Are you working on this issue? If not, I'd be happy to take it over. 1986671 5 ahmad.saleem792 2023-10-21 06:26:32 -0700 (In reply to Kueno from comment #4) > @Ahmad Saleem @Anne van Kesteren > > Are you working on this issue? If not, I'd be happy to take it over. I am not. Go ahead and take it. You are doing amazing job!! We all really appreciate it. 1986742 6 kohei.ueno119 2023-10-22 06:13:08 -0700 Pull request: https://github.com/WebKit/WebKit/pull/19401 1986791 7 ews-feeder 2023-10-23 02:47:58 -0700 Committed 269646@main (d40154a4fe8f): <https://commits.webkit.org/269646@main> Reviewed commits have been landed. Closing PR #19401 and removing active labels.