26019 2009-05-26 03:39:46 -0700 beginElement broken by setAttribute 2011-05-03 07:52:19 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED HasReduction P2 Normal --- 26008 41761 1 jay jchaffraix abarth commit-queue dinesh.garg eric jchaffraix webkit.review.bot zimmermann oldest_to_newest 123115 0 jay 2009-05-26 03:39:46 -0700 open attachment click on green button circle moves across screen click on red button circle reset see bug 26008 click on green button circle restarts across screen in opera, nothing in safari 123116 1 30667 jay 2009-05-26 03:40:32 -0700 Created attachment 30667 reduced testcase for this bug 123118 2 jay 2009-05-26 03:43:56 -0700 do these two bugs have a common issue related to the implementation of beginElement and endElement? 277549 3 67268 dinesh.garg 2010-09-10 17:05:35 -0700 Created attachment 67268 Fixed bug 26019 AnimationValid was reset but not ActiveState of SvgAnimationElement. So reset the ActiveState as well. 277551 4 webkit.review.bot 2010-09-10 17:07:28 -0700 Attachment 67268 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 Total errors found: 0 in 0 files If any of these errors are false positives, please file a bug against check-webkit-style. 277553 5 67268 eric 2010-09-10 17:08:21 -0700 Comment on attachment 67268 Fixed bug 26019 This is not a text plain patch file. Please upload a new patch using webkit-patch upload. 277556 6 67271 dinesh.garg 2010-09-10 17:18:12 -0700 Created attachment 67271 Fixed bug 26019 AnimationValid was reset but not ActiveState of SvgAnimationElement. So reset the ActiveState as well. 281270 7 67271 zimmermann 2010-09-19 07:05:59 -0700 Comment on attachment 67271 Fixed bug 26019 > diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog > index bfaa4fa..d25d800 100644 > --- a/LayoutTests/ChangeLog > +++ b/LayoutTests/ChangeLog > @@ -1,3 +1,14 @@ > +2010-09-10 Dinesh K Garg <dineshg@codeaurora.org> > + > + Reviewed by NOBODY (OOPS!). > + > + New test case for BugId - 26019: You can omit this line. > --- /dev/null > +++ b/LayoutTests/svg/animations/animate-beginElementAt.svg > @@ -0,0 +1,56 @@ > +<?xml version="1.0" encoding="utf-8" standalone="no"?> > +<svg > + xmlns:xlink="http://www.w3.org/1999/xlink" > +width='100%' height='100%' xmlns='http://www.w3.org/2000/svg' > > + <title>Animated Values Test</title> > + > +<circle cx='0' cy='50' r='20' style='fill:orange; ' id='testCircle'> > + <animate attributeName='cx' attributeType='XML' begin='indefinite' end='indefinite' dur='10s' repeatCount='indefinite' from="10" to="200" id='dTripper' fill="freeze" /> > +</circle> > + > +<text y="130" x="20" id="expectedResult">This test verifies the animation behaviour of beginElement in SVG. BugId-26019</text> > + > +<text y="150" x="20" id="console"/> > + > +<script><![CDATA[ > + > + var animatedElement; > + animatedElement = document.getElementById("dTripper"); > + animatedElement.setAttribute("to", 420); > + animatedElement.beginElement(); > + setTimeout(beginElement,100); I don't understand, why you are doing setAttribute("to".., then calling beginElement, and then setTimeout(beginElement, 100) which does the same? Please explain why this is needed. Also you shouldn't use 100ms as timeout, try setTImeout(beginElement, 0) if you want it async. > + > + function stopCircle(evt) > + { > + animatedElement.endElement(); > + } > + > + function beginElement() > + { > + animatedElement.setAttribute("to", 420); > + animatedElement.beginElement(); > + setTimeout(dumpResult,100); Same here, just use setTimeout(dumpResult, 0) > +++ b/WebCore/ChangeLog > @@ -1,3 +1,19 @@ > +2010-09-10 Dinesh K Garg <dineshg@codeaurora.org> > + > + Reviewed by NOBODY (OOPS!). > + > + beginElement broken by setAttribute > + https://bugs.webkit.org/show_bug.cgi?id=26019 Add a newline here. > + Initialized animation element state in beginElementAt The why is missing here, please provide a more detailed ChangeLog, another sentence describing why it is needed etc. > + > + Tests: svg/animations/animate-beginElementAt.svg > + > + * svg/SVGAnimationElement.cpp: > + (WebCore::SVGAnimationElement::beginElementAt): > + (WebCore::SVGAnimationElement::updateAnimation): > + * svg/animation/SVGSMILElement.h: > + (WebCore::SVGSMILElement::setActiveState): > + > 2010-09-10 Ryosuke Niwa <rniwa@webkit.org> > > Reviewed by Antonio Gomes. > diff --git a/WebCore/svg/SVGAnimationElement.cpp b/WebCore/svg/SVGAnimationElement.cpp > index b5eaafc..270fbbd 100644 > --- a/WebCore/svg/SVGAnimationElement.cpp > +++ b/WebCore/svg/SVGAnimationElement.cpp > @@ -159,6 +159,8 @@ void SVGAnimationElement::attributeChanged(Attribute* attr, bool preserveDecls) > { > // Assumptions may not hold after an attribute change. > m_animationValid = false; > + // Reset the animation to InActive state as well. > + setInactive(); > SVGSMILElement::attributeChanged(attr, preserveDecls); > } > > @@ -556,7 +558,7 @@ void SVGAnimationElement::updateAnimation(float percent, unsigned repeat, SVGSMI > { > if (!m_animationValid) > return; > - > + This change is unrelated, please leave it out. > diff --git a/WebCore/svg/animation/SVGSMILElement.h b/WebCore/svg/animation/SVGSMILElement.h > index ed8bbf8..73a8f9d 100644 > --- a/WebCore/svg/animation/SVGSMILElement.h > +++ b/WebCore/svg/animation/SVGSMILElement.h > @@ -88,7 +88,7 @@ namespace WebCore { > bool isContributing(SMILTime elapsed) const; > bool isInactive() const; > bool isFrozen() const; > - > + Ditto. Not needed. Other than that, looks nice. Please upload a new version. 287950 8 69401 dinesh.garg 2010-09-30 17:21:22 -0700 Created attachment 69401 Propose fix after review comments (In reply to comment #7) > > + New test case for BugId - 26019: > You can omit this line. Done > > + var animatedElement; > > + animatedElement = document.getElementById("dTripper"); > > + animatedElement.setAttribute("to", 420); > > + animatedElement.beginElement(); > > + setTimeout(beginElement,100); > I don't understand, why you are doing setAttribute("to".., then calling beginElement, and then setTimeout(beginElement, 100) which does the same? Please explain why this is needed. I am removing setAttribute from here. setAttribute() breaks beginElementAt() when beginElementAt() has been called. i.e. beginElementAt() - setAttribute() - beginElementAt() is broken but not setAttribute() - beginElementAt() > Also you shouldn't use 100ms as timeout, try setTImeout(beginElement, 0) if you want it async. I want some timegap after beginElementAt to be sure that Animation has started. > > + function beginElement() > > + { > > + animatedElement.setAttribute("to", 420); > > + animatedElement.beginElement(); > > + setTimeout(dumpResult,100); > Same here, just use setTimeout(dumpResult, 0) I want circle to move so that I can compare circle positions i.e. current and last one. Value 0 wont help me. if bug fix is working circle will move next time beginElementAt() is called and then dumpresult shall compare current and positions and dump result accordingly. > > + beginElement broken by setAttribute > > + https://bugs.webkit.org/show_bug.cgi?id=26019 > Add a newline here. Done > > + Initialized animation element state in beginElementAt > The why is missing here, please provide a more detailed ChangeLog, another sentence describing why it is needed etc. Done > > @@ -556,7 +558,7 @@ void SVGAnimationElement::updateAnimation(float percent, unsigned repeat, SVGSMI > > - > > + > This change is unrelated, please leave it out. Done > > diff --git a/WebCore/svg/animation/SVGSMILElement.h b/WebCore/svg/animation/SVGSMILElement.h > > @@ -88,7 +88,7 @@ namespace WebCore { > > bool isContributing(SMILTime elapsed) const; > > bool isInactive() const; > > bool isFrozen() const; > > - > > + > Ditto. Not needed. Done > Other than that, looks nice. Please upload a new version. 292355 9 69401 abarth 2010-10-10 12:39:49 -0700 Comment on attachment 69401 Propose fix after review comments Generally, contributors don't add themselves to the copyright line when adding one line to a file. 293294 10 69401 cfleizach 2010-10-13 00:41:23 -0700 Comment on attachment 69401 Propose fix after review comments As Adam said, this is not a significant contribution. Please remove copyright change. 293366 11 dinesh.garg 2010-10-13 05:30:11 -0700 (In reply to comment #10) Sure. I will upload one without copyright soon. 384410 12 89279 jchaffraix 2011-04-12 15:01:29 -0700 Created attachment 89279 Updated patch - addressing Chris' comments. 388345 13 89279 zimmermann 2011-04-19 00:47:56 -0700 Comment on attachment 89279 Updated patch - addressing Chris' comments. View in context: https://bugs.webkit.org/attachment.cgi?id=89279&action=review The code change is great, the test just needs a simple tweak, then it's ready... > LayoutTests/svg/animations/animate-beginElementAt.svg:3 > + xmlns:xlink="http://www.w3.org/1999/xlink" xlink namespace is not needed here. Just make it: <svg xmlns="..."> > LayoutTests/svg/animations/animate-beginElementAt.svg:5 > + <title>Animated Values Test</title> Not needed. > LayoutTests/svg/animations/animate-beginElementAt.svg:7 > +<circle cx='0' cy='50' r='20' style='fill:orange; ' id='testCircle'> you could use fill="orange", no need to use the inline style attribute. The id attribute is not needed as well. > LayoutTests/svg/animations/animate-beginElementAt.svg:21 > + setTimeout(beginElement,100); s/,100/, 0/ > LayoutTests/svg/animations/animate-beginElementAt.svg:32 > + setTimeout(dumpResult,100); Ditto. > LayoutTests/svg/animations/animate-beginElementAt.svg:38 > + if(document.getElementById("testCircle").getAttribute("cx") < 11 ) Formatting: if (document.... < 11) > LayoutTests/svg/animations/animate-beginElementAt.svg:42 > + stopCircle(); Do you really need another method here? Just remove it IMHO. 388810 14 jchaffraix 2011-04-19 14:43:22 -0700 > > LayoutTests/svg/animations/animate-beginElementAt.svg:7 > > +<circle cx='0' cy='50' r='20' style='fill:orange; ' id='testCircle'> > > you could use fill="orange", no need to use the inline style attribute. The id attribute is not needed as well. The id attribute is needed actually as we need to check the circle's cx position. > > LayoutTests/svg/animations/animate-beginElementAt.svg:21 > > + setTimeout(beginElement,100); > > s/,100/, 0/ OK, reworked the test to remove the 100ms delays. The rest is taken care of in the next iteration. Thanks for the comments. 388813 15 90258 jchaffraix 2011-04-19 14:46:00 -0700 Created attachment 90258 Updated patch - fixed the test per Nikolas comments 392876 16 90258 eric 2011-04-26 15:51:17 -0700 Comment on attachment 90258 Updated patch - fixed the test per Nikolas comments Seems reasonable as far as I can tell. 393231 17 commit-queue 2011-04-26 18:26:15 -0700 The commit-queue encountered the following flaky tests while processing attachment 90258: http/tests/xmlhttprequest/cross-origin-authorization.html bug 52398 (author: ap@webkit.org) http/tests/xmlhttprequest/failed-auth.html bug 51835 (author: ap@webkit.org) The commit-queue is continuing to process your patch. 393236 18 90258 commit-queue 2011-04-26 18:28:20 -0700 Comment on attachment 90258 Updated patch - fixed the test per Nikolas comments Clearing flags on attachment: 90258 Committed r84999: <http://trac.webkit.org/changeset/84999> 393237 19 commit-queue 2011-04-26 18:28:26 -0700 All reviewed patches have been landed. Closing bug. 393311 20 webkit.review.bot 2011-04-26 21:17:42 -0700 http://trac.webkit.org/changeset/84999 might have broken SnowLeopard Intel Release (WebKit2 Tests) 397080 21 jchaffraix 2011-05-03 07:52:19 -0700 FYI, the original test case covered several bugs so there is a follow up bug: bug59897. 30667 2009-05-26 03:40:32 -0700 2009-05-26 03:40:32 -0700 reduced testcase for this bug test.svg image/svg+xml 1000 jay PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0idXRmLTgiIHN0YW5kYWxvbmU9Im5vIj8+DQo8 c3ZnCiAgIHhtbG5zOnhsaW5rPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5L3hsaW5rIgp3aWR0aD0n MTAwJScgaGVpZ2h0PScxMDAlJyB4bWxucz0naHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmcnID4N CiAgIDx0aXRsZT5BbmltYXRlZCBWYWx1ZXMgVGVzdDwvdGl0bGU+DQoNCg0KPHNjcmlwdD48IVtD REFUQVsNCg0KICAgZnVuY3Rpb24gc3RhcnRDaXJjbGUoZXZ0KQ0KICAgewoJZG9jdW1lbnQuZ2V0 RWxlbWVudEJ5SWQoImRUcmlwcGVyIikuc2V0QXR0cmlidXRlKCJ0byIsIDQyMCk7DQpkb2N1bWVu dC5nZXRFbGVtZW50QnlJZCgiZFRyaXBwZXIiKS5iZWdpbkVsZW1lbnQoKTsNCiAgIH0NCg0KICAg ZnVuY3Rpb24gc3RvcENpcmNsZShldnQpDQogICB7DQpkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgi ZFRyaXBwZXIiKS5lbmRFbGVtZW50KCk7DQogICB9Cl1dPjwvc2NyaXB0Pg0KPGNpcmNsZSBjeD0n MCcgY3k9JzUwJyByPScyMCcgc3R5bGU9J2ZpbGw6b3JhbmdlOyAnIG9uY2xpY2s9J1NldFJlY3Qo ZXZ0KSc+DQogICA8YW5pbWF0ZSBhdHRyaWJ1dGVOYW1lPSdjeCcgYXR0cmlidXRlVHlwZT0nWE1M JyBiZWdpbj0naW5kZWZpbml0ZScgZW5kPSdpbmRlZmluaXRlJyBkdXI9JzEwcycgcmVwZWF0Q291 bnQ9J2luZGVmaW5pdGUnIGZyb209IjEwIiB0bz0iMjAwIiAgaWQ9J2RUcmlwcGVyJyBmaWxsPSJm cmVlemUiIC8+DQo8L2NpcmNsZT4NCg0KPHJlY3QgaWQ9J2xpdHRsZUxhbWInIHg9JzEwJyB5PScx MzAnIHdpZHRoPSc0MCcgaGVpZ2h0PSc0MCcgcng9JzUnIHJ5PSc1JyBmaWxsPSdncmVlbicgb25j bGljaz0nc3RhcnRDaXJjbGUoKScgLz4KPHJlY3QgaWQ9J2xpdHRsZUxhbWInIHg9JzEwJyB5PScy MzAnIHdpZHRoPSc0MCcgaGVpZ2h0PSc0MCcgcng9JzUnIHJ5PSc1JyBmaWxsPSdyZWQnIG9uY2xp Y2s9J3N0b3BDaXJjbGUoKScgLz4NCiANCjwvc3ZnPg== 67268 2010-09-10 17:05:35 -0700 2010-09-10 17:18:12 -0700 Fixed bug 26019 Bug26019.patch.tar.gz text/plain 1938 dinesh.garg H4sICH+xikwAA0J1ZzI2MDE5LnBhdGNoLnRhcgDtWOtv2zgSz2f/FVMBB9u1LcuOnfgRp3GS3SLY Nina7N4dFosFLVI2UZk0JMqPLvZ/vyElWfLz2u629+E8H6qYnBnO4zfDYW+jcfPCaXTtGVHu5Oyb kIN0cdE6c5rnTqPlmN/njfjrOI1mu90+azRarWa7eXmu+XDp0jkD59uYs0lRqEgAcEa5YOFkfISP BeH3MOj7EuWeB7XamCsg9TdkJSP1zEIV1u8mRIzZGzmG0f71AheULWHkEdLyiG3TZpt2HAcamOxW q1Cr1Q5pLFQqlYNab26g1qieQ6VRbbTg5qZQaToNp+Z0aw0H4N5kCX6C1yQYA1wlWbtxJWUkCmRA bBmMrwuVQgUSes/mnC0YhdEKHp9un+7/DaWnp3cfXpTtPNsjW4BCW8AlIQNPBnAbjR8o1MDURy/j HLExFz/4bMqEglEgPzKhdYdMDZUK+ChSLGOeKDULe/X6KBqH9oKNPnKlLayHE7n4HRdtd8xfcTow h+TteQnhfFwngk+J4lKEyZ+slj9+qGpsOWOuYtRWS9WDIaX45xdrsZErEy5APuTvVzKMPjJ45AuC EQ8Efm8yT64LUEhP24j1UCgpuITXcspCu3AQaF/u5hZ2vlxBQWCyPe4zmCJuUsTGeI6bkmPbrU6X Oe0YyHXK5nUR+f4e6H7F8RrjTtXRGG8aiD9PeBijb84C7nGGvyYM1moRcxMy5zIKQHqbAOQCPvzy 2o7RWktg9I6EIaN/MeYaFF/jq5bbjfBlu70d4YtOmzZp8++JsDk1F9j2hYns1avl1NdRDVF2YDVs xwImsF1wMR5YkfJqHQvwChCU+FKwgSWk9Qr7x5VWp8sIxUXYW/pcfBxYupqxmBeLhb04N3Xc6Ha7 dbNrFSoLTtVkUERv/1GECePjiUp/GTWD4q6CJoZCe1iEa3PeleLKZ9fD2EkKvxA/QjjoSFzV4z3d Jq5cHrgYXnc5KDpFcFeDYhu/waDYxE+oVj4bFDEBfg97IrbWPhQB20xRg+zOiBaT85JwAkmb1yOZ oqy7LGZLz6sZLv3r7ZtiDL5BUafS44IrVsR40s0FGgXa7xDtYTNG1J2MhNpk8QI5xXRgNpQcWBgE C4x99DngsxkLiho9/sDyAsY+MQvqOif12Ok4AIphJ1ihjnOUXWodltZgpZX2noWRr6zrv7e2MAd4 7pYF7U0LXESp9JlVj9lCF11S11cvfr27Hz4Pf026/BzHjiT2NDmwbza2FmEAVLqR/tMeM5Ws3q4e aMlKo2WV94ra+TupZClpVaHVdA4w510vJTyo4JlPGZZiKb9dRVBrDsPjRcI1gQyVnMXYKrG5KpvN P7K7aPs8hM3WaX9ua9w06b8pPOrtXol9LhvK+U2j6SzGUur1Pkszrl07daYNAI9kMsVM3gjulQ7y Z3VslfVmznF3aZXhChoNKGe6NGkZmyBeBL2bcJ9m2t0Aq5Q9I54fsV2XrB8Jtm5qlfPWMD9kX6sv vo829eXQsuk0lBbYKeTC9td3wJ0UKpC+z4Itl/ax2EIq7q3usZ2X1iBNE/ZZ6nO523uATvYw1O5t mL6Xd0G4+lko7q/tSa357bfrq3rSHEyj0NfA9eal/U82upMB25jGd9bSe/XSa567OIlf4FuKErY5 ie9KxRft7np+Au9+xwn8W87VqdgD3j6c+PwTWpPdACw5FOcAvAj5Zt8ZqryRZiLpff5UvTvS440y TCXTPuTOZrkHRinJSa+3h7fX2zyk/PmC0Yyikev1vOTWO0Eb+eHtw5vUvsmhQ3JMvZ7OFHbDOfug 46jVf/uXRArfI5HNgfwIV/qcbTNCPNe2m5eONxrR/UV0TM9mWR3jNIXW7lYvsNTw08Fag7nkFPZm bz2MxZVKS+uqeGkGtSqMpPRhFrCQBXN2z1w/LBewl5l41uswDEPsWwawMCUrwDYJE+ljIXiK6Vkk m/fANWfYsez09zUwcBpF+wbgEbwNktaHqvHmY2prrFISqy3GQ1JYJIQF8/3keYoSD4KYfd0WzUnb iNrxOXZ000eU/ROho6PZbl9UL6HSbnfwczSaW7VQ8nxJFOAo5erxBiIR8rFA+MUDbDWxDMOpzSys b6oX27EpZxAOmIoC0S/UjEgl3ojPYZ7HjOfv4gP7mca1urf65izDYJA8AbK6TXNqIoYBEmMzTvcP V8bhwt6C6mHGpD4Y7YxGXse2L89Jx+seqY8jqnZL5AizzmtH57PSSbIq8IESzojLIFGRD4gpAh6a G1hDB6NT0gr1OIeNnsxwECmDHrfSqOekMkAe4vgxkJ+YyPZr6X6aYE1r9KQD0VNAWfCgA5hKIpBi fGB17XL1NaJTMiDGarnfVbY+yCQHgbFXG9Yr39Fq4trt6rh2k96zN66zQCrznuptWUQovdU3kQ5s FmGF/5T7u6w/CLqXMRe/bX9zydB+kexqQYfSzb6ZpdBKPseNvI08UBHxE22KBOhC3I0eBLa7OfF1 cYHTPyDydQ0ixe1LXNePgeRnctL/+j97T3SiE53oRCc60YlOdKITnehEJzrR/yX9B9hnIGAAKAAA 67271 2010-09-10 17:18:12 -0700 2010-09-30 17:21:22 -0700 Fixed bug 26019 Bug26019.patch text/plain 5485 dinesh.garg ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBiZmFhNGZhLi5kMjVkODAwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDkt MTAgIERpbmVzaCBLIEdhcmcgIDxkaW5lc2hnQGNvZGVhdXJvcmEub3JnPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5ldyB0ZXN0IGNhc2UgZm9yIEJ1 Z0lkIC0gMjYwMTk6CisgICAgICAgIGJlZ2luRWxlbWVudCBicm9rZW4gYnkgc2V0QXR0cmlidXRl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNjAxOQor CisgICAgICAgICogc3ZnL2FuaW1hdGlvbnMvYW5pbWF0ZS1iZWdpbkVsZW1lbnRBdC1leHBlY3Rl ZC50eHQ6IEFkZGVkLgorICAgICAgICAqIHN2Zy9hbmltYXRpb25zL2FuaW1hdGUtYmVnaW5FbGVt ZW50QXQuc3ZnOiBBZGRlZC4KKwogMjAxMC0wOS0xMCAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Vi a2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbnRvbmlvIEdvbWVzLgpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvc3ZnL2FuaW1hdGlvbnMvYW5pbWF0ZS1iZWdpbkVsZW1lbnRBdC1leHBl Y3RlZC50eHQgYi9MYXlvdXRUZXN0cy9zdmcvYW5pbWF0aW9ucy9hbmltYXRlLWJlZ2luRWxlbWVu dEF0LWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi40ODll MDU0Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvc3ZnL2FuaW1hdGlvbnMvYW5pbWF0 ZS1iZWdpbkVsZW1lbnRBdC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwyIEBACitUaGlzIHRlc3Qg dmVyaWZpZXMgdGhlIGFuaW1hdGlvbiBiZWhhdmlvdXIgb2YgYmVnaW5FbGVtZW50IGluIFNWRy4g QnVnSWQtMjYwMTkKK1Bhc3NlZApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvc3ZnL2FuaW1hdGlv bnMvYW5pbWF0ZS1iZWdpbkVsZW1lbnRBdC5zdmcgYi9MYXlvdXRUZXN0cy9zdmcvYW5pbWF0aW9u cy9hbmltYXRlLWJlZ2luRWxlbWVudEF0LnN2ZwpuZXcgZmlsZSBtb2RlIDEwMDc1NQppbmRleCAw MDAwMDAwLi42ODVkMmQyCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvc3ZnL2FuaW1h dGlvbnMvYW5pbWF0ZS1iZWdpbkVsZW1lbnRBdC5zdmcKQEAgLTAsMCArMSw1NiBAQAorPD94bWwg dmVyc2lvbj0iMS4wIiBlbmNvZGluZz0idXRmLTgiIHN0YW5kYWxvbmU9Im5vIj8+Cis8c3ZnCisg ICB4bWxuczp4bGluaz0iaHR0cDovL3d3dy53My5vcmcvMTk5OS94bGluayIKK3dpZHRoPScxMDAl JyBoZWlnaHQ9JzEwMCUnIHhtbG5zPSdodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZycgPgorICAg PHRpdGxlPkFuaW1hdGVkIFZhbHVlcyBUZXN0PC90aXRsZT4KKworPGNpcmNsZSBjeD0nMCcgY3k9 JzUwJyByPScyMCcgc3R5bGU9J2ZpbGw6b3JhbmdlOyAnIGlkPSd0ZXN0Q2lyY2xlJz4KKyAgIDxh bmltYXRlIGF0dHJpYnV0ZU5hbWU9J2N4JyBhdHRyaWJ1dGVUeXBlPSdYTUwnIGJlZ2luPSdpbmRl ZmluaXRlJyBlbmQ9J2luZGVmaW5pdGUnIGR1cj0nMTBzJyByZXBlYXRDb3VudD0naW5kZWZpbml0 ZScgZnJvbT0iMTAiIHRvPSIyMDAiICBpZD0nZFRyaXBwZXInIGZpbGw9ImZyZWV6ZSIgLz4KKzwv Y2lyY2xlPgorCis8dGV4dCB5PSIxMzAiIHg9IjIwIiBpZD0iZXhwZWN0ZWRSZXN1bHQiPlRoaXMg dGVzdCB2ZXJpZmllcyB0aGUgYW5pbWF0aW9uIGJlaGF2aW91ciBvZiBiZWdpbkVsZW1lbnQgaW4g U1ZHLiBCdWdJZC0yNjAxOTwvdGV4dD4KKworPHRleHQgeT0iMTUwIiB4PSIyMCIgaWQ9ImNvbnNv bGUiLz4KKworPHNjcmlwdD48IVtDREFUQVsKKworICAgdmFyIGFuaW1hdGVkRWxlbWVudDsKKyAg IGFuaW1hdGVkRWxlbWVudCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJkVHJpcHBlciIpOwor ICAgYW5pbWF0ZWRFbGVtZW50LnNldEF0dHJpYnV0ZSgidG8iLCA0MjApOworICAgYW5pbWF0ZWRF bGVtZW50LmJlZ2luRWxlbWVudCgpOworICAgc2V0VGltZW91dChiZWdpbkVsZW1lbnQsMTAwKTsK KworICAgZnVuY3Rpb24gc3RvcENpcmNsZShldnQpCisgICB7CisgICAgICAgIGFuaW1hdGVkRWxl bWVudC5lbmRFbGVtZW50KCk7CisgICB9CisKKyAgIGZ1bmN0aW9uIGJlZ2luRWxlbWVudCgpCisg ICB7CisgICAgICAgIGFuaW1hdGVkRWxlbWVudC5zZXRBdHRyaWJ1dGUoInRvIiwgNDIwKTsKKyAg ICAgICAgYW5pbWF0ZWRFbGVtZW50LmJlZ2luRWxlbWVudCgpOworICAgICAgICBzZXRUaW1lb3V0 KGR1bXBSZXN1bHQsMTAwKTsKKyAgIH0KKworICAgZnVuY3Rpb24gZHVtcFJlc3VsdCgpCisgICB7 CisgICAgICAgIHZhciB0ZXN0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImNvbnNvbGUiKTsK KyAgICAgICAgaWYoZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRlc3RDaXJjbGUiKS5nZXRBdHRy aWJ1dGUoImN4IikgPCAxMSApCisgICAgICAgICAgICB0ZXN0LmFwcGVuZENoaWxkKGRvY3VtZW50 LmNyZWF0ZVRleHROb2RlKCJGYWlsZWQiKSk7CisgICAgICAgIGVsc2UKKyAgICAgICAgICAgIHRl c3QuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUoIlBhc3NlZCIpKTsKKyAgICAg ICAgc3RvcENpcmNsZSgpOworICAgICAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVy KQorICAgICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9uZSgpOworCisgICB9 CisKKyAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICB7CisgICAgICAgIGxh eW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKyAgICAgICAgbGF5b3V0VGVzdENvbnRy b2xsZXIud2FpdFVudGlsRG9uZSgpOworICAgfQorCitdXT48L3NjcmlwdD4KKworPC9zdmc+CmRp ZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDA3 ZjIzY2EuLjYxNDRkYWUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNv cmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTAtMDktMTAgIERpbmVzaCBLIEdhcmcg IDxkaW5lc2hnQGNvZGVhdXJvcmEub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIGJlZ2luRWxlbWVudCBicm9rZW4gYnkgc2V0QXR0cmlidXRlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNjAxOQorICAg ICAgICBJbml0aWFsaXplZCBhbmltYXRpb24gZWxlbWVudCBzdGF0ZSBpbiBiZWdpbkVsZW1lbnRB dAorCisgICAgICAgIFRlc3RzOiBzdmcvYW5pbWF0aW9ucy9hbmltYXRlLWJlZ2luRWxlbWVudEF0 LnN2ZworCisgICAgICAgICogc3ZnL1NWR0FuaW1hdGlvbkVsZW1lbnQuY3BwOgorICAgICAgICAo V2ViQ29yZTo6U1ZHQW5pbWF0aW9uRWxlbWVudDo6YmVnaW5FbGVtZW50QXQpOgorICAgICAgICAo V2ViQ29yZTo6U1ZHQW5pbWF0aW9uRWxlbWVudDo6dXBkYXRlQW5pbWF0aW9uKToKKyAgICAgICAg KiBzdmcvYW5pbWF0aW9uL1NWR1NNSUxFbGVtZW50Lmg6CisgICAgICAgIChXZWJDb3JlOjpTVkdT TUlMRWxlbWVudDo6c2V0QWN0aXZlU3RhdGUpOgorCiAyMDEwLTA5LTEwICBSeW9zdWtlIE5pd2Eg IDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFudG9uaW8gR29tZXMu CmRpZmYgLS1naXQgYS9XZWJDb3JlL3N2Zy9TVkdBbmltYXRpb25FbGVtZW50LmNwcCBiL1dlYkNv cmUvc3ZnL1NWR0FuaW1hdGlvbkVsZW1lbnQuY3BwCmluZGV4IGI1ZWFhZmMuLjI3MGZiYmQgMTAw NjQ0Ci0tLSBhL1dlYkNvcmUvc3ZnL1NWR0FuaW1hdGlvbkVsZW1lbnQuY3BwCisrKyBiL1dlYkNv cmUvc3ZnL1NWR0FuaW1hdGlvbkVsZW1lbnQuY3BwCkBAIC0xNTksNiArMTU5LDggQEAgdm9pZCBT VkdBbmltYXRpb25FbGVtZW50OjphdHRyaWJ1dGVDaGFuZ2VkKEF0dHJpYnV0ZSogYXR0ciwgYm9v bCBwcmVzZXJ2ZURlY2xzKQogewogICAgIC8vIEFzc3VtcHRpb25zIG1heSBub3QgaG9sZCBhZnRl ciBhbiBhdHRyaWJ1dGUgY2hhbmdlLgogICAgIG1fYW5pbWF0aW9uVmFsaWQgPSBmYWxzZTsKKyAg ICAvLyBSZXNldCB0aGUgYW5pbWF0aW9uIHRvIEluQWN0aXZlIHN0YXRlIGFzIHdlbGwuCisgICAg c2V0SW5hY3RpdmUoKTsKICAgICBTVkdTTUlMRWxlbWVudDo6YXR0cmlidXRlQ2hhbmdlZChhdHRy LCBwcmVzZXJ2ZURlY2xzKTsKIH0KIApAQCAtNTU2LDcgKzU1OCw3IEBAIHZvaWQgU1ZHQW5pbWF0 aW9uRWxlbWVudDo6dXBkYXRlQW5pbWF0aW9uKGZsb2F0IHBlcmNlbnQsIHVuc2lnbmVkIHJlcGVh dCwgU1ZHU01JCiB7ICAgIAogICAgIGlmICghbV9hbmltYXRpb25WYWxpZCkKICAgICAgICAgcmV0 dXJuOwotICAgIAorCiAgICAgZmxvYXQgZWZmZWN0aXZlUGVyY2VudDsKICAgICBpZiAoYW5pbWF0 aW9uTW9kZSgpID09IFZhbHVlc0FuaW1hdGlvbikgewogICAgICAgICBTdHJpbmcgZnJvbTsKZGlm ZiAtLWdpdCBhL1dlYkNvcmUvc3ZnL2FuaW1hdGlvbi9TVkdTTUlMRWxlbWVudC5oIGIvV2ViQ29y ZS9zdmcvYW5pbWF0aW9uL1NWR1NNSUxFbGVtZW50LmgKaW5kZXggZWQ4YmJmOC4uNzNhOGY5ZCAx MDA2NDQKLS0tIGEvV2ViQ29yZS9zdmcvYW5pbWF0aW9uL1NWR1NNSUxFbGVtZW50LmgKKysrIGIv V2ViQ29yZS9zdmcvYW5pbWF0aW9uL1NWR1NNSUxFbGVtZW50LmgKQEAgLTg4LDcgKzg4LDcgQEAg bmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICBib29sIGlzQ29udHJpYnV0aW5nKFNNSUxUaW1l IGVsYXBzZWQpIGNvbnN0OwogICAgICAgICBib29sIGlzSW5hY3RpdmUoKSBjb25zdDsKICAgICAg ICAgYm9vbCBpc0Zyb3plbigpIGNvbnN0OwotICAgICAgICAKKwogICAgICAgICB1bnNpZ25lZCBk b2N1bWVudE9yZGVySW5kZXgoKSBjb25zdCB7IHJldHVybiBtX2RvY3VtZW50T3JkZXJJbmRleDsg fQogICAgICAgICB2b2lkIHNldERvY3VtZW50T3JkZXJJbmRleCh1bnNpZ25lZCBpbmRleCkgeyBt X2RvY3VtZW50T3JkZXJJbmRleCA9IGluZGV4OyB9CiAgICAgICAgIApAQCAtOTksNyArOTksOCBA QCBuYW1lc3BhY2UgV2ViQ29yZSB7CiBwcm90ZWN0ZWQ6CiAgICAgICAgIHZvaWQgYWRkQmVnaW5U aW1lKFNNSUxUaW1lIHRpbWUpOwogICAgICAgICB2b2lkIGFkZEVuZFRpbWUoU01JTFRpbWUgdGlt ZSk7Ci0gICAgICAgIAorICAgICAgICB2b2lkIHNldEluYWN0aXZlKCkgeyBtX2FjdGl2ZVN0YXRl ID0gSW5hY3RpdmU7IH0KKwogcHJpdmF0ZToKICAgICAgICAgdmlydHVhbCB2b2lkIHN0YXJ0ZWRB Y3RpdmVJbnRlcnZhbCgpID0gMDsKICAgICAgICAgdmlydHVhbCB2b2lkIHVwZGF0ZUFuaW1hdGlv bihmbG9hdCBwZXJjZW50LCB1bnNpZ25lZCByZXBlYXQsIFNWR1NNSUxFbGVtZW50KiByZXN1bHRF bGVtZW50KSA9IDA7Cg== 69401 2010-09-30 17:21:22 -0700 2011-04-12 15:01:29 -0700 Propose fix after review comments 26019.patch text/plain 5677 dinesh.garg ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA1Mzg3Mzg5Li41YTQ0MTljIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDkt MzAgIERpbmVzaCBLIEdhcmcgIDxkaW5lc2hnQGNvZGVhdXJvcmEub3JnPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGJlZ2luRWxlbWVudCBicm9rZW4g Ynkgc2V0QXR0cmlidXRlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yNjAxOQorCisgICAgICAgICogc3ZnL2FuaW1hdGlvbnMvYW5pbWF0ZS1iZWdpbkVs ZW1lbnRBdC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIHN2Zy9hbmltYXRpb25zL2Fu aW1hdGUtYmVnaW5FbGVtZW50QXQuc3ZnOiBBZGRlZC4KKwogMjAxMC0wOS0xMyAgUGF2ZWwgUG9k aXZpbG92ICA8cG9kaXZpbG92QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBQ YXZlbCBGZWxkbWFuLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvc3ZnL2FuaW1hdGlvbnMvYW5p bWF0ZS1iZWdpbkVsZW1lbnRBdC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9zdmcvYW5pbWF0 aW9ucy9hbmltYXRlLWJlZ2luRWxlbWVudEF0LWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEw MDY0NAppbmRleCAwMDAwMDAwLi40ODllMDU0Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVz dHMvc3ZnL2FuaW1hdGlvbnMvYW5pbWF0ZS1iZWdpbkVsZW1lbnRBdC1leHBlY3RlZC50eHQKQEAg LTAsMCArMSwyIEBACitUaGlzIHRlc3QgdmVyaWZpZXMgdGhlIGFuaW1hdGlvbiBiZWhhdmlvdXIg b2YgYmVnaW5FbGVtZW50IGluIFNWRy4gQnVnSWQtMjYwMTkKK1Bhc3NlZApkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvc3ZnL2FuaW1hdGlvbnMvYW5pbWF0ZS1iZWdpbkVsZW1lbnRBdC5zdmcgYi9M YXlvdXRUZXN0cy9zdmcvYW5pbWF0aW9ucy9hbmltYXRlLWJlZ2luRWxlbWVudEF0LnN2ZwpuZXcg ZmlsZSBtb2RlIDEwMDc1NQppbmRleCAwMDAwMDAwLi40NWZiZWUzCi0tLSAvZGV2L251bGwKKysr IGIvTGF5b3V0VGVzdHMvc3ZnL2FuaW1hdGlvbnMvYW5pbWF0ZS1iZWdpbkVsZW1lbnRBdC5zdmcK QEAgLTAsMCArMSw1NSBAQAorPD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0idXRmLTgiIHN0 YW5kYWxvbmU9Im5vIj8+Cis8c3ZnCisgICB4bWxuczp4bGluaz0iaHR0cDovL3d3dy53My5vcmcv MTk5OS94bGluayIKK3dpZHRoPScxMDAlJyBoZWlnaHQ9JzEwMCUnIHhtbG5zPSdodHRwOi8vd3d3 LnczLm9yZy8yMDAwL3N2ZycgPgorICAgPHRpdGxlPkFuaW1hdGVkIFZhbHVlcyBUZXN0PC90aXRs ZT4KKworPGNpcmNsZSBjeD0nMCcgY3k9JzUwJyByPScyMCcgc3R5bGU9J2ZpbGw6b3JhbmdlOyAn IGlkPSd0ZXN0Q2lyY2xlJz4KKyAgIDxhbmltYXRlIGF0dHJpYnV0ZU5hbWU9J2N4JyBhdHRyaWJ1 dGVUeXBlPSdYTUwnIGJlZ2luPSdpbmRlZmluaXRlJyBlbmQ9J2luZGVmaW5pdGUnIGR1cj0nMTBz JyByZXBlYXRDb3VudD0naW5kZWZpbml0ZScgZnJvbT0iMTAiIHRvPSIyMDAiICBpZD0nZFRyaXBw ZXInIGZpbGw9ImZyZWV6ZSIgLz4KKzwvY2lyY2xlPgorCis8dGV4dCB5PSIxMzAiIHg9IjIwIiBp ZD0iZXhwZWN0ZWRSZXN1bHQiPlRoaXMgdGVzdCB2ZXJpZmllcyB0aGUgYW5pbWF0aW9uIGJlaGF2 aW91ciBvZiBiZWdpbkVsZW1lbnQgaW4gU1ZHLiBCdWdJZC0yNjAxOTwvdGV4dD4KKworPHRleHQg eT0iMTUwIiB4PSIyMCIgaWQ9ImNvbnNvbGUiLz4KKworPHNjcmlwdD48IVtDREFUQVsKKworICAg dmFyIGFuaW1hdGVkRWxlbWVudDsKKyAgIGFuaW1hdGVkRWxlbWVudCA9IGRvY3VtZW50LmdldEVs ZW1lbnRCeUlkKCJkVHJpcHBlciIpOworICAgYW5pbWF0ZWRFbGVtZW50LmJlZ2luRWxlbWVudCgp OworICAgc2V0VGltZW91dChiZWdpbkVsZW1lbnQsMTAwKTsKKworICAgZnVuY3Rpb24gc3RvcENp cmNsZShldnQpCisgICB7CisgICAgICAgIGFuaW1hdGVkRWxlbWVudC5lbmRFbGVtZW50KCk7Cisg ICB9CisKKyAgIGZ1bmN0aW9uIGJlZ2luRWxlbWVudCgpCisgICB7CisgICAgICAgIGFuaW1hdGVk RWxlbWVudC5zZXRBdHRyaWJ1dGUoInRvIiwgNDIwKTsKKyAgICAgICAgYW5pbWF0ZWRFbGVtZW50 LmJlZ2luRWxlbWVudCgpOworICAgICAgICBzZXRUaW1lb3V0KGR1bXBSZXN1bHQsMTAwKTsKKyAg IH0KKworICAgZnVuY3Rpb24gZHVtcFJlc3VsdCgpCisgICB7CisgICAgICAgIHZhciB0ZXN0ID0g ZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImNvbnNvbGUiKTsKKyAgICAgICAgaWYoZG9jdW1lbnQu Z2V0RWxlbWVudEJ5SWQoInRlc3RDaXJjbGUiKS5nZXRBdHRyaWJ1dGUoImN4IikgPCAxMSApCisg ICAgICAgICAgICB0ZXN0LmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZVRleHROb2RlKCJGYWls ZWQiKSk7CisgICAgICAgIGVsc2UKKyAgICAgICAgICAgIHRlc3QuYXBwZW5kQ2hpbGQoZG9jdW1l bnQuY3JlYXRlVGV4dE5vZGUoIlBhc3NlZCIpKTsKKyAgICAgICAgc3RvcENpcmNsZSgpOworICAg ICAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgICAgICAgICAgbGF5b3V0 VGVzdENvbnRyb2xsZXIubm90aWZ5RG9uZSgpOworCisgICB9CisKKyAgIGlmICh3aW5kb3cubGF5 b3V0VGVzdENvbnRyb2xsZXIpCisgICB7CisgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1 bXBBc1RleHQoKTsKKyAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIud2FpdFVudGlsRG9uZSgp OworICAgfQorCitdXT48L3NjcmlwdD4KKworPC9zdmc+CmRpZmYgLS1naXQgYS9XZWJDb3JlL0No YW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGM2N2JjMmUuLjcyZWY5ODAgMTAwNjQ0 Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMjMgQEAKKzIwMTAtMDktMzAgIERpbmVzaCBLIEdhcmcgIDxkaW5lc2hnQGNvZGVhdXJvcmEu b3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGJl Z2luRWxlbWVudCBicm9rZW4gYnkgc2V0QXR0cmlidXRlCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNjAxOQorCisgICAgICAgIFNldEF0dHJpYnV0ZSBy ZXNldCBhbmltYXRpb24gc3RhdGUgYW5kIG5vdCB0aGUgYWN0aXZlU3RhdGUuCisgICAgICAgIFRo aXMgd2FzIGJyZWFraW5nIHRoZSBhbmltYXRpb24gd2hlbiBiZWdpbkVsZW1lbnQgd2FzIGNhbGxl ZAorICAgICAgICB0aGUgc2Vjb25kIHRpbWUuIAorICAgICAgICBJbml0aWFsaXplZCBhbmltYXRp b24gZWxlbWVudCdzIGFjdGl2ZVN0YXRlIGluIGJlZ2luRWxlbWVudEF0LgorCisgICAgICAgIFRl c3RzOiBzdmcvYW5pbWF0aW9ucy9hbmltYXRlLWJlZ2luRWxlbWVudEF0LnN2ZworCisgICAgICAg ICogc3ZnL1NWR0FuaW1hdGlvbkVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U1ZHQW5p bWF0aW9uRWxlbWVudDo6YmVnaW5FbGVtZW50QXQpOgorICAgICAgICAoV2ViQ29yZTo6U1ZHQW5p bWF0aW9uRWxlbWVudDo6dXBkYXRlQW5pbWF0aW9uKToKKyAgICAgICAgKiBzdmcvYW5pbWF0aW9u L1NWR1NNSUxFbGVtZW50Lmg6CisgICAgICAgIChXZWJDb3JlOjpTVkdTTUlMRWxlbWVudDo6c2V0 QWN0aXZlU3RhdGUpOgorCiAyMDEwLTA5LTEzICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bXNhbmNo ZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYXJ0aW4gUm9iaW5zb24uCmRp ZmYgLS1naXQgYS9XZWJDb3JlL3N2Zy9TVkdBbmltYXRpb25FbGVtZW50LmNwcCBiL1dlYkNvcmUv c3ZnL1NWR0FuaW1hdGlvbkVsZW1lbnQuY3BwCmluZGV4IGI1ZWFhZmMuLmNkZjJkOWYgMTAwNjQ0 Ci0tLSBhL1dlYkNvcmUvc3ZnL1NWR0FuaW1hdGlvbkVsZW1lbnQuY3BwCisrKyBiL1dlYkNvcmUv c3ZnL1NWR0FuaW1hdGlvbkVsZW1lbnQuY3BwCkBAIC01LDYgKzUsNyBAQAogICogQ29weXJpZ2h0 IChDKSAyMDA4IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqIENvcHlyaWdodCAo QykgMjAwOSBDYW1lcm9uIE1jQ29ybWFjayA8Y2FtQG1jYy5pZC5hdT4KICAqIENvcHlyaWdodCAo QykgUmVzZWFyY2ggSW4gTW90aW9uIExpbWl0ZWQgMjAxMC4gQWxsIHJpZ2h0cyByZXNlcnZlZC4K KyAqIENvcHlyaWdodCAoYykgMjAxMCwgQ29kZSBBdXJvcmEgRm9ydW0uIEFsbCByaWdodHMgcmVz ZXJ2ZWQuCiAgKgogICogVGhpcyBsaWJyYXJ5IGlzIGZyZWUgc29mdHdhcmU7IHlvdSBjYW4gcmVk aXN0cmlidXRlIGl0IGFuZC9vcgogICogbW9kaWZ5IGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUg R05VIExpYnJhcnkgR2VuZXJhbCBQdWJsaWMKQEAgLTE1OSw2ICsxNjAsOCBAQCB2b2lkIFNWR0Fu aW1hdGlvbkVsZW1lbnQ6OmF0dHJpYnV0ZUNoYW5nZWQoQXR0cmlidXRlKiBhdHRyLCBib29sIHBy ZXNlcnZlRGVjbHMpCiB7CiAgICAgLy8gQXNzdW1wdGlvbnMgbWF5IG5vdCBob2xkIGFmdGVyIGFu IGF0dHJpYnV0ZSBjaGFuZ2UuCiAgICAgbV9hbmltYXRpb25WYWxpZCA9IGZhbHNlOworICAgIC8v IFJlc2V0IHRoZSBhbmltYXRpb24gdG8gSW5BY3RpdmUgc3RhdGUgYXMgd2VsbC4KKyAgICBzZXRJ bmFjdGl2ZSgpOwogICAgIFNWR1NNSUxFbGVtZW50OjphdHRyaWJ1dGVDaGFuZ2VkKGF0dHIsIHBy ZXNlcnZlRGVjbHMpOwogfQogCmRpZmYgLS1naXQgYS9XZWJDb3JlL3N2Zy9hbmltYXRpb24vU1ZH U01JTEVsZW1lbnQuaCBiL1dlYkNvcmUvc3ZnL2FuaW1hdGlvbi9TVkdTTUlMRWxlbWVudC5oCmlu ZGV4IGVkOGJiZjguLjgyZDEwZjggMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvc3ZnL2FuaW1hdGlvbi9T VkdTTUlMRWxlbWVudC5oCisrKyBiL1dlYkNvcmUvc3ZnL2FuaW1hdGlvbi9TVkdTTUlMRWxlbWVu dC5oCkBAIC0xLDUgKzEsNiBAQAogLyoKICAqIENvcHlyaWdodCAoQykgMjAwOCBBcHBsZSBJbmMu IEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKiBDb3B5cmlnaHQgKGMpIDIwMTAsIENvZGUgQXVyb3Jh IEZvcnVtLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1 c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogICogbW9kaWZp Y2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRp b25zCkBAIC05OSw3ICsxMDAsOCBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiBwcm90ZWN0ZWQ6CiAg ICAgICAgIHZvaWQgYWRkQmVnaW5UaW1lKFNNSUxUaW1lIHRpbWUpOwogICAgICAgICB2b2lkIGFk ZEVuZFRpbWUoU01JTFRpbWUgdGltZSk7Ci0gICAgICAgIAorICAgICAgICB2b2lkIHNldEluYWN0 aXZlKCkgeyBtX2FjdGl2ZVN0YXRlID0gSW5hY3RpdmU7IH0KKwogcHJpdmF0ZToKICAgICAgICAg dmlydHVhbCB2b2lkIHN0YXJ0ZWRBY3RpdmVJbnRlcnZhbCgpID0gMDsKICAgICAgICAgdmlydHVh bCB2b2lkIHVwZGF0ZUFuaW1hdGlvbihmbG9hdCBwZXJjZW50LCB1bnNpZ25lZCByZXBlYXQsIFNW R1NNSUxFbGVtZW50KiByZXN1bHRFbGVtZW50KSA9IDA7Cg== 89279 2011-04-12 15:01:29 -0700 2011-04-19 14:46:00 -0700 Updated patch - addressing Chris' comments. bug26019-beginElement-broken-setAttribute-updated-1.diff text/plain 5745 jchaffraix ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBjZTUwNTU2Li44ZDdlOTFkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDQt MTIgIERpbmVzaCBLIEdhcmcgIDxkaW5lc2hnQGNvZGVhdXJvcmEub3JnPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3QgY2FzZSBmb3I6IGJlZ2lu RWxlbWVudCBicm9rZW4gYnkgc2V0QXR0cmlidXRlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNjAxOQorCisgICAgICAgICogc3ZnL2FuaW1hdGlvbnMv YW5pbWF0ZS1iZWdpbkVsZW1lbnRBdC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIHN2 Zy9hbmltYXRpb25zL2FuaW1hdGUtYmVnaW5FbGVtZW50QXQuc3ZnOiBBZGRlZC4KKyAgICAgICAg KiBzdmcvYW5pbWF0aW9ucy9hbmltYXRlLWR5bmFtaWMtdXBkYXRlLWF0dHJpYnV0ZU5hbWUtZXhw ZWN0ZWQudHh0OgorICAgICAgICBOaWNlIHNpZGUgZWZmZWN0IG9mIHRoZSBwYXRjaCwgd2UgYXJl IG5vdyBmdWxseSBwYXNzaW5nIHRoaXMgdGVzdC4KKwogMjAxMS0wNC0xMSAgQWJoaXNoZWsgQXJ5 YSAgPGluZmVybm9AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhdmUgSHlh dHQuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9zdmcvYW5pbWF0aW9ucy9hbmltYXRlLWJlZ2lu RWxlbWVudEF0LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3N2Zy9hbmltYXRpb25zL2FuaW1h dGUtYmVnaW5FbGVtZW50QXQtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAuLmJhNzJlYjIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9zdmcvYW5p bWF0aW9ucy9hbmltYXRlLWJlZ2luRWxlbWVudEF0LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDIg QEAKK1RoaXMgdGVzdCB2ZXJpZmllcyB0aGUgYW5pbWF0aW9uIGJlaGF2aW91ciBvZiBiZWdpbkVs ZW1lbnQgaW4gU1ZHLiBTZWUgYnVnIDI2MDE5CitQYXNzZWQKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL3N2Zy9hbmltYXRpb25zL2FuaW1hdGUtYmVnaW5FbGVtZW50QXQuc3ZnIGIvTGF5b3V0VGVz dHMvc3ZnL2FuaW1hdGlvbnMvYW5pbWF0ZS1iZWdpbkVsZW1lbnRBdC5zdmcKbmV3IGZpbGUgbW9k ZSAxMDA3NTUKaW5kZXggMDAwMDAwMC4uZWIzNjlhYgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91 dFRlc3RzL3N2Zy9hbmltYXRpb25zL2FuaW1hdGUtYmVnaW5FbGVtZW50QXQuc3ZnCkBAIC0wLDAg KzEsNTUgQEAKKzw/eG1sIHZlcnNpb249IjEuMCIgZW5jb2Rpbmc9InV0Zi04IiBzdGFuZGFsb25l PSJubyI/PgorPHN2ZworICAgeG1sbnM6eGxpbms9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkveGxp bmsiCit3aWR0aD0nMTAwJScgaGVpZ2h0PScxMDAlJyB4bWxucz0naHR0cDovL3d3dy53My5vcmcv MjAwMC9zdmcnID4KKyAgIDx0aXRsZT5BbmltYXRlZCBWYWx1ZXMgVGVzdDwvdGl0bGU+CisKKzxj aXJjbGUgY3g9JzAnIGN5PSc1MCcgcj0nMjAnIHN0eWxlPSdmaWxsOm9yYW5nZTsgJyBpZD0ndGVz dENpcmNsZSc+CisgICA8YW5pbWF0ZSBhdHRyaWJ1dGVOYW1lPSdjeCcgYXR0cmlidXRlVHlwZT0n WE1MJyBiZWdpbj0naW5kZWZpbml0ZScgZW5kPSdpbmRlZmluaXRlJyBkdXI9JzEwcycgcmVwZWF0 Q291bnQ9J2luZGVmaW5pdGUnIGZyb209IjEwIiB0bz0iMjAwIiAgaWQ9J2RUcmlwcGVyJyBmaWxs PSJmcmVlemUiIC8+Cis8L2NpcmNsZT4KKworPHRleHQgeT0iMTMwIiB4PSIyMCIgaWQ9ImV4cGVj dGVkUmVzdWx0Ij5UaGlzIHRlc3QgdmVyaWZpZXMgdGhlIGFuaW1hdGlvbiBiZWhhdmlvdXIgb2Yg YmVnaW5FbGVtZW50IGluIFNWRy4gU2VlIDxhIGhyZWY9Imh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yNjAxOSI+YnVnIDI2MDE5PC9hPjwvdGV4dD4KKworPHRleHQgeT0i MTUwIiB4PSIyMCIgaWQ9ImNvbnNvbGUiLz4KKworPHNjcmlwdD48IVtDREFUQVsKKworICAgdmFy IGFuaW1hdGVkRWxlbWVudDsKKyAgIGFuaW1hdGVkRWxlbWVudCA9IGRvY3VtZW50LmdldEVsZW1l bnRCeUlkKCJkVHJpcHBlciIpOworICAgYW5pbWF0ZWRFbGVtZW50LnNldEF0dHJpYnV0ZSgidG8i LCA0MjApOworICAgYW5pbWF0ZWRFbGVtZW50LmJlZ2luRWxlbWVudCgpOworICAgc2V0VGltZW91 dChiZWdpbkVsZW1lbnQsMTAwKTsKKworICAgZnVuY3Rpb24gc3RvcENpcmNsZShldnQpCisgICB7 CisgICAgICAgIGFuaW1hdGVkRWxlbWVudC5lbmRFbGVtZW50KCk7CisgICB9CisKKyAgIGZ1bmN0 aW9uIGJlZ2luRWxlbWVudCgpCisgICB7CisgICAgICAgIGFuaW1hdGVkRWxlbWVudC5zZXRBdHRy aWJ1dGUoInRvIiwgNDIwKTsKKyAgICAgICAgYW5pbWF0ZWRFbGVtZW50LmJlZ2luRWxlbWVudCgp OworICAgICAgICBzZXRUaW1lb3V0KGR1bXBSZXN1bHQsMTAwKTsKKyAgIH0KKworICAgZnVuY3Rp b24gZHVtcFJlc3VsdCgpCisgICB7CisgICAgICAgIHZhciB0ZXN0ID0gZG9jdW1lbnQuZ2V0RWxl bWVudEJ5SWQoImNvbnNvbGUiKTsKKyAgICAgICAgaWYoZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo InRlc3RDaXJjbGUiKS5nZXRBdHRyaWJ1dGUoImN4IikgPCAxMSApCisgICAgICAgICAgICB0ZXN0 LmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZVRleHROb2RlKCJGYWlsZWQiKSk7CisgICAgICAg IGVsc2UKKyAgICAgICAgICAgIHRlc3QuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlVGV4dE5v ZGUoIlBhc3NlZCIpKTsKKyAgICAgICAgc3RvcENpcmNsZSgpOworICAgICAgICBpZiAod2luZG93 LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIu bm90aWZ5RG9uZSgpOworCisgICB9CisKKyAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xs ZXIpIHsKKyAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworICAgICAg ICBsYXlvdXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7CisgICB9CisKK11dPjwvc2Ny aXB0PgorCis8L3N2Zz4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3N2Zy9hbmltYXRpb25zL2Fu aW1hdGUtZHluYW1pYy11cGRhdGUtYXR0cmlidXRlTmFtZS1leHBlY3RlZC50eHQgYi9MYXlvdXRU ZXN0cy9zdmcvYW5pbWF0aW9ucy9hbmltYXRlLWR5bmFtaWMtdXBkYXRlLWF0dHJpYnV0ZU5hbWUt ZXhwZWN0ZWQudHh0CmluZGV4IDNmNzIyYWEuLjg4NjVjZWEgMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL3N2Zy9hbmltYXRpb25zL2FuaW1hdGUtZHluYW1pYy11cGRhdGUtYXR0cmlidXRlTmFtZS1l eHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvc3ZnL2FuaW1hdGlvbnMvYW5pbWF0ZS1keW5h bWljLXVwZGF0ZS1hdHRyaWJ1dGVOYW1lLWV4cGVjdGVkLnR4dApAQCAtNiw3ICs2LDcgQEAgT24g c3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93 ZWQgYnkgIlRFU1QgQ09NUExFVEUKIAogCiBQQVNTIHJlY3Quc3R5bGUuY29sb3IgaXMgJ3JnYigw LCAxMjgsIDApJwotRkFJTCByZWN0LnN0eWxlLmZpbGwgc2hvdWxkIGJlICMwMDgwMDAuIFdhcyAj ZmYwMDAwLgorUEFTUyByZWN0LnN0eWxlLmZpbGwgaXMgJyMwMDgwMDAnCiBQQVNTIHN1Y2Nlc3Nm dWxseVBhcnNlZCBpcyB0cnVlCiAKIFRFU1QgQ09NUExFVEUKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA4MTBkNmNm Li5jMGZiZTNkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDQtMTIgIERpbmVz aCBLIEdhcmcgIDxkaW5lc2hnQGNvZGVhdXJvcmEub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGJlZ2luRWxlbWVudCBicm9rZW4gYnkgc2V0QXR0 cmlidXRlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y NjAxOQorCisgICAgICAgIFRlc3Q6IHN2Zy9hbmltYXRpb25zL2FuaW1hdGUtYmVnaW5FbGVtZW50 QXQuc3ZnCisKKyAgICAgICAgKiBzdmcvU1ZHQW5pbWF0aW9uRWxlbWVudC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpTVkdBbmltYXRpb25FbGVtZW50OjphdHRyaWJ1dGVDaGFuZ2VkKToKKyAgICAg ICAgUmVzZXQgdGhlIGFuaW1hdGlvbiBzdGF0ZSBoZXJlIGFzIHRoZSByZXN0IG9mIHRoZSBjb2Rl IHJlYWRzIGl0IGFuZCB3b3VsZCBzdGlsbAorICAgICAgICB0aGluayB3ZSBhcmUgYW5pbWF0aW5n IHdoZW4gd2UgYXJlIG5vdC4KKworICAgICAgICAqIHN2Zy9hbmltYXRpb24vU1ZHU01JTEVsZW1l bnQuaDoKKyAgICAgICAgKFdlYkNvcmU6OlNWR1NNSUxFbGVtZW50OjpzZXRJbmFjdGl2ZSk6IEhl bHBlciBmdW5jdGlvbiB0byByZXNldCB0aGUgc3RhdGUuCisKIDIwMTEtMDQtMTEgIEFiaGlzaGVr IEFyeWEgIDxpbmZlcm5vQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXZl IEh5YXR0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvc3ZnL1NWR0FuaW1hdGlvbkVsZW1l bnQuY3BwIGIvU291cmNlL1dlYkNvcmUvc3ZnL1NWR0FuaW1hdGlvbkVsZW1lbnQuY3BwCmluZGV4 IDIxNzg0YzIuLjQ2MzQ0OTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdBbmlt YXRpb25FbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHQW5pbWF0aW9uRWxl bWVudC5jcHAKQEAgLTE2MSw2ICsxNjEsNyBAQCB2b2lkIFNWR0FuaW1hdGlvbkVsZW1lbnQ6OmF0 dHJpYnV0ZUNoYW5nZWQoQXR0cmlidXRlKiBhdHRyLCBib29sIHByZXNlcnZlRGVjbHMpCiB7CiAg ICAgLy8gQXNzdW1wdGlvbnMgbWF5IG5vdCBob2xkIGFmdGVyIGFuIGF0dHJpYnV0ZSBjaGFuZ2Uu CiAgICAgbV9hbmltYXRpb25WYWxpZCA9IGZhbHNlOworICAgIHNldEluYWN0aXZlKCk7CiAgICAg U1ZHU01JTEVsZW1lbnQ6OmF0dHJpYnV0ZUNoYW5nZWQoYXR0ciwgcHJlc2VydmVEZWNscyk7CiB9 CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9hbmltYXRpb24vU1ZHU01JTEVsZW1l bnQuaCBiL1NvdXJjZS9XZWJDb3JlL3N2Zy9hbmltYXRpb24vU1ZHU01JTEVsZW1lbnQuaAppbmRl eCAwZjI2ZjI2Li5hZjZkYmZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9zdmcvYW5pbWF0 aW9uL1NWR1NNSUxFbGVtZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvc3ZnL2FuaW1hdGlvbi9T VkdTTUlMRWxlbWVudC5oCkBAIC0xMTEsNiArMTExLDggQEAgcHJvdGVjdGVkOgogICAgIHZvaWQg YWRkQmVnaW5UaW1lKFNNSUxUaW1lKTsKICAgICB2b2lkIGFkZEVuZFRpbWUoU01JTFRpbWUpOwog CisgICAgdm9pZCBzZXRJbmFjdGl2ZSgpIHsgbV9hY3RpdmVTdGF0ZSA9IEluYWN0aXZlOyB9CisK IHByaXZhdGU6CiAgICAgdmlydHVhbCB2b2lkIHN0YXJ0ZWRBY3RpdmVJbnRlcnZhbCgpID0gMDsK ICAgICB2aXJ0dWFsIHZvaWQgdXBkYXRlQW5pbWF0aW9uKGZsb2F0IHBlcmNlbnQsIHVuc2lnbmVk IHJlcGVhdCwgU1ZHU01JTEVsZW1lbnQqIHJlc3VsdEVsZW1lbnQpID0gMDsK 90258 2011-04-19 14:46:00 -0700 2011-04-26 18:28:20 -0700 Updated patch - fixed the test per Nikolas comments bug26019-beginElement-broken-setAttribute-updated-2.diff text/plain 5599 jchaffraix ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA4MWUwYTUxLi5jMWVlYjU4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDQt MTkgIERpbmVzaCBLIEdhcmcgIDxkaW5lc2hnQGNvZGVhdXJvcmEub3JnPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3QgY2FzZSBmb3I6IGJlZ2lu RWxlbWVudCBicm9rZW4gYnkgc2V0QXR0cmlidXRlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNjAxOQorCisgICAgICAgICogc3ZnL2FuaW1hdGlvbnMv YW5pbWF0ZS1iZWdpbkVsZW1lbnRBdC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIHN2 Zy9hbmltYXRpb25zL2FuaW1hdGUtYmVnaW5FbGVtZW50QXQuc3ZnOiBBZGRlZC4KKyAgICAgICAg KiBzdmcvYW5pbWF0aW9ucy9hbmltYXRlLWR5bmFtaWMtdXBkYXRlLWF0dHJpYnV0ZU5hbWUtZXhw ZWN0ZWQudHh0OgorICAgICAgICBOaWNlIHNpZGUgZWZmZWN0IG9mIHRoZSBwYXRjaCwgd2UgYXJl IG5vdyBmdWxseSBwYXNzaW5nIHRoaXMgdGVzdC4KKwogMjAxMS0wNC0xNSAgSmFtZXMgUm9iaW5z b24gIDxqYW1lc3JAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEZpeCBkdXBsaWNhdGUgZXhwZWN0 YXRpb24gZm9yIGNvbXBvc2l0aW5nL3RpbGluZy9odWdlLWxheWVyLWltZy5odG1sIG9uIGNocm9t aXVtIG1hYy4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3N2Zy9hbmltYXRpb25zL2FuaW1hdGUt YmVnaW5FbGVtZW50QXQtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvc3ZnL2FuaW1hdGlvbnMv YW5pbWF0ZS1iZWdpbkVsZW1lbnRBdC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQK aW5kZXggMDAwMDAwMC4uYmE3MmViMgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3N2 Zy9hbmltYXRpb25zL2FuaW1hdGUtYmVnaW5FbGVtZW50QXQtZXhwZWN0ZWQudHh0CkBAIC0wLDAg KzEsMiBAQAorVGhpcyB0ZXN0IHZlcmlmaWVzIHRoZSBhbmltYXRpb24gYmVoYXZpb3VyIG9mIGJl Z2luRWxlbWVudCBpbiBTVkcuIFNlZSBidWcgMjYwMTkKK1Bhc3NlZApkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvc3ZnL2FuaW1hdGlvbnMvYW5pbWF0ZS1iZWdpbkVsZW1lbnRBdC5zdmcgYi9MYXlv dXRUZXN0cy9zdmcvYW5pbWF0aW9ucy9hbmltYXRlLWJlZ2luRWxlbWVudEF0LnN2ZwpuZXcgZmls ZSBtb2RlIDEwMDc1NQppbmRleCAwMDAwMDAwLi5lNWRmZGUxCi0tLSAvZGV2L251bGwKKysrIGIv TGF5b3V0VGVzdHMvc3ZnL2FuaW1hdGlvbnMvYW5pbWF0ZS1iZWdpbkVsZW1lbnRBdC5zdmcKQEAg LTAsMCArMSwzOSBAQAorPD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0idXRmLTgiIHN0YW5k YWxvbmU9Im5vIj8+Cis8c3ZnIHhtbG5zPSdodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2Zyc+Cis8 Y2lyY2xlIGN4PScwJyBjeT0nNTAnIHI9JzIwJyBmaWxsPSdvcmFuZ2UnIGlkPSd0ZXN0Q2lyY2xl Jz4KKyAgIDxhbmltYXRlIGF0dHJpYnV0ZU5hbWU9J2N4JyBhdHRyaWJ1dGVUeXBlPSdYTUwnIGJl Z2luPSdpbmRlZmluaXRlJyBlbmQ9J2luZGVmaW5pdGUnIGR1cj0nMTBzJyByZXBlYXRDb3VudD0n aW5kZWZpbml0ZScgZnJvbT0iMTAiIHRvPSIyMDAiICBpZD0nZFRyaXBwZXInIGZpbGw9ImZyZWV6 ZSIvPgorPC9jaXJjbGU+Cis8dGV4dCB5PSIxMzAiIHg9IjIwIj5UaGlzIHRlc3QgdmVyaWZpZXMg dGhlIGFuaW1hdGlvbiBiZWhhdmlvdXIgb2YgYmVnaW5FbGVtZW50IGluIFNWRy4gU2VlIDxhIGhy ZWY9Imh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNjAxOSI+YnVnIDI2 MDE5PC9hPjwvdGV4dD4KKzx0ZXh0IHk9IjE1MCIgeD0iMjAiIGlkPSJjb25zb2xlIi8+Cis8c2Ny aXB0PjwhW0NEQVRBWworICAgIHZhciBhbmltYXRlZEVsZW1lbnQ7CisgICAgYW5pbWF0ZWRFbGVt ZW50ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImRUcmlwcGVyIik7CisgICAgYW5pbWF0ZWRF bGVtZW50LnNldEF0dHJpYnV0ZSgidG8iLCA0MjApOworICAgIGFuaW1hdGVkRWxlbWVudC5iZWdp bkVsZW1lbnQoKTsKKyAgICBzZXRUaW1lb3V0KGJlZ2luRWxlbWVudCwgMCk7CisKKyAgICBmdW5j dGlvbiBiZWdpbkVsZW1lbnQoKQorICAgIHsKKyAgICAgICAgYW5pbWF0ZWRFbGVtZW50LnNldEF0 dHJpYnV0ZSgidG8iLCA0MjApOworICAgICAgICBhbmltYXRlZEVsZW1lbnQuYmVnaW5FbGVtZW50 KCk7CisgICAgICAgIHNldFRpbWVvdXQoZHVtcFJlc3VsdCwgMCk7CisgICAgfQorCisgICAgZnVu Y3Rpb24gZHVtcFJlc3VsdCgpCisgICAgeworICAgICAgICB2YXIgY29uc29sZSA9IGRvY3VtZW50 LmdldEVsZW1lbnRCeUlkKCJjb25zb2xlIik7CisgICAgICAgIHZhciBjeCA9IGRvY3VtZW50Lmdl dEVsZW1lbnRCeUlkKCJ0ZXN0Q2lyY2xlIikuZ2V0QXR0cmlidXRlKCJjeCIpOworICAgICAgICBp ZiAoY3ggPT09IDApCisgICAgICAgICAgICBjb25zb2xlLmFwcGVuZENoaWxkKGRvY3VtZW50LmNy ZWF0ZVRleHROb2RlKCJGYWlsZWQgKGN4IHdhcyBub3QgYW5pbWF0ZWQpIikpOworICAgICAgICBl bHNlCisgICAgICAgICAgICBjb25zb2xlLmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZVRleHRO b2RlKCJQYXNzZWQiKSk7CisgICAgICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIp CisgICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCk7CisgICAgfQor CisgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgeworICAgICAgICBsYXlvdXRU ZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVy LndhaXRVbnRpbERvbmUoKTsKKyAgICB9CitdXT48L3NjcmlwdD4KKzwvc3ZnPgpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvc3ZnL2FuaW1hdGlvbnMvYW5pbWF0ZS1keW5hbWljLXVwZGF0ZS1hdHRy aWJ1dGVOYW1lLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3N2Zy9hbmltYXRpb25zL2FuaW1h dGUtZHluYW1pYy11cGRhdGUtYXR0cmlidXRlTmFtZS1leHBlY3RlZC50eHQKaW5kZXggM2Y3MjJh YS4uODg2NWNlYSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvc3ZnL2FuaW1hdGlvbnMvYW5pbWF0 ZS1keW5hbWljLXVwZGF0ZS1hdHRyaWJ1dGVOYW1lLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRU ZXN0cy9zdmcvYW5pbWF0aW9ucy9hbmltYXRlLWR5bmFtaWMtdXBkYXRlLWF0dHJpYnV0ZU5hbWUt ZXhwZWN0ZWQudHh0CkBAIC02LDcgKzYsNyBAQCBPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBz ZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURQogCiAK IFBBU1MgcmVjdC5zdHlsZS5jb2xvciBpcyAncmdiKDAsIDEyOCwgMCknCi1GQUlMIHJlY3Quc3R5 bGUuZmlsbCBzaG91bGQgYmUgIzAwODAwMC4gV2FzICNmZjAwMDAuCitQQVNTIHJlY3Quc3R5bGUu ZmlsbCBpcyAnIzAwODAwMCcKIFBBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKIAogVEVT VCBDT01QTEVURQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGRjODRiNjQuLmFkMGE5NDQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwyMCBAQAorMjAxMS0wNC0xOSAgRGluZXNoIEsgR2FyZyAgPGRpbmVzaGdAY29kZWF1 cm9yYS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgYmVnaW5FbGVtZW50IGJyb2tlbiBieSBzZXRBdHRyaWJ1dGUKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI2MDE5CisKKyAgICAgICAgVGVzdDogc3Zn L2FuaW1hdGlvbnMvYW5pbWF0ZS1iZWdpbkVsZW1lbnRBdC5zdmcKKworICAgICAgICAqIHN2Zy9T VkdBbmltYXRpb25FbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNWR0FuaW1hdGlvbkVs ZW1lbnQ6OmF0dHJpYnV0ZUNoYW5nZWQpOgorICAgICAgICBSZXNldCB0aGUgYW5pbWF0aW9uIHN0 YXRlIGhlcmUgYXMgdGhlIHJlc3Qgb2YgdGhlIGNvZGUgcmVhZHMgaXQgYW5kIHdvdWxkIHN0aWxs CisgICAgICAgIHRoaW5rIHdlIGFyZSBhbmltYXRpbmcgd2hlbiB3ZSBhcmUgbm90LgorCisgICAg ICAgICogc3ZnL2FuaW1hdGlvbi9TVkdTTUlMRWxlbWVudC5oOgorICAgICAgICAoV2ViQ29yZTo6 U1ZHU01JTEVsZW1lbnQ6OnNldEluYWN0aXZlKTogSGVscGVyIGZ1bmN0aW9uIHRvIHJlc2V0IHRo ZSBzdGF0ZS4KKwogMjAxMS0wNC0xNSAgTWlrZSBSZWVkICA8cmVlZEBnb29nbGUuY29tPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IERhcmluIEZpc2hlci4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3N2Zy9TVkdBbmltYXRpb25FbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdB bmltYXRpb25FbGVtZW50LmNwcAppbmRleCAyMTc4NGMyLi40NjM0NDkzIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9zdmcvU1ZHQW5pbWF0aW9uRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvc3ZnL1NWR0FuaW1hdGlvbkVsZW1lbnQuY3BwCkBAIC0xNjEsNiArMTYxLDcgQEAgdm9p ZCBTVkdBbmltYXRpb25FbGVtZW50OjphdHRyaWJ1dGVDaGFuZ2VkKEF0dHJpYnV0ZSogYXR0ciwg Ym9vbCBwcmVzZXJ2ZURlY2xzKQogewogICAgIC8vIEFzc3VtcHRpb25zIG1heSBub3QgaG9sZCBh ZnRlciBhbiBhdHRyaWJ1dGUgY2hhbmdlLgogICAgIG1fYW5pbWF0aW9uVmFsaWQgPSBmYWxzZTsK KyAgICBzZXRJbmFjdGl2ZSgpOwogICAgIFNWR1NNSUxFbGVtZW50OjphdHRyaWJ1dGVDaGFuZ2Vk KGF0dHIsIHByZXNlcnZlRGVjbHMpOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9z dmcvYW5pbWF0aW9uL1NWR1NNSUxFbGVtZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9zdmcvYW5pbWF0 aW9uL1NWR1NNSUxFbGVtZW50LmgKaW5kZXggMGYyNmYyNi4uYWY2ZGJmZiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvc3ZnL2FuaW1hdGlvbi9TVkdTTUlMRWxlbWVudC5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3N2Zy9hbmltYXRpb24vU1ZHU01JTEVsZW1lbnQuaApAQCAtMTExLDYgKzExMSw4 IEBAIHByb3RlY3RlZDoKICAgICB2b2lkIGFkZEJlZ2luVGltZShTTUlMVGltZSk7CiAgICAgdm9p ZCBhZGRFbmRUaW1lKFNNSUxUaW1lKTsKIAorICAgIHZvaWQgc2V0SW5hY3RpdmUoKSB7IG1fYWN0 aXZlU3RhdGUgPSBJbmFjdGl2ZTsgfQorCiBwcml2YXRlOgogICAgIHZpcnR1YWwgdm9pZCBzdGFy dGVkQWN0aXZlSW50ZXJ2YWwoKSA9IDA7CiAgICAgdmlydHVhbCB2b2lkIHVwZGF0ZUFuaW1hdGlv bihmbG9hdCBwZXJjZW50LCB1bnNpZ25lZCByZXBlYXQsIFNWR1NNSUxFbGVtZW50KiByZXN1bHRF bGVtZW50KSA9IDA7Cg==