25900 2009-05-20 16:42:04 -0700 [Gtk] ROLE_ROW_HEADER should not be used for list item bullets/numbers 2009-07-27 17:56:37 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux VERIFIED FIXED Gtk P2 Normal --- 25531 0 jdiggs webkit-unassigned apinheiro walker.willie xan.lopez oldest_to_newest 122224 0 jdiggs 2009-05-20 16:42:04 -0700 Steps to reproduce: 1. Open the (to be) attached test case. 2. Use Accerciser to explore the accessible hierarchy for list items. Preferred results: The text for the list item bullet/number would be combined with the text of the item itself (i.e. in one object rather than two). Expected results: Assuming it is necessary to maintain separate accessible objects for the item's bullet/number and the item's text, the bullet/number would be of ROLE_TEXT. Actual results: The item's bullet/number is of ROLE_ROW_HEADER (a role associated and expected in tables; not list items). 122225 1 30515 jdiggs 2009-05-20 16:42:44 -0700 Created attachment 30515 aforementioned test case 122338 2 30541 jmalonzo 2009-05-21 06:30:59 -0700 Created attachment 30541 use ROLE_TEXT for ListMarkerRole 122401 3 xan.lopez 2009-05-21 13:20:55 -0700 Have you tried to figure out how to do the 'preferred result'? :) 122849 4 xan.lopez 2009-05-23 06:29:48 -0700 Joannie, would it be useful to you if we commit this while we figure out if we can get the preferred solution? 122874 5 jdiggs 2009-05-23 11:50:55 -0700 (In reply to comment #4) > Joannie, would it be useful to you if we commit this while we figure out if we > can get the preferred solution? > I could go either way. That said, the preferred solution could be looked at as another bug, one related to (if not the same as) bug 25675. In both cases, multiple accessibles are present when only one (IMHO) should be. Jan fixed the most important issue reported here, namely the role. Thanks! 122875 6 30541 xan.lopez 2009-05-23 12:11:41 -0700 Comment on attachment 30541 use ROLE_TEXT for ListMarkerRole OK! Then let's commit this and let's try to fix the bigger issue in other bug. FWIW, I need to fix something similar to finish my get_text_at_offset patch, WebKit splits text separated by <br> in different elements, which makes testing the feature pretty complicated. 122890 7 jmalonzo 2009-05-23 15:23:51 -0700 Patch landed in r44104. 135077 8 jdiggs 2009-07-27 17:56:37 -0700 Verifying. Thanks! 30515 2009-05-20 16:42:44 -0700 2009-05-20 16:42:44 -0700 aforementioned test case lists.html text/html 207 jdiggs PGh0bWw+CjxoZWFkPgo8dGl0bGU+TGlzdHM8L3RpdGxlPgo8L2hlYWQ+Cjxib2R5Pgo8dWw+Cjxs aT5JdGVtIDE8L2xpPgo8bGk+SXRlbSAyPC9saT4KPC91bD4KPG9sPgo8bGk+SXRlbSAxPC9saT4K PGxpPkl0ZW0gMjwvbGk+CiAgIDxvbD4KICAgPGxpPkl0ZW0gMTwvbGk+CiAgIDxsaT5JdGVtIDI8 L2xpPgogICA8L29sPgo8L29sPgo8L2JvZHk+CjwvaHRtbD4K 30541 2009-05-21 06:30:59 -0700 2009-05-23 12:11:41 -0700 use ROLE_TEXT for ListMarkerRole 25900.patch text/plain 1186 jmalonzo ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YjU5YTdlYy4uNzY1NGQwNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAwOS0wNS0yMSAgSmFuIE1pY2hhZWwg QWxvbnpvICA8am1hbG9uem9Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBbR3RrXSBST0xFX1JPV19IRUFERVIgc2hvdWxkIG5vdCBi ZSB1c2VkIGZvciBsaXN0IGl0ZW0gYnVsbGV0cy9udW1iZXJzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNTkwMAorCisgICAgICAgICogYWNjZXNzaWJp bGl0eS9ndGsvQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJBdGsuY3BwOgorICAgICAgICAoYXRr Um9sZSk6CisKIDIwMDktMDUtMjEgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAog ICAgICAgICBSZXZpZXdlZCBieSBBbmRlcnMgQ2FybHNzb24uCmRpZmYgLS1naXQgYS9XZWJDb3Jl L2FjY2Vzc2liaWxpdHkvZ3RrL0FjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyQXRrLmNwcCBiL1dl YkNvcmUvYWNjZXNzaWJpbGl0eS9ndGsvQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJBdGsuY3Bw CmluZGV4IGUyNWQ1NmEuLmVhZTIxMTggMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvYWNjZXNzaWJpbGl0 eS9ndGsvQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJBdGsuY3BwCisrKyBiL1dlYkNvcmUvYWNj ZXNzaWJpbGl0eS9ndGsvQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJBdGsuY3BwCkBAIC0yNDcs NyArMjQ3LDcgQEAgc3RhdGljIEF0a1JvbGUgYXRrUm9sZShBY2Nlc3NpYmlsaXR5Um9sZSByb2xl KQogICAgIGNhc2UgSW1hZ2VSb2xlOgogICAgICAgICByZXR1cm4gQVRLX1JPTEVfSU1BR0U7CiAg ICAgY2FzZSBMaXN0TWFya2VyUm9sZToKLSAgICAgICAgcmV0dXJuIEFUS19ST0xFX1JPV19IRUFE RVI7CisgICAgICAgIHJldHVybiBBVEtfUk9MRV9URVhUOwogICAgIGNhc2UgV2ViQXJlYVJvbGU6 CiAgICAgICAgIC8vcmV0dXJuIEFUS19ST0xFX0hUTUxfQ09OVEFJTkVSOyAvLyBJcyB0aGlzIHJp Z2h0PwogICAgICAgICByZXR1cm4gQVRLX1JPTEVfRE9DVU1FTlRfRlJBTUU7Cg==