258556 2023-06-27 03:25:52 -0700 WasmSignalHandler.cpp doesn't compile on Windows 2023-07-18 03:05:39 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 222315 1 Ryuichi.Hayashida Ryuichi.Hayashida fujii webkit-bug-importer ysuzuki oldest_to_newest 1963761 0 Ryuichi.Hayashida 2023-06-27 03:25:52 -0700 wasm/WasmFaultSignalHandler.cpp doesn't compile on Windows because it uses wtf/threads/Signals.h. This is because Signals.h misses many APIs such as Signal class when it is not on Unix platform. 1964424 1 ysuzuki 2023-06-30 02:05:53 -0700 The same interface needs to be implemented on Windows with vectored exception handlers. 1964958 2 webkit-bug-importer 2023-07-04 03:26:14 -0700 <rdar://problem/111733870> 1966184 3 Ryuichi.Hayashida 2023-07-11 06:54:10 -0700 I'd like to prioritize fixing llint for Wasm on Windows at first since it prevents Wasm feature from being enabled on Windows. For now, I want to just disable the signal handlers on Windows. For implementing signals on Windows, I created the ticket bug259108. I'd like to work on signal handlers for Windows in the ticket once Wasm implementation starts to work on Windows. 1966189 4 Ryuichi.Hayashida 2023-07-11 07:08:54 -0700 Pull request: https://github.com/WebKit/WebKit/pull/15740 1966261 5 ews-feeder 2023-07-11 13:32:17 -0700 Committed 265964@main (62ac852fe74f): <https://commits.webkit.org/265964@main> Reviewed commits have been landed. Closing PR #15740 and removing active labels. 1966291 6 ysuzuki 2023-07-11 16:03:09 -0700 Note that wasm shared memory requires this as a mandatory option, so it must be implemented before enabling wasm. 1967161 7 Ryuichi.Hayashida 2023-07-18 03:05:39 -0700 Thank you. I need to understand how the shared memory works.