255728 2023-04-20 08:30:19 -0700 Result of -webkit-line-clamp with block children may be incorrect during partial repint 2023-04-25 08:52:37 -0700 1 1 1 Unclassified WebKit Layout and Rendering Safari 16 All All RESOLVED DUPLICATE 255487 P2 Normal --- 1 bunnnywong webkit-unassigned ahmad.saleem792 bfulgham simon.fraser zalan oldest_to_newest 1950071 0 466009 bunnnywong 2023-04-20 08:30:19 -0700 Created attachment 466009 Test case to reproduce this issue visibleLineCountForLineClamp for individual child should be propagated to the parent layoutState. 1950072 1 466010 bunnnywong 2023-04-20 08:31:01 -0700 Created attachment 466010 Expected result for the test case 1950075 2 bunnnywong 2023-04-20 08:35:45 -0700 Pull request: https://github.com/WebKit/WebKit/pull/12973 1950089 3 466011 bunnnywong 2023-04-20 09:02:12 -0700 Created attachment 466011 Expected result for the test case 1951004 4 ahmad.saleem792 2023-04-25 03:41:02 -0700 (In reply to Ethan Wong from comment #2) > Pull request: https://github.com/WebKit/WebKit/pull/12973 This PR points to different bug? PR just landed. Is this duplicate of bug 255487? 1951023 5 bunnnywong 2023-04-25 05:42:50 -0700 (In reply to Ahmad Saleem from comment #4) > (In reply to Ethan Wong from comment #2) > > Pull request: https://github.com/WebKit/WebKit/pull/12973 > > This PR points to different bug? > > PR just landed. Is this duplicate of bug 255487? The above PR should point to this bug. It seems the bug id is mistaken. The two bugs results visually similar issue, could probably be merged together. 1951027 6 ahmad.saleem792 2023-04-25 06:13:49 -0700 (In reply to Ethan Wong from comment #5) > (In reply to Ahmad Saleem from comment #4) > > (In reply to Ethan Wong from comment #2) > > > Pull request: https://github.com/WebKit/WebKit/pull/12973 > > > > This PR points to different bug? > > > > PR just landed. Is this duplicate of bug 255487? > > The above PR should point to this bug. It seems the bug id is mistaken. > > The two bugs results visually similar issue, could probably be merged > together. I asked @Alan for his comment on GitHub, once I get input, I will mark this as duplicate or I will revert your change so you can do PR with updated bug URL and then I will push it to main. Again - it is depending on Alan's response. :-) For Reference - https://github.com/WebKit/WebKit/pull/12973#issuecomment-1521570408 1951070 7 ahmad.saleem792 2023-04-25 08:52:37 -0700 This landed in bug 255487 as: Committed 263360@main (59088ba85057): <https://commits.webkit.org/263360@main> Reviewed commits have been landed. Closing PR #12973 and removing active labels. *** This bug has been marked as a duplicate of bug 255487 *** 466009 2023-04-20 08:30:19 -0700 2023-04-20 08:30:19 -0700 Test case to reproduce this issue line-clamp-nested-blocks-with-layout-state.html text/html 479 bunnnywong PHN0eWxlPgogIC5jbGFtcGVkIHsKICAgIGZvbnQ6IEFoZW07CiAgICBkaXNwbGF5OiAtd2Via2l0 LWJveDsKICAgIC13ZWJraXQtYm94LW9yaWVudDogdmVydGljYWw7CiAgICAtd2Via2l0LWxpbmUt Y2xhbXA6IDI7CiAgICBvdmVyZmxvdzogaGlkZGVuOwogIH0KPC9zdHlsZT4KPGJvZHk+CiAgPGRp diBjbGFzcz0iY2xhbXBlZCI+CiAgICA8c3BhbiBpZD0idGVzdCI+VEVTVDwvc3Bhbj4KICAgIDxk aXY+RkFJTDwvZGl2PgogIDwvZGl2Pgo8L2JvZHk+CjxzY3JpcHQ+CiAgaWYgKHdpbmRvdy50ZXN0 UnVubmVyKSB0ZXN0UnVubmVyLndhaXRVbnRpbERvbmUoKTsKICBzZXRUaW1lb3V0KCgpID0+IHsK ICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJ0ZXN0IikuaW5uZXJIVE1MID0gIlRFU1Q8YnIg Lz5DQVNFIjsKICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikgdGVzdFJ1bm5lci5ub3RpZnlEb25l KCk7CiAgfSwgMCk7Cjwvc2NyaXB0Pgo= 466010 2023-04-20 08:31:01 -0700 2023-04-20 09:02:12 -0700 Expected result for the test case line-clamp-nested-blocks-with-layout-state-expected.html text/html 270 bunnnywong PHN0eWxlPgogIC5jbGFtcGVkIHsKICAgIGZvbnQ6IEFoZW07CiAgICBkaXNwbGF5OiAtd2Via2l0 LWJveDsKICAgIC13ZWJraXQtYm94LW9yaWVudDogdmVydGljYWw7CiAgICAtd2Via2l0LWxpbmUt Y2xhbXA6IDI7CiAgICBvdmVyZmxvdzogaGlkZGVuOwogIH0KPC9zdHlsZT4KPGJvZHk+CiAgPGRp diBjbGFzcz0iY2xhbXBlZCI+CiAgICA8c3BhbiBpZD0idGVzdCI+VEVTVDxiciAvPkNBU0U8YnIg Lz48ZGl2PkZBSUw8L2Rpdj48L3NwYW4+CiAgPC9kaXY+CjwvYm9keT4K 466011 2023-04-20 09:02:12 -0700 2023-04-20 09:02:12 -0700 Expected result for the test case line-clamp-nested-blocks-with-layout-state-expected.html text/html 259 bunnnywong PHN0eWxlPgogIC5jbGFtcGVkIHsKICAgIGZvbnQ6IEFoZW07CiAgICBkaXNwbGF5OiAtd2Via2l0 LWJveDsKICAgIC13ZWJraXQtYm94LW9yaWVudDogdmVydGljYWw7CiAgICAtd2Via2l0LWxpbmUt Y2xhbXA6IDI7CiAgICBvdmVyZmxvdzogaGlkZGVuOwogIH0KPC9zdHlsZT4KPGJvZHk+CiAgPGRp diBjbGFzcz0iY2xhbXBlZCI+CiAgICA8c3Bhbj5URVNUPGJyIC8+Q0FTRTwvc3Bhbj4KICAgIDxk aXY+RkFJTDwvZGl2PgogIDwvZGl2Pgo8L2JvZHk+Cg==