25529 2009-05-03 15:30:32 -0700 [Gtk] Expected states not exposed to assistive technologies 2009-07-27 14:17:12 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC Linux VERIFIED FIXED Gtk P2 Normal --- 25531 0 jdiggs xan.lopez apinheiro walker.willie xan.lopez oldest_to_newest 119738 0 jdiggs 2009-05-03 15:30:32 -0700 The Atk state types can be found here: http://library.gnome.org/devel/atk/unstable/atk-AtkState.html#AtkStateType A number of these states are not being exposed when they should be. A comparison with Firefox or with any Gtk+ app should be helpful. (Using Accerciser, view any page and then choose an accessible in the pane on the left. Then use the Interface Viewer, expanding "Accessible" to see the states being exposed for that object.) That said, of especial/immediate interest are: * STATE_SENSITIVE * STATE_VISIBLE * STATE_EDITABLE because these three states frequently (arguably, almost constantly) impact what a screen reader such as Orca presents to the user interacting with the content being displayed. 126432 1 31407 xan.lopez 2009-06-17 03:11:48 -0700 Created attachment 31407 a11ystates.patch Implement requested states. For now I'm just doing SHOWING = VISIBLE and ENABLED = SENSITIVE, since I'm not sure how to tell the subtle difference between those in WebCore (specially SHOWING vs VISIBLE, which seems to be a GTK+-ism related to MAPPED vs VISIBLE (as in the visible flag for widgets)). 126433 2 apinheiro 2009-06-17 03:40:40 -0700 (In reply to comment #1) > For now I'm just doing SHOWING = VISIBLE and ENABLED = SENSITIVE, since I'm not > sure how to tell the subtle difference between those in WebCore (specially > SHOWING vs VISIBLE, which seems to be a GTK+-ism related to MAPPED vs VISIBLE > (as in the visible flag for widgets)). FYI: in GTK, SHOWING is a little more than VISIBLE&&MAPPING, as you said, as it also search if the widget has an antecedent that is a GtkViewPort, to check if the widget intersects with the visible rectangle of the GtkViewPort. I'm not sure if this can affects to WebKit. And, in the same way, this could be not enough, and a extra condition could be required: http://bugzilla.gnome.org/show_bug.cgi?id=509650 128315 3 31407 jmalonzo 2009-06-25 16:42:32 -0700 Comment on attachment 31407 a11ystates.patch > From 1939ce04b5b0025ffbdfee678a0ec0d52b24bedb Mon Sep 17 00:00:00 2001 > From: Xan Lopez <xlopez@igalia.com> > Date: Wed, 17 Jun 2009 13:08:13 +0300 > Subject: [PATCH] 2009-06-17 Xan Lopez <xlopez@igalia.com> Assuming you've tested this, r=me. Also please add a the bugzilla.gnome.org bug link (by Alejandro) where appropriate so we can keep track what else is missing. Thanks! ( 128438 4 eric 2009-06-26 01:38:29 -0700 Assigning to xan for corrections and landing. 128453 5 xan.lopez 2009-06-26 02:13:34 -0700 Landed with a pointer to the bug pointed by Alejandro in r45252. Closing this now, new bugs can be opened about the issues remaining, if any. 135014 6 jdiggs 2009-07-27 14:17:12 -0700 Verifying. Thanks! 31407 2009-06-17 03:11:48 -0700 2009-06-25 16:42:32 -0700 a11ystates.patch a11ystates.patch text/plain 3245 xan.lopez RnJvbSAxOTM5Y2UwNGI1YjAwMjVmZmJkZmVlNjc4YTBlYzBkNTJiMjRiZWRiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYYW4gTG9wZXogPHhsb3BlekBpZ2FsaWEuY29tPgpEYXRlOiBX ZWQsIDE3IEp1biAyMDA5IDEzOjA4OjEzICswMzAwClN1YmplY3Q6IFtQQVRDSF0gMjAwOS0wNi0x NyAgWGFuIExvcGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CgogICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgoKICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjU1MjkKICAgICAgICBbR3RrXSBFeHBlY3RlZCBzdGF0ZXMgbm90IGV4cG9zZWQgdG8g YXNzaXN0aXZlIHRlY2hub2xvZ2llcwoKICAgICAgICBBZGQgc3VwcG9ydCBmb3IgVklTSUJMRSwg RURJVEFCTEUgYW5kIFNFTlNJVElWRSBzdGF0ZXMuCgogICAgICAgICogYWNjZXNzaWJpbGl0eS9n dGsvQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJBdGsuY3BwOgogICAgICAgIChzZXRBdGtTdGF0 ZVNldEZyb21Db3JlT2JqZWN0KToKLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICB8ICAgMTIgKysrKysrKysrKysrCiAuLi4vZ3RrL0FjY2Vzc2li aWxpdHlPYmplY3RXcmFwcGVyQXRrLmNwcCAgICAgICAgICB8ICAgMTcgKysrKysrKysrKysrLS0t LS0KIDIgZmlsZXMgY2hhbmdlZCwgMjQgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKCmRp ZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDAz ZTk2NzAuLjRjMmZmYjYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNv cmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMDYtMTcgIFhhbiBMb3BleiAgPHhs b3BlekBpZ2FsaWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNTUyOQor ICAgICAgICBbR3RrXSBFeHBlY3RlZCBzdGF0ZXMgbm90IGV4cG9zZWQgdG8gYXNzaXN0aXZlIHRl Y2hub2xvZ2llcworCisgICAgICAgIEFkZCBzdXBwb3J0IGZvciBWSVNJQkxFLCBFRElUQUJMRSBh bmQgU0VOU0lUSVZFIHN0YXRlcy4KKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvZ3RrL0FjY2Vz c2liaWxpdHlPYmplY3RXcmFwcGVyQXRrLmNwcDoKKyAgICAgICAgKHNldEF0a1N0YXRlU2V0RnJv bUNvcmVPYmplY3QpOgorCiAyMDA5LTA2LTE3ICBEYXZpZCBMZXZpbiAgPGxldmluQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFksIGxheW91dCB0ZXN0cyBmaXguCmRp ZmYgLS1naXQgYS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvZ3RrL0FjY2Vzc2liaWxpdHlPYmplY3RX cmFwcGVyQXRrLmNwcCBiL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9ndGsvQWNjZXNzaWJpbGl0eU9i amVjdFdyYXBwZXJBdGsuY3BwCmluZGV4IGVlN2EzN2UuLmRlY2ZjZTYgMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvYWNjZXNzaWJpbGl0eS9ndGsvQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJBdGsuY3Bw CisrKyBiL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9ndGsvQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBw ZXJBdGsuY3BwCkBAIC0yOTMsMTEgKzI5MywxNyBAQCBzdGF0aWMgdm9pZCBzZXRBdGtTdGF0ZVNl dEZyb21Db3JlT2JqZWN0KEFjY2Vzc2liaWxpdHlPYmplY3QqIGNvcmVPYmplY3QsIEF0a1N0YQog ICAgIGlmIChjb3JlT2JqZWN0LT5pc0NoZWNrZWQoKSkKICAgICAgICAgYXRrX3N0YXRlX3NldF9h ZGRfc3RhdGUoc3RhdGVTZXQsIEFUS19TVEFURV9DSEVDS0VEKTsKIAotICAgIGlmICghY29yZU9i amVjdC0+aXNSZWFkT25seSgpKQorICAgIC8vIEZJWE1FOiBpc1JlYWRPbmx5IGRvZXMgbm90IHNl ZW0gdG8gZG8gdGhlIHJpZ2h0IHRoaW5nIGZvcgorICAgIC8vIGNvbnRyb2xzLCBzbyBjaGVjayBl eHBsaWNpdGx5IGZvciB0aGVtCisgICAgaWYgKCFjb3JlT2JqZWN0LT5pc1JlYWRPbmx5KCkgfHwK KyAgICAgICAgKGNvcmVPYmplY3QtPmlzQ29udHJvbCgpICYmIGNvcmVPYmplY3QtPmNhblNldFZh bHVlQXR0cmlidXRlKCkpKQogICAgICAgICBhdGtfc3RhdGVfc2V0X2FkZF9zdGF0ZShzdGF0ZVNl dCwgQVRLX1NUQVRFX0VESVRBQkxFKTsKIAotICAgIGlmIChjb3JlT2JqZWN0LT5pc0VuYWJsZWQo KSkKKyAgICAvLyBGSVhNRTogUHV0IGJvdGggRU5BQkxFRCBhbmQgU0VOU0lUSVZFIHRvZ2V0aGVy IGhlcmUgZm9yIG5vdworICAgIGlmIChjb3JlT2JqZWN0LT5pc0VuYWJsZWQoKSkgewogICAgICAg ICBhdGtfc3RhdGVfc2V0X2FkZF9zdGF0ZShzdGF0ZVNldCwgQVRLX1NUQVRFX0VOQUJMRUQpOwor ICAgICAgICBhdGtfc3RhdGVfc2V0X2FkZF9zdGF0ZShzdGF0ZVNldCwgQVRLX1NUQVRFX1NFTlNJ VElWRSk7CisgICAgfQogCiAgICAgaWYgKGNvcmVPYmplY3QtPmNhblNldEZvY3VzQXR0cmlidXRl KCkpCiAgICAgICAgIGF0a19zdGF0ZV9zZXRfYWRkX3N0YXRlKHN0YXRlU2V0LCBBVEtfU1RBVEVf Rk9DVVNBQkxFKTsKQEAgLTMyMCwxMyArMzI2LDE0IEBAIHN0YXRpYyB2b2lkIHNldEF0a1N0YXRl U2V0RnJvbUNvcmVPYmplY3QoQWNjZXNzaWJpbGl0eU9iamVjdCogY29yZU9iamVjdCwgQXRrU3Rh CiAKICAgICAvLyBUT0RPOiBBVEtfU1RBVEVfU0VMRUNUQUJMRV9URVhUCiAKLSAgICAvLyBUT0RP OiBBVEtfU1RBVEVfU0VOU0lUSVZFCi0KICAgICBpZiAoY29yZU9iamVjdC0+aXNTZWxlY3RlZCgp KQogICAgICAgICBhdGtfc3RhdGVfc2V0X2FkZF9zdGF0ZShzdGF0ZVNldCwgQVRLX1NUQVRFX1NF TEVDVEVEKTsKIAotICAgIGlmICghY29yZU9iamVjdC0+aXNPZmZTY3JlZW4oKSkKKyAgICAvLyBG SVhNRTogR3JvdXAgYm90aCBTSE9XSU5HIGFuZCBWSVNJQkxFIGhlcmUgZm9yIG5vdworICAgIGlm ICghY29yZU9iamVjdC0+aXNPZmZTY3JlZW4oKSkgewogICAgICAgICBhdGtfc3RhdGVfc2V0X2Fk ZF9zdGF0ZShzdGF0ZVNldCwgQVRLX1NUQVRFX1NIT1dJTkcpOworICAgICAgICBhdGtfc3RhdGVf c2V0X2FkZF9zdGF0ZShzdGF0ZVNldCwgQVRLX1NUQVRFX1ZJU0lCTEUpOworICAgIH0KIAogICAg IC8vIE11dHVhbGx5IGV4Y2x1c2l2ZSwgc28gd2UgZ3JvdXAgdGhlc2UgdHdvCiAgICAgaWYgKGNv cmVPYmplY3QtPnJvbGVWYWx1ZSgpID09IFRleHRGaWVsZFJvbGUpCi0tIAoxLjYuMy4xCgo=