25525 2009-05-03 13:19:43 -0700 [Gtk] Tooltips should be fully keyboard accessible 2010-11-29 04:35:33 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 48986 25531 0 jdiggs webkit-unassigned alex apinheiro cgarcia commit-queue mario walker.willie xan.lopez oldest_to_newest 119732 0 jdiggs 2009-05-03 13:19:43 -0700 Steps to reproduce: 1. Load the test case (https://bugs.webkit.org/attachment.cgi?id=29966&action=view) 2. Hover the mouse over the "Phone number" link. This will cause the tooltip associated with that link to appear. Leave the mouse pointer there. 3. Press Tab until focus is on the Submit button. 4. Press Ctrl+F1 (the traditional Gtk app command to show/hide the tooltip associated with the focused item). Expected results: The tooltip associated with the Submit button would be displayed -- and ideally displayed near the Submit button. Actual results: The tooltip associated with the "Phone number" link is displayed -- and, at least on my system, displayed at the bottom of the window. Comments: The reason for wanting Ctrl+F1 to toggle the visibility of the tooltip associated with the focused object is so that users who prefer to (or need to) use the keyboard instead of the mouse can access the title attribute information. The reason for wanting it displayed in the vicinity of the focused object is for users with low vision who currently have to do additional visual work to locate the desired information. 173951 1 alex 2009-12-21 04:37:45 -0800 This bug depends on bug 32819. After applying that patch we would have to do a small workaround to solve the fact that the tooltips in GTK when opened with Ctrl+F1 are rendered outside and under the widget area (makes sense when the widget is a line of text for instance). The best option would be probably to allow users to redefine the x and y properties in the query-tooltip, but it seems the API does not allow it; and anyway we need the position of the focused element of the webpage and we do not have it. We would have to wait for the DOM bindings, bug 16401, and check how to change the position of the tooltip if possible at all. 186252 2 jdiggs 2010-01-31 15:49:37 -0800 Alex, since the bugs you mention seem to be fixed, is this something that can be tackled now? 189252 3 alex 2010-02-09 23:45:51 -0800 (In reply to comment #2) > Alex, since the bugs you mention seem to be fixed, is this something that can > be tackled now? I'm afraid we have to check how we could do fix a couple of things before because I think gtk+ positions the tooltip under the widget when you use Ctrl+F1 (in this case the widget is the webview) and there is not API to change it. And in webkit the tooltip is not associated with the focused element but with the mouse position, but I did not check it in detail. We still need to check those things in order to fix the bug, I'll try to check them. 189254 4 jdiggs 2010-02-09 23:54:22 -0800 (In reply to comment #3) > (In reply to comment #2) > > Alex, since the bugs you mention seem to be fixed, is this something that can > > be tackled now? > > I'm afraid we have to check how we could do fix a couple of things before > because I think gtk+ positions the tooltip under the widget when you use > Ctrl+F1 (in this case the widget is the webview) and there is not API to change > it. And in webkit the tooltip is not associated with the focused element but > with the mouse position, but I did not check it in detail. We still need to > check those things in order to fix the bug, I'll try to check them. Thanks!! Depending on what you find.... I wonder if this could (should?) be broken into two separate bugs: 1. Ctrl+F1 should cause the tooltip to appear.... somewhere :-) 2. The tooltip should appear next to the focused element to be consistent with Gtk+ If item #1 is solved, users who are blind could then cause the tooltip to appear (which a screen reader could then speak and display in braille). This is the important thing IMHO. 304572 5 72925 cgarcia 2010-11-04 04:02:17 -0700 Created attachment 72925 Patch to fix tooltip location and text when using the keyboard Attached patch fixed the text and position of the tooltip when using the keyboard. It uses the current focused element to get its location and title. I'm not sure the title is enough, but it fixes the test case attached to this report. There are two issues blocking this though: - GTK+ bug: https://bugzilla.gnome.org/show_bug.cgi?id=633974 - https://bugs.webkit.org/show_bug.cgi?id=48986 309794 6 72925 cgarcia 2010-11-16 10:08:48 -0800 Comment on attachment 72925 Patch to fix tooltip location and text when using the keyboard Now that bug #48986 is fixed this patch can be committed, it still won't work because of the gtk+ issue, but it's not more broken than current code, at least now it will show the right tooltip although wrongly positioned. 313251 7 72925 xan.lopez 2010-11-24 05:32:06 -0800 Comment on attachment 72925 Patch to fix tooltip location and text when using the keyboard View in context: https://bugs.webkit.org/attachment.cgi?id=72925&action=review r- for always using main frame, which I think is wrong. > WebKit/gtk/webkit/webkitwebview.cpp:1634 > + I think you want to use focusedOrMainFrame()from FocusController here? 313632 8 74836 cgarcia 2010-11-25 00:17:26 -0800 Created attachment 74836 Updated patch using focusedOrMainFrame() 313636 9 74836 xan.lopez 2010-11-25 00:36:00 -0800 Comment on attachment 74836 Updated patch using focusedOrMainFrame() r=me 314346 10 75013 cgarcia 2010-11-29 04:10:53 -0800 Created attachment 75013 New patch that converts tooltip area to window coords 314354 11 75013 commit-queue 2010-11-29 04:35:26 -0800 Comment on attachment 75013 New patch that converts tooltip area to window coords Clearing flags on attachment: 75013 Committed r72789: <http://trac.webkit.org/changeset/72789> 314355 12 commit-queue 2010-11-29 04:35:33 -0800 All reviewed patches have been landed. Closing bug. 72925 2010-11-04 04:02:17 -0700 2010-11-25 00:17:26 -0800 Patch to fix tooltip location and text when using the keyboard tooltips-keyboard.diff text/plain 3202 cgarcia ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggNmIzMzEwOC4uYTM2MjE4NCAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0xMS0wNCAg Q2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0d0a10gVG9vbHRpcHMgc2hvdWxk IGJlIGZ1bGx5IGtleWJvYXJkIGFjY2Vzc2libGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTI1NTI1CisKKyAgICAgICAgUG9zaXRpb24gdGhlIHRvb2x0 aXAgdW5kZXIgdGhlIGN1cnJlbnQgZm9jdXNlZCBlbGVtZW50IHdoZW4KKyAgICAgICAgdGhlIHRv b2x0aXAgaGFzIGJlZW4gdHJpZ2dlcmVkIHVzaW5nIHRoZSBrZXlib2FyZC4KKworICAgICAgICAq IHdlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcDoKKyAgICAgICAgKHdlYmtpdF93ZWJfdmlld19xdWVy eV90b29sdGlwKToKKyAgICAgICAgKHdlYmtpdF93ZWJfdmlld19zaG93X2hlbHApOgorICAgICAg ICAod2Via2l0X3dlYl92aWV3X2NsYXNzX2luaXQpOgorCiAyMDEwLTExLTAzICBEYW5pZWwgQmF0 ZXMgIDxkYmF0ZXNAcmltLmNvbT4KIAogICAgICAgICBGb3IgdW5uYW1lZCBmcmFtZXMsIHdpbmRv dy5uYW1lIHJldHVybnMgYSBnZW5lcmF0ZWQgbmFtZQpkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay93 ZWJraXQvd2Via2l0d2Vidmlldy5jcHAgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3 LmNwcAppbmRleCBhM2Q2YzIxLi45YzZkZDIzIDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL3dlYmtp dC93ZWJraXR3ZWJ2aWV3LmNwcAorKysgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3 LmNwcApAQCAtMTYyNCw2ICsxNjI0LDM4IEBAIHN0YXRpYyBnYm9vbGVhbiB3ZWJraXRfd2ViX3Zp ZXdfcXVlcnlfdG9vbHRpcChHdGtXaWRnZXQgKndpZGdldCwgZ2ludCB4LCBnaW50IHksCiB7CiAg ICAgV2ViS2l0V2ViVmlld1ByaXZhdGUqIHByaXYgPSBXRUJLSVRfV0VCX1ZJRVdfR0VUX1BSSVZB VEUod2lkZ2V0KTsKIAorICAgIGlmIChrZXlib2FyZF9tb2RlKSB7CisgICAgICAgIFdlYktpdFdl YlZpZXcqIHdlYlZpZXcgPSBXRUJLSVRfV0VCX1ZJRVcod2lkZ2V0KTsKKworICAgICAgICAvLyBH ZXQgdGhlIHRpdGxlIG9mIHRoZSBjdXJyZW50IGZvY3VzZWQgZWxlbWVudC4KKyAgICAgICAgRnJh bWUqIGNvcmVGcmFtZSA9IGNvcmUod2ViVmlldyktPm1haW5GcmFtZSgpOworICAgICAgICBpZiAo IWNvcmVGcmFtZSkKKyAgICAgICAgICAgIHJldHVybiBGQUxTRTsKKworICAgICAgICBEb2N1bWVu dCogZG9jID0gY29yZUZyYW1lLT5kb2N1bWVudCgpOworICAgICAgICBpZiAoIWRvYykKKyAgICAg ICAgICAgIHJldHVybiBGQUxTRTsKKworICAgICAgICBOb2RlKiBub2RlID0gZG9jLT5mb2N1c2Vk Tm9kZSgpOworICAgICAgICBpZiAoIW5vZGUpCisgICAgICAgICAgICByZXR1cm4gRkFMU0U7CisK KyAgICAgICAgZm9yIChOb2RlKiB0aXRsZU5vZGUgPSBub2RlOyB0aXRsZU5vZGU7IHRpdGxlTm9k ZSA9IHRpdGxlTm9kZS0+cGFyZW50Tm9kZSgpKSB7CisgICAgICAgICAgICBpZiAodGl0bGVOb2Rl LT5pc0VsZW1lbnROb2RlKCkpIHsKKyAgICAgICAgICAgICAgICBTdHJpbmcgdGl0bGUgPSBzdGF0 aWNfY2FzdDxFbGVtZW50Kj4odGl0bGVOb2RlKS0+dGl0bGUoKTsKKyAgICAgICAgICAgICAgICBp ZiAoIXRpdGxlLmlzRW1wdHkoKSkgeworICAgICAgICAgICAgICAgICAgICBHZGtSZWN0YW5nbGUg YXJlYSA9IG5vZGUtPmdldFJlY3QoKTsKKyAgICAgICAgICAgICAgICAgICAgZ3RrX3Rvb2x0aXBf c2V0X3RpcF9hcmVhKHRvb2x0aXAsICZhcmVhKTsKKyAgICAgICAgICAgICAgICAgICAgZ3RrX3Rv b2x0aXBfc2V0X3RleHQodG9vbHRpcCwgdGl0bGUudXRmOCgpLmRhdGEoKSk7CisKKyAgICAgICAg ICAgICAgICAgICAgcmV0dXJuIFRSVUU7CisgICAgICAgICAgICAgICAgfQorICAgICAgICAgICAg fQorICAgICAgICB9CisKKyAgICAgICAgcmV0dXJuIEZBTFNFOworICAgIH0KKwogICAgIGlmIChw cml2LT50b29sdGlwVGV4dC5sZW5ndGgoKSA+IDApIHsKICAgICAgICAgZ3RrX3Rvb2x0aXBfc2V0 X3RleHQodG9vbHRpcCwgcHJpdi0+dG9vbHRpcFRleHQuZGF0YSgpKTsKICAgICAgICAgcmV0dXJu IFRSVUU7CkBAIC0xNjMxLDYgKzE2NjMsMTQgQEAgc3RhdGljIGdib29sZWFuIHdlYmtpdF93ZWJf dmlld19xdWVyeV90b29sdGlwKEd0a1dpZGdldCAqd2lkZ2V0LCBnaW50IHgsIGdpbnQgeSwKIAog ICAgIHJldHVybiBGQUxTRTsKIH0KKworc3RhdGljIGdib29sZWFuIHdlYmtpdF93ZWJfdmlld19z aG93X2hlbHAoR3RrV2lkZ2V0KiB3aWRnZXQsIEd0a1dpZGdldEhlbHBUeXBlIGhlbHBfdHlwZSkK K3sKKyAgICBpZiAoaGVscF90eXBlID09IEdUS19XSURHRVRfSEVMUF9UT09MVElQKQorICAgICAg ICBndGtfd2lkZ2V0X3NldF9oYXNfdG9vbHRpcCh3aWRnZXQsIFRSVUUpOworCisgICAgcmV0dXJu IEdUS19XSURHRVRfQ0xBU1Mod2Via2l0X3dlYl92aWV3X3BhcmVudF9jbGFzcyktPnNob3dfaGVs cCh3aWRnZXQsIGhlbHBfdHlwZSk7Cit9CiAjZW5kaWYKIAogc3RhdGljIEd0a0lNQ29udGV4dCog d2Via2l0X3dlYl92aWV3X2dldF9pbV9jb250ZXh0KFdlYktpdFdlYlZpZXcqIHdlYlZpZXcpCkBA IC0yNjUyLDYgKzI2OTIsNyBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfd2ViX3ZpZXdfY2xhc3NfaW5p dChXZWJLaXRXZWJWaWV3Q2xhc3MqIHdlYlZpZXdDbGFzcykKICAgICB3aWRnZXRDbGFzcy0+ZHJh Z19kYXRhX3JlY2VpdmVkID0gd2Via2l0X3dlYl92aWV3X2RyYWdfZGF0YV9yZWNlaXZlZDsKICNp ZiBHVEtfQ0hFQ0tfVkVSU0lPTigyLCAxMiwgMCkKICAgICB3aWRnZXRDbGFzcy0+cXVlcnlfdG9v bHRpcCA9IHdlYmtpdF93ZWJfdmlld19xdWVyeV90b29sdGlwOworICAgIHdpZGdldENsYXNzLT5z aG93X2hlbHAgPSB3ZWJraXRfd2ViX3ZpZXdfc2hvd19oZWxwOwogI2VuZGlmCiAKICAgICBHdGtD b250YWluZXJDbGFzcyogY29udGFpbmVyQ2xhc3MgPSBHVEtfQ09OVEFJTkVSX0NMQVNTKHdlYlZp ZXdDbGFzcyk7Cg== 74836 2010-11-25 00:17:26 -0800 2010-11-29 04:10:53 -0800 Updated patch using focusedOrMainFrame() tooltips2.diff text/plain 3105 cgarcia ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggZDYwOGU3Ny4uMzZiNTYwOSAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0xMS0yNSAg Q2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0d0a10gVG9vbHRpcHMgc2hvdWxk IGJlIGZ1bGx5IGtleWJvYXJkIGFjY2Vzc2libGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTI1NTI1CisKKyAgICAgICAgUG9zaXRpb24gdGhlIHRvb2x0 aXAgdW5kZXIgdGhlIGN1cnJlbnQgZm9jdXNlZCBlbGVtZW50IHdoZW4gdGhlCisgICAgICAgIHRv b2x0aXAgaGFzIGJlZW4gdHJpZ2dlcmVkIHVzaW5nIHRoZSBrZXlib2FyZC4KKworICAgICAgICAq IHdlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcDoKKyAgICAgICAgKHdlYmtpdF93ZWJfdmlld19xdWVy eV90b29sdGlwKToKKyAgICAgICAgKHdlYmtpdF93ZWJfdmlld19zaG93X2hlbHApOgorICAgICAg ICAod2Via2l0X3dlYl92aWV3X2NsYXNzX2luaXQpOgorCiAyMDEwLTExLTI0ICBYYW4gTG9wZXog IDx4bG9wZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYXJ0aW4gUm9iaW5z b24uCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcCBiL1dl YktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCmluZGV4IDBjNmIyMGMuLmRlODBjZjMg MTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCisrKyBiL1dl YktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCkBAIC0xNjU0LDYgKzE2NTQsMzQgQEAg c3RhdGljIGdib29sZWFuIHdlYmtpdF93ZWJfdmlld19xdWVyeV90b29sdGlwKEd0a1dpZGdldCAq d2lkZ2V0LCBnaW50IHgsIGdpbnQgeSwKIHsKICAgICBXZWJLaXRXZWJWaWV3UHJpdmF0ZSogcHJp diA9IFdFQktJVF9XRUJfVklFV19HRVRfUFJJVkFURSh3aWRnZXQpOwogCisgICAgaWYgKGtleWJv YXJkX21vZGUpIHsKKyAgICAgICAgV2ViS2l0V2ViVmlldyogd2ViVmlldyA9IFdFQktJVF9XRUJf VklFVyh3aWRnZXQpOworCisgICAgICAgIC8vIEdldCB0aGUgdGl0bGUgb2YgdGhlIGN1cnJlbnQg Zm9jdXNlZCBlbGVtZW50LgorICAgICAgICBGcmFtZSogY29yZUZyYW1lID0gY29yZSh3ZWJWaWV3 KS0+Zm9jdXNDb250cm9sbGVyKCktPmZvY3VzZWRPck1haW5GcmFtZSgpOworICAgICAgICBpZiAo IWNvcmVGcmFtZSkKKyAgICAgICAgICAgIHJldHVybiBGQUxTRTsKKworICAgICAgICBOb2RlKiBu b2RlID0gZ2V0Rm9jdXNlZE5vZGUoY29yZUZyYW1lKTsKKyAgICAgICAgaWYgKCFub2RlKQorICAg ICAgICAgICAgcmV0dXJuIEZBTFNFOworCisgICAgICAgIGZvciAoTm9kZSogdGl0bGVOb2RlID0g bm9kZTsgdGl0bGVOb2RlOyB0aXRsZU5vZGUgPSB0aXRsZU5vZGUtPnBhcmVudE5vZGUoKSkgewor ICAgICAgICAgICAgaWYgKHRpdGxlTm9kZS0+aXNFbGVtZW50Tm9kZSgpKSB7CisgICAgICAgICAg ICAgICAgU3RyaW5nIHRpdGxlID0gc3RhdGljX2Nhc3Q8RWxlbWVudCo+KHRpdGxlTm9kZSktPnRp dGxlKCk7CisgICAgICAgICAgICAgICAgaWYgKCF0aXRsZS5pc0VtcHR5KCkpIHsKKyAgICAgICAg ICAgICAgICAgICAgR2RrUmVjdGFuZ2xlIGFyZWEgPSBub2RlLT5nZXRSZWN0KCk7CisgICAgICAg ICAgICAgICAgICAgIGd0a190b29sdGlwX3NldF90aXBfYXJlYSh0b29sdGlwLCAmYXJlYSk7Cisg ICAgICAgICAgICAgICAgICAgIGd0a190b29sdGlwX3NldF90ZXh0KHRvb2x0aXAsIHRpdGxlLnV0 ZjgoKS5kYXRhKCkpOworCisgICAgICAgICAgICAgICAgICAgIHJldHVybiBUUlVFOworICAgICAg ICAgICAgICAgIH0KKyAgICAgICAgICAgIH0KKyAgICAgICAgfQorCisgICAgICAgIHJldHVybiBG QUxTRTsKKyAgICB9CisKICAgICBpZiAocHJpdi0+dG9vbHRpcFRleHQubGVuZ3RoKCkgPiAwKSB7 CiAgICAgICAgIGlmICgha2V5Ym9hcmRfbW9kZSkgewogICAgICAgICAgICAgaWYgKCFwcml2LT50 b29sdGlwQXJlYS5pc0VtcHR5KCkpIHsKQEAgLTE2NjgsNiArMTY5NiwxNCBAQCBzdGF0aWMgZ2Jv b2xlYW4gd2Via2l0X3dlYl92aWV3X3F1ZXJ5X3Rvb2x0aXAoR3RrV2lkZ2V0ICp3aWRnZXQsIGdp bnQgeCwgZ2ludCB5LAogCiAgICAgcmV0dXJuIEZBTFNFOwogfQorCitzdGF0aWMgZ2Jvb2xlYW4g d2Via2l0X3dlYl92aWV3X3Nob3dfaGVscChHdGtXaWRnZXQqIHdpZGdldCwgR3RrV2lkZ2V0SGVs cFR5cGUgaGVscF90eXBlKQoreworICAgIGlmIChoZWxwX3R5cGUgPT0gR1RLX1dJREdFVF9IRUxQ X1RPT0xUSVApCisgICAgICAgIGd0a193aWRnZXRfc2V0X2hhc190b29sdGlwKHdpZGdldCwgVFJV RSk7CisKKyAgICByZXR1cm4gR1RLX1dJREdFVF9DTEFTUyh3ZWJraXRfd2ViX3ZpZXdfcGFyZW50 X2NsYXNzKS0+c2hvd19oZWxwKHdpZGdldCwgaGVscF90eXBlKTsKK30KICNlbmRpZgogCiBzdGF0 aWMgR3RrSU1Db250ZXh0KiB3ZWJraXRfd2ViX3ZpZXdfZ2V0X2ltX2NvbnRleHQoV2ViS2l0V2Vi Vmlldyogd2ViVmlldykKQEAgLTI3NDEsNiArMjc3Nyw3IEBAIHN0YXRpYyB2b2lkIHdlYmtpdF93 ZWJfdmlld19jbGFzc19pbml0KFdlYktpdFdlYlZpZXdDbGFzcyogd2ViVmlld0NsYXNzKQogICAg IHdpZGdldENsYXNzLT5kcmFnX2RhdGFfcmVjZWl2ZWQgPSB3ZWJraXRfd2ViX3ZpZXdfZHJhZ19k YXRhX3JlY2VpdmVkOwogI2lmIEdUS19DSEVDS19WRVJTSU9OKDIsIDEyLCAwKQogICAgIHdpZGdl dENsYXNzLT5xdWVyeV90b29sdGlwID0gd2Via2l0X3dlYl92aWV3X3F1ZXJ5X3Rvb2x0aXA7Cisg ICAgd2lkZ2V0Q2xhc3MtPnNob3dfaGVscCA9IHdlYmtpdF93ZWJfdmlld19zaG93X2hlbHA7CiAj ZW5kaWYKIAogICAgIEd0a0NvbnRhaW5lckNsYXNzKiBjb250YWluZXJDbGFzcyA9IEdUS19DT05U QUlORVJfQ0xBU1Mod2ViVmlld0NsYXNzKTsK 75013 2010-11-29 04:10:53 -0800 2010-11-29 04:35:25 -0800 New patch that converts tooltip area to window coords tooltips-keyboard3.diff text/plain 3148 cgarcia ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggNGNmOWIxOC4uN2MyZjNkMiAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0xMS0yOSAg Q2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0d0a10gVG9vbHRpcHMgc2hvdWxk IGJlIGZ1bGx5IGtleWJvYXJkIGFjY2Vzc2libGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTI1NTI1CisKKyAgICAgICAgUG9zaXRpb24gdGhlIHRvb2x0 aXAgdW5kZXIgdGhlIGN1cnJlbnQgZm9jdXNlZCBlbGVtZW50IHdoZW4gdGhlCisgICAgICAgIHRv b2x0aXAgaGFzIGJlZW4gdHJpZ2dlcmVkIHVzaW5nIHRoZSBrZXlib2FyZC4KKworICAgICAgICAq IHdlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcDoKKyAgICAgICAgKHdlYmtpdF93ZWJfdmlld19xdWVy eV90b29sdGlwKToKKyAgICAgICAgKHdlYmtpdF93ZWJfdmlld19zaG93X2hlbHApOgorICAgICAg ICAod2Via2l0X3dlYl92aWV3X2NsYXNzX2luaXQpOgorCiAyMDEwLTExLTI2ICBDYXJsb3MgR2Fy Y2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBY YW4gTG9wZXouCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNw cCBiL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCmluZGV4IDBjNmIyMGMuLjNl ODg4ZjggMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCisr KyBiL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCkBAIC0xNjU0LDYgKzE2NTQs MzQgQEAgc3RhdGljIGdib29sZWFuIHdlYmtpdF93ZWJfdmlld19xdWVyeV90b29sdGlwKEd0a1dp ZGdldCAqd2lkZ2V0LCBnaW50IHgsIGdpbnQgeSwKIHsKICAgICBXZWJLaXRXZWJWaWV3UHJpdmF0 ZSogcHJpdiA9IFdFQktJVF9XRUJfVklFV19HRVRfUFJJVkFURSh3aWRnZXQpOwogCisgICAgaWYg KGtleWJvYXJkX21vZGUpIHsKKyAgICAgICAgV2ViS2l0V2ViVmlldyogd2ViVmlldyA9IFdFQktJ VF9XRUJfVklFVyh3aWRnZXQpOworCisgICAgICAgIC8vIEdldCB0aGUgdGl0bGUgb2YgdGhlIGN1 cnJlbnQgZm9jdXNlZCBlbGVtZW50LgorICAgICAgICBGcmFtZSogY29yZUZyYW1lID0gY29yZSh3 ZWJWaWV3KS0+Zm9jdXNDb250cm9sbGVyKCktPmZvY3VzZWRPck1haW5GcmFtZSgpOworICAgICAg ICBpZiAoIWNvcmVGcmFtZSkKKyAgICAgICAgICAgIHJldHVybiBGQUxTRTsKKworICAgICAgICBO b2RlKiBub2RlID0gZ2V0Rm9jdXNlZE5vZGUoY29yZUZyYW1lKTsKKyAgICAgICAgaWYgKCFub2Rl KQorICAgICAgICAgICAgcmV0dXJuIEZBTFNFOworCisgICAgICAgIGZvciAoTm9kZSogdGl0bGVO b2RlID0gbm9kZTsgdGl0bGVOb2RlOyB0aXRsZU5vZGUgPSB0aXRsZU5vZGUtPnBhcmVudE5vZGUo KSkgeworICAgICAgICAgICAgaWYgKHRpdGxlTm9kZS0+aXNFbGVtZW50Tm9kZSgpKSB7CisgICAg ICAgICAgICAgICAgU3RyaW5nIHRpdGxlID0gc3RhdGljX2Nhc3Q8RWxlbWVudCo+KHRpdGxlTm9k ZSktPnRpdGxlKCk7CisgICAgICAgICAgICAgICAgaWYgKCF0aXRsZS5pc0VtcHR5KCkpIHsKKyAg ICAgICAgICAgICAgICAgICAgR2RrUmVjdGFuZ2xlIGFyZWEgPSBjb3JlRnJhbWUtPnZpZXcoKS0+ Y29udGVudHNUb1dpbmRvdyhub2RlLT5nZXRSZWN0KCkpOworICAgICAgICAgICAgICAgICAgICBn dGtfdG9vbHRpcF9zZXRfdGlwX2FyZWEodG9vbHRpcCwgJmFyZWEpOworICAgICAgICAgICAgICAg ICAgICBndGtfdG9vbHRpcF9zZXRfdGV4dCh0b29sdGlwLCB0aXRsZS51dGY4KCkuZGF0YSgpKTsK KworICAgICAgICAgICAgICAgICAgICByZXR1cm4gVFJVRTsKKyAgICAgICAgICAgICAgICB9Cisg ICAgICAgICAgICB9CisgICAgICAgIH0KKworICAgICAgICByZXR1cm4gRkFMU0U7CisgICAgfQor CiAgICAgaWYgKHByaXYtPnRvb2x0aXBUZXh0Lmxlbmd0aCgpID4gMCkgewogICAgICAgICBpZiAo IWtleWJvYXJkX21vZGUpIHsKICAgICAgICAgICAgIGlmICghcHJpdi0+dG9vbHRpcEFyZWEuaXNF bXB0eSgpKSB7CkBAIC0xNjY4LDYgKzE2OTYsMTQgQEAgc3RhdGljIGdib29sZWFuIHdlYmtpdF93 ZWJfdmlld19xdWVyeV90b29sdGlwKEd0a1dpZGdldCAqd2lkZ2V0LCBnaW50IHgsIGdpbnQgeSwK IAogICAgIHJldHVybiBGQUxTRTsKIH0KKworc3RhdGljIGdib29sZWFuIHdlYmtpdF93ZWJfdmll d19zaG93X2hlbHAoR3RrV2lkZ2V0KiB3aWRnZXQsIEd0a1dpZGdldEhlbHBUeXBlIGhlbHBfdHlw ZSkKK3sKKyAgICBpZiAoaGVscF90eXBlID09IEdUS19XSURHRVRfSEVMUF9UT09MVElQKQorICAg ICAgICBndGtfd2lkZ2V0X3NldF9oYXNfdG9vbHRpcCh3aWRnZXQsIFRSVUUpOworCisgICAgcmV0 dXJuIEdUS19XSURHRVRfQ0xBU1Mod2Via2l0X3dlYl92aWV3X3BhcmVudF9jbGFzcyktPnNob3df aGVscCh3aWRnZXQsIGhlbHBfdHlwZSk7Cit9CiAjZW5kaWYKIAogc3RhdGljIEd0a0lNQ29udGV4 dCogd2Via2l0X3dlYl92aWV3X2dldF9pbV9jb250ZXh0KFdlYktpdFdlYlZpZXcqIHdlYlZpZXcp CkBAIC0yNzQxLDYgKzI3NzcsNyBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfd2ViX3ZpZXdfY2xhc3Nf aW5pdChXZWJLaXRXZWJWaWV3Q2xhc3MqIHdlYlZpZXdDbGFzcykKICAgICB3aWRnZXRDbGFzcy0+ ZHJhZ19kYXRhX3JlY2VpdmVkID0gd2Via2l0X3dlYl92aWV3X2RyYWdfZGF0YV9yZWNlaXZlZDsK ICNpZiBHVEtfQ0hFQ0tfVkVSU0lPTigyLCAxMiwgMCkKICAgICB3aWRnZXRDbGFzcy0+cXVlcnlf dG9vbHRpcCA9IHdlYmtpdF93ZWJfdmlld19xdWVyeV90b29sdGlwOworICAgIHdpZGdldENsYXNz LT5zaG93X2hlbHAgPSB3ZWJraXRfd2ViX3ZpZXdfc2hvd19oZWxwOwogI2VuZGlmCiAKICAgICBH dGtDb250YWluZXJDbGFzcyogY29udGFpbmVyQ2xhc3MgPSBHVEtfQ09OVEFJTkVSX0NMQVNTKHdl YlZpZXdDbGFzcyk7Cg==