255021 2023-04-05 00:53:37 -0700 Remove Quirk shouldDisableElementFullscreenQuirk for nfl.com 2023-08-10 02:01:09 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://nfl.com/ InRadar P2 Normal --- 207020 1 karlcow karlcow webkit-bug-importer oldest_to_newest 1946692 0 karlcow 2023-04-05 00:53:37 -0700 It's about removing shouldDisableElementFullscreenQuirk 1. With an iPad (large format, not a mini) 2. Go to https://nfl.com/ 3. Remote Inspect the iPad from the desktop 4. Disable Site Specific Hacks 5. Reload the https://nfl.com/ page 6. Play a video 7. Tap the fullscreen button Expected: Video goes fullscreen and the video controls are displayed. The Quirk had been put in place because the video had no controls. https://github.com/WebKit/WebKit/blob/f37c05e1232e7be8dca7ddebe2003a9b1d75948c/Source/WebCore/page/Quirks.cpp#L968-L986 1946693 1 karlcow 2023-04-05 00:54:24 -0700 rdar://107633365 1947571 2 karlcow 2023-04-09 21:54:15 -0700 Thanks to Zohreh Momeni for testing. We can remove it. 1947572 3 karlcow 2023-04-09 21:57:48 -0700 Pull request: https://github.com/WebKit/WebKit/pull/12560 1947759 4 karlcow 2023-04-10 15:48:27 -0700 Hmm retested today on iPadOS 16.4 And it seems we can't remove it. I will close the PR for now. 1970468 5 ews-feeder 2023-08-10 02:01:07 -0700 Committed 266757@main (c8e45de869f8): <https://commits.webkit.org/266757@main> Reviewed commits have been landed. Closing PR #12560 and removing active labels.