<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>254788</bug_id>
          
          <creation_ts>2023-03-30 17:49:17 -0700</creation_ts>
          <short_desc>Remove Quirk needsPerDocumentAutoplayBehavior for Netflix.com</short_desc>
          <delta_ts>2024-08-20 15:51:59 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Media</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>REOPENED</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc>http://netflix.com</bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>GoodFirstBug, InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>193301</dependson>
    
    <dependson>259933</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Karl Dubost">karlcow</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>brandonstewart</cc>
    
    <cc>commit-queue</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1945574</commentid>
    <comment_count>0</comment_count>
    <who name="Karl Dubost">karlcow</who>
    <bug_when>2023-03-30 17:49:17 -0700</bug_when>
    <thetext>In Bug 173030, a quirk has been added for Netflix.com
Code https://github.com/WebKit/WebKit/blob/7e8331b4cad9e69af27575d0ada29e950e33f059/Source/WebCore/page/Quirks.cpp#L131-L139

With ear detection enabled, when I a bud is out of ear, the sound should pause. 

Steps To Reproduce:
1. Connect airpods to a laptop
2. Watch Netflix 
3. Take one bud out of ear

Results:
Audio/Video continue to play


If/when the issue doesn&apos;t reproduce, remove the Quirk.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1945576</commentid>
    <comment_count>1</comment_count>
    <who name="Karl Dubost">karlcow</who>
    <bug_when>2023-03-30 17:50:01 -0700</bug_when>
    <thetext>rdar://107428381</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1966555</commentid>
    <comment_count>2</comment_count>
    <who name="Karl Dubost">karlcow</who>
    <bug_when>2023-07-13 00:14:15 -0700</bug_when>
    <thetext>It has been tested on March 31, 2023.
And taking out one bug and the audio/video stopped playing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1969949</commentid>
    <comment_count>3</comment_count>
    <who name="Brandon">brandonstewart</who>
    <bug_when>2023-08-07 13:04:25 -0700</bug_when>
    <thetext>https://github.com/WebKit/WebKit/pull/16445</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1969954</commentid>
    <comment_count>4</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2023-08-07 13:22:13 -0700</bug_when>
    <thetext>Committed 266653@main (24c3998f7296): &lt;https://commits.webkit.org/266653@main&gt;

Reviewed commits have been landed. Closing PR #16445 and removing active labels.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1970097</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2023-08-08 09:38:09 -0700</bug_when>
    <thetext>Re-opened since this is blocked by bug 259933</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1970438</commentid>
    <comment_count>6</comment_count>
    <who name="Karl Dubost">karlcow</who>
    <bug_when>2023-08-09 21:22:01 -0700</bug_when>
    <thetext>The test on this bug and the subsequent patch are not about needsSeekingSupportDisabled.

There is a mistake which propagated in between two different quirks about Netflix.

https://searchfox.org/wubkat/source/Source/WebCore/page/Quirks.cpp#131
needsSeekingSupportDisabled()

https://searchfox.org/wubkat/source/Source/WebCore/page/Quirks.cpp#141
needsPerDocumentAutoplayBehavior()</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1970439</commentid>
    <comment_count>7</comment_count>
    <who name="Karl Dubost">karlcow</who>
    <bug_when>2023-08-09 21:22:43 -0700</bug_when>
    <thetext>I will rename this bug to needsPerDocumentAutoplayBehavior</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1970451</commentid>
    <comment_count>8</comment_count>
    <who name="Karl Dubost">karlcow</who>
    <bug_when>2023-08-09 22:56:28 -0700</bug_when>
    <thetext>That said, I&apos;m still not sure that removing needsPerDocumentAutoplayBehavior will solve more issues than creating new or old ones.

We need more testing on the consequences of removing this Quirk too.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>