254410 2023-03-24 06:15:15 -0700 [CG] Handle properly the case when an image does not have a valid output colorspace 2023-03-27 23:01:38 -0700 1 1 1 Unclassified WebKit Images WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 254406 https://bugs.webkit.org/show_bug.cgi?id=229021 InRadar P2 Normal --- 1 sabouhallawa sabouhallawa sabouhallawa webkit-bug-importer oldest_to_newest 1943694 0 sabouhallawa 2023-03-24 06:15:15 -0700 NativeImage::colorSpace() always creates DestinationColorSpace from the return of CGImageGetColorSpace() without checking its value which can be null. We need to check the image colorspace is CGColorSpaceSupportsOutput() before creating DestinationColorSpace. CGColorSpaceSupportsOutput() will return false for a null input. We can make the return type of NativeImage::colorSpace() std::optional<DestinationColorSpace> and make it return std::nullopt if CGColorSpaceSupportsOutput() returns false. We should let the caller decide what to do when the image does not have a valid DestinationColorSpace. 1943695 1 sabouhallawa 2023-03-24 06:15:27 -0700 rdar://107103646 1943696 2 sabouhallawa 2023-03-24 06:16:17 -0700 rdar://107103646 1943702 3 sabouhallawa 2023-03-24 06:25:14 -0700 Pull request: https://github.com/WebKit/WebKit-security/pull/33 1943754 4 sabouhallawa 2023-03-24 08:50:01 -0700 Pull request: https://github.com/WebKit/WebKit/pull/11928 1944503 5 sabouhallawa 2023-03-27 23:01:38 -0700 This is already fixed by bug 254406. *** This bug has been marked as a duplicate of bug 254406 ***