25414 2009-04-26 16:49:49 -0700 [GTK] ROLE_PANEL should not be used for paragraphs and list items. 2009-05-20 12:42:27 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC Linux VERIFIED FIXED Gtk P2 Normal --- 21546 25531 0 jdiggs webkit-unassigned apinheiro walker.willie xan.lopez oldest_to_newest 118933 0 jdiggs 2009-04-26 16:49:49 -0700 Steps to reproduce: 1. View the (to be) attached document in WebKit Gtk. 2. Examine any of the paragraphs (i.e. items formatted with <p></p>) and list items (i.e. items formatted with <li></li>) using Accerciser. Expected results: Paragraphs would be exposed as being of ROLE_PARAGRAPH; list items as ROLE_LIST_ITEM. Actual results: Paragraphs and list items are exposed as ROLE_PANEL. 118934 1 29807 jdiggs 2009-04-26 16:51:08 -0700 Created attachment 29807 aforementioned test case 122137 2 30505 xan.lopez 2009-05-20 05:59:37 -0700 Created attachment 30505 paragraphrole.patch Implement ATK_ROLE_PARAGRAPH. 122138 3 30506 xan.lopez 2009-05-20 06:00:00 -0700 Created attachment 30506 listitemrole.patch Implement ATK_ROLE_LIST_ITEM. 122145 4 30506 jmalonzo 2009-05-20 06:33:28 -0700 Comment on attachment 30506 listitemrole.patch > + // WebCore does not seem to have a role for list items > + if (AXObject->roleValue() == GroupRole) { Why? List is not a child role of group so I don't think it's required (http://www.w3.org/TR/wai-aria/#group) > + AccessibilityObject* parent = AXObject->parentObjectUnignored(); > + if (parent && parent->roleValue() == ListRole) You can just isList() here instead. 122147 5 30506 jmalonzo 2009-05-20 06:59:58 -0700 Comment on attachment 30506 listitemrole.patch > + // WebCore does not seem to have a role for list items > + if (AXObject->roleValue() == GroupRole) { isGroup() > + AccessibilityObject* parent = AXObject->parentObjectUnignored(); > + if (parent && parent->roleValue() == ListRole) isList() With those changes, r=me. 122149 6 30505 jmalonzo 2009-05-20 07:13:06 -0700 Comment on attachment 30505 paragraphrole.patch Please check if we have a node() first just in case we may not have one. r=me. 122156 7 xan.lopez 2009-05-20 07:33:50 -0700 (In reply to comment #5) > (From update of attachment 30506 [review]) > > + // WebCore does not seem to have a role for list items > > + if (AXObject->roleValue() == GroupRole) { > > isGroup() > > > + AccessibilityObject* parent = AXObject->parentObjectUnignored(); > > + if (parent && parent->roleValue() == ListRole) > > isList() > > With those changes, r=me. > Thanks, landed as r43907. 122157 8 xan.lopez 2009-05-20 07:34:14 -0700 (In reply to comment #6) > (From update of attachment 30505 [review]) > Please check if we have a node() first just in case we may not have one. > > r=me. > Done so and landed as r43908. 122197 9 jdiggs 2009-05-20 12:42:27 -0700 Thanks Xan. Marking as VERIFIED. 29807 2009-04-26 16:51:08 -0700 2009-04-26 16:51:08 -0700 aforementioned test case foo.html text/html 432 jdiggs PGh0bWw+CjxoZWFkPgo8dGl0bGU+U2ltcGxlIFRlc3Q8L3RpdGxlPgo8L2hlYWQ+Cjxib2R5Pgo8 aDE+SGVhZGluZyAxPC9oMT4KPGgyPkhlYWRpbmcgMjwvaDI+CjxwPkhlcmUgaXMgc29tZSA8Yj5i b2xkPC9iPiB0ZXh0IHdoaWNoIHdvdWxkIGludHJvZHVjZSB0aGUgbmV4dCBzZWN0aW9ucywgd2Vy ZSB0aGVyZSBhbnl0aGluZyB3b3J0aCBpbnRyb2R1Y2luZyB0aGVyZS48L3A+CjxoMz5TZWN0aW9u IDEgKEhlYWRpbmcgMyk8L2gzPgo8cD5GaXJzdCBwYXJhZ3JhcGg8L3A+CjxwPlNlY29uZCBwYXJh Z3JhcGg8L3A+CjxoMz5TZWN0aW9uIDIgKEhlYWRpbmcgMyk8L2gzPgo8cD5GaXJzdCBwYXJhZ3Jh cGg8L3A+CjxwPlNlY29uZCBwYXJhZ3JhcGg8L3A+CjxvbD4KPGxpPkl0ZW0gMTwvbGk+CjxsaT5J dGVtIDI8L2xpPgo8L29sPgo8L2JvZHk+CjwvaHRtbD4K 30505 2009-05-20 05:59:37 -0700 2009-05-20 07:13:06 -0700 paragraphrole.patch paragraphrole.patch text/plain 2306 xan.lopez RnJvbSBmMmEwMmQ5NjY4NjRiMmYxYzE0OGVjMjI5YTNhY2IwMjM0NjBkNmYyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYYW4gTG9wZXogPHhsb3BlekBpZ2FsaWEuY29tPgpEYXRlOiBX ZWQsIDIwIE1heSAyMDA5IDE1OjQwOjAxICswMzAwClN1YmplY3Q6IFtQQVRDSF0gMjAwOS0wNS0y MCAgWGFuIExvcGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CgogICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgoKICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjU0MTQKICAgICAgICBbR1RLXSBST0xFX1BBTkVMIHNob3VsZCBub3QgYmUgdXNlZCBm b3IgcGFyYWdyYXBocyBhbmQgbGlzdCBpdGVtcy4KCiAgICAgICAgSW1wbGVtZW50IEF0ayBwYXJh Z3JhcGggcm9sZSBmb3IgcGFyYWdyYXBoIGVsZW1lbnRzLgoKICAgICAgICAqIGFjY2Vzc2liaWxp dHkvZ3RrL0FjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyQXRrLmNwcDoKICAgICAgICAod2Via2l0 X2FjY2Vzc2libGVfZ2V0X3JvbGUpOgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIHwgICAxMiArKysrKysrKysrKysKIC4uLi9ndGsvQWNjZXNz aWJpbGl0eU9iamVjdFdyYXBwZXJBdGsuY3BwICAgICAgICAgIHwgICAgNSArKysrKwogMiBmaWxl cyBjaGFuZ2VkLCAxNyBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBh L1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjI4NTBjMi4uZDAy ZTM5OCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0wNS0yMCAgWGFuIExvcGV6ICA8eGxvcGV6QGlnYWxp YS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI1NDE0CisgICAgICAgIFtH VEtdIFJPTEVfUEFORUwgc2hvdWxkIG5vdCBiZSB1c2VkIGZvciBwYXJhZ3JhcGhzIGFuZCBsaXN0 IGl0ZW1zLgorCisgICAgICAgIEltcGxlbWVudCBBdGsgcGFyYWdyYXBoIHJvbGUgZm9yIHBhcmFn cmFwaCBlbGVtZW50cy4KKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvZ3RrL0FjY2Vzc2liaWxp dHlPYmplY3RXcmFwcGVyQXRrLmNwcDoKKyAgICAgICAgKHdlYmtpdF9hY2Nlc3NpYmxlX2dldF9y b2xlKToKKwogMjAwOS0wNS0yMCAgSmFuIE1pY2hhZWwgQWxvbnpvICA8am1hbG9uem9Ad2Via2l0 Lm9yZz4KIAogICAgICAgICBSdWJiZXItc3RhbXBlZCBieSBYYW4gTG9wZXouCmRpZmYgLS1naXQg YS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvZ3RrL0FjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyQXRr LmNwcCBiL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9ndGsvQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBw ZXJBdGsuY3BwCmluZGV4IGY1OTE0NTIuLmYwY2NhZmEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvYWNj ZXNzaWJpbGl0eS9ndGsvQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJBdGsuY3BwCisrKyBiL1dl YkNvcmUvYWNjZXNzaWJpbGl0eS9ndGsvQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJBdGsuY3Bw CkBAIC00MSw2ICs0MSw3IEBACiAjaW5jbHVkZSAiRWRpdG9yLmgiCiAjaW5jbHVkZSAiRnJhbWUu aCIKICNpbmNsdWRlICJGcmFtZVZpZXcuaCIKKyNpbmNsdWRlICJIVE1MTmFtZXMuaCIKICNpbmNs dWRlICJJbnRSZWN0LmgiCiAjaW5jbHVkZSAiTm90SW1wbGVtZW50ZWQuaCIKIApAQCAtMjY4LDYg KzI2OSwxMCBAQCBzdGF0aWMgQXRrUm9sZSB3ZWJraXRfYWNjZXNzaWJsZV9nZXRfcm9sZShBdGtP YmplY3QqIG9iamVjdCkKICAgICBpZiAoIUFYT2JqZWN0KQogICAgICAgICByZXR1cm4gQVRLX1JP TEVfVU5LTk9XTjsKIAorICAgIC8vIFdlYkNvcmUgZG9lcyBub3Qga25vdyBhYm91dCBwYXJhZ3Jh cGggcm9sZQorICAgIGlmIChzdGF0aWNfY2FzdDxBY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0Kj4o QVhPYmplY3QpLT5yZW5kZXJlcigpLT5ub2RlKCktPmhhc1RhZ05hbWUoSFRNTE5hbWVzOjpwVGFn KSkKKyAgICAgICAgcmV0dXJuIEFUS19ST0xFX1BBUkFHUkFQSDsKKwogICAgIC8vIE5vdGU6IFdo eSBkb2Vzbid0IFdlYkNvcmUgaGF2ZSBhIHBhc3N3b3JkIGZpZWxkIGZvciB0aGlzCiAgICAgaWYg KEFYT2JqZWN0LT5pc1Bhc3N3b3JkRmllbGQoKSkKICAgICAgICAgcmV0dXJuIEFUS19ST0xFX1BB U1NXT1JEX1RFWFQ7Ci0tIAoxLjYuMi4yCgo= 30506 2009-05-20 06:00:00 -0700 2009-05-20 06:59:58 -0700 listitemrole.patch listitemrole.patch text/plain 2439 xan.lopez RnJvbSBkZjhjZDBiN2Y5YWU4ZmJlNWIzMjhjODJhMjkzZmM3NTExMjRmZTA4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYYW4gTG9wZXogPHhsb3BlekBpZ2FsaWEuY29tPgpEYXRlOiBX ZWQsIDIwIE1heSAyMDA5IDE1OjU3OjM0ICswMzAwClN1YmplY3Q6IFtQQVRDSF0gMjAwOS0wNS0y MCAgWGFuIExvcGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CgogICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgoKICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjU0MTQKICAgICAgICBbR1RLXSBST0xFX1BBTkVMIHNob3VsZCBub3QgYmUgdXNlZCBm b3IgcGFyYWdyYXBocyBhbmQgbGlzdCBpdGVtcy4KCiAgICAgICAgSW1wbGVtZW50IEF0ayBsaXN0 IGl0ZW0gcm9sZSBmb3IgbGlzdCBpdGVtcy4KCiAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L2d0ay9B Y2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlckF0ay5jcHA6CiAgICAgICAgKHdlYmtpdF9hY2Nlc3Np YmxlX2dldF9yb2xlKToKLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICB8ICAgMTIgKysrKysrKysrKysrCiAuLi4vZ3RrL0FjY2Vzc2liaWxpdHlP YmplY3RXcmFwcGVyQXRrLmNwcCAgICAgICAgICB8ICAgIDcgKysrKysrKwogMiBmaWxlcyBjaGFu Z2VkLCAxOSBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYkNv cmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDAyZTM5OC4uMDQ2YzJiZiAx MDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAg LTUsNiArNSwxOCBAQAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjU0MTQKICAgICAgICAgW0dUS10gUk9MRV9QQU5FTCBzaG91bGQgbm90IGJlIHVzZWQg Zm9yIHBhcmFncmFwaHMgYW5kIGxpc3QgaXRlbXMuCiAKKyAgICAgICAgSW1wbGVtZW50IEF0ayBs aXN0IGl0ZW0gcm9sZSBmb3IgbGlzdCBpdGVtcy4KKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkv Z3RrL0FjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyQXRrLmNwcDoKKyAgICAgICAgKHdlYmtpdF9h Y2Nlc3NpYmxlX2dldF9yb2xlKToKKworMjAwOS0wNS0yMCAgWGFuIExvcGV6ICA8eGxvcGV6QGln YWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI1NDE0CisgICAgICAg IFtHVEtdIFJPTEVfUEFORUwgc2hvdWxkIG5vdCBiZSB1c2VkIGZvciBwYXJhZ3JhcGhzIGFuZCBs aXN0IGl0ZW1zLgorCiAgICAgICAgIEltcGxlbWVudCBBdGsgcGFyYWdyYXBoIHJvbGUgZm9yIHBh cmFncmFwaCBlbGVtZW50cy4KIAogICAgICAgICAqIGFjY2Vzc2liaWxpdHkvZ3RrL0FjY2Vzc2li aWxpdHlPYmplY3RXcmFwcGVyQXRrLmNwcDoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvYWNjZXNzaWJp bGl0eS9ndGsvQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJBdGsuY3BwIGIvV2ViQ29yZS9hY2Nl c3NpYmlsaXR5L2d0ay9BY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlckF0ay5jcHAKaW5kZXggZjBj Y2FmYS4uMjk2MjRkNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2d0ay9BY2Nl c3NpYmlsaXR5T2JqZWN0V3JhcHBlckF0ay5jcHAKKysrIGIvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5 L2d0ay9BY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlckF0ay5jcHAKQEAgLTI2OSw2ICsyNjksMTMg QEAgc3RhdGljIEF0a1JvbGUgd2Via2l0X2FjY2Vzc2libGVfZ2V0X3JvbGUoQXRrT2JqZWN0KiBv YmplY3QpCiAgICAgaWYgKCFBWE9iamVjdCkKICAgICAgICAgcmV0dXJuIEFUS19ST0xFX1VOS05P V047CiAKKyAgICAvLyBXZWJDb3JlIGRvZXMgbm90IHNlZW0gdG8gaGF2ZSBhIHJvbGUgZm9yIGxp c3QgaXRlbXMKKyAgICBpZiAoQVhPYmplY3QtPnJvbGVWYWx1ZSgpID09IEdyb3VwUm9sZSkgewor ICAgICAgICBBY2Nlc3NpYmlsaXR5T2JqZWN0KiBwYXJlbnQgPSBBWE9iamVjdC0+cGFyZW50T2Jq ZWN0VW5pZ25vcmVkKCk7CisgICAgICAgIGlmIChwYXJlbnQgJiYgcGFyZW50LT5yb2xlVmFsdWUo KSA9PSBMaXN0Um9sZSkKKyAgICAgICAgICAgIHJldHVybiBBVEtfUk9MRV9MSVNUX0lURU07Cisg ICAgfQorCiAgICAgLy8gV2ViQ29yZSBkb2VzIG5vdCBrbm93IGFib3V0IHBhcmFncmFwaCByb2xl CiAgICAgaWYgKHN0YXRpY19jYXN0PEFjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QqPihBWE9iamVj dCktPnJlbmRlcmVyKCktPm5vZGUoKS0+aGFzVGFnTmFtZShIVE1MTmFtZXM6OnBUYWcpKQogICAg ICAgICByZXR1cm4gQVRLX1JPTEVfUEFSQUdSQVBIOwotLSAKMS42LjIuMgoK