253043 2023-02-27 16:53:12 -0800 HTTP/2 WPT layout tests actually run over HTTP/1.1 2023-03-09 22:13:09 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=204469 InRadar P2 Normal --- 253533 1 nham nham ap gsnedders jbedard nham webkit-bug-importer oldest_to_newest 1937238 0 nham 2023-02-27 16:53:12 -0800 There are a number of WPT tests that use "h2" in the filename to designate that they should be run over HTTP/2: https://web-platform-tests.org/writing-tests/server-features.html#tests-requiring-http-2-0 However, when I add logging to various h2 layout tests, I see that they're actually directed towards the plain-text HTTP/1.1 WPT server. For instance, `console.log(window.location)` in `imported/w3c/web-platform-tests/xhr/status.h2.window.html` produces this URL: http://localhost:8800/xhr/status.h2.window.html It should actually produce this URL, since the h2 server runs on port 9000 by default: https://localhost:9000/xhr/status.h2.window.html It looks like the issue might be that the `wpt_test_path_to_uri` method has to be updated to parse `h2` out of the test filename and direct the request to the HTTP/2 as necessary. 1937239 1 webkit-bug-importer 2023-02-27 16:55:09 -0800 <rdar://problem/106003603> 1937421 2 nham 2023-02-28 09:30:54 -0800 I was able to get the particular h2-only test I cared about to run over h2 by editing `wpt_test_path_to_uri` to run h2 tests on port 9000. 1937671 3 gsnedders 2023-03-01 00:15:02 -0800 (In reply to Ben Nham from comment #2) > I was able to get the particular h2-only test I cared about to run over h2 > by editing `wpt_test_path_to_uri` to run h2 tests on port 9000. This is probably a reasonable fix for now, if you want to submit a PR for it? 1938336 4 nham 2023-03-02 16:10:29 -0800 Pull request: https://github.com/WebKit/WebKit/pull/10974 1940309 5 ews-feeder 2023-03-09 22:13:07 -0800 Committed 261489@main (7fb8f6320080): <https://commits.webkit.org/261489@main> Reviewed commits have been landed. Closing PR #10974 and removing active labels.