25299 2009-04-20 14:24:13 -0700 Don't bound caret to root line box if it is still inside its containing block 2009-04-20 15:31:12 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 justin.garcia justin.garcia mitz oldest_to_newest 118157 0 justin.garcia 2009-04-20 14:24:13 -0700 In RTL, I think we should distribute odd caret widths more to the left than to the right, so that the caret doesn't overlap what is usually the just typed character. Also in RTL, we shouldn't make the caret stay in the root line box in auto wrap modes, it should just be kept inside the containing block (like we do in non wrapping modes before the text wraps). <rdar://problem/6804912> 118158 1 mitz 2009-04-20 14:35:20 -0700 (In reply to comment #0) > Also in RTL, we shouldn't make the caret stay in the root line box in auto wrap > modes, it should just be kept inside the containing block (like we do in non > wrapping modes before the text wraps). I don't understand why there needs to be a different rule for RTL. 118159 2 justin.garcia 2009-04-20 14:37:10 -0700 >> Also in RTL, we shouldn't make the caret stay in the root line box in auto wrap >> modes, it should just be kept inside the containing block (like we do in non >> wrapping modes before the text wraps). > I don't understand why there needs to be a different rule for RTL. Sorry I was unclear. I only mean that right now, we don't bound carets in LTR text to their root line box in auto wrap, only in RTL, so the fix only needs to happen in the RTL case. 118161 3 mitz 2009-04-20 14:38:13 -0700 As for the caret width, I agree, but I think the definition of "in RTL" should not be too fine-grained: perhaps consider the block direction, but not individual text boxes'. 118164 4 justin.garcia 2009-04-20 14:46:45 -0700 Going to hold off on the caretWidth distribution change for now, since we think it may make us deviate from AppKit. 118166 5 29625 justin.garcia 2009-04-20 14:51:25 -0700 Created attachment 29625 patch 118170 6 justin.garcia 2009-04-20 15:29:05 -0700 http://trac.webkit.org/changeset/42685 118171 7 justin.garcia 2009-04-20 15:31:12 -0700 Oops! Made a big typo. Fixed it in http://trac.webkit.org/changeset/42686 29625 2009-04-20 14:51:25 -0700 2009-04-20 15:22:56 -0700 patch 25299.txt text/plain 1218 justin.garcia SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDkyMDg0 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMDQt MjAgIEp1c3RpbiBHYXJjaWEgIDxqdXN0aW4uZ2FyY2lhQGFwcGxlLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNTI5OQorICAgICAgICBEb24ndCBib3VuZCBj YXJldCB0byByb290IGxpbmUgYm94IGlmIGl0IGlzIHN0aWxsIGluc2lkZSBpdHMgY29udGFpbmlu ZyBibG9jaworCisgICAgICAgIENhbid0IHlldCB0ZXN0IGNoYW5nZXMgdG8gYmVoYXZpb3Igd2l0 aCBub24tc3RhbmRhcmQgY2FyZXQgd2lkdGhzLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRl clRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGV4dDo6bG9jYWxDYXJldFJlY3Qp OgorCiAyMDA5LTA0LTIwICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CgpJbmRl eDogcmVuZGVyaW5nL1JlbmRlclRleHQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHJlbmRlcmluZy9SZW5k ZXJUZXh0LmNwcAkocmV2aXNpb24gOTIwNTgpCisrKyByZW5kZXJpbmcvUmVuZGVyVGV4dC5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTQ4NCw3ICs0ODQsNyBAQAogICAgICAgICBpZiAoYm94LT5kaXJl Y3Rpb24oKSA9PSBMVFIpCiAgICAgICAgICAgICBsZWZ0ID0gbWluKGxlZnQsIHJvb3RMZWZ0ICsg YXZhaWxhYmxlV2lkdGggLSBjYXJldFdpZHRoUmlnaHRPZk9mZnNldCk7CiAgICAgICAgIGVsc2UK LSAgICAgICAgICAgIGxlZnQgPSBtYXgobGVmdCwgcm9vdExlZnQpOworICAgICAgICAgICAgbGVm dCA9IG1heChsZWZ0LCBjYi0+eCgpKTsKICAgICB9IGVsc2UgewogICAgICAgICAvLyBJZiB0aGVy ZSBpcyBubyB3cmFwcGluZywgdGhlIGNhcmV0IGNhbiBsZWF2ZSBpdHMgY29udGFpbmluZyBibG9j aywgYnV0IG5vdCBpdHMgcm9vdCBsaW5lIGJveC4KICAgICAgICAgaWYgKGNiLT5zdHlsZSgpLT5k aXJlY3Rpb24oKSA9PSBMVFIpIHsK