252383 2023-02-16 00:54:13 -0800 [GLib] WebKitPermissionRequest should use G_DECLARE_INTERFACE in 2022 API 2023-02-16 16:06:42 -0800 1 1 1 Unclassified WebKit WebKit API WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=243663 InRadar P2 Normal --- 210100 1 aperez aperez bugs-noreply mcatanzaro webkit-bug-importer oldest_to_newest 1934108 0 aperez 2023-02-16 00:54:13 -0800 Somewhat related to bug #243663, now that we have WEBKIT_DECLARE{,_DERIVABLE,_FINAL}_TYPE then the WebKitPermissionRequest type should also use the new macros to cut on the manual boilerplate. 1934113 1 aperez 2023-02-16 01:09:31 -0800 Correction: it is an interface, so we want to use a new macro i.e. WEBKIT_DECLARE_INTERFACE that forwards most of the work to G_DECLARE_INTERFACE. Amusingly, the implementation is already using G_DEFINE_INTERFACE. 1934167 2 aperez 2023-02-16 07:47:33 -0800 Given that WebKitPermissionRequest is the only interface defined in the API, I plan to skip making a WEBKIT_DEFINE_INTERFACE macro and put directly an expansion of G_DECLARE_INTERFACE in the header. Also, it's not like we want to do much other than what G_DECLARE_INTERFACE does anyway, so it does not seem worth the effort to maintain a new macro inside WebKit :) 1934175 3 aperez 2023-02-16 07:51:11 -0800 Pull request: https://github.com/WebKit/WebKit/pull/10200 1934356 4 ews-feeder 2023-02-16 16:05:33 -0800 Committed 260403@main (10d6f8608be4): <https://commits.webkit.org/260403@main> Reviewed commits have been landed. Closing PR #10200 and removing active labels. 1934357 5 webkit-bug-importer 2023-02-16 16:06:42 -0800 <rdar://problem/105569323>